[PATCH 3/3] rust: upgrade to Rust 1.73.0

m/rust-lang/rust/blob/stable/RELEASES.md#version-1730-2023-10-05 [1] Link: https://rust-for-linux.com/rust-version-policy [2] Link: https://github.com/Rust-for-Linux/linux/issues/2 [3] Link: https://github.com/rust-lang/compiler-team/issues/596 [4] Signed-off-by: Miguel Ojeda --- Documentation/pro

RE: [PATCH v3] Documentation/process/coding-style.rst: space around const

On Wed, 11 Oct 2023 14:44:17 -0700, Dan Williams wrote: > > I notice that clang-format reflows that example to: > > const void *a; > void *const b; > void **const c; > void *const *const d; > int strcmp(const char *a, const char *b); > > ...but someone more clang-format savvy th

Re: [PATCH v3] Documentation/process/coding-style.rst: space around const

On Thu, Oct 12, 2023 at 4:48 PM Joe Perches wrote: > > Do older versions of clang-format ignore entries > they don't understand? Sadly, no, that is the reason we keep it at the minimum. However, I just took a look again at it, and I see that such support was added to LLVM 12, the `--Wno-error=un

Re: [PATCH 4/7] Docs: Move clang-format from process/ to dev-tools/

On Mon, Jun 24, 2024 at 8:53 PM SeongJae Park wrote: > > 'clang-format' is on 'Other material' section of 'process/index', but it > may fit more under 'dev-tools/' directory. Move it. > > Signed-off-by: SeongJae Park Happy either way -- thanks! Acked-by: Miguel Ojeda Cheers, Miguel

[PATCH 06/13] rust: start supporting several compiler versions

/pull/125209 [1] Signed-off-by: Miguel Ojeda --- Documentation/process/changes.rst | 4 +--- Documentation/rust/quick-start.rst | 9 - scripts/rust_is_available.sh | 8 scripts/rust_is_available_test.py | 5 - 4 files changed, 5 insertions(+), 21 deletions(-) diff --

Re: [PATCH 06/13] rust: start supporting several compiler versions

On Thu, Jul 4, 2024 at 4:45 PM Finn Behrens wrote: > > One idea below, but fine with or without it. > > Reviewed-by: Finn Behrens Thanks Finn! > Would it make sense to not advise the min version but the “max” or just > latest stable version? Min version should work as well latest could > pote

Re: [PATCH 13/13] docs: rust: quick-start: add section on Linux distributions

On Fri, Jul 5, 2024 at 8:19 AM Andrea Righi wrote: > > This implicitly covers Ubuntu, since packages are sync'ed with Debian. Do you mean the names (i.e. command) is the same, or that the newer versions from e.g. Sid can be used in Ubuntu? If the latter, that would be definitely worth adding, yea

Re: [PATCH 13/13] docs: rust: quick-start: add section on Linux distributions

On Fri, Jul 5, 2024 at 8:47 AM Fabian Grünbichler wrote: > > Debian (for building firefox and chromium), and uses a -web suffix for > that: > > https://tracker.debian.org/pkg/rustc-web Like for Ubuntu's versioned ones, it seems not recent enough at the moment (i.e. for the current kernel), if I u

Re: [PATCH 13/13] docs: rust: quick-start: add section on Linux distributions

On Fri, Jul 5, 2024 at 3:09 PM Fabian Grünbichler wrote: > > right now it is updated whenever its rdeps (firefox and chromium in > stable) need newer versions. once e.g. a stable Debian kernel has > similar requirements, I guess the same would apply there. I am not sure > upstream kernel developme

[PATCH v2 00/13] Support several Rust toolchain versions

s! Cheers, Miguel Miguel Ojeda (13): rust: macros: indent list item in `paste!`'s docs rust: init: simplify from `map_err` to `inspect_err` rust: allow `dead_code` for never constructed bindings rust: relax most deny-level lints to warnings rust: simplify Clippy warning flags se

[PATCH v2 06/13] rust: start supporting several compiler versions

/pull/125209 [1] Reviewed-by: Finn Behrens Tested-by: Benno Lossin Tested-by: Andreas Hindborg Signed-off-by: Miguel Ojeda --- v2: - Update suggested `rustup` command to just install `stable`. (Finn) - Update suggested command for installing manually the Rust standard library sources wit

Re: [PATCH v2 00/13] Support several Rust toolchain versions

On Tue, Jul 9, 2024 at 6:06 PM Miguel Ojeda wrote: > > A few things improved here and there, and rebased on top of `rust-next`. > > The changelog is attached to each patch. > > I kept the `Tested-by`s since most of the changes are on documentation > or comments, though I d

Re: [PATCH] kernel-docs: Add new section for Rust learning materials

On Wed, Sep 11, 2024 at 8:59 PM Carlos Bilbao wrote: > > Include a new section in the Index of Further Kernel Documentation with > resources to learn Rust. Reference it in the Rust index. Thanks for this, Carlos! It would be nice to mention that this came out of a session of Kangrejos with sugges

Re: [PATCH 07/22] docs: admin-guide: add auxdisplay files to it after conversion to ReST

On Mon, Jul 22, 2019 at 1:08 PM Mauro Carvalho Chehab wrote: > > Those two files describe userspace-faced information. While part of > it might fit on uAPI, it sounds to me that the admin guide is the > best place for them. Acked-by: Miguel Ojeda Thanks a lot for all the work

Re: [PATCH 3/4] Documentation/process: Add fallthrough pseudo-keyword

On Sat, Oct 5, 2019 at 6:47 PM Joe Perches wrote: > > diff --git a/Documentation/process/deprecated.rst > b/Documentation/process/deprecated.rst > index 56280e108d5a..a0ffdc8daef3 100644 > --- a/Documentation/process/deprecated.rst > +++ b/Documentation/process/deprecated.rst > @@ -122,14 +122,27

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

Hi Linus, On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds wrote: > > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > > > Add 'fallthrough' pseudo-keyword to enable the removal of comments > > like '/* fallthrough */'. > > I applied patches 1-3 to my tree just to make it easier for people to

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

On Sat, Oct 12, 2019 at 12:08 AM Kees Cook wrote: > > On Fri, Oct 11, 2019 at 08:01:42PM +0200, Miguel Ojeda wrote: > > Hi Linus, > > > > On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds > > wrote: > > > > > > On Sat, Oct 5, 2019 at 9:46 AM Joe

Re: [PATCH RFC 4/5] rculist: Remove hlist_for_each_entry_rcu_notrace since no users

On Sat, May 25, 2019 at 1:50 AM Joel Fernandes (Google) wrote: > > The series removes all users of the API and with this patch, the API > itself. > > Signed-off-by: Joel Fernandes (Google) > --- > .clang-format | 1 - Ack for clang-format, and thanks for removing it there too! :-) Ch

Re: [PATCH v2 02/29] docs: lcd-panel-cgram.txt: convert docs to ReST and rename to *.rst

On Tue, Jun 18, 2019 at 10:56 PM Mauro Carvalho Chehab wrote: > > This small text file describes the usage of parallel port LCD > displays from userspace PoV. So, a good candidate for the > admin guide. > > While this is not part of the admin-guide book, mark it as > :orphan:, in order to avoid bu

Re: [PATCH v2 02/29] docs: lcd-panel-cgram.txt: convert docs to ReST and rename to *.rst

On Wed, Jun 19, 2019 at 1:15 AM Mauro Carvalho Chehab wrote: > > Yeah, the plan is to move all text files inside Documentation/ to .rst[1]. > > [1] There are some exceptions: for ABI and features, the current plan > is to have a script that parses their strict formats and produce > a ReST output.

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

On Thu, Feb 22, 2018 at 2:29 AM, Jae Hyun Yoo wrote: > On 2/21/2018 4:37 PM, Andrew Lunn wrote: >>> >>> But even with this change, it still needs to use delayed creation >>> because BMC side kernel doesn't know how many DIMMs are populated on >>> a remote server before the remote server completes

[PATCH] Doc: misc-devices: move lcd-panel-cgram.txt to auxdisplay/

Commit 7005b58458e4beecaf5efacb872c456bc7d3541a ("Staging: add lcd-panel driver") introduced the panel driver, which is now in drivers/auxdisplay. Cc: Willy Tarreau Cc: Jonathan Corbet Signed-off-by: Miguel Ojeda --- Documentation/{misc-devices => auxdisplay}/lcd-panel-cgram.tx

Re: [PATCH v5 00/15] Compiler Attributes

Hi Sedat, On Mon, Sep 24, 2018 at 10:46 AM Sedat Dilek wrote: > > [ Please CC me I am not subcribed to this ML ] > > Quote from : > > Tested-by: Sedat Dilek (against Linux > v4.19-rc5 and built with LLVM/Clang v7) Thanks a lot for testing! Which configuratio

Re: [PATCH v5 00/15] Compiler Attributes

On Sat, Oct 6, 2018 at 9:13 AM Sedat Dilek wrote: > > Hi Miguel, > > In my testoings I am booting in QEMU and on bare metal. > Both tests were successful. Wow! I only wanted to confirm it booted and/or run for a while -- but having more information is always good. Thanks a *lot*! I will add a re

[GIT PULL] Compiler Attributes for v4.20-rc1

terwards. ---- Miguel Ojeda (15): Compiler Attributes: remove unused attributes Compiler Attributes: always use the extra-underscores syntax Compiler Attributes: remove unneeded tests Compiler Attributes: homogenize __must_be_array Compiler Attributes: remove unneede

Re: [GIT PULL] Compiler Attributes for v4.20-rc1

On Thu, Nov 1, 2018 at 6:06 PM Linus Torvalds wrote: > > I'm not sure how much that matters (maybe the original check for 4.9.2 > was just a random pick by Andrey? Added to cc), but together with the > movement to that looks like it also > wouldn't want the CONFIG_KASAN tests, I wonder what the r

Re: [GIT PULL] Compiler Attributes for v4.20-rc1

On Fri, Nov 2, 2018 at 2:52 AM Linus Torvalds wrote: > > Anyway, I decided to do the merge by just getting rid of the > GCC_VERSION check around __no_sanitize_address_or_inline entirely. If > you enable KASAN, then a function with that marking just won't be > marked inline. I was a bit confused w

Re: [PATCH v5 00/15] Compiler Attributes

On Mon, Sep 24, 2018 at 4:36 PM Luc Van Oostenryck wrote: > > On Thu, Sep 20, 2018 at 07:22:46PM +0200, Miguel Ojeda wrote: > > The Compiler Attributes series is an effort to disentangle > > the include/linux/compiler*.h headers and bring them up to date. > > > > T

Re: [PATCH v5 12/15] Compiler Attributes: add support for __nonstring (gcc >= 8)

On Thu, Sep 20, 2018 at 10:08 PM Kees Cook wrote: > > Reviewed-by: Kees Cook > Done! Thanks! Cheers, Miguel

Re: [PATCH v5 13/15] Compiler Attributes: enable -Wstringop-truncation on W=1 (gcc >= 8)

On Thu, Sep 20, 2018 at 9:56 PM Kees Cook wrote: > > Ye. :) > > Reviewed-by: Kees Cook Done! Thanks! :) Cheers, Miguel

[GIT PULL linux-next] Add Compiler Attributes tree

10-02 15:11:26 +0200) -------- Miguel Ojeda (15): Compiler Attributes: remove unused attributes Compiler Attributes: always use the extra-underscores syntax Compiler Attributes: remove unneeded tests Compiler Attributes: homogenize __must_be_

Re: [GIT PULL linux-next] Add Compiler Attributes tree

Hi Stephen, On Tue, Oct 2, 2018 at 11:11 PM Stephen Rothwell wrote: > > Hi Miguel, > > On Tue, 2 Oct 2018 15:47:12 +0200 Miguel Ojeda > wrote: > > > > The Compiler Attributes series has been stable for 10+ days. To > > increase testing before 4.20, I would to r

Re: [GIT PULL linux-next] Add Compiler Attributes tree

Hi Nick, On Tue, Oct 2, 2018 at 11:16 PM Nick Desaulniers wrote: > > On Tue, Oct 2, 2018 at 2:11 PM Stephen Rothwell wrote: > > > > Hi Miguel, > > > > On Tue, 2 Oct 2018 15:47:12 +0200 Miguel Ojeda > > wrote: > > > > > > The Compi

Re: [GIT PULL linux-next] Add Compiler Attributes tree

Hi Ted, On Wed, Oct 3, 2018 at 1:25 AM Theodore Y. Ts'o wrote: > > On Wed, Oct 03, 2018 at 12:12:10AM +0200, Miguel Ojeda wrote: > > As I have read, -next is supposed to be a vision of what the merge > > window will look like after merging everything, i.e. ideally -rc1. F

Re: [GIT PULL linux-next] Add Compiler Attributes tree

HI Dominique, On Wed, Oct 3, 2018 at 12:37 AM Dominique Martinet wrote: > > Miguel Ojeda wrote on Wed, Oct 03, 2018: > > As I have read, -next is supposed to be a vision of what the merge > > window will look like after merging everything, i.e. ideally -rc1. For > > that

Re: [GIT PULL linux-next] Add Compiler Attributes tree

Hi Stephen, On Wed, Oct 3, 2018 at 1:00 AM Stephen Rothwell wrote: > > Hi Miguel, > > On Wed, 3 Oct 2018 00:36:52 +0200 Dominique Martinet > wrote: > > > > Miguel Ojeda wrote on Wed, Oct 03, 2018: > > > As I have read, -next is supposed to be a vision of w

Re: [GIT PULL linux-next] Add Compiler Attributes tree

Hi Ted, On Wed, Oct 3, 2018 at 5:33 PM Theodore Y. Ts'o wrote: > > On Wed, Oct 03, 2018 at 01:54:05PM +0200, Miguel Ojeda wrote: > > > > Exactly. And for this case, I simply assumed Stephen wanted a clean > > series to apply on top of the latest next-* tag (same wa

Re: [GIT PULL linux-next] Add Compiler Attributes tree

On Wed, Oct 3, 2018 at 11:23 PM Miguel Ojeda wrote: > On Wed, Oct 3, 2018 at 5:33 PM Theodore Y. Ts'o wrote: > > had done with full consideration, specifically for this reason. Even > > if the definition was different, my definition *had* been fully tested > > w

Re: [GIT PULL linux-next] Add Compiler Attributes tree

Hi Ted, On Thu, Oct 4, 2018 at 7:02 AM Theodore Y. Ts'o wrote: > In this case, yes. Again, I emphasize that I was using the ext4.h > cleanup as an *example*. The point I was trying to make was that your > change did *not* do a full set of deep ext4 regression tests because > the your change did

[GIT PULL linux-next] Add Compiler Attributes (v6) tree

github.com/ojeda/linux.git compiler-attributes for you to fetch changes up to f0604f63033d4020f019d2aaee805c1075b1077b: Compiler Attributes: ext4: remove local __nonstring definition (2018-09-30 20:14:04 +0200) -------- Miguel Ojeda (15):

Re: [PATCH] docs: Introduce deprecated APIs list

On Wed, Oct 17, 2018 at 4:20 AM Kees Cook wrote: > > As discussed in the "API replacement/deprecation" thread[1], this > makes an effort to document what things shouldn't get (re)added to the > kernel, by introducing Documentation/process/deprecated.rst. It also > adds the overflow kerndoc to ReST

[PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough

Let gcc know these cases are meant to fall through to the next label by annotating them with the new __fallthrough statement attribute; and remove the comment since it conveys the same information (which was also parsed by gcc to suppress the warning). Signed-off-by: Miguel Ojeda --- drivers

[PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

for C as well. Further, icc >= 18 does not seem to know anything about the warning; except that it accepts (i.e. ignores) [[fallthrough]] in C++17 mode (to be conformant, probably). Link: https://lore.kernel.org/lkml/20181017062255.oiu44y4zuuwilan3@mwanda/ Suggested-by: Dan Carpenter Signed-of

[PATCH 0/2] Compiler Attributes: __fallthrough

Agner Cc: Luc Van Oostenryck Cc: Nick Desaulniers Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Linus Torvalds Cc: linux-doc@vger.kernel.org Cc: linux-e...@vger.kernel.org Cc: linux-spa...@vger.kernel.org Cc: linux-kbu...@vger.kernel.org Miguel Ojeda (2): Compiler Attributes: add suppor

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 12:27 AM Theodore Y. Ts'o wrote: > > On Sun, Oct 21, 2018 at 07:14:13PM +0200, Miguel Ojeda wrote: > > From the GCC manual: > > > > fallthrough > > > > The fallthrough attribute with a null statement serves as a > >

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 2:42 AM Matthew Wilcox wrote: > > On Sun, Oct 21, 2018 at 07:14:13PM +0200, Miguel Ojeda wrote: > > +#if __has_attribute(__fallthrough__) > > +# define __fallthrough __attribute__((__fallthrough__)) > > +#else > > +# de

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 11:36 AM Kees Cook wrote: > > We need to make sure the static analyzers are happy with either > method. Additionally, when was -Wimplicit-fallthrough added to GCC? If > it was added _before_ the attribute, we need to continue using the > comment style otherwise we lose cove

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 11:41 AM Miguel Ojeda wrote: > > * clang does *not* support the attribute in C. ...nor the warning at all, by the way (which is why this is OK). Cheers, Miguel

Re: [PATCH 0/2] Compiler Attributes: __fallthrough

On Sun, Oct 21, 2018 at 8:29 PM Greg Kroah-Hartman wrote: > > On Sun, Oct 21, 2018 at 07:14:12PM +0200, Miguel Ojeda wrote: > > These are two patches are meant to go on top of the rest of the compiler > > attributes series on: > > > > https://github.com/ojeda/

Re: [PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough

On Sun, Oct 21, 2018 at 8:11 PM Joe Perches wrote: > > On Sun, 2018-10-21 at 19:14 +0200, Miguel Ojeda wrote: > > Let gcc know these cases are meant to fall through to the next label > > by annotating them with the new __fallthrough statement attribute; > > and remove the

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 12:54 PM Dan Carpenter wrote: > > Doing both is super ugly. Let's just do comments until Eclipse gets > updated. > > I had wanted to move to the attribute because that would simplify things > in Smatch but it's not a huge deal to delay for another year. I can re-send them

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 12:53 PM Kees Cook wrote: > > On Mon, Oct 22, 2018 at 2:41 AM, Miguel Ojeda > wrote: > > Please take a look at the rationale (also more details at the linked > > thread): > > > > * gcc 7.1 added -Wimplicit-fallthrough at the same

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 2:07 PM Luc Van Oostenryck wrote: > > On Sun, Oct 21, 2018 at 07:14:13PM +0200, Miguel Ojeda wrote: > > > > While comment parsing is a good idea to deal with old codebases > > that used such a comment as documentation for humans, the best &g

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 1:24 PM Miguel Ojeda wrote: > > On Mon, Oct 22, 2018 at 12:53 PM Kees Cook wrote: > > > > On Mon, Oct 22, 2018 at 2:41 AM, Miguel Ojeda > > wrote: > > > > > * clang does *not* support the attribute in C. > > > > We

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 7:17 PM Nick Desaulniers wrote: > > On Mon, Oct 22, 2018 at 2:43 AM Miguel Ojeda > wrote: > > > > On Mon, Oct 22, 2018 at 11:41 AM Miguel Ojeda > > wrote: > > > > > > * clang does *not* support the attribute in C. > >

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 7:36 PM Nick Desaulniers wrote: > > On Sun, Oct 21, 2018 at 10:14 AM Miguel Ojeda > wrote: > > > > of its kind) to deal with this: [[fallthrough]] is meant to be > > a new control keyword in the form of an extension. > > I think w

Re: [PATCH 0/2] Compiler Attributes: __fallthrough

On Mon, Oct 22, 2018 at 6:54 PM Nick Desaulniers wrote: > > On Mon, Oct 22, 2018 at 2:48 AM Miguel Ojeda > wrote: > > > > On Sun, Oct 21, 2018 at 8:29 PM Greg Kroah-Hartman > > wrote: > > > > > > Will this work with all of the static tools tha

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 7:50 PM Bernd Petrovitsch wrote: > > Hi all! > > On 22/10/18 13:07, Miguel Ojeda wrote: > > On Mon, Oct 22, 2018 at 12:54 PM Dan Carpenter > > wrote: > >> > >> Doing both is super ugly. Let's just do comments until Eclip

Re: [PATCH] Documentation: fix spelling mistake, EACCESS -> EACCES

On Fri, Oct 26, 2018 at 7:27 PM Colin King wrote: > > From: Colin Ian King > > Trivial fix to a spelling mistake of the error access name EACCESS, > rename to EACCES ? It is not a typo, it is the name of the error (POSIX). Same thing for the rest of the patches. Cheers, Miguel

Re: [PATCH] Documentation: fix spelling mistake, EACCESS -> EACCES

On Fri, Oct 26, 2018 at 8:40 PM Matthew Wilcox wrote: > > On Fri, Oct 26, 2018 at 08:20:12PM +0200, Miguel Ojeda wrote: > > On Fri, Oct 26, 2018 at 7:27 PM Colin King wrote: > > > > > > From: Colin Ian King > > > > > > Trivial fix to a s

Re: [PATCH] Documentation: fix spelling mistake, EACCESS -> EACCES

On Fri, Oct 26, 2018 at 8:53 PM Miguel Ojeda wrote: > > On Fri, Oct 26, 2018 at 8:40 PM Matthew Wilcox wrote: > > > > On Fri, Oct 26, 2018 at 08:20:12PM +0200, Miguel Ojeda wrote: > > > On Fri, Oct 26, 2018 at 7:27 PM Colin King > > > wrote:

Re: [PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough

Hi Dan, On Tue, Oct 23, 2018 at 7:37 AM Dan Carpenter wrote: > > On Mon, Oct 22, 2018 at 07:10:02AM -0700, Kees Cook wrote: > > I would prefer we continue to use the comment style until we've got > > confirmed support for (at least) Clang, Coverity, CPPcheck, smatch, > > and eclipse. > > Clang an

Re: [PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough

On Fri, Nov 2, 2018 at 11:49 AM Miguel Ojeda wrote: > > Thanks for checking! Let's wait then a few months and see if we can > get cppcheck/Eclipse to support it. In the meantime, saved here too: https://github.com/ojeda/linux/tree/compiler-attributes-fallthrough reb