Hi Doug,
Thank you for reviewing the patch. I will take a stab at a few comments
below. We will address most of the other comments in next version of I2C
patch.
+
+#define I2C_AUTO_SUSPEND_DELAY 250
Why 250 ms? That seems like an eternity. Is it really that expensive
to turn resources of
Hi Doug
On 3/8/2018 2:12 PM, Doug Anderson wrote:
Hi,
On Wed, Mar 7, 2018 at 9:19 PM, Doug Anderson wrote:
DMA is hard and i2c transfers > 32 bytes are rare. Do we really gain
a lot by transferring i2c commands over DMA compared to a FIFO?
Enough to justify the code complexity and the set of
Hi Doug,
On 3/7/2018 10:19 PM, Doug Anderson wrote:
Hi,
On Wed, Mar 7, 2018 at 6:42 PM, Sagar Dharia wrote:
Hi Doug,
Thank you for reviewing the patch. I will take a stab at a few comments
below. We will address most of the other comments in next version of I2C
patch.
+
+static const
Hi Doug,
Thanks for reviewing the patch.
On 3/16/2018 5:54 PM, Doug Anderson wrote:
> Hi,
>
> On Wed, Mar 14, 2018 at 4:58 PM, Karthikeyan Ramasubramanian
> wrote:
>> Add I2C master controller support for a built-in test I2C slave.
>>
>> Signed-off-by: Karthikeyan Ramasubramanian
>> ---
>> arc
Hi,
On 3/19/2018 5:56 PM, Doug Anderson wrote:
> Hi,
>
> On Mon, Mar 19, 2018 at 3:15 PM, Sagar Dharia wrote:
>>>> + pinconf {
>>>> + pins = "gpio55", "gpio56";
>
a programmable
>> module supporting a wide range of serial interfaces including I2C. The
>> driver supports FIFO mode and DMA mode of transfer and switches modes
>> dynamically depending on the size of the transfer.
>>
>> Signed-off-by: Karthikeyan Ramasubramanian
&g
Hi Doug
On 3/20/2018 9:47 PM, Doug Anderson wrote:
> Hi,
>
> On Tue, Mar 20, 2018 at 3:16 PM, Sagar Dharia wrote:
>>>>>> + pinconf {
>>>>>> + pins = "gpio55", "gpio56&
a programmable
>> module supporting a wide range of serial interfaces including I2C. The
>> driver supports FIFO mode and DMA mode of transfer and switches modes
>> dynamically depending on the size of the transfer.
>>
>> Signed-off-by: Karthikeyan Ramasubramanian
&g
