Re: [PATCH v3] x86, efi: never relocate kernel below lowest acceptable address

2019-10-14 Thread Kairui Song
On Mon, Oct 14, 2019 at 6:14 PM Borislav Petkov wrote: > > On Sat, Oct 12, 2019 at 11:44:21AM +0800, Kairui Song wrote: > > Currently, kernel fails to boot on some HyperV VMs when using EFI. > > And it's a potential issue on all platforms. > > > > It's caused a broken kernel relocation on EFI

Re: [PATCH] efi: libstub/arm: account for firmware reserved memory at the base of RAM

2019-10-14 Thread Chester Lin
On Mon, Oct 14, 2019 at 06:33:09PM +0200, Ard Biesheuvel wrote: > The EFI stubloader for ARM starts out by allocating a 32 MB window > at the base of RAM, in order to ensure that the decompressor (which > blindly copies the uncompressed kernel into that window) does not > overwrite other

Re: [PATCH v3] x86, efi: never relocate kernel below lowest acceptable address

2019-10-14 Thread Borislav Petkov
On Mon, Oct 14, 2019 at 11:21:11PM +0300, Jarkko Sakkinen wrote: > Was there a section in the patch submission documentation to point out > when people send patches with all the possible twists for an acronym? I don't think so. > This is giving me constantly gray hairs with TPM patches. Well,

Re: [PATCH v3] x86, efi: never relocate kernel below lowest acceptable address

2019-10-14 Thread Jarkko Sakkinen
On Mon, Oct 14, 2019 at 12:14:19PM +0200, Borislav Petkov wrote: > Your spelling of "EFI" is like a random number generator in this > paragraph: "Efi", "efi" and "EFI". Can you please be more careful when > writing your commit messages? They're not some random text you hurriedly > jot down before

[PATCH] efi/tpm: return -EINVAL when determining tpm final events log size fails

2019-10-14 Thread Jerry Snitselaar
Currently nothing checks the return value of efi_tpm_eventlog_init, but in case that changes in the future make sure an error is returned when it fails to determine the tpm final events log size. Cc: Ard Biesheuvel Cc: Jarkko Sakkinen Cc: linux-efi@vger.kernel.org Cc:

[PATCH] efi: libstub/arm: account for firmware reserved memory at the base of RAM

2019-10-14 Thread Ard Biesheuvel
The EFI stubloader for ARM starts out by allocating a 32 MB window at the base of RAM, in order to ensure that the decompressor (which blindly copies the uncompressed kernel into that window) does not overwrite other allocations that are made while running in the context of the EFI firmware. In

Re: [PATCH v3] x86, efi: never relocate kernel below lowest acceptable address

2019-10-14 Thread Borislav Petkov
On Sat, Oct 12, 2019 at 11:44:21AM +0800, Kairui Song wrote: > Currently, kernel fails to boot on some HyperV VMs when using EFI. > And it's a potential issue on all platforms. > > It's caused a broken kernel relocation on EFI systems, when below three > conditions are met: > > 1. Kernel image

Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y

2019-10-14 Thread Narendra.K
On Mon, Oct 14, 2019 at 08:49:51AM +0200, Ard Biesheuvel wrote: > > [EXTERNAL EMAIL] > > On Mon, 14 Oct 2019 at 08:41, Geert Uytterhoeven wrote: > > > > Hi Narendra, > > > > On Sun, Oct 13, 2019 at 8:57 PM wrote: > > > From: Narendra K > > > > > > For the EFI_RCI2_TABLE kconfig option, 'make

Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y

2019-10-14 Thread Ard Biesheuvel
On Mon, 14 Oct 2019 at 08:41, Geert Uytterhoeven wrote: > > Hi Narendra, > > On Sun, Oct 13, 2019 at 8:57 PM wrote: > > From: Narendra K > > > > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user > > for input on platforms where the option may not be applicable. This patch >

Re: [PATCH v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y

2019-10-14 Thread Geert Uytterhoeven
Hi Narendra, On Sun, Oct 13, 2019 at 8:57 PM wrote: > From: Narendra K > > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user > for input on platforms where the option may not be applicable. This patch > modifies the kconfig option to ask the user for input only when