Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-18 Thread Greg Kroah-Hartman
On Tue, Nov 18, 2014 at 06:31:38AM +, Kweh, Hock Leong wrote: -Original Message- From: Matt Fleming [mailto:m...@console-pimps.org] Sent: Monday, November 17, 2014 11:12 PM - Only doing module unload is required to be aware of this synchronization - Ensuring the call

Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-17 Thread Matt Fleming
On Thu, 13 Nov, at 02:51:28AM, Kweh, Hock Leong wrote: Hi everyone, First of all, I would like to apologize if my commit message gives you guys an impression that to use request_firmware_abort(), you guys MUST do the synchronization on your own. But the fact is, it is not a MUST.

Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-08 Thread Greg Kroah-Hartman
On Mon, Nov 03, 2014 at 11:07:08AM +0800, Kweh Hock Leong wrote: From: Kweh, Hock Leong hock.leong.k...@intel.com Besides aborting through user helper interface, a new API request_firmware_abort() allows kernel driver module to abort the request_firmware() / request_firmware_nowait() when

Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-03 Thread Henrique de Moraes Holschuh
On Mon, 03 Nov 2014, Kweh Hock Leong wrote: Note for people who use request_firmware_nowait(): You are required to do your own synchronization after you call request_firmware_abort() in order to continue unloading the module. The example synchronization code shows below: while (THIS_MODULE

Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-03 Thread Matt Fleming
On Mon, 2014-11-03 at 08:15 -0200, Henrique de Moraes Holschuh wrote: On Mon, 03 Nov 2014, Kweh Hock Leong wrote: Note for people who use request_firmware_nowait(): You are required to do your own synchronization after you call request_firmware_abort() in order to continue unloading the