Re: [PATCH 1/1] [x86] Configuration options to compile out x86 CPU support code

2008-08-15 Thread Ingo Molnar

* Thomas Petazzoni [EMAIL PROTECTED] wrote:

 This patch adds some configuration options that allow to compile out 
 CPU vendor-specific code in x86 kernels (in arch/x86/kernel/cpu). The 
 new configuration options are only visible when CONFIG_EMBEDDED is 
 selected, as they are mostly interesting for space savings reasons.
 
 An example of size saving, on x86 with only Intel CPU support:
 
text  data bss dec hex filename
 1125479118760  212992 1457231  163c4f vmlinux.old
 1121355116536  212992 1450883  162383 vmlinux
   -4124   -2224   0   -6348   -18CC +/-
 
 However, I'm not exactly sure that the Kconfig wording is correct with 
 regard to !64BIT / 64BIT.

applied to tip/x86/cpu, thanks Thomas. (I've done a trivial cleanup: 
converted the macro to an inline.)

Peter, do you like this version of the patch or would you like further 
improvements?

Ingo
--
To unsubscribe from this list: send the line unsubscribe linux-embedded in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/1] [x86] Configuration options to compile out x86 CPU support code

2008-08-15 Thread Ingo Molnar

-tip testing found a couple of build failures:

  LD  .tmp_vmlinux1
arch/x86/lib/lib.a(usercopy_32.o): In function `__copy_to_user_ll':
(.text+0x11e): undefined reference to `movsl_mask'
arch/x86/lib/lib.a(usercopy_32.o): In function `__copy_from_user_ll':
(.text+0x1fa): undefined reference to `movsl_mask'
arch/x86/lib/lib.a(usercopy_32.o): In function 
`__copy_from_user_ll_nozero':
(.text+0x2d6): undefined reference to `movsl_mask'
arch/x86/lib/lib.a(usercopy_32.o): In function `copy_from_user':
(.text+0x5ac): undefined reference to `movsl_mask'
arch/x86/lib/lib.a(usercopy_32.o): In function `copy_to_user':
(.text+0x6bf): undefined reference to `movsl_mask'
make: *** [.tmp_vmlinux1] Error 1

with:

  http://redhat.com/~mingo/misc/config-Fri_Aug_15_16_35_03_CEST_2008.bad

and:

arch/x86/kvm/built-in.o: In function `paging64_cmpxchg_gpte':
mmu.c:(.text+0xa80d): undefined reference to `cmpxchg_486_u64'

with:

  http://redhat.com/~mingo/misc/config-Fri_Aug_15_16_27_47_CEST_2008.bad

reverting your change solved both of them.

i still have the commit in tip/x86/cpu so please send a delta fix ontop 
of your previous patch once you figure out the problem. Thanks,

Ingo
--
To unsubscribe from this list: send the line unsubscribe linux-embedded in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/1] [x86] Configuration options to compile out x86 CPU support code

2008-08-09 Thread Bodo Eggert
Thomas Petazzoni [EMAIL PROTECTED] wrote:

 This patch adds some configuration options that allow to compile out
 CPU vendor-specific code in x86 kernels (in arch/x86/kernel/cpu). The
 new configuration options are only visible when CONFIG_EMBEDDED is
 selected, as they are mostly interesting for space savings reasons.

 +menuconfig PROCESSOR_SELECT
 + default y
 + bool Supported processor vendors if EMBEDDED
 + help
 +   This lets you choose what x86 vendor support code your kernel
 +   will include.
 +
 +config CPU_SUP_INTEL_32
 + default y
 + bool Support Intel processors if PROCESSOR_SELECT
 + depends on !64BIT
 + help
 +   This enables extended support for Intel processors
 +

I don't think having a generic kernel for only Intel CPUs makes much sense,
and OTOH, if you optimize for e.g. Athlon CPUs, you're likely to not need
Intel code on that machine - even on desktop systems.

What about an option to Include code for CPUs from all supported vendors,
invisible and y for generic kernels?

--
To unsubscribe from this list: send the line unsubscribe linux-embedded in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html