[RFC/PATCH] ext4: Fix the memory leak and buffer head leak with respect to ext4_ext_path

2008-02-14 Thread Aneesh Kumar K.V
The path variable returned via ext4_ext_find_extent is a kmalloc variable and need to be freeded. It also contain refrences to buffer_head which need to be dropped. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/extents.c |6 +++--- fs/ext4/migrate.c

[RFC/PATCH] ext4: Request for journal write access early.

2008-02-14 Thread Aneesh Kumar K.V
In ext4_ext_convert_to_initialized before we need to request for journal write access before we even modify the extent length. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/extents.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] ext4: Fix kernel BUG at fs/ext4/mballoc.c:910!

2008-02-14 Thread Valerie Clement
Andreas Dilger wrote: On Feb 13, 2008 18:19 +0100, Valerie Clement wrote: From: Valerie Clement [EMAIL PROTECTED] With the flex_bg feature enabled, a large file creation oopses the kernel. The BUG_ON is: BUG_ON(len = EXT4_BLOCKS_PER_GROUP(sb)); As the allocation of the bitmaps and

Re: [PATCH] ext4: Fix kernel BUG at fs/ext4/mballoc.c:910!

2008-02-14 Thread Valerie Clement
Aneesh Kumar K.V wrote: diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index b0f84b4..0275150 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -907,7 +907,7 @@ static void ext4_mb_mark_free_simple(struct super_block *sb, unsigned short chunk; unsigned short border;

Re: [RFC/PATCH] ext4: Fix the memory leak and buffer head leak with respect to ext4_ext_path

2008-02-14 Thread Mingming Cao
On Thu, 2008-02-14 at 16:00 +0530, Aneesh Kumar K.V wrote: The path variable returned via ext4_ext_find_extent is a kmalloc variable and need to be freeded. It also contain refrences to buffer_head which need to be dropped. Acked. Mingming Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]

Re: [RFC/PATCH] ext4: Request for journal write access early.

2008-02-14 Thread Mingming Cao
On Thu, 2008-02-14 at 16:00 +0530, Aneesh Kumar K.V wrote: In ext4_ext_convert_to_initialized before we need to request for journal write access before we even modify the extent length. Acked. Thanks Mingming Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/extents.c | 11

Re: [PATCH RESEND] ext4: Fix kernel BUG at fs/ext4/mballoc.c:910!

2008-02-14 Thread Andreas Dilger
On Feb 14, 2008 17:35 +0100, Valerie Clement wrote: From: Valerie Clement [EMAIL PROTECTED] With the flex_bg feature enabled, a large file creation oopses the kernel. The BUG_ON is: BUG_ON(len = EXT4_BLOCKS_PER_GROUP(sb)); As the allocation of the bitmaps and the inode table can

+ ext2-convert-byte-order-of-constant-instead-of-variable.patch added to -mm tree

2008-02-14 Thread akpm
The patch titled ext2: convert byte order of constant instead of variable has been added to the -mm tree. Its filename is ext2-convert-byte-order-of-constant-instead-of-variable.patch Before you just go and hit reply, please: a) Consider who else should be cc'ed b) Prefer to cc

+ ext4-convert-byte-order-of-constant-instead-of-variable.patch added to -mm tree

2008-02-14 Thread akpm
The patch titled ext4: convert byte order of constant instead of variable has been added to the -mm tree. Its filename is ext4-convert-byte-order-of-constant-instead-of-variable.patch Before you just go and hit reply, please: a) Consider who else should be cc'ed b) Prefer to cc

Re: [RFC/PATCH] ext4: Fix the memory leak and buffer head leak with respect to ext4_ext_path

2008-02-14 Thread Mingming Cao
Added in ext4 patch queue, Thanks On Thu, 2008-02-14 at 16:00 +0530, Aneesh Kumar K.V wrote: The path variable returned via ext4_ext_find_extent is a kmalloc variable and need to be freeded. It also contain refrences to buffer_head which need to be dropped. Signed-off-by: Aneesh Kumar K.V

Re: [RFC/PATCH] ext4: Request for journal write access early.

2008-02-14 Thread Mingming Cao
Added in ext4 patch queue, Thanks On Thu, 2008-02-14 at 16:00 +0530, Aneesh Kumar K.V wrote: In ext4_ext_convert_to_initialized before we need to request for journal write access before we even modify the extent length. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] ---

Re: [PATCH resend] ext2/3/4: convert byte order of constant instead of variable

2008-02-14 Thread Mingming Cao
On Thu, 2008-02-14 at 14:20 -0800, Andrew Morton wrote: On Sun, 10 Feb 2008 11:10:15 +0100 Marcin Slusarz [EMAIL PROTECTED] wrote: fs/ext2/super.c |8 +++- fs/ext3/super.c |2 +- fs/ext4/super.c |2 +- Please don't bundle the filesystem patches in this manner. I split

[PATCH] blkid detection for ZFS

2008-02-14 Thread Andreas Dilger
Attached is a patch to detect ZFS in libblkid. It isn't by any means complete, because it doesn't report the LABEL or UUID of the device, nor names any of the constituent filesystems. The latter is quite complex to implement and may be beyond the scope of libblkid. Some input is welcome here