Re: [f2fs-dev] [PATCH V2 2/2 RESEND] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-20 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Thursday, November 21, 2013 12:46 PM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net; '谭姝' > Subject: RE: [f2fs-dev] [PATCH V2 2/

Re: [f2fs-dev] [PATCH V2 2/2] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-20 Thread Chao Yu
Hi Gu, > -Original Message- > From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] > Sent: Wednesday, November 20, 2013 5:38 PM > To: Chao Yu > Cc: '???'; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net; '谭姝' > Subject: Re: [f2fs-dev] [PATC

Re: [f2fs-dev] [PATCH 1/2] f2fs: disable the extent cache ops on high fragmented files

2013-11-20 Thread Haicheng Li
> Signed-off-by: Jaegeuk Kim Function looks good to me. But some nitpicking below for code cleanup.. > @@ -71,6 +71,9 @@ static int check_extent_cache(struct inode *inode, pgoff_t > pgofs, return value could be boolean? > pgoff_t start_fofs, end_fofs; > block_t start_blkaddr; > >

Re: [f2fs-dev] [PATCH V2 2/2 RESEND] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-20 Thread Jaegeuk Kim
Hi, 2013-11-21 (목), 11:18 +0800, Chao Yu: > Hi, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > > Sent: Thursday, November 21, 2013 9:32 AM > > To: Chao Yu > > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > > linux-f2fs-devel@lists.so

Re: [f2fs-dev] [PATCH V2 2/2 RESEND] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-20 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Thursday, November 21, 2013 9:32 AM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net; 谭姝 > Subject: Re: [f2fs-dev] [PATCH V2 2/2 R

Re: [f2fs-dev] [PATCH V2 2/2 RESEND] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-20 Thread Jaegeuk Kim
Hi, It seems that ra_sit_pages() is too tightly coupled with build_sit_entries(). Is there another way not to use *is_order? The ra_sit_pages() tries to read consecutive sit pages as many as possible. So then, what about just checking whether its block address is contiguous or not? Something lik

Re: [f2fs-dev] [PATCH 5/5] f2fs: move the list_head initialization into the lock protection region

2013-11-20 Thread Jaegeuk Kim
Ok, got it. Thanks, :) 2013-11-20 (수), 17:48 +0800, Gu Zheng: > Hi Kim, > On 11/20/2013 09:31 AM, Jaegeuk Kim wrote: > > > Hi Gu, > > > > IMO, there is no reason to cover the list header by the lock. > > In any flows, sbi should have the header all the time. > > Yes, you're right. > > > What i

Re: [f2fs-dev] [Bug] Inaccessible, unerasable file

2013-11-20 Thread tast ky
If there are no further questions, I will format the stick this weekend. On Tue, Nov 19, 2013 at 4:34 PM, tast ky wrote: > Hello again, > > after buying a new USB stick and moving everything but the partition's > broken file & folder to it, I am now able to send you an image after > all. > > Alth

Re: [f2fs-dev] [PATCH V2 4/6] f2fs: Key functions to handle inline data

2013-11-20 Thread Huajun Li
On Fri, Nov 15, 2013 at 3:49 PM, Jaegeuk Kim wrote: > Hi Huajun, > > [snip] > >> +static int __f2fs_convert_inline_data(struct inode *inode, struct page >> *page) >> +{ >> + int err; >> + struct page *ipage; >> + struct dnode_of_data dn; >> + void *src_addr, *dst_addr; >> + bl

Re: [f2fs-dev] [PATCH 5/5] f2fs: move the list_head initialization into the lock protection region

2013-11-20 Thread Gu Zheng
Hi Kim, On 11/20/2013 09:31 AM, Jaegeuk Kim wrote: > Hi Gu, > > IMO, there is no reason to cover the list header by the lock. > In any flows, sbi should have the header all the time. Yes, you're right. > What is your opinion? Moving the list_head initialization into the lock protection region,

Re: [f2fs-dev] [PATCH V2 2/2] f2fs: read contiguous sit entry pages by merging for mount performance

2013-11-20 Thread Gu Zheng
Hi Yu, On 11/20/2013 01:37 PM, Chao Yu wrote: > Hi Gu, > >> -Original Message- >> From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] >> Sent: Monday, November 18, 2013 7:16 PM >> To: Chao Yu >> Cc: '???'; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; >> linux-f2fs-devel@lists

[f2fs-dev] [PATCH 2/2] f2fs: adds a tracepoint for f2fs_submit_read_bio

2013-11-20 Thread Chao Yu
This patch adds a tracepoint for f2fs_submit_read_bio. Signed-off-by: Chao Yu --- fs/f2fs/data.c |2 ++ include/trace/events/f2fs.h | 27 +++ 2 files changed, 29 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 0ca93be..c9e9d79 100644 -

[f2fs-dev] [PATCH 1/2] f2fs: adds a tracepoint for submit_read_page

2013-11-20 Thread Chao Yu
This patch adds a tracepoint for submit_read_page. Signed-off-by: Chao Yu --- fs/f2fs/data.c |1 + include/trace/events/f2fs.h | 30 ++ 2 files changed, 31 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 9cf3f6c..0ca93be 100644 ---