[f2fs-dev] [PATCH] mkfs.f2fs.8: Better document the -g argument.

2020-12-16 Thread John A. Leuenhagen via Linux-f2fs-devel
To use Android defaults, you must use `-g android`. However, the man page previously implied that you need only use `-g`. Since you must specify `android`, I figured it would be appropriate to name that field `default-options` in the man page. If there was ever a reason to have a different set of

Re: [f2fs-dev] [PATCH] mkfs.f2fs: Fix behavior of -g option to match the man page.

2020-12-16 Thread John A. Leuenhagen via Linux-f2fs-devel
On Wed, Dec 16, 2020 at 10:26:54PM -0800, Jaegeuk Kim wrote: > Hi, > > On 12/14, John A. Leuenhagen via Linux-f2fs-devel wrote: > > The man page states that simply specifying the -g option will use the > > default Android options. However, mkfs.f2fs currently requires the user > > to specify `-g

Re: [f2fs-dev] [PATCH] f2fs: fix out-of-repair __setattr_copy()

2020-12-16 Thread Chao Yu
On 2020/12/16 17:44, Greg KH wrote: On Wed, Dec 16, 2020 at 05:15:23PM +0800, Chao Yu wrote: __setattr_copy() was copied from setattr_copy() in fs/attr.c, there is two missing patches doesn't cover this inner function, fix it. Commit 7fa294c8991c ("userns: Allow chown and setgid preservation")

[f2fs-dev] [Bug 210745] New: kernel crash during umounting a partition with f2fs filesystem

2020-12-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210745 Bug ID: 210745 Summary: kernel crash during umounting a partition with f2fs filesystem Product: File System Version: 2.5 Kernel Version: 4.14.193 Hardware: All

Re: [f2fs-dev] [PATCH] mkfs.f2fs: Fix behavior of -g option to match the man page.

2020-12-16 Thread Jaegeuk Kim
Hi, On 12/14, John A. Leuenhagen via Linux-f2fs-devel wrote: > The man page states that simply specifying the -g option will use the > default Android options. However, mkfs.f2fs currently requires the user > to specify `-g android`. This makes the behavior of mkfs.f2fs match the > man page. I

Re: [f2fs-dev] [PATCH] f2fs: fix to set inode->i_mode correctly for posix_acl_update_mode

2020-12-16 Thread Jaegeuk Kim
On 12/16, Chao Yu wrote: > Jaegeuk, > > Do you remember why we use i_acl_mode to store acl related mode? > Can we get rid of it? IIRC, it is used for error handling, so it seems we can't remove it. > > Thanks, > > On 2020/12/16 17:16, Chao Yu wrote: > > On 2020/12/14 11:54, Weichao Guo wrote:

[f2fs-dev] [GIT PULL] f2fs update for 5.11-rc1

2020-12-16 Thread Jaegeuk Kim
Hi Linus, Could you please consider this pull request? Thank you so much, The following changes since commit 3cea11cd5e3b00d91caf0b4730194039b45c5891: Linux 5.10-rc2 (2020-11-01 14:43:51 -0800) are available in the Git repository at:

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-16 Thread Michał Mirosław
On Wed, Dec 16, 2020 at 10:07:38PM +, Nick Terrell wrote: [...] > It is very large. If it helps, in the commit message I’ve provided this link > [0], > which provides the diff between upstream zstd as-is and the imported zstd, > which has been modified by the automated tooling to work in the

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-16 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 16, 2020, at 10:50 AM, David Sterba wrote: > > On Wed, Dec 16, 2020 at 11:58:07AM +1100, Herbert Xu wrote: >> On Wed, Dec 16, 2020 at 12:48:51AM +, Nick Terrell wrote: >>> >>> Thanks for the advice! The first zstd patches went through Herbert’s tree, >>> which is >>> why I’ve

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-16 Thread David Sterba
On Wed, Dec 16, 2020 at 11:58:07AM +1100, Herbert Xu wrote: > On Wed, Dec 16, 2020 at 12:48:51AM +, Nick Terrell wrote: > > > > Thanks for the advice! The first zstd patches went through Herbert’s tree, > > which is > > why I’ve sent them this way. > > Sorry, but I'm not touch these patches

Re: [f2fs-dev] [PATCH] f2fs: fix out-of-repair __setattr_copy()

2020-12-16 Thread Greg KH
On Wed, Dec 16, 2020 at 05:15:23PM +0800, Chao Yu wrote: > __setattr_copy() was copied from setattr_copy() in fs/attr.c, there is > two missing patches doesn't cover this inner function, fix it. > > Commit 7fa294c8991c ("userns: Allow chown and setgid preservation") > Commit 23adbe12ef7d

Re: [f2fs-dev] [PATCH] f2fs: fix to set inode->i_mode correctly for posix_acl_update_mode

2020-12-16 Thread Chao Yu
Jaegeuk, Do you remember why we use i_acl_mode to store acl related mode? Can we get rid of it? Thanks, On 2020/12/16 17:16, Chao Yu wrote: On 2020/12/14 11:54, Weichao Guo wrote: We should update the ~S_IRWXUGO part of inode->i_mode in __setattr_copy, because posix_acl_update_mode updates

Re: [f2fs-dev] [PATCH] f2fs: fix to set inode->i_mode correctly for posix_acl_update_mode

2020-12-16 Thread Chao Yu
On 2020/12/14 11:54, Weichao Guo wrote: We should update the ~S_IRWXUGO part of inode->i_mode in __setattr_copy, because posix_acl_update_mode updates mode based on inode->i_mode, which finally overwrites the ~S_IRWXUGO part of i_acl_mode with old i_mode. Testcase to reproduce this bug: 0.

[f2fs-dev] [PATCH] f2fs: fix out-of-repair __setattr_copy()

2020-12-16 Thread Chao Yu
__setattr_copy() was copied from setattr_copy() in fs/attr.c, there is two missing patches doesn't cover this inner function, fix it. Commit 7fa294c8991c ("userns: Allow chown and setgid preservation") Commit 23adbe12ef7d ("fs,userns: Change inode_capable to capable_wrt_inode_uidgid") Cc: