[f2fs-dev] [PATCH] f2fs: introduce gc_urgent_mid mode

2022-03-15 Thread Daeho Jeong
From: Daeho Jeong We need a mid level of gc urgent mode to do GC forcibly in a period of given gc_urgent_sleep_time, but not like using greedy GC approach and switching to SSR mode such as gc urgent high mode. This can be used for more aggressive periodic storage clean up. Signed-off-by: Daeho J

Re: [f2fs-dev] [PATCH 2/2] f2fs: use spin_lock to avoid hang

2022-03-15 Thread Chao Yu
On 2022/3/10 5:48, Jaegeuk Kim wrote: [14696.634553] task:cat state:D stack:0 pid:1613738 ppid:1613735 flags:0x0004 [14696.638285] Call Trace: [14696.639038] [14696.640032] __schedule+0x302/0x930 [14696.640969] schedule+0x58/0xd0 [14696.641799] schedule_preempt_disabled+

Re: [f2fs-dev] EIO returned when reading files from R/O, compressed f2fs image

2022-03-15 Thread Jaegeuk Kim
On 03/15, Juhyung Park wrote: > Here's strace from both commands right after drop_caches. > > cp: https://pastebin.com/raw/GH51BjV4 > tar: https://pastebin.com/raw/0wgiu7fE Can we catch who sets EIO? # echo 1 > /sys/kernel/tracing/events/f2fs/f2fs_readpage/enable # echo 1 > /sys/kernel/tracing/e

Re: [f2fs-dev] EIO returned when reading files from R/O, compressed f2fs image

2022-03-15 Thread Juhyung Park
Here's strace from both commands right after drop_caches. cp: https://pastebin.com/raw/GH51BjV4 tar: https://pastebin.com/raw/0wgiu7fE It seems that cp is calling a few extra fadvise and ioctl. On Tue, Mar 15, 2022 at 7:25 PM Juhyung Park wrote: > > Hi Chao, > > On Tue, Mar 15, 2022 at 5:45 PM

Re: [f2fs-dev] EIO returned when reading files from R/O, compressed f2fs image

2022-03-15 Thread Juhyung Park
Hi Chao, On Tue, Mar 15, 2022 at 5:45 PM Chao Yu wrote: > > Hi Juhyung, > > On 2022/3/15 16:37, Juhyung Park wrote: > > Hi Chao, > > > > I actually have never used compression on f2fs yet and this image is > > from an unmodified firmware taken directly from the OTA server, not > > made by me. > >

Re: [f2fs-dev] [PATCH v2] generic/066: attr1 is still there after log replay on f2fs

2022-03-15 Thread Sun Ke via Linux-f2fs-devel
在 2022/3/15 12:01, Chao Yu 写道: On 2022/3/11 17:43, Sun Ke via Linux-f2fs-devel wrote: The test fail on f2fs:   xattr names and values after second fsync log replay:   # file: SCRATCH_MNT/foobar +user.attr1="val1"   user.attr3="val3" attr1 is still there after log replay. f2fs

Re: [f2fs-dev] EIO returned when reading files from R/O, compressed f2fs image

2022-03-15 Thread Chao Yu
Hi Juhyung, On 2022/3/15 16:37, Juhyung Park wrote: Hi Chao, I actually have never used compression on f2fs yet and this image is from an unmodified firmware taken directly from the OTA server, not made by me. Alright. If you can tell me how to check if the file is compressed or not, I'll

Re: [f2fs-dev] EIO returned when reading files from R/O, compressed f2fs image

2022-03-15 Thread Juhyung Park
Hi Chao, I actually have never used compression on f2fs yet and this image is from an unmodified firmware taken directly from the OTA server, not made by me. If you can tell me how to check if the file is compressed or not, I'll run it and report back. I never had this sort of issue (a lot of mu

Re: [f2fs-dev] EIO returned when reading files from R/O, compressed f2fs image

2022-03-15 Thread Chao Yu
On 2022/3/14 1:52, Juhyung Park wrote: Hi. We have a production server storing some Android firmwares over a ZFS file-system, and we noticed some issues when extracting firmware files that use f2fs for Android system partitions. This is a proprietary environment, so I cannot disclose every deta

Re: [f2fs-dev] [PATCH] f2fs: remove redundant parameter judgment

2022-03-15 Thread Chao Yu
On 2022/3/14 15:15, Wang Xiaojun via Linux-f2fs-devel wrote: iput() has already judged the incoming parameter, so there is no need to repeat the judgment here. Signed-off-by: Wang Xiaojun Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing