Chao Yu 于2025年8月8日周五 12:14写道:
>
> On 8/8/2025 9:07 AM, Zhiguo Niu wrote:
> > Chao Yu via Linux-f2fs-devel
> > 于2025年8月7日周四 09:52写道:
> >>
> >> mount -t f2fs -o checkpoint=disable:10% /dev/vdb /mnt/f2fs/
> >> mount -t f2fs -o remount,checkpoint=en
Chao Yu via Linux-f2fs-devel
于2025年8月7日周四 09:52写道:
>
> mount -t f2fs -o checkpoint=disable:10% /dev/vdb /mnt/f2fs/
> mount -t f2fs -o remount,checkpoint=enable /dev/vdb /mnt/f2fs/
>
> kernel log:
> F2FS-fs (vdb): Adjust unusable cap for checkpoint=disable = 204440 / 10%
>
> If we has assigned chec
Chunhai Guo via Linux-f2fs-devel
于2025年8月6日周三 17:22写道:
>
> This patch allows privileged users to reserve nodes via the
> 'reserve_node' mount option, which is similar to the existing
> 'reserve_root' option.
>
> "-o reserve_node=" means nodes are reserved for privileged
> users only.
>
> Signed-o
: Chao Yu
> ---
> v3:
> - export f2fs_submit_flush_wait()
looks good to me.
Reviewed-by: Zhiguo Niu
> Documentation/ABI/testing/sysfs-fs-f2fs | 9 +
> fs/f2fs/checkpoint.c| 11 ++-
> fs/f2fs/f2fs.h | 9 +
> fs/f2
bad performance on REQ_FUA command, result in that
> checkpoint being blocked for long time, w/ this sysfs entry, we can give
> an option to use REQ_PREFLUSH command instead of REQ_FUA during checkpoint,
> it can help to mitigate long latency of checkpoint.
>
> Signed-off-by:
Chao Yu via Linux-f2fs-devel
于2025年7月31日周四 16:49写道:
>
> This patch introduces a new sysfs entry /sys/fs/f2fs//flush_policy
> in order to tune performance of f2fs data flush flow.
>
> For example, checkpoint will use REQ_FUA to persist CP metadata, however,
> some kind device has bad performance on
set_sb(s_encoding, c.s_encoding);
> set_sb(s_encoding_flags, c.s_encoding_flags);
> }
> diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
> index f0bec4f..8f8e975 100644
> --- a/mkfs/f2fs_format_main.c
> +++ b/mkfs/f2fs_format_main.c
> @@ -143,7
Chao Yu 于2025年7月25日周五 10:45写道:
>
> On 7/25/2025 10:08 AM, Zhiguo Niu wrote:
> > Chao Yu via Linux-f2fs-devel
> > 于2025年7月25日周五 09:03写道:
> >>
> >> It provides a way to disable linear lookup fallback during mkfs.
> >>
> >> Behavior summary
Chao Yu via Linux-f2fs-devel
于2025年7月25日周五 09:03写道:
>
> It provides a way to disable linear lookup fallback during mkfs.
>
> Behavior summary:
> Android Distro
> By default disabledenabled
> Tune w/ [no]hashonlyno yes
>
> Androi
Should check these after c.devices[1].start_blkaddr is assigned
when c.ndevs > 1.
Fixes: 316e128fe3dc ("mkfs.f2fs: adjust zone alignment when using
multi-partitions")
Signed-off-by: Zhiguo Niu
---
mkfs/f2fs_format.c | 23 ---
1 file changed, 12 insertions(+),
wangzijie 于2025年6月12日周四 20:38写道:
>
> > On 6/12/25 11:27, wangzijie wrote:
> > > Wu Bo once mentioned a fallocate fail scenario in this link[1].
> > > After commit 3fdd89b452c2("f2fs: prevent writing without fallocate()
> > > for pinned files"), we cannot directly generate 4K size file and
> > > pi
https://lore.kernel.org/all/c36ab955-c8db-4a8b-a9d0-f07b5f426...@kernel.org
Cc: Daeho Jeong
Fixes: bff139b49d9f ("f2fs: handle decompress only post processing in softirq")
Signed-off-by: Zhiguo Niu
Signed-off-by: Baocong Liu
---
fs/f2fs/compress.c | 40
No logic changes, just cleanup and prepare for fixing the UAF issue
in f2fs_free_dic.
Signed-off-by: Zhiguo Niu
Signed-off-by: Baocong Liu
---
fs/f2fs/compress.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/fs/f2fs/compress.c b
Zhiguo Niu 于2025年6月11日周三 14:52写道:
>
> Chao Yu 于2025年6月11日周三 14:47写道:
> >
> > On 6/11/25 14:41, Zhiguo Niu wrote:
> > > Chao Yu 于2025年6月11日周三 14:07写道:
> > >>
> > >> On 6/11/25 00:08, Jaegeuk Kim wrote:
> > >>> Hi Zhiguo,
&
to solve this problem?
" store i_compress_algorithm/sbi in dic to avoid inode access?"
thanks!
>
> >
> > On 06/05, Zhiguo Niu wrote:
> >> The decompress_io_ctx may be released asynchronously after
> >> I/O completion. If this file is deleted immediate
Chao Yu 于2025年6月11日周三 14:47写道:
>
> On 6/11/25 14:41, Zhiguo Niu wrote:
> > Chao Yu 于2025年6月11日周三 14:07写道:
> >>
> >> On 6/11/25 00:08, Jaegeuk Kim wrote:
> >>> Hi Zhiguo,
> >>>
> >>> This patch causes CPU hang when running fsst
Chao Yu 于2025年6月5日周四 17:28写道:
>
> On 4/27/25 09:49, Zhiguo Niu wrote:
> > Hi Chao
> >
> > Chao Yu 于2025年4月25日周五 13:30写道:
> >>
> >> Zhiguo,
> >>
> >> On 4/25/25 13:11, Zhiguo Niu wrote:
> >>> Hi Chao and Jaegeuk,
> &g
decompress only post processing in softirq")
Signed-off-by: Zhiguo Niu
Signed-off-by: Baocong Liu
---
v3: use igrab to replace __iget
v2: use __iget/iput function
---
fs/f2fs/compress.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/comp
* zero_range
> * insert_range
> * collapse_range
> - clone_range (doesn’t support in f2fs)
> - copy_range (doesn’t support in f2fs)
>
> [1] https://man7.org/linux/man-pages/man2/mmap.2.html 'BUG section'
>
> Cc: sta...@kernel.org
> Signed-off-by: Chao Yu
Review
Chao Yu 于2025年6月5日周四 11:31写道:
>
> On 6/5/25 10:44, Zhiguo Niu wrote:
> > Chao Yu 于2025年6月5日周四 10:23写道:
> >>
> >> On 6/4/25 19:37, Zhiguo Niu wrote:
> >>> The decompress_io_ctx may be released asynchronously after
> >>> I/O completion. If this
Chao Yu 于2025年6月5日周四 10:23写道:
>
> On 6/4/25 19:37, Zhiguo Niu wrote:
> > The decompress_io_ctx may be released asynchronously after
> > I/O completion. If this file is deleted immediately after read,
> > and the kworker of processing post_read_wq has not been exec
Chao Yu via Linux-f2fs-devel
于2025年6月4日周三 17:01写道:
>
> fstest reports a f2fs bug:
>
> generic/363 42s ... [failed, exit status 1]- output mismatch (see
> /share/git/fstests/results//generic/363.out.bad)
> --- tests/generic/363.out 2025-01-12 21:57:40.271440542 +0800
> +++ /share/git/fst
in softirq")
Signed-off-by: Zhiguo Niu
Signed-off-by: Baocong Liu
---
v2: use __iget/iput function
---
fs/f2fs/compress.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index b3c1df9..3f0c18d 100644
--- a/fs/f2fs/com
Chao Yu 于2025年6月4日周三 19:09写道:
>
> On 6/4/25 18:49, Zhiguo Niu wrote:
> > Chao Yu 于2025年6月4日周三 17:48写道:
> >>
> >> On 6/4/25 13:54, Zhiguo Niu wrote:
> >>> The decompress_io_ctx may be released asynchronously after
> >>> I/O completion. If this
Chao Yu 于2025年6月4日周三 17:48写道:
>
> On 6/4/25 13:54, Zhiguo Niu wrote:
> > The decompress_io_ctx may be released asynchronously after
> > I/O completion. If this file is deleted immediately after read,
> > and the kworker of processing post_read_wq has not been exec
ress only post processing in softirq")
Signed-off-by: Zhiguo Niu
Signed-off-by: Baocong Liu
---
fs/f2fs/compress.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index b3c1df9..6b3b3a7 100644
--- a/fs/f2fs/compr
> - clean up the codes
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 5ff0111ed974..24b4bb2a4b9b 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -433,7 +433,7 @@
Chao Yu via Linux-f2fs-devel
于2025年5月21日周三 20:02写道:
>
> INFO: task syz-executor328:5856 blocked for more than 144 seconds.
> Not tainted 6.15.0-rc6-syzkaller-00208-g3c21441eeffc #0
> "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> task:syz-executor328 state:D stac
Should be "old_dir" here.
Fixes: 5c57132eaf52 ("f2fs: support project quota")
Signed-off-by: Zhiguo Niu
---
fs/f2fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index bb22543..07e333e 100644
--- a/fs/f2fs/n
no logic changes.
Signed-off-by: Zhiguo Niu
---
fs/f2fs/namei.c | 8
fs/f2fs/super.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 0b231bc..bb22543 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -414,7 +414,7
Hi Chao
Chao Yu 于2025年4月25日周五 13:30写道:
>
> Zhiguo,
>
> On 4/25/25 13:11, Zhiguo Niu wrote:
> > Hi Chao and Jaegeuk,
> >
> > I encountered a problem with node footer data being corrupted on an
> > Android device.(kernel version 6.6 and android version:15)
>
Hi Chao and Jaegeuk,
I encountered a problem with node footer data being corrupted on an
Android device.(kernel version 6.6 and android version:15)
after I merged the following patches, the problem still exists.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev-t
Chao Yu 于2025年4月11日周五 18:32写道:
>
> On 2025/4/11 10:07, Zhiguo Niu wrote:
> > Chao Yu via Linux-f2fs-devel
> > 于2025年4月7日周一 10:11写道:
> >>
> >> Support a new option --nolinear-lookup=X for fsck.f2fs to tune
> >> linear lookup fallback conditionally,
Chao Yu via Linux-f2fs-devel
于2025年4月7日周一 10:11写道:
>
> Support a new option --nolinear-lookup=X for fsck.f2fs to tune
> linear lookup fallback conditionally, X=1: disable linear lookup,
> X=0: enable linear lookup.
>
> This can help to 1) add a regression testcase to check kernel
> whether linear
fter we commit all data, before committing metadata, we need to
> clear atomic dirty status, and set vfs dirty status to allow vfs flush
> dirty inode.
>
> Cc: Daeho Jeong
> Reported-by: Zhiguo Niu
> Signed-off-by: Chao Yu
Hi Chao,
it is more clear and I understand, thanks a
read IO error 0
> checkpoint error0
> discard error 0
> write IO error 0
> slab alloc 0
> dquot initialize0
> lock_op 0
> invalid blkaddr 0
> inconsistent blkaddr0
> no free segment
Chao Yu 于2025年3月26日周三 17:26写道:
>
> On 3/26/25 16:46, Zhiguo Niu wrote:
> > Commit fccaa81de87e ("f2fs: prevent atomic file from being dirtied before
> > commit")
> > adds the processing of FI_ATOMIC_DIRTIED in the following two positions,
&g
n atomic file is committing, then FI_ATOMIC_DIRTIED is just cleared here, and
then do the repeating action of setting FI_ATOMIC_DIRTIED?
So is it enough to do this only in [2]?
Cc: Daeho Jeong
Fixes: fccaa81de87e ("f2fs: prevent atomic file from being dirtied before
commit")
Signed-off-by
Chao Yu via Linux-f2fs-devel
于2025年3月25日周二 16:15写道:
>
> This patch uses i_sem to protect access/update on f2fs_inode_info.flag
> in finish_preallocate_blocks(), it avoids grabbing inode_lock() in
> each open().
>
> Signed-off-by: Chao Yu
Reviewed-by: Zhiguo Niu
thanks!
>
Chao Yu via Linux-f2fs-devel
于2025年3月24日周一 19:36写道:
>
> This patch uses i_sem to protect access/update on f2fs_inode_info.flag
> in finish_preallocate_blocks(), it avoids grabbing inode_lock() in
> each open().
>
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/file.c | 40 +++---
Chao Yu via Linux-f2fs-devel
于2025年3月19日周三 23:38写道:
>
> This patch adds a proc entry named inject_stats to show total injected
> count for each fault type.
>
> cat /proc/fs/f2fs//inject_stats
> fault_type injected_count
> kmalloc 0
> kvmalloc0
> page al
Chao Yu via Linux-f2fs-devel
于2025年3月3日周一 11:57写道:
>
> This patch introduces a new wrapper f2fs_get_inode_page(), then, caller
> can use it to load inode block to page cache, meanwhile it will do sanity
> check on inode footer.
>
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/data.c | 6 ++---
> fs
e for this time (e.g., their number
is below shrinkable limit)."
Signed-off-by: Zhiguo Niu
---
fs/f2fs/shrinker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/shrinker.c b/fs/f2fs/shrinker.c
index 45efff6..9c8d3ae 100644
--- a/fs/f2fs/shrinker.c
+++ b/fs/f2fs/
Chao Yu via Linux-f2fs-devel
于2025年2月6日周四 14:50写道:
>
> F2FS-fs (dm-59): checkpoint=enable has some unwritten data.
>
> [ cut here ]
> WARNING: CPU: 6 PID: 8013 at fs/quota/dquot.c:691
> dquot_writeback_dquots+0x2fc/0x308
> pc : dquot_writeback_dquots+0x2fc/0x308
> lr : f2f
xpectedly, thereby changing the caller's
behavior
This patch let the f2fs_recover_fsync_data return correct value,and not do
f2fs_check_and_fix_write_pointer when the device is read-only.
Fixes: c426d99127b1 ("f2fs: Check write pointer consistency of open zones")
Signed-off-by
a sysfs node to limit max read extent count for each inode,
> by default, value of this threshold is 10240, it can be updated
> according to user's requirement.
>
> Reported-by: Xiuhong Wang
> Closes:
> https://lore.kernel.org/linux-f2fs-devel/20241112110627.1314632-1-xiuho
Chao Yu 于2024年11月20日周三 16:15写道:
>
> On 2024/11/20 13:45, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月20日周三 11:26写道:
> >>
> >> On 2024/11/19 16:26, Zhiguo Niu wrote:
> >>> Chao Yu 于2024年11月19日周二 15:50写道:
> >>>>
> >>>> On 2024/
Chao Yu 于2024年11月20日周三 11:26写道:
>
> On 2024/11/19 16:26, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月19日周二 15:50写道:
> >>
> >> On 2024/11/19 14:46, Xiuhong Wang wrote:
> >>> Chao Yu 于2024年11月19日周二 14:05写道:
> >>>>
> >>>> On 20
> >>>
> >>> crash_arm64_sprd_v8.0.3++> extent_tree.node_cnt ff80896cc500
> >>> node_cnt = {
> >>> counter = 1086911
> >>> },
> >>>
> >>> The root cause of this problem is that when the f2fs_bal
Chao Yu 于2024年11月8日周五 09:22写道:
>
> On 2024/11/7 18:53, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月7日周四 16:22写道:
> >>
> >> On 2024/11/7 14:54, Zhiguo Niu wrote:
> >>> Chao Yu 于2024年11月7日周四 14:18写道:
> >>>>
> >>>> On 2
Chao Yu 于2024年11月7日周四 16:22写道:
>
> On 2024/11/7 14:54, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月7日周四 14:18写道:
> >>
> >> On 2024/11/6 16:41, Zhiguo Niu wrote:
> >>> Chao Yu 于2024年11月6日周三 15:40写道:
> >>>>
> >>>> On 2
Chao Yu 于2024年11月7日周四 14:18写道:
>
> On 2024/11/6 16:41, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月6日周三 15:40写道:
> >>
> >> On 2024/11/6 14:08, Zhiguo Niu wrote:
> >>> Chao Yu 于2024年11月6日周三 10:40写道:
> >>>>
> >>>> On 2
cleanup.
>
> Reported-by: Zhiguo Niu
> Signed-off-by: Chao Yu
feel free to add:
Reviewed-by: Zhiguo Niu
thanks!
> ---
> fs/f2fs/data.c | 68 +-
> 1 file changed, 29 insertions(+), 39 deletions(-)
>
> diff --git a/fs/
Chao Yu 于2024年11月6日周三 15:40写道:
>
> On 2024/11/6 14:08, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月6日周三 10:40写道:
> >>
> >> On 2024/11/6 10:26, Zhiguo Niu wrote:
> >>> Chao Yu 于2024年11月6日周三 10:16写道:
> >>>>
> >>>> On 2
Chao Yu 于2024年11月6日周三 10:40写道:
>
> On 2024/11/6 10:26, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月6日周三 10:16写道:
> >>
> >> On 2024/11/5 19:02, Zhiguo Niu wrote:
> >>> Chao Yu 于2024年11月5日周二 18:39写道:
> >>>>
> >>>> On 2
Chao Yu 于2024年11月6日周三 10:40写道:
>
> On 2024/11/6 10:26, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月6日周三 10:16写道:
> >>
> >> On 2024/11/5 19:02, Zhiguo Niu wrote:
> >>> Chao Yu 于2024年11月5日周二 18:39写道:
> >>>>
> >>>> On 2
Chao Yu 于2024年11月6日周三 10:16写道:
>
> On 2024/11/5 19:02, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月5日周二 18:39写道:
> >>
> >> On 2024/11/5 15:28, Zhiguo Niu wrote:
> >>> Chao Yu 于2024年11月5日周二 15:04写道:
> >>>>
> >>>> On 2024/
Should check after c.devices[1].start_blkaddr is assigned
if c.ndevs > 1.
Signed-off-by: Zhiguo Niu
---
mkfs/f2fs_format.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index 52a1e18..f7cfa5e 100644
--
Chao Yu 于2024年11月5日周二 18:39写道:
>
> On 2024/11/5 15:28, Zhiguo Niu wrote:
> > Chao Yu 于2024年11月5日周二 15:04写道:
> >>
> >> On 2024/11/4 9:56, Zhiguo Niu wrote:
> >>> If user give a file size as "length" parameter for fiemap
> >>> opera
Chao Yu 于2024年11月5日周二 15:04写道:
>
> On 2024/11/4 9:56, Zhiguo Niu wrote:
> > If user give a file size as "length" parameter for fiemap
> > operations, but if this size is non-block size aligned,
> > it will show 2 segments fiemap results even this whole file
>
Chao Yu 于2024年11月5日周二 11:15写道:
>
> On 2024/11/4 9:56, Zhiguo Niu wrote:
> > If user give a file size as "length" parameter for fiemap
> > operations, but if this size is non-block size aligned,
> > it will show 2 segments fiemap results even this whole file
>
en = 19034
logical addr.physical addr. length flags
0 315f3000 5000 1001
Signed-off-by: Zhiguo Niu
---
V2: correct commit msg according to Chao's questions
f2fs_io has been modified for testing, the length for fiemap is
real file
Chao Yu 于2024年11月1日周五 10:36写道:
>
> On 2024/10/31 13:59, Zhiguo Niu wrote:
> > If user give a file size as "length" parameter for fiemap
> > operations, but this size is non-block size aligned,
> > it will show 2 segments fiemap results even this whole file
>
Zhiguo Niu 于2024年11月1日周五 11:27写道:
>
> Chao Yu 于2024年11月1日周五 10:36写道:
> >
> > On 2024/10/31 13:59, Zhiguo Niu wrote:
> > > If user give a file size as "length" parameter for fiemap
> > > operations, but this size is non-block size aligned,
> >
Chao Yu 于2024年11月1日周五 10:36写道:
>
> On 2024/10/31 13:59, Zhiguo Niu wrote:
> > If user give a file size as "length" parameter for fiemap
> > operations, but this size is non-block size aligned,
> > it will show 2 segments fiemap results even this whole file
>
yi sun 于2024年10月31日周四 11:00写道:
>
> On Thu, Oct 31, 2024 at 1:00 AM Daeho Jeong wrote:
> >
> > On Wed, Oct 30, 2024 at 3:35 AM Yi Sun wrote:
> > >
> > > New function can process some consecutive blocks at a time.
> > >
> > > Function f2fs_invalidate_blocks()->down_write() and up_write()
> > > are
_io fiemap 0 19304 ylog/analyzer.py
Fiemap: offset = 0 len = 19304
logical addr.physical addr. length flags
0 315f3000 5000 1000
Signed-off-by: Zhiguo Niu
---
f2fs_io has been modified for testing, the length for fiemap is
real
f2fs_is_atomic_file(inode) is checked in f2fs_defragment_range,
so remove the redundant checking in f2fs_ioc_defragment.
Signed-off-by: Zhiguo Niu
---
fs/f2fs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 75a8b22..3e22f6e 100644
5fa8cd75ac ("mkfs.f2fs: change -c option description").
Signed-off-by: Zhiguo Niu
---
V2: unify default block size in f2fs_io.c
---
man/mkfs.f2fs.8 | 2 +-
tools/f2fs_io/f2fs_io.c | 37 -
tools/f2fs_io/f2fs_io.h | 2 +-
3 files changed, 22 inserti
= 1562, dents = 2,
imeta = 18, free_sec:44898, free_seg:44898, rsv_seg:239, prefree_seg:0
Fixes: 0e5e81114de1 ("f2fs: add GC_URGENT_LOW mode in gc_urgent")
Fixes: d98af5f45520 ("f2fs: introduce gc_urgent_mid mode")
Signed-off-by: Zhiguo Niu
---
v3: add more description
Chao Yu 于2024年10月28日周一 17:34写道:
>
> On 2024/10/23 11:08, Zhiguo Niu wrote:
> > If gc_mode is set to GC_URGENT_LOW or GC_URGENT_MID, cost benefit GC
> > approach should be used, but if ATGC is enabled at the same time,
> > Age-threshold approach will be selected, which can
Chao Yu 于2024年10月24日周四 18:49写道:
>
> On 2024/10/24 17:28, Zhiguo Niu wrote:
> > F2FS_BLKSIZE may be 4KB, 16KB, so use F2FS_BLKSIZE to replace
> > some hardcode desc about unit in some f2fs_io cmd, also
> > adjust "-c" parameters in mkfs man, to be consi
Dear Chao,
any suggestions about this patch version? base your kindly suggestions
on patch v1
this is the issue encountered when I test GC.
thanks!
Zhiguo Niu 于2024年10月23日周三 11:08写道:
>
> If gc_mode is set to GC_URGENT_LOW or GC_URGENT_MID, cost benefit GC
> approach should be used, bu
F2FS_BLKSIZE may be 4KB, 16KB, so use F2FS_BLKSIZE to replace
some hardcode desc about unit in some f2fs_io cmd, also
adjust "-c" parameters in mkfs man, to be consistent with
commit c35fa8cd75ac ("mkfs.f2fs: change -c option description").
Signed-off-by: Zhiguo Niu
= 1562, dents = 2,
imeta = 18, free_sec:44898, free_seg:44898, rsv_seg:239, prefree_seg:0
Fixes: 0e5e81114de1 ("f2fs: add GC_URGENT_LOW mode in gc_urgent")
Fixes: d98af5f45520 ("f2fs: introduce gc_urgent_mid mode")
Signed-off-by: Zhiguo Niu
---
v2: make GC_URGENT_LOW also use
Chao Yu 于2024年10月23日周三 10:42写道:
>
> On 2024/10/22 17:14, Zhiguo Niu wrote:
> > GC_URGENT_MID is introduced by commit
> > d98af5f45520 ("f2fs: introduce gc_urgent_mid mode"), aim to does GC
> > forcibly uses cost benefit GC approach, but if ATGC is enabled a
c_end: dev =
(254,48), ret = -61, seg_freed = 0, sec_freed = 0, nodes = 1562, dents = 2,
imeta = 18, free_sec:44898, free_seg:44898, rsv_seg:239, prefree_seg:0
Fixes: d98af5f45520 ("f2fs: introduce gc_urgent_mid mode")
Signed-off-by: Zhiguo Niu
---
fs/f2fs/gc.c | 1 +
1 file changed, 1 insert
Chao Yu via Linux-f2fs-devel
于2024年10月17日周四 17:57写道:
>
> On 2024/10/9 18:27, Qi Han wrote:
> > When the free segment is used up during CP disable, many write or
> > ioctl operations will get ENOSPC error codes, even if there are
> > still many blocks available. We can reproduce it in the following
Daeho Jeong 于2024年9月28日周六 00:08写道:
>
> From: Daeho Jeong
>
> Current description confuses users like they can add addtional devices
> with one -c option using commas(,) at the same time.
>
> Signed-off-by: Daeho Jeong
> Reviewed-by: Chao Yu
> ---
> mkfs/f2fs_format_main.c | 2 +-
> 1 file chan
Chao Yu via Linux-f2fs-devel
于2024年9月18日周三 14:45写道:
>
> On 2024/9/12 14:40, liuder...@oppo.com wrote:
> > From: liuderong
> >
> > When segs_per_sec is larger than 1, section may contain free segments,
> > mtime should be the mean value of each valid segments,
> > so introduce get_section_mtime to
Hi all,
please ignore this patch, we can resove this by "-b" parameter .
thanks!
Zhiguo Niu 于2024年9月14日周六 11:12写道:
>
> When 16K page/block size is enabled in Android platform,
> a error maybe detected in mount process in kernel if "-b"
> parameters is not speci
rrect default blocksize.
Signed-off-by: Zhiguo Niu
Signed-off-by: Xiuhong Wang
---
lib/libf2fs.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/libf2fs.c b/lib/libf2fs.c
index ecd22d4..98ee0ae 100644
--- a/lib/libf2fs.c
+++ b/lib/libf2fs.c
@@ -685,8 +685,17 @@ void f2fs_init_confi
Use F2FS_BYTES_TO_BLK(bytes) and F2FS_BLK_TO_BYTES(blk) for cleanup
Signed-off-by: Zhiguo Niu
---
fs/f2fs/checkpoint.c| 2 +-
fs/f2fs/debug.c | 2 +-
fs/f2fs/file.c | 6 +++---
fs/f2fs/node.c | 4 ++--
fs/f2fs/super.c | 2 +-
include/linux/f2fs_fs.h | 2
This is a supplement to commit 6d1451bf7f84 ("f2fs: fix to use per-inode
maxbytes")
for some missed cases, also cleanup redundant code in f2fs_llseek.
Cc: Chengguang Xu
Signed-off-by: Zhiguo Niu
---
v2: use Macro F2FS_BLK_TO_BYTES
---
---
fs/f2fs/data.c | 4 ++--
fs/f2fs/fi
This is a supplement to commit 6d1451bf7f84 ("f2fs: fix to use per-inode
maxbytes")
for some missed cases, also cleanup redundant code in f2fs_llseek.
Cc: Chengguang Xu
Signed-off-by: Zhiguo Niu
---
fs/f2fs/data.c | 2 +-
fs/f2fs/file.c | 7 ++-
fs/f2fs/verity.c | 5 +++-
Chao Yu 于2024年6月25日周二 22:29写道:
>
> If lfs mode is on, buffered read may race w/ OPU dio write as below,
> it may cause buffered read hits unwritten data unexpectly, and for
> dio read, the race condition exists as well.
>
> Thread AThread B
> - f2fs_file_write_iter
> - f2f
Chao Yu 于2024年6月26日周三 09:36写道:
>
> On 2024/6/25 19:07, Zhiguo Niu wrote:
> > Chao Yu 于2024年6月25日周二 18:38写道:
> >>
> >> On 2024/6/25 16:09, 牛志国 (Zhiguo Niu) wrote:
> >>>
> >>>
> >>> -邮件原件-
> >>> 发件人: Chao Yu
&
Chao Yu 于2024年6月25日周二 18:38写道:
>
> On 2024/6/25 16:09, 牛志国 (Zhiguo Niu) wrote:
> >
> >
> > -邮件原件-
> > 发件人: Chao Yu
> > 发送时间: 2024年6月25日 14:55
> > 收件人: jaeg...@kernel.org
> > 抄送: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.ke
-邮件原件-
发件人: Chao Yu
发送时间: 2024年6月25日 14:55
收件人: jaeg...@kernel.org
抄送: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org; Chao
Yu ; wangzijie ; 牛志国 (Zhiguo Niu)
; Yunlei He
主题: [PATCH v4] f2fs: reduce expensive checkpoint trigger frequency
注意: 这封邮件来自于外部。除非你确定邮件内
mnt_{want,drop}_write_file is more suitable than
file_{start,end}_wrtie and also is consistent with
other ioctl operations.
Signed-off-by: Zhiguo Niu
---
fs/f2fs/file.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
off-by: Chao Yu
Signed-off-by: Zhiguo Niu
---
v2: try to enabe atgc in cp to avoid some race cases
---
---
fs/f2fs/checkpoint.c | 1 +
fs/f2fs/f2fs.h | 1 +
fs/f2fs/segment.c| 27 ---
3 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/checkp
On Wed, Jun 5, 2024 at 2:26 PM Chao Yu wrote:
>
> On 2024/6/5 13:59, Zhiguo Niu wrote:
> > On Wed, Jun 5, 2024 at 11:48 AM Chao Yu wrote:
> >>
> >> On 2024/6/3 17:05, Zhiguo Niu wrote:
> >>> On Mon, Jun 3, 2024 at 3:41 PM Chao Yu wrote:
> >
On Wed, Jun 5, 2024 at 1:59 PM Zhiguo Niu wrote:
>
> On Wed, Jun 5, 2024 at 11:48 AM Chao Yu wrote:
> >
> > On 2024/6/3 17:05, Zhiguo Niu wrote:
> > > On Mon, Jun 3, 2024 at 3:41 PM Chao Yu wrote:
> > >>
> > >> On 2024/5/20 19:36, Zhiguo Niu
On Wed, Jun 5, 2024 at 11:48 AM Chao Yu wrote:
>
> On 2024/6/3 17:05, Zhiguo Niu wrote:
> > On Mon, Jun 3, 2024 at 3:41 PM Chao Yu wrote:
> >>
> >> On 2024/5/20 19:36, Zhiguo Niu wrote:
> >>> Now atgc can be enabled based on the following c
;data" to "level" for more readable.
Signed-off-by: Zhiguo Niu
---
v2: also change variable name from "data" to "level"
---
---
fs/f2fs/sysfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
ind
On Mon, Jun 3, 2024 at 3:41 PM Chao Yu wrote:
>
> On 2024/5/20 19:36, Zhiguo Niu wrote:
> > Now atgc can be enabled based on the following conditions:
> > -ATGC mount option is set
> > -elapsed_time is more than atgc_age_threshold already
> > but these conditions ar
On Mon, Jun 3, 2024 at 3:50 PM Chao Yu wrote:
>
> On 2024/6/3 14:52, Zhiguo Niu wrote:
> > On Mon, Jun 3, 2024 at 2:39 PM Chao Yu wrote:
> >>
> >> On 2024/5/31 17:10, Zhiguo Niu wrote:
> >>> Use new Macro IOPRIO_PRIO_LEVEL to get ckpt thread ioprio
On Mon, Jun 3, 2024 at 2:39 PM Chao Yu wrote:
>
> On 2024/5/31 17:10, Zhiguo Niu wrote:
> > Use new Macro IOPRIO_PRIO_LEVEL to get ckpt thread ioprio data(level),
> > it is more accurate and consisten with the way setting ckpt thread
> > ioprio(IOPRIO_PRIO_VALUE(class, da
Use new Macro IOPRIO_PRIO_LEVEL to get ckpt thread ioprio data(level),
it is more accurate and consisten with the way setting ckpt thread
ioprio(IOPRIO_PRIO_VALUE(class, data)).
Signed-off-by: Zhiguo Niu
---
fs/f2fs/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs
On Fri, May 31, 2024 at 10:04 AM Chao Yu wrote:
>
> On 2024/5/30 17:49, Zhiguo Niu wrote:
> > On Mon, May 27, 2024 at 12:07 PM Zhiguo Niu wrote:
> >>
> >> On Mon, May 27, 2024 at 11:49 AM Chao Yu wrote:
> >>>
> >>> On 2024/5/20 19:36, Zhi
1 - 100 of 199 matches
Mail list logo