Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-27 Thread boojin.kim
On Tue, Aug 27, 2019 at 05:33:33PM +0900, boojin.kim wrote: > > Hi Boojin, > > I think the important thing to realize here is that there are a large > number of hardware devices for which the keyslot manager *is* needed. > And from the upstream kernel's perspective, supporting two different > schem

Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-27 Thread Theodore Y. Ts'o
On Tue, Aug 27, 2019 at 05:33:33PM +0900, boojin.kim wrote: > > Dear Satya. > Keyslot manager is a good solution for ICE. And probably no issue for FMP. > But, I think it's complicated for FMP because FMP doesn't need > any keyslot control. Hi Boojin, I think the important thing to realize here

Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-27 Thread boojin.kim
On Wed, Aug 21, 2019 at 5:10 AM Satya Tangirala wrote: > > Hi Boojin, > > We're very keen to make sure that our approach to inline encryption can > work with diverse hardware, including Samsung's FMP hardware; if you > can see any issues with using our approach with your hardware please > let us

Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-22 Thread Satya Tangirala via Linux-f2fs-devel
On Wed, Aug 21, 2019 at 5:10 AM Jens Axboe wrote: > > On 8/21/19 12:42 AM, boojin.kim wrote: > > This patch supports crypto information to be maintained via BIO > > and passed to the storage driver. > > > > To do this, 'bi_aux_private', 'REQ_CYPTE' and 'bi_dun' are added > > to the block layer. >

Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-21 Thread boojin.kim
On 8/21/19 21:09 AM, Jens Axboe wrote: > This isn't going to happen. With this, and the inline encryption > proposed by Google, we'll bloat the bio even more. At least the Google > approach didn't include bio iter changes as well. > Please work it out between yourselves so we can have a single, cl

Re: [f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-21 Thread Jens Axboe
On 8/21/19 12:42 AM, boojin.kim wrote: > This patch supports crypto information to be maintained via BIO > and passed to the storage driver. > > To do this, 'bi_aux_private', 'REQ_CYPTE' and 'bi_dun' are added > to the block layer. > > 'bi_aux_private' is added for loading additional private info

[f2fs-dev] [PATCH 5/9] block: support diskcipher

2019-08-20 Thread boojin.kim
This patch supports crypto information to be maintained via BIO and passed to the storage driver. To do this, 'bi_aux_private', 'REQ_CYPTE' and 'bi_dun' are added to the block layer. 'bi_aux_private' is added for loading additional private information into BIO. 'REQ_CRYPT' is added to distinguish