Re: [f2fs-dev] [PATCH] f2fs: fix to keep backward compatibility of flexible inline xattr feature

2017-10-27 Thread Jaegeuk Kim
On 10/27, Chao Yu wrote: > On 2017/10/26 22:05, Jaegeuk Kim wrote: > > On 10/26, Chao Yu wrote: > >> On 2017/10/26 19:52, Jaegeuk Kim wrote: > >>> On 10/26, Chao Yu wrote: > Hi Jaegeuk, > > On 2017/10/26 18:02, Jaegeuk Kim wrote: > > Hi Chao, > > > > On 10/26, Jaegeuk Kim

Re: [f2fs-dev] [PATCH v4] f2fs: support soft block reservation

2017-10-27 Thread Jaegeuk Kim
On 10/27, Chao Yu wrote: > On 2017/10/27 11:11, Yunlong Song wrote: > > It renames reserved_blocks sysfs interface to target_reserved_blocks, > > and supports to extend it to be soft threshold, which allows user > > configure it exceeding current available user space. So this patch > > also introdu

Re: [f2fs-dev] [PATCH] f2fs: fix to keep backward compatibility of flexible inline xattr feature

2017-10-27 Thread Chao Yu
On 2017/10/27 18:56, Jaegeuk Kim wrote: > On 10/27, Chao Yu wrote: >> On 2017/10/26 22:05, Jaegeuk Kim wrote: >>> On 10/26, Chao Yu wrote: On 2017/10/26 19:52, Jaegeuk Kim wrote: > On 10/26, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2017/10/26 18:02, Jaegeuk Kim wrote: >>> Hi

Re: [f2fs-dev] [PATCH] f2fs: fix out-of-free problem caused by atomic write

2017-10-27 Thread Jaegeuk Kim
On 10/26, Christoph Hellwig wrote: > On Thu, Oct 26, 2017 at 04:30:19PM +0200, Jaegeuk Kim wrote: > > On 10/26, Yunlong Song wrote: > > > f2fs_balance_fs only actives once in the commit_inmem_pages, but there > > > are more than one page to commit, so all the other pages will miss the > > > check.

Re: [f2fs-dev] [PATCH] f2fs: fix to keep backward compatibility of flexible inline xattr feature

2017-10-27 Thread Jaegeuk Kim
On 10/27, Chao Yu wrote: > On 2017/10/27 18:56, Jaegeuk Kim wrote: > > On 10/27, Chao Yu wrote: > >> On 2017/10/26 22:05, Jaegeuk Kim wrote: > >>> On 10/26, Chao Yu wrote: > On 2017/10/26 19:52, Jaegeuk Kim wrote: > > On 10/26, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2017/

Re: [f2fs-dev] [PATCH] f2fs: fix to keep backward compatibility of flexible inline xattr feature

2017-10-27 Thread Chao Yu
On 2017/10/27 19:32, Jaegeuk Kim wrote: > On 10/27, Chao Yu wrote: >> On 2017/10/27 18:56, Jaegeuk Kim wrote: >>> On 10/27, Chao Yu wrote: On 2017/10/26 22:05, Jaegeuk Kim wrote: > On 10/26, Chao Yu wrote: >> On 2017/10/26 19:52, Jaegeuk Kim wrote: >>> On 10/26, Chao Yu wrote:

Re: [f2fs-dev] Fwd: Re: [PATCH 1/1] f2fs: simplify the calculation of fggc_threshold

2017-10-27 Thread Jaegeuk Kim
On 10/27, Chao Yu wrote: > On 2017/10/27 11:43, Sun Qiuyang wrote: > > > > Hi Jaegeuk, > > > > I noticed that the log of the commit: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=7e515b31d44dcd20a98c938dfdc21877a30042a0 > > > > used a new express

[f2fs-dev] [PATCH v5] f2fs: support soft block reservation

2017-10-27 Thread Yunlong Song
It supports to extend reserved_blocks sysfs interface to be soft threshold, which allows user configure it exceeding current available user space. This patch also introduces a new sysfs interface called current_reserved_blocks, which shows the current blocks that have already been reserved. Signed

Re: [f2fs-dev] Fwd: Re: [PATCH 1/1] f2fs: simplify the calculation of fggc_threshold

2017-10-27 Thread Chao Yu
On 2017/10/27 19:42, Jaegeuk Kim wrote: > On 10/27, Chao Yu wrote: >> On 2017/10/27 11:43, Sun Qiuyang wrote: >>> >>> Hi Jaegeuk, >>> >>> I noticed that the log of the commit: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=7e515b31d44dcd20a98c938dfdc2

Re: [f2fs-dev] [PATCH v5] f2fs: support soft block reservation

2017-10-27 Thread Chao Yu
On 2017/10/27 19:47, Yunlong Song wrote: > It supports to extend reserved_blocks sysfs interface to be soft > threshold, which allows user configure it exceeding current available > user space. This patch also introduces a new sysfs interface called > current_reserved_blocks, which shows the curren

[f2fs-dev] [PATCH v5 RESEND] f2fs: support soft block reservation

2017-10-27 Thread Yunlong Song
It supports to extend reserved_blocks sysfs interface to be soft threshold, which allows user configure it exceeding current available user space. This patch also introduces a new sysfs interface called current_reserved_blocks, which shows the current blocks that have already been reserved. Signed

Re: [f2fs-dev] [RFC PATCH 01/25] fs, fscrypt: move uapi definitions to new header

2017-10-27 Thread Michael Halcrow via Linux-f2fs-devel
On Mon, Oct 23, 2017 at 02:40:34PM -0700, Eric Biggers wrote: > From: Eric Biggers > > There are going to be more filesystem encryption definitions added, and > we don't want to use a disproportionate amount of space in > for filesystem encryption stuff. So move the fscrypt definitions to a > n

Re: [f2fs-dev] [RFC PATCH 02/25] fscrypt: use FSCRYPT_ prefix for uapi constants

2017-10-27 Thread Michael Halcrow via Linux-f2fs-devel
On Mon, Oct 23, 2017 at 02:40:35PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Prefix all filesystem encryption UAPI constants except the ioctl numbers > with "FSCRYPT_" rather than with "FS_". This namespaces the constants > more appropriately and makes it clear that they are related sp

Re: [f2fs-dev] [RFC PATCH 03/25] fscrypt: use FSCRYPT_* definitions, not FS_*

2017-10-27 Thread Michael Halcrow via Linux-f2fs-devel
On Mon, Oct 23, 2017 at 02:40:36PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Update the filesystem encryption kernel code to use the new names for > the UAPI constants rather than the old names. > > Signed-off-by: Eric Biggers Reviewed-by: Michael Halcrow > --- > fs/crypto/fname.c

Re: [f2fs-dev] [RFC PATCH 04/25] fscrypt: refactor finding and deriving key

2017-10-27 Thread Michael Halcrow via Linux-f2fs-devel
On Mon, Oct 23, 2017 at 02:40:37PM -0700, Eric Biggers wrote: > From: Eric Biggers > > In preparation for introducing a new way to find the master keys and > derive the per-file keys, clean up the current method. This includes: > > - Introduce a helper function find_and_derive_key() so that we

Re: [f2fs-dev] [RFC PATCH 05/25] fs: add ->s_master_keys to struct super_block

2017-10-27 Thread Michael Halcrow via Linux-f2fs-devel
On Mon, Oct 23, 2017 at 02:40:38PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Add an ->s_master_keys keyring to 'struct super_block' for holding > encryption keys which have been added to the filesystem. This keyring > will be populated using a new fscrypt ioctl. > > This is needed for

Re: [f2fs-dev] [RFC PATCH 06/25] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl

2017-10-27 Thread Michael Halcrow via Linux-f2fs-devel
On Mon, Oct 23, 2017 at 02:40:39PM -0700, Eric Biggers wrote: > By having an API to add a key to the *filesystem* we'll be able to > eliminate all the above hacks and better express the intended semantics: > the "locked/unlocked" status of an encrypted directory is global. And > orthogonally to en

Re: [f2fs-dev] [RFC PATCH 07/25] fs/inode.c: export inode_lru_list_del()

2017-10-27 Thread Michael Halcrow via Linux-f2fs-devel
On Mon, Oct 23, 2017 at 02:40:40PM -0700, Eric Biggers wrote: > From: Eric Biggers > > When a filesystem encryption key is removed, we need all files which had > been "unlocked" (had ->i_crypt_info set up) with it to appear "locked" > again. This is most easily done by evicting the inodes. This

Re: [f2fs-dev] [PATCH] f2fs: fix to keep backward compatibility of flexible inline xattr feature

2017-10-27 Thread Chao Yu
On 2017/10/27 19:39, Chao Yu wrote: > On 2017/10/27 19:32, Jaegeuk Kim wrote: >> On 10/27, Chao Yu wrote: >>> On 2017/10/27 18:56, Jaegeuk Kim wrote: On 10/27, Chao Yu wrote: > On 2017/10/26 22:05, Jaegeuk Kim wrote: >> On 10/26, Chao Yu wrote: >>> On 2017/10/26 19:52, Jaegeuk Kim