Re: [f2fs-dev] [PATCH] f2fs: avoid frequent costly fsck triggers

2018-12-07 Thread Chao Yu
On 2018/12/1 4:28, Jaegeuk Kim wrote: > On 11/30, Chao Yu wrote: >> On 2018/11/30 10:35, Sheng Yong wrote: >>> Hi, Jaegeuk and Chao, >>> >>> On 2018/11/29 1:48, Jaegeuk Kim wrote: On 11/28, Chao Yu wrote: > On 2018/11/28 16:10, Jaegeuk Kim wrote: >> On 11/28, Chao Yu wrote: >>> Hi

Re: [f2fs-dev] [PATCH v2] f2fs: fix sbi->extent_list corruption issue

2018-12-07 Thread Chao Yu
On 2018/12/1 4:33, Jaegeuk Kim wrote: > On 11/29, Sahitya Tummala wrote: >> >> On Tue, Nov 27, 2018 at 09:42:39AM +0800, Chao Yu wrote: >>> On 2018/11/27 8:30, Jaegeuk Kim wrote: On 11/26, Sahitya Tummala wrote: > When there is a failure in f2fs_fill_super() after/during > the recovery

Re: [f2fs-dev] [PATCH] f2fs: add an ioctl() to explicitly trigger fsck later

2018-12-07 Thread Chao Yu
On 2018/12/1 4:36, Jaegeuk Kim wrote: > On 11/30, Chao Yu wrote: >> On 2018/11/29 9:52, Jaegeuk Kim wrote: >>> This adds an option in ioctl(F2FS_IOC_SHUTDOWN) in order to trigger fsck by >>> setting a NEED_FSCK flag. >>> >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/f2fs.h | 1 + >>> fs/f2fs

Re: [f2fs-dev] [PATCH] f2fs: clear PG_writeback if IPU failed

2018-12-07 Thread Chao Yu
On 2018/12/4 22:59, Sheng Yong wrote: > If IPU failed, nothing is commited, we should end page writeback. > > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://l

[f2fs-dev] [PATCH] fsck: Fix big endian platforms

2018-12-07 Thread Rosen Penev
Since "fsck.f2fs: integrate sanity_check_inode to __check_inode_mode", big endian platforms have been broken due to an endianness bug. More info: https://github.com/openwrt/openwrt/pull/1575 Signed-off-by: Rosen Penev --- fsck/fsck.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[f2fs-dev] [PATCH V3 0/9] Remove fs specific fscrypt and fsverity build config options

2018-12-07 Thread Chandan Rajendra
In order to have a common code base for fscrypt & fsverity "post read" processing across filesystems which implement fscrypt/fsverity, this commit removes filesystem specific build config option (CONFIG_EXT4_FS_ENCRYPTION, CONFIG_EXT4_FS_VERITY, CONFIG_F2FS_FS_ENCRYPTION, CONFIG_F2FS_FS_VERITY and

[f2fs-dev] [PATCH V3 1/9] ext4: use IS_ENCRYPTED() to check encryption status

2018-12-07 Thread Chandan Rajendra
This commit removes the ext4 specific ext4_encrypted_inode() and makes use of the generic IS_ENCRYPTED() macro to check for the encryption status of an inode. Reviewed-by: Eric Biggers Signed-off-by: Chandan Rajendra --- fs/ext4/dir.c | 8 fs/ext4/ext4.h| 5 - fs/

[f2fs-dev] [PATCH V3 2/9] f2fs: use IS_ENCRYPTED() to check encryption status

2018-12-07 Thread Chandan Rajendra
This commit removes the f2fs specific f2fs_encrypted_inode() and makes use of the generic IS_ENCRYPTED() macro to check for the encryption status of an inode. Acked-by: Chao Yu Signed-off-by: Chandan Rajendra --- fs/f2fs/data.c | 4 ++-- fs/f2fs/dir.c | 10 +- fs/f2fs/f2fs.h | 7 +

[f2fs-dev] [PATCH V3 3/9] fscrypt: remove filesystem specific build config option

2018-12-07 Thread Chandan Rajendra
In order to have a common code base for fscrypt "post read" processing for all filesystems which support encryption, this commit removes filesystem specific build config option (e.g. CONFIG_EXT4_FS_ENCRYPTION) and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose value affects all t

[f2fs-dev] [PATCH V3 6/9] f2fs: use IS_VERITY() to check inode's fsverity status

2018-12-07 Thread Chandan Rajendra
This commit removes the f2fs specific f2fs_verity_file() and makes use of the generic IS_VERITY() macro or file_is_verity() to check for the verity status of an inode. Signed-off-by: Chandan Rajendra --- fs/f2fs/f2fs.h | 7 +-- fs/f2fs/file.c | 6 +++--- fs/f2fs/inode.c | 4 +++- fs/f2fs/s

[f2fs-dev] [PATCH V3 4/9] Add S_VERITY and IS_VERITY()

2018-12-07 Thread Chandan Rajendra
Similar to S_ENCRYPTED/IS_ENCRYPTED(), this commit adds S_VERITY/IS_VERITY() to be able to check if a VFS inode has verity information associated with it. Reviewed-by: Eric Biggers Signed-off-by: Chandan Rajendra --- include/linux/fs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/inclu

[f2fs-dev] [PATCH V3 8/9] fsverity: Move verity status check to fsverity_file_open

2018-12-07 Thread Chandan Rajendra
Instead of conditionally checking for verity status of an inode before invoking fsverity_file_open(), this commit moves the check inside the definition of fsverity_file_open(). Signed-off-by: Chandan Rajendra --- fs/ext4/file.c| 8 +++- fs/f2fs/file.c| 8 +++- fs/verity/setup.c |

[f2fs-dev] [PATCH V3 9/9] fsverity: Move verity status check to fsverity_prepare_setattr

2018-12-07 Thread Chandan Rajendra
Instead of conditionally checking for verity status of an inode before invoking fsverity_prepare_setattr(), this commit moves the check inside the definition of fsverity_prepare_setattr(). Signed-off-by: Chandan Rajendra --- fs/ext4/inode.c | 8 +++- fs/f2fs/file.c| 8 +++- fs/veri

[f2fs-dev] [PATCH V3 5/9] ext4: use IS_VERITY() to check inode's fsverity status

2018-12-07 Thread Chandan Rajendra
This commit removes the ext4 specific ext4_verity_inode() and makes use of the generic IS_ENCRYPTED() macro or ext4_test_inode_flag() to check for the encryption status of an inode. Reviewed-by: Eric Biggers Signed-off-by: Chandan Rajendra --- fs/ext4/ext4.h | 9 - fs/ext4/file.c

[f2fs-dev] [PATCH V3 7/9] fsverity: Remove filesystem specific build config option

2018-12-07 Thread Chandan Rajendra
In order to have a common code base for fsverity "post read" processing for all filesystems which support fsverity, this commit removes filesystem specific build config option (e.g. CONFIG_EXT4_FS_VERITY) and replaces it with a build option (i.e. CONFIG_FS_VERITY) whose value affects all the filesy

Re: [f2fs-dev] [PATCH V2 3/7] fscrypt: remove filesystem specific build config option

2018-12-07 Thread Chandan Rajendra
On Wednesday, December 5, 2018 5:13:21 AM IST Eric Biggers wrote: > Hi Chandan, > > On Tue, Dec 04, 2018 at 03:26:46PM +0530, Chandan Rajendra wrote: > > In order to have a common code base for fscrypt "post read" processing > > for all filesystems which support encryption, this commit removes > >