Re: [f2fs-dev] [PATCH] f2fs: add a way to turn off ipu bio cache

2020-01-08 Thread Chao Yu
On 2020/1/7 10:07, Jaegeuk Kim wrote: > Setting 0x40 in /sys/fs/f2fs/dev/ipu_policy gives a way to turn off > bio cache, which is useufl to check whether block layer using hardware > encryption engine merges IOs correctly. > > Signed-off-by: Jaegeuk Kim > --- > Documentation/filesystems/f2fs.txt

Re: [f2fs-dev] problem with f2fs android partition

2020-01-08 Thread Chao Yu
Hi Stephanos, On 2020/1/7 22:09, Stephanos Mallouris wrote: > Dear Yu, > > Thanks for the reply, i did patch and compile the f2fs-tools. > I run two cases > 1. sudo ./fsck.f2fs /media/elementary/eengineering/mmcblk0p49.raw > --dry-run -a -y > > Results attached in firest log file > > 2. sudo

Re: [f2fs-dev] Multidevice f2fs mount after disk rearrangement

2020-01-08 Thread Chao Yu
On 2020/1/7 2:40, Jaegeuk Kim wrote: > On 01/06, Chao Yu wrote: >> Hello, >> >> Thanks for the report. :) >> >> On 2020/1/5 5:52, Oleksandr Natalenko via Linux-f2fs-devel wrote: >>> Hi. >>> >>> On 04.01.2020 17:29, Oleksandr Natalenko wrote: I was brave enough to create f2fs filesystem spannin

Re: [f2fs-dev] Multidevice f2fs mount after disk rearrangement

2020-01-08 Thread Chao Yu
On 2020/1/7 2:40, Oleksandr Natalenko via Linux-f2fs-devel wrote: > Hi. > > On 06.01.2020 19:34, Jaegeuk Kim wrote: >> Thank you for investigating this ahead of me. :) Yes, the device list >> is stored >> in superblock, so hacking it manually should work. >> >> Let me think about a tool to tune t

Re: [f2fs-dev] [PATCH v3] fs: Fix page_mkwrite off-by-one errors

2020-01-08 Thread Chao Yu
On 2020/1/8 7:20, Darrick J. Wong wrote: > On Wed, Dec 18, 2019 at 02:09:35PM +0100, Andreas Gruenbacher wrote: >> Hi Darrick, >> >> can this fix go in via the xfs tree? >> >> Thanks, >> Andreas >> >> -- >> >> The check in block_page_mkwrite that is meant to determine whether an >> offset is within

Re: [f2fs-dev] [PATCH 2/4] f2fs: compress: revert error path fix

2020-01-08 Thread Chao Yu
On 2020/1/7 3:26, Jaegeuk Kim wrote: > Hi Chao, > > Could you please check this out? > https://github.com/jaegeuk/f2fs/commits/g-dev-test Looks good to me, I add some minor comments on github. Any comments on below thread? Re: [f2fs-dev] [PATCH 3/4] f2fs: compress: fix error path in prepare_co

Re: [f2fs-dev] [PATCH v3] fs: Fix page_mkwrite off-by-one errors

2020-01-08 Thread Jaegeuk Kim
Hi Andreas, On 12/18, Andreas Gruenbacher wrote: > Hi Darrick, > > can this fix go in via the xfs tree? > > Thanks, > Andreas > > -- > > The check in block_page_mkwrite that is meant to determine whether an > offset is within the inode size is off by one. This bug has been copied > into iomap

Re: [f2fs-dev] Multidevice f2fs mount after disk rearrangement

2020-01-08 Thread Jaegeuk Kim
On 01/08, Chao Yu wrote: > On 2020/1/7 2:40, Oleksandr Natalenko via Linux-f2fs-devel wrote: > > Hi. > > > > On 06.01.2020 19:34, Jaegeuk Kim wrote: > >> Thank you for investigating this ahead of me. :) Yes, the device list > >> is stored > >> in superblock, so hacking it manually should work. >

Re: [f2fs-dev] [PATCH] f2fs: add a way to turn off ipu bio cache

2020-01-08 Thread Jaegeuk Kim
On 01/08, Chao Yu wrote: > On 2020/1/7 10:07, Jaegeuk Kim wrote: > > Setting 0x40 in /sys/fs/f2fs/dev/ipu_policy gives a way to turn off > > bio cache, which is useufl to check whether block layer using hardware > > encryption engine merges IOs correctly. > > > > Signed-off-by: Jaegeuk Kim > > --

Re: [f2fs-dev] [PATCH] f2fs: add a way to turn off ipu bio cache

2020-01-08 Thread Chao Yu
On 2020/1/8 20:04, Jaegeuk Kim wrote: > On 01/08, Chao Yu wrote: >> On 2020/1/7 10:07, Jaegeuk Kim wrote: >>> Setting 0x40 in /sys/fs/f2fs/dev/ipu_policy gives a way to turn off >>> bio cache, which is useufl to check whether block layer using hardware >>> encryption engine merges IOs correctly. >>

[f2fs-dev] [PATCH v4] fs: Fix page_mkwrite off-by-one errors

2020-01-08 Thread Andreas Gruenbacher
Hi Darrick, here's an updated version with the latest feedback incorporated. Hope you find that useful. As far as the f2fs merge conflict goes, I've been told by Linus not to resolve those kinds of conflicts but to point them out when sending the merge request. So this shouldn't be a big deal.

Re: [f2fs-dev] [PATCH v6 0/9] Inline Encryption Support

2020-01-08 Thread Christoph Hellwig
I haven't been able to deep dive into the details, but the structure of this still makes me very unhappy. Most of it is related to the software fallback again. Please split the fallback into a separate file, and also into a separate data structure. There is abslutely no need to have the overhead

Re: [f2fs-dev] [PATCH v6 2/9] block: Add encryption context to struct bio

2020-01-08 Thread Christoph Hellwig
On Wed, Dec 18, 2019 at 07:47:56PM -0500, Martin K. Petersen wrote: > Absolutely. That's why it's a union. Putting your stuff there is a > prerequisite as far as I'm concerned. No need to grow the bio when the > two features are unlikely to coexist. We can revisit that later should > the need arise

Re: [f2fs-dev] [PATCH v4] fs: Fix page_mkwrite off-by-one errors

2020-01-08 Thread Christoph Hellwig
I don't want to be the party pooper, but shouldn't this be a series with one patch to add the helper, and then once for each fs / piece of common code switched over? On Wed, Jan 08, 2020 at 02:15:28PM +0100, Andreas Gruenbacher wrote: > Hi Darrick, > > here's an updated version with the latest fe

Re: [f2fs-dev] [PATCH v6 2/9] block: Add encryption context to struct bio

2020-01-08 Thread Eric Biggers
On Wed, Jan 08, 2020 at 06:07:30AM -0800, Christoph Hellwig wrote: > On Wed, Dec 18, 2019 at 07:47:56PM -0500, Martin K. Petersen wrote: > > Absolutely. That's why it's a union. Putting your stuff there is a > > prerequisite as far as I'm concerned. No need to grow the bio when the > > two features

[f2fs-dev] TRIM issue

2020-01-08 Thread Piergiorgio Sartor
Hi all, I've a small box, with Fedora 31 up-to-date. The system has LUKS + LVM + f2fs. Since kernel 5.3.16-300.fc31.x86_64 the fstrim.service, triggered by the systemd service fstrim.timer or from command line, does return an error: Starting Discard unused blocks on filesystems from /etc/fstab.

Re: [f2fs-dev] [PATCH v2 0/6] Support for Casefolding and Encryption

2020-01-08 Thread Theodore Y. Ts'o
On Mon, Jan 06, 2020 at 09:16:32PM -0800, Daniel Rosenberg wrote: > changes: > fscrypt moved to separate thread to rebase on fscrypt dev branch > addressed feedback, plus some minor fixes What branch was this based on? There is no fscrypt dev branch, so I took the fscrypt master branch, and then

Re: [f2fs-dev] [PATCH v6 0/9] Inline Encryption Support

2020-01-08 Thread Satya Tangirala via Linux-f2fs-devel
On Wed, Jan 08, 2020 at 06:05:56AM -0800, Christoph Hellwig wrote: > I haven't been able to deep dive into the details, but the structure > of this still makes me very unhappy. > > Most of it is related to the software fallback again. Please split the > fallback into a separate file, and also int

Re: [f2fs-dev] [PATCH 3/4] f2fs: compress: fix error path in prepare_compress_overwrite()

2020-01-08 Thread Jaegeuk Kim
On 01/07, Chao Yu wrote: > On 2020/1/7 3:08, Jaegeuk Kim wrote: > > On 01/06, Chao Yu wrote: > >> - fix to release cluster pages in retry flow > >> - fix to call f2fs_put_dnode() & __do_map_lock() in error path > >> > >> Signed-off-by: Chao Yu > >> --- > >> fs/f2fs/compress.c | 22 +++

Re: [f2fs-dev] [PATCH v2 0/6] Support for Casefolding and Encryption

2020-01-08 Thread Daniel Rosenberg via Linux-f2fs-devel
On Wed, Jan 8, 2020 at 10:50 AM Theodore Y. Ts'o wrote: > > On Mon, Jan 06, 2020 at 09:16:32PM -0800, Daniel Rosenberg wrote: > > changes: > > fscrypt moved to separate thread to rebase on fscrypt dev branch > > addressed feedback, plus some minor fixes > > What branch was this based on? There is

Re: [f2fs-dev] [PATCH v4] fs: Fix page_mkwrite off-by-one errors

2020-01-08 Thread Jaegeuk Kim
On 01/08, Andreas Gruenbacher wrote: > Hi Darrick, > > here's an updated version with the latest feedback incorporated. Hope > you find that useful. > > As far as the f2fs merge conflict goes, I've been told by Linus not to > resolve those kinds of conflicts but to point them out when sending th

Re: [f2fs-dev] [PATCH] f2fs: add a way to turn off ipu bio cache

2020-01-08 Thread Jaegeuk Kim
On 01/08, Chao Yu wrote: > On 2020/1/8 20:04, Jaegeuk Kim wrote: > > On 01/08, Chao Yu wrote: > >> On 2020/1/7 10:07, Jaegeuk Kim wrote: > >>> Setting 0x40 in /sys/fs/f2fs/dev/ipu_policy gives a way to turn off > >>> bio cache, which is useufl to check whether block layer using hardware > >>> encry

[f2fs-dev] [PATCH] f2fs-tools: avoid ambigous checkpoint mirroring

2020-01-08 Thread Jaegeuk Kim
Signed-off-by: Jaegeuk Kim --- fsck/fsck.c | 26 ++ fsck/fsck.h | 1 - fsck/mount.c | 20 +--- 3 files changed, 19 insertions(+), 28 deletions(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 507437d..8383f08 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@

Re: [f2fs-dev] TRIM issue

2020-01-08 Thread Jaegeuk Kim
Hi, On 01/08, Piergiorgio Sartor wrote: > Hi all, > > I've a small box, with Fedora 31 up-to-date. > > The system has LUKS + LVM + f2fs. > > Since kernel 5.3.16-300.fc31.x86_64 the fstrim.service, > triggered by the systemd service fstrim.timer or from > command line, does return an error: > >

Re: [f2fs-dev] [PATCH v6 2/9] block: Add encryption context to struct bio

2020-01-08 Thread Martin K. Petersen
Christoph, >> Absolutely. That's why it's a union. Putting your stuff there is a >> prerequisite as far as I'm concerned. No need to grow the bio when the >> two features are unlikely to coexist. We can revisit that later should >> the need arise. > > With NVMe key per I/O support some form of i

Re: [f2fs-dev] [PATCH] resize.f2fs: add option for large_nat_bitmap feature

2020-01-08 Thread Chao Yu
On 2020/1/8 19:20, Ping1 Xiong 熊平 wrote: > ​From d5b8411dbae37180c37d96bf164fab16138fc21a Mon Sep 17 00:00:00 2001 > > From: xiongping1 > Date: Wed, 8 Jan 2020 17:20:55 +0800 > Subject: [PATCH] resize.f2fs: add option for large_nat_bitmap feature Thanks for your contribution. The patch format i