>
> On 2022/8/25 10:41, Zhang Qilong wrote:
> > If the written page was mapped more than twice, the written data here
> > will not be seen by others. We add the flush_dcache_page to fix it.
> >
> > Fixes:0a2aa8fbb9693 ("f2fs: refactor __exchange_data_block for speed
> > up")
> > Signed-off-by:
On 09/08, Chao Yu wrote:
> Sometimes we can get a cached meta_inode which has no aops yet. Let's set it
> all the time to fix the below panic.
>
> Unable to handle kernel NULL pointer dereference at virtual address
>
> Mem abort info:
> ESR = 0x8604
> EC = 0x21:
Convert function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
Acked-by: Ryusuke Konishi
---
fs/nilfs2/page.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
Convert to use folios throughout. This function is in preparation to
remove find_get_pages_range_tag().
Also modified this function to write the whole batch one at a time,
rather than calling for a new set every single write.
Signed-off-by: Vishal Moola (Oracle)
---
fs/afs/write.c | 114
Converted function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
Acked-by: David Sterba
---
fs/btrfs/extent_io.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git
Convert function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag().
This change does NOT support large folios. This shouldn't be an issue as
of now since ceph only utilizes folios of size 1 anyways, and there is a
lot of work to be done on ceph
This is the equivalent of find_get_pages_range_tag(), except for folios
instead of pages.
One noteable difference is filemap_get_folios_tag() does not take in a
maximum pages argument. It instead tries to fill a folio batch and stops
either once full (15 folios) or reaching the end of the search
Convert function to use folios. This is in preparation for the removal
of find_get_pages_range_tag(). Does NOT support large folios.
Signed-off-by: Vishal Moola (Oracle)
---
fs/f2fs/node.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/node.c
Convert function to use folios. This is in preparation for the removal
of find_get_pages_range_tag(). Does NOT support large
folios.
Signed-off-by: Vishal Moola (Oracle)
---
fs/f2fs/node.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/fs/f2fs/node.c
Converted the function to use folios throughout. This is in preparation
for the removal of find_get_pages_range_tag(). Now supports large
folios.
Signed-off-by: Vishal Moola (Oracle)
---
fs/ext4/inode.c | 55 -
1 file changed, 27 insertions(+), 28
Converted function to use folios throughout. This is in preparation for
the removal of find_get_pgaes_range_tag().
Also had to modify and rename gfs2_write_jdata_pagevec() to take in
and utilize folio_batch rather than pagevec and use folios rather
than pages. gfs2_write_jdata_batch() now
Converted the function to use folios. This is in preparation for the
removal of find_get_pages_range_tag().
Also modified f2fs_all_cluster_page_ready to take in a folio_batch instead
of pagevec. This does NOT support large folios. The function currently
only utilizes folios of size 1 so this
Convert function to use folios. This is in preparation for the removal
of find_get_pages_range_tag().
Initially the function was checking if the previous page index is truly the
previous page i.e. 1 index behind the current page. To convert to folios and
maintain this check we need to make the
Convert function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
Acked-by: Ryusuke Konishi
---
fs/nilfs2/segment.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
Convert to use folios. This is in preparation for the removal of
find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
---
fs/f2fs/node.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index
Convert function to use folios. This is in preparation for the removal
of find_get_pages_tag(). Does NOT support large folios.
Signed-off-by: Vishal Moola (Oracle)
---
fs/f2fs/node.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/node.c
Convert function to use folios. This is in preparation for the removal
of find_get_pages_range_tag(). Now also supports the use of large
folios.
Since tofind might be larger than the max number of folios in a
folio_batch (15), we loop through filling in wdata->pages pulling more
batches until we
Convert function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
---
fs/nilfs2/segment.c | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/fs/nilfs2/segment.c
All callers to find_get_pages_range_tag(), find_get_pages_tag(),
pagevec_lookup_range_tag(), and pagevec_lookup_tag() have been removed.
Signed-off-by: Vishal Moola (Oracle)
---
include/linux/pagemap.h | 10 ---
include/linux/pagevec.h | 8 --
mm/filemap.c| 60
This patch series replaces find_get_pages_range_tag() with
filemap_get_folios_tag(). This also allows the removal of multiple
calls to compound_head() throughout.
It also makes a good chunk of the straightforward conversions to folios,
and takes the opportunity to introduce a function that grabs a
Convert function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
Acked-by: Ryusuke Konishi
---
fs/nilfs2/page.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
Convert function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
Acked-by: Ryusuke Konishi
---
fs/nilfs2/btree.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
Converted function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
---
mm/page-writeback.c | 44 +++-
1 file changed, 23 insertions(+), 21 deletions(-)
diff --git
Converted function to use folios. This is in preparation for the removal
of find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
---
mm/filemap.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index
Converted function to use folios throughout. This is in preparation for
the removal of find_get_pages_range_tag(). Now also supports large
folios.
Signed-off-by: Vishal Moola (Oracle)
Acked-by: David Sterba
---
fs/btrfs/extent_io.c | 38 +++---
1 file changed,
Add function filemap_grab_folio() to grab a folio from the page cache.
This function is meant to serve as a folio replacement for
grab_cache_page, and is used to facilitate the removal of
find_get_pages_range_tag().
Signed-off-by: Vishal Moola (Oracle)
---
include/linux/pagemap.h | 20
On 09/08, Chao Yu wrote:
> On 2022/9/8 10:19, Jaegeuk Kim wrote:
> > On 09/08, Chao Yu wrote:
> > > On 2022/9/8 10:02, Jaegeuk Kim wrote:
> > > > On 08/31, Chao Yu wrote:
> > > > > From: Chao Yu
> > > > >
> > > > > Introduce f2fs_iget_inner() for f2fs_fill_super() to get inner inode:
> > > > >
On Tue, Sep 13, 2022 at 3:30 AM Vishal Moola (Oracle) wrote:
>
> Convert function to use folios throughout. This is in preparation for
> the removal of find_get_pages_range_tag().
>
> Signed-off-by: Vishal Moola (Oracle)
> ---
> fs/nilfs2/segment.c | 29 -
> 1 file
On 2022/9/12 23:39, Jaegeuk Kim wrote:
On 09/08, Chao Yu wrote:
On 2022/9/8 10:19, Jaegeuk Kim wrote:
On 09/08, Chao Yu wrote:
On 2022/9/8 10:02, Jaegeuk Kim wrote:
On 08/31, Chao Yu wrote:
From: Chao Yu
Introduce f2fs_iget_inner() for f2fs_fill_super() to get inner inode:
meta inode,
As Wenqing Liu reported in bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=216456
loop5: detected capacity change from 0 to 131072
F2FS-fs (loop5): recover_inode: ino = 6, name = hln, inline = 1
F2FS-fs (loop5): recover_data: ino = 6 (i_size: recover) err = 0
F2FS-fs (loop5):
As Wenqing Liu reported in bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=216456
BUG: KASAN: use-after-free in recover_data+0x63ae/0x6ae0 [f2fs]
Read of size 4 at addr 8881464dcd80 by task mount/1013
CPU: 3 PID: 1013 Comm: mount Tainted: GW 6.0.0-rc4 #1
Hardware
On 2022/9/13 11:05, Zhang Qilong wrote:
If we do not truncate source page cache, user can still
see the previous source data after being moved. We fix
it by adding truncating after __exchange_data_block.
Fixes:4dd6f977fc778 ("f2fs: support an ioctl to move a range of data blocks")
>
> On 2022/9/13 11:41, zhangqilong wrote:
> >> On 2022/9/13 11:05, Zhang Qilong wrote:
> >>> If we do not truncate source page cache, user can still see the
> >>> previous source data after being moved. We fix it by adding
> >>> truncating after __exchange_data_block.
> >>>
> >>>
On 2022/8/25 4:02, Jaegeuk Kim wrote:
This avoids -EINVAL when trying to freeze f2fs.
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
On 2022/8/25 4:30, Jaegeuk Kim wrote:
Otherwise, pending checkpoints can contribute a race condition to give a
quota warning.
- Thread - checkpoint thread
add checkpoints to the list
do_remount()
down_write(>s_umount);
f2fs_remount()
> On 2022/9/13 11:05, Zhang Qilong wrote:
> > If we do not truncate source page cache, user can still see the
> > previous source data after being moved. We fix it by adding truncating
> > after __exchange_data_block.
> >
> > Fixes:4dd6f977fc778 ("f2fs: support an ioctl to move a range of data
> >
On 2022/9/13 11:41, zhangqilong wrote:
On 2022/9/13 11:05, Zhang Qilong wrote:
If we do not truncate source page cache, user can still see the
previous source data after being moved. We fix it by adding truncating
after __exchange_data_block.
Fixes:4dd6f977fc778 ("f2fs: support an ioctl to
On 09/13, Chao Yu wrote:
> On 2022/9/12 23:39, Jaegeuk Kim wrote:
> > On 09/08, Chao Yu wrote:
> > > On 2022/9/8 10:19, Jaegeuk Kim wrote:
> > > > On 09/08, Chao Yu wrote:
> > > > > On 2022/9/8 10:02, Jaegeuk Kim wrote:
> > > > > > On 08/31, Chao Yu wrote:
> > > > > > > From: Chao Yu
> > > > > >
If we do not truncate source page cache, user can still
see the previous source data after being moved. We fix
it by adding truncating after __exchange_data_block.
Fixes:4dd6f977fc778 ("f2fs: support an ioctl to move a range of data blocks")
Signed-off-by: Zhang Qilong
---
fs/f2fs/file.c | 4
On 2022/8/24 1:21, Jaegeuk Kim wrote:
This patch increases the threshold that limits the reserved root space from 0.2%
to 12.5% by using simple shift operation.
Typically Android sets 128MB, but if the storage capacity is 32GB, 0.2% which is
around 64MB becomes too small. Let's relax it.
On 2022/9/12 23:37, Jaegeuk Kim wrote:
On 09/08, Chao Yu wrote:
Sometimes we can get a cached meta_inode which has no aops yet. Let's set it
all the time to fix the below panic.
Unable to handle kernel NULL pointer dereference at virtual address
Mem abort info:
ESR =
41 matches
Mail list logo