Re: [f2fs-dev] [PATCH v6 02/10] fscrypt: Factor out a helper to configure the lookup dentry

2024-02-14 Thread Eric Biggers
On Mon, Feb 12, 2024 at 09:13:13PM -0500, Gabriel Krisman Bertazi wrote: > Both fscrypt_prepare_lookup_dentry_partial and > fscrypt_prepare_lookup_dentry Neither of these functions exist. - Eric ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists

Re: [f2fs-dev] [PATCH v6 03/10] fscrypt: Drop d_revalidate for valid dentries during lookup

2024-02-14 Thread Eric Biggers
On Mon, Feb 12, 2024 at 09:13:14PM -0500, Gabriel Krisman Bertazi wrote: > Finally, we need to clean the dentry->flags even for unencrypted > dentries, so the ->d_lock might be acquired even for them. In order to might => must? > diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h > i

Re: [f2fs-dev] [PATCH v6 04/10] fscrypt: Drop d_revalidate once the key is added

2024-02-14 Thread Eric Biggers
On Mon, Feb 12, 2024 at 09:13:15PM -0500, Gabriel Krisman Bertazi wrote: > From fscrypt perspective, once the key is available, the dentry will > remain valid until evicted for other reasons, since keyed dentries don't > require revalidation and, if the key is removed, the dentry is > forcefully ev

Re: [f2fs-dev] [PATCH v6 00/10] Set casefold/fscrypt dentry operations through sb->s_d_op

2024-02-14 Thread Eric Biggers
On Mon, Feb 12, 2024 at 09:13:11PM -0500, Gabriel Krisman Bertazi wrote: > Hi, > > v6 of this patchset applying the comments from Eric and the suggestion from > Christian. Thank you for your feedback. > > Eric, since this is getting close to merging, how do you want to handle > it? I will take pa

Re: [f2fs-dev] [PATCH v6 04/10] fscrypt: Drop d_revalidate once the key is added

2024-02-14 Thread Eric Biggers
On Wed, Feb 14, 2024 at 04:16:31PM -0800, Eric Biggers wrote: > On Mon, Feb 12, 2024 at 09:13:15PM -0500, Gabriel Krisman Bertazi wrote: > > From fscrypt perspective, once the key is available, the dentry will > > remain valid until evicted for other reasons, since keyed dentries don't > > require

[f2fs-dev] [PATCH v10 1/8] ext4: Simplify the handling of cached insensitive names

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
From: Gabriel Krisman Bertazi Keeping it as qstr avoids the unnecessary conversion in ext4_match Reviewed-by: Eric Biggers Signed-off-by: Gabriel Krisman Bertazi [eugen.hris...@collabora.com: port to 6.8-rc3] Signed-off-by: Eugen Hristev --- fs/ext4/ext4.h | 2 +- fs/ext4/namei.c | 23

[f2fs-dev] [PATCH v10 4/8] ext4: Reuse generic_ci_match for ci comparisons

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
From: Gabriel Krisman Bertazi Instead of reimplementing ext4_match_ci, use the new libfs helper. It also adds a comment explaining why fname->cf_name.name must be checked prior to the encryption hash optimization, because that tripped me before. Signed-off-by: Gabriel Krisman Bertazi Signed-of

[f2fs-dev] [PATCH v10 0/8]

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
Hello, I am trying to respin the series here : https://www.spinics.net/lists/linux-ext4/msg85081.html I resent some of the v9 patches and got some reviews from Gabriel, I did changes as requesteid and here is v10. Changes in v10: - reworked a bit the comparison helper to improve performance by f

[f2fs-dev] [PATCH v10 2/8] f2fs: Simplify the handling of cached insensitive names

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
From: Gabriel Krisman Bertazi Keeping it as qstr avoids the unnecessary conversion in f2fs_match Reviewed-by: Eric Biggers Signed-off-by: Gabriel Krisman Bertazi [eugen.hris...@collabora.com: port to 6.8-rc3] Signed-off-by: Eugen Hristev --- fs/f2fs/dir.c | 53 ++

[f2fs-dev] [PATCH v10 5/8] f2fs: Reuse generic_ci_match for ci comparisons

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
From: Gabriel Krisman Bertazi Now that ci_match is part of libfs, make f2fs reuse it instead of having a different implementation. Reviewed-by: Chao Yu Reviewed-by: Eric Biggers Signed-off-by: Gabriel Krisman Bertazi Signed-off-by: Eugen Hristev --- fs/f2fs/dir.c | 58 --

[f2fs-dev] [PATCH v10 3/8] libfs: Introduce case-insensitive string comparison helper

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
From: Gabriel Krisman Bertazi generic_ci_match can be used by case-insensitive filesystems to compare strings under lookup with dirents in a case-insensitive way. This function is currently reimplemented by each filesystem supporting casefolding, so this reduces code duplication in filesystem-sp

[f2fs-dev] [PATCH v10 7/8] ext4: Move CONFIG_UNICODE defguards into the code flow

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
From: Gabriel Krisman Bertazi Instead of a bunch of ifdefs, make the unicode built checks part of the code flow where possible, as requested by Torvalds. Reviewed-by: Eric Biggers Signed-off-by: Gabriel Krisman Bertazi [eugen.hris...@collabora.com: port to 6.8-rc3] Signed-off-by: Eugen Hristev

[f2fs-dev] [PATCH v10 6/8] ext4: Log error when lookup of encoded dentry fails

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
From: Gabriel Krisman Bertazi If the volume is in strict mode, ext4_ci_compare can report a broken encoding name. This will not trigger on a bad lookup, which is caught earlier, only if the actual disk name is bad. Reviewed-by: Eric Biggers Signed-off-by: Gabriel Krisman Bertazi Signed-off-by

[f2fs-dev] [PATCH v10 8/8] f2fs: Move CONFIG_UNICODE defguards into the code flow

2024-02-14 Thread Eugen Hristev via Linux-f2fs-devel
From: Gabriel Krisman Bertazi Instead of a bunch of ifdefs, make the unicode built checks part of the code flow where possible, as requested by Torvalds. Reviewed-by: Eric Biggers Reviewed-by: Chao Yu Signed-off-by: Gabriel Krisman Bertazi [eugen.hris...@collabora.com: port to 6.8-rc3] Signed