Re: [f2fs-dev] [PATCH v2] f2fs: add unlikely() macro for compiler more aggressively

2013-12-10 Thread Jaegeuk Kim
From d373d7084e4d132fa596fd5def1b9a9843e1410f Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Fri, 6 Dec 2013 15:00:58 +0900 Subject: [PATCH] f2fs: add unlikely() macro for compiler more aggressively This patch adds unlikely() macro into the most of codes. The basic rule

Re: [f2fs-dev] [PATCH 3/3 V3] f2fs: introduce f2fs_cache_node_page() to add page into node_inode cache

2013-12-10 Thread Chao Yu
-Original Message- From: Chao Yu [mailto:chao2...@samsung.com] Sent: Tuesday, December 10, 2013 9:52 AM To: jaegeuk@samsung.com Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 3/3 V3] f2fs:

Re: [f2fs-dev] [PATCH 00/18] Consolidate Posix ACL implementation

2013-12-10 Thread Andreas Gruenbacher
Christoph, nice work, and a pretty diffstat. I see that get_acl and set_acl are being defined in some but not all symlink inode operations (for example, btrfs them while ext4 does not), and that posix_acl_xattr_set() doesn't check if set_acl is defined. Symlinks cannot have ACLs, so set_acl

Re: [f2fs-dev] [PATCH 12/18] ocfs2: use generic posix ACL infrastructure

2013-12-10 Thread Christoph Hellwig
On Tue, Dec 03, 2013 at 12:00:07AM +0100, Jan Kara wrote: Hum, this changes the cluster locking. Previously ocfs2_acl_get() used from ocfs2_acl_chmod() grabbed cluster wide inode lock. Now getting of ACL isn't protected by the inode lock. That being said the cluster locking around setattr

Re: [f2fs-dev] [PATCH 09/18] f2fs: use generic posix ACL infrastructure

2013-12-10 Thread Jaegeuk Kim
2013-12-08 (일), 01:14 -0800, Christoph Hellwig: On Fri, Dec 06, 2013 at 10:37:34AM +0900, Jaegeuk Kim wrote: f2fs caches a new mode bit for a while to make the consistency between xattr's acl mode and the inode mode. Can you explain what exactly you're trying to do there? I've been

Re: [f2fs-dev] [PATCH 09/18] f2fs: use generic posix ACL infrastructure

2013-12-10 Thread Jaegeuk Kim
2013-12-01 (일), 03:59 -0800, Christoph Hellwig: f2fs has some weird mode bit handling, so still using the old chmod code for now. f2fs caches a new mode bit for a while to make the consistency between xattr's acl mode and the inode mode. Anyway, it's a very good job. Thanks, You can add:

Re: [f2fs-dev] [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastructure

2013-12-10 Thread Christoph Hellwig
On Wed, Dec 04, 2013 at 12:12:37PM +, Steven Whitehouse wrote: error = posix_acl_equiv_mode(acl, mode); + if (error 0) Andy Price has pointed out a missing return error; here - if (error = 0) { - posix_acl_release(acl); +

Re: [f2fs-dev] [PATCH 09/18] f2fs: use generic posix ACL infrastructure

2013-12-10 Thread Christoph Hellwig
On Fri, Dec 06, 2013 at 10:37:34AM +0900, Jaegeuk Kim wrote: f2fs caches a new mode bit for a while to make the consistency between xattr's acl mode and the inode mode. Can you explain what exactly you're trying to do there? I've been trying to unwrap what's going on and can't really see the

Re: [f2fs-dev] [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastructure

2013-12-10 Thread Steven Whitehouse
Hi, On Sun, 2013-12-01 at 03:59 -0800, Christoph Hellwig wrote: plain text document attachment (0016-gfs2-use-generic-posix-ACL-infrastructure.patch) This contains some major refactoring for the create path so that inodes are created with the right mode to start with instead of fixing it up

[f2fs-dev] [SPAM] luxury goods - The order in 2 clicks. + 15% discount! -enjoy!

2013-12-10 Thread Jill
offer luxury-simple and elegant. - http://tiny.cc/pdtk7w hxaac.jpg-- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance

[f2fs-dev] [PATCH] f2fs: missing kmem_cache_destroy for discard_entry

2013-12-10 Thread Changman Lee
insmod f2fs.ko is failed after insmod and rmmod firstly. $ sudo insmod fs/f2fs/f2fs.ko insmod: error inserting 'fs/f2fs/f2fs.ko': -1 Cannot allocate memory -- dmesg -- kmem_cache_sanity_check (free_nid): Cache name already exists. Signed-off-by: Changman Lee cm224@samsung.com ---