Re: [f2fs-dev] [PATCH 01/11] f2fs: add nobarrier mount option

2014-07-29 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 01/11] f2fs: add

Re: [f2fs-dev] [PATCH 02/11] f2fs: punch the core function for inode management

2014-07-29 Thread Chao Yu
-Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 02/11] f2fs: punch the core

Re: [f2fs-dev] [PATCH 03/11] f2fs: add infra for ino management

2014-07-29 Thread Chao Yu
-Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 03/11] f2fs: add infra for ino

Re: [f2fs-dev] [PATCH 04/11] f2fs: use radix_tree for ino management

2014-07-29 Thread Chao Yu
Hi, One comment as following. -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH

Re: [f2fs-dev] [PATCH 05/11] f2fs: add info of appended or updated data writes

2014-07-29 Thread Chao Yu
-Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 05/11] f2fs: add info of appended

Re: [f2fs-dev] [PATCH 06/11] f2fs: skip unnecessary data writes during fsync

2014-07-29 Thread Chao Yu
Hi, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 06/11] f2fs: skip

Re: [f2fs-dev] [PATCH 07/11] f2fs: enable in-place-update for fdatasync

2014-07-29 Thread Jaegeuk Kim
Hi Changman, On Tue, Jul 29, 2014 at 09:41:11AM +0900, Changman Lee wrote: Hi Jaegeuk, On Fri, Jul 25, 2014 at 03:47:21PM -0700, Jaegeuk Kim wrote: This patch enforces in-place-updates only when fdatasync is requested. If we adopt this in-place-updates for the fdatasync, we can skip to

Re: [f2fs-dev] [PATCH 01/11] f2fs: add nobarrier mount option

2014-07-29 Thread Jaegeuk Kim
Hi Chao, On Tue, Jul 29, 2014 at 07:28:16PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org;

Re: [f2fs-dev] [PATCH 04/11] f2fs: use radix_tree for ino management

2014-07-29 Thread Jaegeuk Kim
Got it. Fixed that. Thanks, On Tue, Jul 29, 2014 at 07:32:08PM +0800, Chao Yu wrote: Hi, One comment as following. -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org;

Re: [f2fs-dev] [PATCH 10/11] f2fs: avoid checkpoint when error was occurred

2014-07-29 Thread Jaegeuk Kim
Hi Chao, On Tue, Jul 29, 2014 at 07:41:35PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org;

Re: [f2fs-dev] [PATCH v2 11/11] f2fs: avoid retrying wrong recovery routine when error was occurred

2014-07-29 Thread Jaegeuk Kim
Change log from v1: o adjust need_writecp condition, pointed by Chao From 387830bd09845dce83bf277bf8416c986c108eb7 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaeg...@kernel.org Date: Fri, 25 Jul 2014 15:47:25 -0700 Subject: [PATCH] f2fs: avoid retrying wrong recovery routine when error was

Re: [f2fs-dev] [PATCH] Remove an unnecessary line in allocate_data_block.

2014-07-29 Thread Jaegeuk Kim
Hi Dongho, At first, please write a patch under the correct rule. (e.g., description) About this change, it's negative. When considering SSR, we need to take care of the following scenario. - old segno : X - new address : Z - old curseg : Y This means, a new block is supposed to be written to Z

[f2fs-dev] ★ Привези свой груз с удовольствием!

2014-07-29 Thread ООО РУССНАБАВТОБРОКЕР
Специальное предложение Вы дополнительно получаете 20 000 рублей за 2 перевозки из Европы Что для этого нужно? - если Вы можете планировать свои отгрузки, давая предварительную заявку за пять рабочих дней, для Вас действует система накопительной скидки, форма возврата любая -

[f2fs-dev] [PATCH] f2fs: add tracepoint for f2fs_issue_flush

2014-07-29 Thread Jaegeuk Kim
This patch adds a tracepoint for f2fs_issue_flush. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/segment.c | 3 +++ include/trace/events/f2fs.h | 24 2 files changed, 27 insertions(+) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index

Re: [f2fs-dev] [PATCH 07/11] f2fs: enable in-place-update for fdatasync

2014-07-29 Thread Changman Lee
On Tue, Jul 29, 2014 at 05:22:15AM -0700, Jaegeuk Kim wrote: Hi Changman, On Tue, Jul 29, 2014 at 09:41:11AM +0900, Changman Lee wrote: Hi Jaegeuk, On Fri, Jul 25, 2014 at 03:47:21PM -0700, Jaegeuk Kim wrote: This patch enforces in-place-updates only when fdatasync is requested.

Re: [f2fs-dev] [PATCH] Remove an unnecessary line in allocate_data_block.

2014-07-29 Thread Changman Lee
On Tue, Jul 29, 2014 at 06:24:48AM -0700, Jaegeuk Kim wrote: Hi Dongho, At first, please write a patch under the correct rule. (e.g., description) About this change, it's negative. When considering SSR, we need to take care of the following scenario. - old segno : X - new address : Z -

Re: [f2fs-dev] [PATCH 07/11] f2fs: enable in-place-update for fdatasync

2014-07-29 Thread Jaegeuk Kim
On Wed, Jul 30, 2014 at 08:54:55AM +0900, Changman Lee wrote: On Tue, Jul 29, 2014 at 05:22:15AM -0700, Jaegeuk Kim wrote: Hi Changman, On Tue, Jul 29, 2014 at 09:41:11AM +0900, Changman Lee wrote: Hi Jaegeuk, On Fri, Jul 25, 2014 at 03:47:21PM -0700, Jaegeuk Kim wrote: This

Re: [f2fs-dev] [PATCH] Remove an unnecessary line in allocate_data_block.

2014-07-29 Thread Jaegeuk Kim
On Wed, Jul 30, 2014 at 09:24:50AM +0900, Changman Lee wrote: On Tue, Jul 29, 2014 at 06:24:48AM -0700, Jaegeuk Kim wrote: Hi Dongho, At first, please write a patch under the correct rule. (e.g., description) About this change, it's negative. When considering SSR, we need to take

Re: [f2fs-dev] [PATCH 07/11] f2fs: enable in-place-update for fdatasync

2014-07-29 Thread Chao Yu
Hi Jaegeuk Changman, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, July 30, 2014 9:08 AM To: Changman Lee Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH

Re: [f2fs-dev] [PATCH 07/11] f2fs: enable in-place-update for fdatasync

2014-07-29 Thread Jaegeuk Kim
On Wed, Jul 30, 2014 at 10:56:31AM +0900, Changman Lee wrote: On Tue, Jul 29, 2014 at 06:08:21PM -0700, Jaegeuk Kim wrote: On Wed, Jul 30, 2014 at 08:54:55AM +0900, Changman Lee wrote: On Tue, Jul 29, 2014 at 05:22:15AM -0700, Jaegeuk Kim wrote: Hi Changman, On Tue, Jul 29, 2014

Re: [f2fs-dev] [PATCH 07/11] f2fs: enable in-place-update for fdatasync

2014-07-29 Thread Jaegeuk Kim
On Wed, Jul 30, 2014 at 10:45:38AM +0800, Chao Yu wrote: Hi Jaegeuk Changman, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, July 30, 2014 9:08 AM To: Changman Lee Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;

Re: [f2fs-dev] [PATCH 08/11] f2fs: fix wrong condition for unlikely

2014-07-29 Thread Jaegeuk Kim
On Wed, Jul 30, 2014 at 09:44:43AM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Saturday, July 26, 2014 6:47 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net

[f2fs-dev] [PATCH v2] Remove an unnecessary line in allocate_data_block.

2014-07-29 Thread Dongho Sim
Hi. There was an unnecessary line in function, allocate_data_block. In this function, we already choosed old curseg(Y) and then we always allocate new address(∈Y) from it. After that we call refresh_sit_entry(sbi, old_blkaddr, *new_blkaddr). In that function, we call located_dirty_segment with