It turns out that a bit operation like find_next_bit is not always fast enough
for f2fs_find_entry.
Instead, it is pretty much simple and fast to traverse each dentries.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/dir.c | 32 +---
1 file changed, 17
list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
--
Jaegeuk Kim
Samsung
--
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic
.
The performance numbers are like below, which is measured by Alex.
1. 355MB/s ext4
2. 225MB/s f2fs : WRITE for node writes
3. 525MB/s f2fs : WRITE_SYNC for node writes
Reported-And-Tested-by: Alex hb...@yandex.com.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs
/HACKING
new file mode 100644
index 000..515b73e
--- /dev/null
+++ b/HACKING
@@ -0,0 +1 @@
+Send patches to linux-f2fs-devel@lists.sourceforge.net
--
Jaegeuk Kim
Samsung
--
Subversion Kills Productivity. Get
://www.tux.org/lkml/
--
Jaegeuk Kim
Samsung
--
Learn Graph Databases - Download FREE O'Reilly Book
Graph Databases is the definitive new guide to graph databases and their
applications. Written by three acclaimed
) {
f2fs_put_page(new, 1);
- return -EINVAL;
+ return err;
}
}
}
--
Jaegeuk Kim
Samsung
--
Learn Graph Databases
f2fs_sb_info *sbi)
INIT_LIST_HEAD(nm_i-dirty_nat_entries);
mutex_init(nm_i-build_lock);
+ init_waitqueue_head(nm_i-build_wq);
spin_lock_init(nm_i-free_nid_list_lock);
rwlock_init(nm_i-nat_tree_lock);
--
Jaegeuk Kim
Samsung
Hi,
2014-03-10 (월), 13:13 +0800, Chao Yu:
Hi Gu, Kim:
One more comment.
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Monday, March 10, 2014 12:46 PM
To: Gu Zheng
Cc: linux-kernel; f2fs
Subject: Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize
, off, 3))
+ else if (!strncmp(name, off, strlen(name)))
clear_opt(sbi, BG_GC);
else {
kfree(name);
--
Jaegeuk Kim
Samsung
If a page is on writeback, f2fs can face with deadlock due to under writepages.
This is caused by merging IOs inside f2fs, so if it comes to detect, let's throw
merged IOs, which is implemented by f2fs_wait_on_page_writeback.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs
The get_dirty_dents gives us the number of dirty dentry pages.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/checkpoint.c | 2 +-
fs/f2fs/f2fs.h | 5 +
fs/f2fs/inode.c | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs
This patch introduces nr_pages_to_write to align page writes to the segment
or other operational unit size, which can be tuned according to the system
environment.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/checkpoint.c | 11 ++-
fs/f2fs/data.c | 12
This patch increases pages_skipped when skipping writepages.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/checkpoint.c | 11 ++-
fs/f2fs/data.c | 6 +-
fs/f2fs/node.c | 6 +-
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/fs/f2fs
/ 1024) = 10MB.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++
Documentation/filesystems/f2fs.txt | 4
fs/f2fs/f2fs.h | 1 +
fs/f2fs/node.c | 23 ---
fs
It is more reasonable to determine the reclaiming rate of prefree segments
according to the volume size, which is set to 5% by default.
For example, if the volume is 128GB, the prefree segments are reclaimed
when the number reaches to 6.4GB.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
This patch adds missing dir_level documentation.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs
b/Documentation/ABI/testing/sysfs-fs-f2fs
index
.
Otherwise, we should do a new node block with the mark for roll-forward
recovery.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/f2fs.h | 1 +
fs/f2fs/file.c | 2 ++
fs/f2fs/node.c | 37 -
fs/f2fs/node.h | 1 +
4 files changed, 32 insertions
This patch introduces fi-i_sem to protect fi's info that includes xattr_ver,
pino, i_nlink.
This enables to remove i_mutex during f2fs_sync_file, resulting in performance
improvement when a number of fsync calls are triggered from many concurrent
threads.
Signed-off-by: Jaegeuk Kim jaegeuk
/0x180
f2fs_init_acl+0x29/0xcc [f2fs]
__f2fs_add_link+0x259/0x710 [f2fs]
f2fs_create+0xad/0x1c0 [f2fs]
vfs_create+0xed/0x150
do_last+0xd36/0xed0
path_openat+0xc5/0x680
do_filp_open+0x43/0xa0
do_sys_open+0x13c/0x230
SyS_creat+0x1e/0x20
system_call_fastpath+0x16/0x1b
Signed-off-by: Jaegeuk
During the cleaing of node segments, F2FS can get errored node blocks due to
data race between node page lock and its valid bitmap operations.
In that case, it needs to return an error to skip such the obsolete block copy.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/node.c | 3
In the f2fs_wait_on_page_writeback, io-bio should be covered by io_rwsem.
Otherwise, the bio pointer can become a dangling pointer due to data races.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/segment.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
be used under a workload consisting of very intensive
concurrent fsync calls, while the storage handles cache_flush commands slowly.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
Documentation/filesystems/f2fs.txt | 4 ++
fs/f2fs/f2fs.h | 16 +++
fs/f2fs/file.c
change log from v1:
o do not create a flush thread, if the option is not set
From deb512157c4bcae079197eb55590e3e764cedc7f Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim jaegeuk@samsung.com
Date: Wed, 2 Apr 2014 15:34:36 +0900
Subject: [PATCH] f2fs: introduce f2fs_issue_flush to avoid redundant
--
Jaegeuk Kim
Samsung
--
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net
segment_info's show for better legibility
f2fs: optimize restore_node_summary slightly
Jaegeuk Kim (37):
f2fs: update_inode_page should be done all the time
f2fs: handle dirty segments inside refresh_sit_entry
f2fs: fix to recover xattr node block
f2fs: remove the ugly pointer
/segment.c
+++ b/fs/f2fs/segment.c
@@ -226,6 +226,7 @@ repeat:
next = cmd-next;
complete(cmd-wait);
}
+ bio_put(bio);
sm_i-dispatch_list = NULL;
}
--
Jaegeuk Kim
Samsung
(-)
--
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jaegeuk Kim
Samsung
The f2fs_write_data_page should decrease the number of dirty dentry page
all the time.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/data.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 45abd60..9a3fa38 100644
incur any performance regression significantly.
Could you test this patch?
From 60588ceb7277aae2a79e7f67f5217d1256720d78 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim jaegeuk@samsung.com
Date: Tue, 15 Apr 2014 13:57:55 +0900
Subject: [PATCH] f2fs: avoid to conduct roll-forward due to the remained
Change log from v1:
o change the patch, which includes this bug fix
From 0f3b8427b40b9ace829ba0b16336d5cd67589022 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim jaegeuk@samsung.com
Date: Tue, 15 Apr 2014 16:04:15 +0900
Subject: [PATCH] f2fs: call redirty_page_for_writepage
This patch replace
Hi all,
Please ignore this, since it turns out that is doesn't solve the
problem.
Instead, please consider the following patch.
From ac9ad0b1de42dc311323b9c3b8f431f4b097b43b Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim jaegeuk@samsung.com
Date: Wed, 16 Apr 2014 10:47:06 +0900
Subject: [PATCH
If it occurs an error, we should call f2fs_unlock_op.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/inline.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 383db1f..3258c7c 100644
--- a/fs/f2fs/inline.c
disable_roll_forward.
Thanks,
15.04.2014 15:04, Jaegeuk Kim пишет:
Hi,
Thank you for the report.
I retrieved the fault image and found out that previous garbage data
wreak such the wrong behaviors.
So, I wrote the following patch that fills one zero-block at the
checkpoint procedure
-nat_cnt = 0;
nm_i-ram_thresh = DEF_RAM_THRESHOLD;
--
Jaegeuk Kim
Samsung
--
Learn Graph Databases - Download FREE O'Reilly Book
Graph Databases is the definitive new guide to graph databases and their
applications
mean it needs to avoid such the BUG_ONs if the image has
obsolete data being used before?
Thanks,
Regards,
Alexey
On 16.04.2014 16:35, Jaegeuk Kim wrote:
Hi,
2014-04-16 (수), 13:11 +0400, Andrey Tsyvarev:
Hi,
With this patch mounting of the image continues to fail (with similar
--
Jaegeuk Kim
Samsung
--
Learn Graph Databases - Download FREE O'Reilly Book
Graph Databases is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first
Got it.
The patch is like this.
Thanks,
From 5f7a3bcf0df10bbb47a6e4409cc92ba8e6090674 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim jaegeuk@samsung.com
Date: Fri, 18 Apr 2014 11:14:37 +0900
Subject: [PATCH] f2fs: add available_nids to fix handling max_nid
correctly
This patch introduces
This patch announces LGPL v2 for the following files.
- include/f2fs_fs.h
- lib/libf2fs.c
- lib/libf2fs_io.c
- mkfs/f2fs_format.c
- mkfs/f2fs_format_main.c
- mkfs/f2fs_format_utils.c
- mkfs/f2fs_format_utils.h
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
COPYING | 492
2) write 4KB at 5MB offset
f - N N N N N X N N N N N N ... N
3) SEEK_DATA from 0 should return 5MB offset
So, this patch adds a routine to search the first dirty page to handle that.
Then, the SEEK_DATA flow skips NEW_ADDR offsets until any dirty page is found.
Signed-off-by: Jaegeuk Kim jaegeuk
f2fs_sb_info *sbi = F2FS_SB(inode-i_sb);
--
Jaegeuk Kim
Samsung
--
Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled
Hi,
2014-04-29 (화), 15:53 +0800, Chao Yu:
Hi Kim,
-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Tuesday, April 29, 2014 2:16 PM
To: Chao Yu
Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org
This patch reduces the lock granularity during write_begin.
When the system is under memory pressure, it would be better to reduce
the locking time for the data pages.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/data.c | 14 +-
1 file changed, 13 insertions(+), 1
This patch splits grab_cache_page_write_begin into grab_cache_page and
wait_on_page_writeback for node pages.
This patch intends to enhance the latency to get node pages by alleviating
unnecessary wait_on_page_writeback.
Signed-off-by: Chao Yu chao2...@samsung.com
Signed-off-by: Jaegeuk Kim
This patch removes grab_cache_page_write_begin for meta pages.
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/checkpoint.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 1346ce9..b6f6ead 100644
--- a/fs
;
}
--
Jaegeuk Kim
signature.asc
Description: This is a digitally signed message part
--
Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get
#define CP_COMPACT_SUM_FLAG 0x0004
#define CP_ORPHAN_PRESENT_FLAG 0x0002
--
Jaegeuk Kim
signature.asc
Description: This is a digitally signed message part
--
Accelerate Dev Cycles with Automated Cross
If a fallocated file is fsynced, we should recover the i_size after sudden
power cut.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/file.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index d97e5c4..78110da 100644
--- a/fs/f2fs/file.c
+++ b/fs
The fsck tool should call f2fs_finalize_device before exit to close the device
file.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fsck/main.c | 3 +++
include/f2fs_fs.h| 1 +
lib/libf2fs.c| 12
mkfs/f2fs_format.c | 2 --
mkfs
And let's show some debug info as well.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
mkfs/Makefile.am | 2 +-
mkfs/f2fs_format_utils.c | 6 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
index 68cab66..ff136a7 100644
blocks, f2fs allocates 6 blocks
including pg_end.
So, this patch adds one condition to avoid block allocation.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/file.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 623df73..d621ddb
This patch arranges the f2fs_locks to cover the fallocated data and its i_size.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/file.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 9c49c59..623df73 100644
--- a/fs/f2fs
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
--
Jaegeuk Kim
--
HPCC Systems Open Source Big Data Platform from LexisNexis
On 19/06/14 21:27, Jaegeuk Kim wrote:
Hi,
On Thu, Jun 19, 2014 at 08:32:43PM +1000, Brian Chadwick wrote:
Hi
I cant get file contexts to work with F2FS. I have tried a variety of
kernels up to the latest 3.16rc1 with the Security Labels option
selected in the config. I am using the latest
Hi,
On Fri, Jun 20, 2014 at 11:00:10AM +1000, Brian Chadwick wrote:
On 20/06/14 01:33, Jaegeuk Kim wrote:
Hi,
On Thu, Jun 19, 2014 at 10:14:22PM +1000, Brian Chadwick wrote:
Hi again
I tried mounting with seclabel specifically stated, i.e.:
mount -t f2fs -o
rw,relatime,background_gc
On Fri, Jun 20, 2014 at 03:15:49PM +1000, Brian Chadwick wrote:
On 20/06/14 15:00, Jaegeuk Kim wrote:
Hi,
On Fri, Jun 20, 2014 at 11:00:10AM +1000, Brian Chadwick wrote:
On 20/06/14 01:33, Jaegeuk Kim wrote:
Hi,
On Thu, Jun 19, 2014 at 10:14:22PM +1000, Brian Chadwick wrote:
Hi again
Hi,
On Fri, Jun 20, 2014 at 10:50:27PM +1000, Brian Chadwick wrote:
On 20/06/14 16:21, Jaegeuk Kim wrote:
On Fri, Jun 20, 2014 at 03:15:49PM +1000, Brian Chadwick wrote:
On 20/06/14 15:00, Jaegeuk Kim wrote:
Hi,
On Fri, Jun 20, 2014 at 11:00:10AM +1000, Brian Chadwick wrote:
On 20/06/14
This patch adds f2fs_do_tmpfile to eliminate the redundant init_inode_metadata
flow.
Throught this, we can provide the consistent lock usage, e.g., fi-i_sem, and
this will enable better debugging stuffs.
Cc: Chao Yu chao2...@samsung.com
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs
This patch cleans up simple unnecessary codes.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/dir.c | 2 +-
fs/f2fs/f2fs.h | 2 +-
fs/f2fs/namei.c | 26 +-
fs/f2fs/node.c | 2 +-
4 files changed, 12 insertions(+), 20 deletions(-)
diff --git a/fs/f2fs
entry_list;/* link with dirty nat entries */
+ nid_t start_nid;/* start nid of nats in set */
+ unsigned int entry_cnt; /* the # of nat entries in set */
+};
+
/*
* For free nid mangement
*/
--
1.7.9.5
--
Jaegeuk Kim
If we don't check the current backing device status, balance_dirty_pages can
fall into infinite pausing routine.
This can be occurred when a lot of directories make a small number of dirty
dentry pages including files.
Reported-by: Brian Chadwick brianc...@westnet.com.au
Signed-off-by: Jaegeuk
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
--
Jaegeuk Kim
--
Open source business
On Tue, Jul 01, 2014 at 10:54:20PM -0700, Andrew Morton wrote:
On Sat, 28 Jun 2014 20:58:38 +0900 Jaegeuk Kim jaeg...@kernel.org wrote:
If we don't check the current backing device status, balance_dirty_pages can
fall into infinite pausing routine.
This can be occurred when a lot
is written without dent_mark by
sync_node_pages.
So, this patch fixes this bug by assinging file_lost_pino to the a's inode.
If the pino is lost, f2fs_sync_file conducts checkpoint, and then recovers
the latest pino and its dentry information for further recovery.
Signed-off-by: Jaegeuk Kim jaeg
.
Any ideas?
Thanks,
On Fri, Jul 04, 2014 at 04:04:09PM +0800, Gu Zheng wrote:
Hi Yu,
Thanks.
On 07/04/2014 02:21 PM, Chao Yu wrote:
Hi Jaegeuk, Gu, Changman
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Friday, July 04, 2014 1:36 PM
To: Gu Zheng
On Mon, Jul 07, 2014 at 11:17:35AM +0800, Chao Yu wrote:
Hi Jaegeuk,
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Wednesday, July 02, 2014 6:35 PM
To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
Hi Chao,
On Wed, Jul 09, 2014 at 10:57:43AM +0800, Chao Yu wrote:
Hi,
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Tuesday, July 08, 2014 1:56 PM
To: Chao Yu
Cc: 'Changman Lee'; linux-f2fs-devel@lists.sourceforge.net;
linux-fsde...@vger.kernel.org
of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
--
Jaegeuk Kim
On Mon, Jul 14, 2014 at 05:53:36PM -0700, Greg KH wrote:
On Mon, Jul 14, 2014 at 07:52:51AM -0700, Jaegeuk Kim wrote:
commit dd6b9bf5883c3ca9c17bac80ccd8615fe5a452a3 upstream.
You mean 2743f865543c0c4a5e12fc13edb2bf89a6e9687c, right?
Ah, correct.
Thank you. :)
thanks,
greg k-h
Thank you guys.
I merged two patches. :)
--
Jaegeuk Kim
2014-07-24 22:49 GMT-07:00 Gu Zheng guz.f...@cn.fujitsu.com:
On 07/25/2014 11:22 AM, Chao Yu wrote:
Hi,
To Andrey:
Thanks for your test on this patch!
To Gu:
If you do not object, let me make and resend a patch base on the one
This patch adds a mount option, nobarrier, in f2fs.
The assumption in here is that file system keeps the IO ordering, but
doesn't care about cache flushes inside the storages.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/data.c| 5 -
fs/f2fs/f2fs.h| 1 +
fs/f2fs
This patch punches out the core functions to manage the inode numbers.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/checkpoint.c | 81
1 file changed, 44 insertions(+), 37 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs
For better ino management, this patch replaces the data structure from list
to radix tree.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/checkpoint.c | 48 ++--
fs/f2fs/f2fs.h | 1 +
2 files changed, 27 insertions(+), 22 deletions
This patch introduces a inode number list in which represents inodes having
appended data writes or updated data writes after last checkpoint.
This will be used at fsync to determine whether the recovery information
should be written or not.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs
This patch intends to improve the fsync performance by skipping remaining the
recovery information, only when there is no data that we should recover.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/file.c | 16
1 file changed, 16 insertions(+)
diff --git a/fs/f2fs
This patch enforces in-place-updates only when fdatasync is requested.
If we adopt this in-place-updates for the fdatasync, we can skip to write the
recovery information.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/f2fs.h| 1 +
fs/f2fs/file.c| 7 +++
fs/f2fs/segment.h
If the bit is already set, we don't need to reset it, and vice versa.
Because we don't need to make the caches dirty for that.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/f2fs.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs
This patch fixes the wrongly used unlikely condition.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/checkpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 42a16c1..36b0d47 100644
--- a/fs/f2fs/checkpoint.c
No need to do checkpoint, whenever any errors were detected.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/recovery.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index a112368..90d7e80 100644
--- a/fs/f2fs/recovery.c
Hi Huang,
On Sat, Jul 26, 2014 at 04:03:34PM +0800, huang ying wrote:
Hi, Jaegeuk,
Do you have time to take a look at this patch?
I merged this in my local tree. :)
Thanks,
Best Regards,
Huang, Ying
--
Want
Hi Changman,
On Tue, Jul 29, 2014 at 09:41:11AM +0900, Changman Lee wrote:
Hi Jaegeuk,
On Fri, Jul 25, 2014 at 03:47:21PM -0700, Jaegeuk Kim wrote:
This patch enforces in-place-updates only when fdatasync is requested.
If we adopt this in-place-updates for the fdatasync, we can skip
Hi Chao,
On Tue, Jul 29, 2014 at 07:28:16PM +0800, Chao Yu wrote:
Hi Jaegeuk,
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Saturday, July 26, 2014 6:47 AM
To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org;
linux-f2fs-devel
Got it.
Fixed that.
Thanks,
On Tue, Jul 29, 2014 at 07:32:08PM +0800, Chao Yu wrote:
Hi,
One comment as following.
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Saturday, July 26, 2014 6:47 AM
To: linux-ker...@vger.kernel.org; linux-fsde
Hi Chao,
On Tue, Jul 29, 2014 at 07:41:35PM +0800, Chao Yu wrote:
Hi Jaegeuk,
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Saturday, July 26, 2014 6:47 AM
To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org;
linux-f2fs-devel
Change log from v1:
o adjust need_writecp condition, pointed by Chao
From 387830bd09845dce83bf277bf8416c986c108eb7 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim jaeg...@kernel.org
Date: Fri, 25 Jul 2014 15:47:25 -0700
Subject: [PATCH] f2fs: avoid retrying wrong recovery routine when error
Hi Dongho,
At first, please write a patch under the correct rule.
(e.g., description)
About this change, it's negative.
When considering SSR, we need to take care of the following scenario.
- old segno : X
- new address : Z
- old curseg : Y
This means, a new block is supposed to be written to Z
This patch adds a tracepoint for f2fs_issue_flush.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/segment.c | 3 +++
include/trace/events/f2fs.h | 24
2 files changed, 27 insertions(+)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index
On Wed, Jul 30, 2014 at 08:54:55AM +0900, Changman Lee wrote:
On Tue, Jul 29, 2014 at 05:22:15AM -0700, Jaegeuk Kim wrote:
Hi Changman,
On Tue, Jul 29, 2014 at 09:41:11AM +0900, Changman Lee wrote:
Hi Jaegeuk,
On Fri, Jul 25, 2014 at 03:47:21PM -0700, Jaegeuk Kim wrote
On Wed, Jul 30, 2014 at 09:24:50AM +0900, Changman Lee wrote:
On Tue, Jul 29, 2014 at 06:24:48AM -0700, Jaegeuk Kim wrote:
Hi Dongho,
At first, please write a patch under the correct rule.
(e.g., description)
About this change, it's negative.
When considering SSR, we need to take
On Wed, Jul 30, 2014 at 10:56:31AM +0900, Changman Lee wrote:
On Tue, Jul 29, 2014 at 06:08:21PM -0700, Jaegeuk Kim wrote:
On Wed, Jul 30, 2014 at 08:54:55AM +0900, Changman Lee wrote:
On Tue, Jul 29, 2014 at 05:22:15AM -0700, Jaegeuk Kim wrote:
Hi Changman,
On Tue, Jul 29, 2014
On Wed, Jul 30, 2014 at 10:45:38AM +0800, Chao Yu wrote:
Hi Jaegeuk Changman,
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Wednesday, July 30, 2014 9:08 AM
To: Changman Lee
Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs
On Wed, Jul 30, 2014 at 09:44:43AM +0800, Chao Yu wrote:
Hi Jaegeuk,
-Original Message-
From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
Sent: Saturday, July 26, 2014 6:47 AM
To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net
This patch fixes wrong coding style.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/f2fs.h | 2 +-
fs/f2fs/file.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 14b9f74..80c7869 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs
On Thu, Jul 31, 2014 at 01:31:46PM +0800, Chao Yu wrote:
Hi Changman,
-Original Message-
From: Changman Lee [mailto:cm224@samsung.com]
Sent: Thursday, July 31, 2014 10:07 AM
To: Chao Yu
Cc: 'Jaegeuk Kim'; linux-fsde...@vger.kernel.org;
linux-ker...@vger.kernel.org
Hi Chao,
On Thu, Jul 31, 2014 at 09:13:11PM +0800, Chao Yu wrote:
When inode is evicted, all the page cache belong to this inode should be
released including the xattr node page. But previously we didn't do this, this
patch fixed this issue.
Signed-off-by: Chao Yu chao2...@samsung.com
---
Hi Matt,
On Sat, Aug 09, 2014 at 10:15:15PM +, Matt Parnell wrote:
I had a similar issue as a gentlemen whose message I recently read on this
list, where power loss caused his f2fs partition to cause a kernel oops
every time it was attempted to mount. I have the same issue. Is any form of
If a new inode page is needed for recover_dentry, we should assing i_inline
as zero.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/node.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 1f33299..093d799 100644
--- a/fs/f2fs/node.c
+++ b/fs
During the recovery, if an error like EIO or ENOMEM, f2fs_bug_on should skip.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/recovery.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index d7b67b8..7ca7aad 100644
--- a/fs
This patch adds f2fs_cp_error for readability.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/checkpoint.c | 4 ++--
fs/f2fs/f2fs.h | 5 +
fs/f2fs/gc.c | 2 +-
fs/f2fs/super.c | 2 +-
4 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs
This patch fixes missing unlock_page when a node page is redirtied out.
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/node.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index c80e3d5..9f126f8 100644
--- a/fs/f2fs/node.c
If mkwrite is called to an inode having inline_data, it can overwrite the data
index space as NEW_ADDR. (e.g., the first 4 bytes are coincidently zero)
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
fs/f2fs/data.c | 2 +-
fs/f2fs/f2fs.h | 2 +-
fs/f2fs/file.c | 11 ---
fs/f2fs
101 - 200 of 4179 matches
Mail list logo
