[f2fs-dev] [PATCH 6/6] f2fs: add inline_data recovery routine

2013-12-26 Thread Jaegeuk Kim
- recover data blocks Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h | 2 ++ fs/f2fs/file.c | 2 +- fs/f2fs/inline.c| 48 fs/f2fs/recovery.c | 8 ++-- include/linux/f2fs_fs.h | 3 +-- 5 files

[f2fs-dev] [PATCH 1/6] f2fs: don't need to get f2fs_lock_op for the inline_data test

2013-12-26 Thread Jaegeuk Kim
This patch locates checking the inline_data prior to calling f2fs_lock_op() in truncate_blocks(), since getting the lock is unnecessary. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/file.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/f2fs

[f2fs-dev] [PATCH 2/6] f2fs: convert inline_data for punch_hole

2013-12-26 Thread Jaegeuk Kim
In the punch_hole(), let's convert inline_data all the time for simplicity and to avoid potential deadlock conditions. It is pretty much not a big deal to do this. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/file.c | 22 +++--- 1 file changed, 3 insertions

Re: [f2fs-dev] [PATCH 5/6] f2fs: add the number of inline_data files to status info

2013-12-26 Thread Jaegeuk Kim
Change log from v1: o fix kbuild failure From a9ebdcffd30b9642b2973ea8e9688e7b0d4bf7e3 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Tue, 26 Nov 2013 11:08:57 +0900 Subject: [PATCH] f2fs: add the number of inline_data files to status info This patch adds the number

[f2fs-dev] [PATCH] f2fs: handle errors correctly during f2fs_reserve_block

2013-12-27 Thread Jaegeuk Kim
of f2fs_reserve_block() is to nullify inode page when there is any error internally. Finally, two callers of f2fs_reserve_block() should call f2fs_put_dnode() appropriately if they got an error since successful f2fs_reserve_block(). Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c

Re: [f2fs-dev] [PATCH] f2fs: fix build warning for f2fs_has_inline_data()

2013-12-27 Thread Jaegeuk Kim
(F2FS_I(inode), FI_INLINE_DATA); -} - bool f2fs_may_inline(struct inode *inode) { struct f2fs_sb_info *sbi = F2FS_SB(inode-i_sb); -- Jaegeuk Kim Samsung -- Rapidly troubleshoot problems before they affect your

Re: [f2fs-dev] assertion failed

2014-01-06 Thread Jaegeuk Kim
) == hash_code Folkert van Heusden -- Jaegeuk Kim Samsung -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects

[f2fs-dev] [PATCH] f2fs: update documents and a MAINTAINERS entry

2014-01-09 Thread Jaegeuk Kim
This patch adds missing some description of sysfs entries in - Documentation/ABI/testing/sysfs-fs-f2fs - Documentation/filesystems/f2fs.txt. And it adds a maintained document entry of F2FS in MAINTAINERS. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- Documentation/ABI/testing/sysfs

Re: [f2fs-dev] A lot of data written by cleaner for specific workload

2014-01-26 Thread Jaegeuk Kim
___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- Jaegeuk Kim Samsung -- CenturyLink Cloud: The Leader in Enterprise

[f2fs-dev] [PATCH 4/4] f2fs: fix a build warning

2014-01-27 Thread Jaegeuk Kim
/f2fs/recovery.c:260:23: warning: ‘sum.nid’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/recovery.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/fs/f2fs/recovery.c b

[f2fs-dev] [PATCH 1/4] f2fs: update_inode_page should be done all the time

2014-01-27 Thread Jaegeuk Kim
In order to make fs consistency, update_inode_page should not be failed all the time. Otherwise, it is possible to lose some metadata in the inode like a link count. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 3 +-- fs/f2fs/f2fs.h | 8 +++- fs/f2fs/inode.c

Re: [f2fs-dev] [PATCH] f2fs: use inode mutex to keep atomicity of f2fs_falloc

2014-01-27 Thread Jaegeuk Kim
f2fs_fallocate(struct file *file, int mode, inode-i_mtime = inode-i_ctime = CURRENT_TIME; mark_inode_dirty(inode); } + + mutex_unlock(inode-i_mutex); + trace_f2fs_fallocate(inode, mode, offset, len, ret); return ret; } -- Jaegeuk Kim

[f2fs-dev] [PATCH] f2fs: remove the ugly pointer conversion

2014-02-02 Thread Jaegeuk Kim
of the bi_private. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 11 +++ fs/f2fs/f2fs.h | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 20c3c64..d175ae3 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c

[f2fs-dev] [PATCH 1/2] f2fs: fix the potential mismatch between dir's i_size and i_blocks

2014-02-03 Thread Jaegeuk Kim
there is no valid dentry due to i_size = 4096. But, still there is one dentry in page-index = 1. So this patch moves the code to write dir-i_size into on-disk i_size in order to sync dir's i_size, on-disk i_size, and its i_blocks. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/dir.c

[f2fs-dev] [PATCH 2/2] f2fs: clean up with a macro

2014-02-03 Thread Jaegeuk Kim
This patch adds GET_BLKOFF_FROM_SEG0 to clean up some codes. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/recovery.c | 3 +-- fs/f2fs/segment.c | 11 --- fs/f2fs/segment.h | 3 +++ 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/fs/f2fs/recovery.c b

[f2fs-dev] [PATCH 1/2] f2fs: fix to truncate dentry pages in the error case

2014-02-04 Thread Jaegeuk Kim
When a new directory is allocated, if an error is occurred, we should truncate preallocated dentry pages too. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index bfcb4ae..daea906c 100644

[f2fs-dev] [PATCH 2/2] f2fs: fix f2fs_write_meta_page at no checkpoint status

2014-02-04 Thread Jaegeuk Kim
If f2fs entered errorneous checkpoint status, it should skip writing meta pages instead of redirtying the pages out. Otherwise, it cannot unmount the partition even though f2fs is under read-only status. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 29

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-05 Thread Jaegeuk Kim
Hi, Thank you for the test and valuable report. This bug was fixed recently by: commit 03dea3129d558bf5293a6e9f12777176619ac876 Author: Jaegeuk Kim jaegeuk@samsung.com Date: Wed Feb 5 11:16:39 2014 +0900 f2fs: fix to truncate dentry pages in the error case You can find that from

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-06 Thread Jaegeuk Kim
Hi, 2014-02-06 (목), 16:17 +0400, Andrey Tsyvarev: Hi, 06.02.2014 10:02, Jaegeuk Kim пишет: Hi, Thank you for the test and valuable report. This bug was fixed recently by: commit 03dea3129d558bf5293a6e9f12777176619ac876 Author: Jaegeuk Kim jaegeuk@samsung.com Date: Wed

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-06 Thread Jaegeuk Kim
can do that. 2. truncate_blocks() Preallocated dentry pages are trucated here to sync i_blocks. Reported-by: Andrey Tsyvarev tsyva...@ispras.ru Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/dir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/dir.c b/fs/f2fs

[f2fs-dev] [PATCH] f2fs: clean up redundant function call

2014-02-06 Thread Jaegeuk Kim
This patch integrates inode_[inc|dec]_dirty_dents with inc_page_count to remove redundant calls. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 1 - fs/f2fs/data.c | 11 ++- fs/f2fs/dir.c| 4 ++-- fs/f2fs/f2fs.h | 5 + fs/f2fs

Re: [f2fs-dev] [PATCH] f2fs: introduce ra_meta_pages to readahead CP/NAT/SIT pages

2014-02-06 Thread Jaegeuk Kim
{ - readed = ra_sit_pages(sbi, start_blk, nrpages); + readed = ra_meta_pages(sbi, start_blk, nrpages, META_SIT); start = start_blk * sit_i-sents_per_block; end = (start_blk + readed) * sit_i-sents_per_block; -- Jaegeuk Kim Samsung

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Jaegeuk Kim
, -- Jaegeuk Kim Samsung -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Jaegeuk Kim
you. :) Thanks, Gu -- Jaegeuk Kim Samsung -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more

[f2fs-dev] [PATCH] f2fs: fix not to write data pages on the page reclaiming path

2014-02-18 Thread Jaegeuk Kim
/0x3d0 ? generic_file_aio_write+0x52/0xb0 ? generic_file_aio_write+0x52/0xb0 generic_file_aio_write+0x65/0xb0 do_sync_write+0x5a/0x90 vfs_write+0xc5/0x1f0 SyS_write+0x55/0xa0 system_call_fastpath+0x16/0x1b Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 40

[f2fs-dev] [PATCH] f2fs: fix to do build_stat prior to the recovery procedure

2014-02-19 Thread Jaegeuk Kim
/0x160 [811c5cb1] ? __get_fs_type+0x51/0x60 [811c9727] do_mount+0x237/0xb50 [811c936a] ? copy_mount_options+0x3a/0x170 So, this patche changes the order of recovery_fsync_data() and f2fs_build_stats(). Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs

Re: [f2fs-dev] [RFC PATCH 2/2] f2fs: simplify free nid management

2014-02-23 Thread Jaegeuk Kim
= page_address(xpage); -- Jaegeuk Kim Samsung -- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic

[f2fs-dev] [PATCH 1/2] f2fs: introduce a radix_tree for the free_nid list

2014-02-23 Thread Jaegeuk Kim
This patch introduces a radix tree for the list of free_nids, which enhances the performance on free nid management. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h | 1 + fs/f2fs/node.c | 36 +--- 2 files changed, 18 insertions(+), 19

[f2fs-dev] [PATCH 2/2] f2fs: implement a lock-free stat_show

2014-02-23 Thread Jaegeuk Kim
The stat_show is just to show the current status of f2fs. So, we can remove all the there-in locks. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/debug.c | 3 --- fs/f2fs/f2fs.h| 18 +++--- fs/f2fs/segment.h | 27 +++ 3 files changed, 6

[f2fs-dev] [PATCH 2/3] f2fs: introduce large directory support

2014-02-27 Thread Jaegeuk Kim
hash tables. This patch adds just a facility for this by introducing i_dir_level in f2fs_inode. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- Documentation/filesystems/f2fs.txt | 6 -- fs/f2fs/dir.c | 21 - fs/f2fs/f2fs.h

[f2fs-dev] [PATCH 3/3] f2fs: add an sysfs entry to control the directory level

2014-02-27 Thread Jaegeuk Kim
-by: Jaegeuk Kim jaegeuk@samsung.com --- Documentation/filesystems/f2fs.txt | 7 +++ fs/f2fs/f2fs.h | 3 +++ fs/f2fs/super.c| 7 +++ 3 files changed, 17 insertions(+) diff --git a/Documentation/filesystems/f2fs.txt b/Documentation/filesystems/f2fs.txt

[f2fs-dev] [PATCH 1/3] f2fs: remove costly bit operations for f2fs_find_entry

2014-02-27 Thread Jaegeuk Kim
It turns out that a bit operation like find_next_bit is not always fast enough for f2fs_find_entry. Instead, it is pretty much simple and fast to traverse each dentries. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/dir.c | 32 +--- 1 file changed, 17

Re: [f2fs-dev] Regression in kernel 3.14.0-rc1

2014-02-27 Thread Jaegeuk Kim
list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- Jaegeuk Kim Samsung -- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic

[f2fs-dev] [PATCH] f2fs: fix to write node pages with WRITE_SYNC

2014-03-02 Thread Jaegeuk Kim
. The performance numbers are like below, which is measured by Alex. 1. 355MB/s ext4 2. 225MB/s f2fs : WRITE for node writes 3. 525MB/s f2fs : WRITE_SYNC for node writes Reported-And-Tested-by: Alex hb...@yandex.com. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs

Re: [f2fs-dev] [PATCH] HACKING: document where to send patches

2014-03-04 Thread Jaegeuk Kim
/HACKING new file mode 100644 index 000..515b73e --- /dev/null +++ b/HACKING @@ -0,0 +1 @@ +Send patches to linux-f2fs-devel@lists.sourceforge.net -- Jaegeuk Kim Samsung -- Subversion Kills Productivity. Get

Re: [f2fs-dev] [PATCH 1/5] f2fs: update start nid only once each circle

2014-03-09 Thread Jaegeuk Kim
://www.tux.org/lkml/ -- Jaegeuk Kim Samsung -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed

Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary slightly

2014-03-09 Thread Jaegeuk Kim
) { f2fs_put_page(new, 1); - return -EINVAL; + return err; } } } -- Jaegeuk Kim Samsung -- Learn Graph Databases

Re: [f2fs-dev] [PATCH 5/5] f2fs: add a wait queue to avoid unnecessary, build_free_nid

2014-03-09 Thread Jaegeuk Kim
f2fs_sb_info *sbi) INIT_LIST_HEAD(nm_i-dirty_nat_entries); mutex_init(nm_i-build_lock); + init_waitqueue_head(nm_i-build_wq); spin_lock_init(nm_i-free_nid_list_lock); rwlock_init(nm_i-nat_tree_lock); -- Jaegeuk Kim Samsung

Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary slightly

2014-03-09 Thread Jaegeuk Kim
Hi, 2014-03-10 (월), 13:13 +0800, Chao Yu: Hi Gu, Kim: One more comment. -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Monday, March 10, 2014 12:46 PM To: Gu Zheng Cc: linux-kernel; f2fs Subject: Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize

Re: [f2fs-dev] [PATCH] f2fs: fix incorrect parsing with option string

2014-03-17 Thread Jaegeuk Kim
, off, 3)) + else if (!strncmp(name, off, strlen(name))) clear_opt(sbi, BG_GC); else { kfree(name); -- Jaegeuk Kim Samsung

[f2fs-dev] [PATCH 5/5] f2fs: call f2fs_wait_on_page_writeback instead of native function

2014-03-18 Thread Jaegeuk Kim
If a page is on writeback, f2fs can face with deadlock due to under writepages. This is caused by merging IOs inside f2fs, so if it comes to detect, let's throw merged IOs, which is implemented by f2fs_wait_on_page_writeback. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs

[f2fs-dev] [PATCH 1/5] f2fs: introduce get_dirty_dents for readability

2014-03-18 Thread Jaegeuk Kim
The get_dirty_dents gives us the number of dirty dentry pages. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 2 +- fs/f2fs/f2fs.h | 5 + fs/f2fs/inode.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs

[f2fs-dev] [PATCH 4/5] f2fs: introduce nr_pages_to_write for segment alignment

2014-03-18 Thread Jaegeuk Kim
This patch introduces nr_pages_to_write to align page writes to the segment or other operational unit size, which can be tuned according to the system environment. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 11 ++- fs/f2fs/data.c | 12

[f2fs-dev] [PATCH 3/5] f2fs: increase pages_skipped when skipping writepages

2014-03-18 Thread Jaegeuk Kim
This patch increases pages_skipped when skipping writepages. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 11 ++- fs/f2fs/data.c | 6 +- fs/f2fs/node.c | 6 +- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/fs/f2fs

[f2fs-dev] [PATCH 2/5] f2fs: throttle the memory footprint with a sysfs entry

2014-03-19 Thread Jaegeuk Kim
/ 1024) = 10MB. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++ Documentation/filesystems/f2fs.txt | 4 fs/f2fs/f2fs.h | 1 + fs/f2fs/node.c | 23 --- fs

[f2fs-dev] [PATCH 5/5] f2fs: change reclaim rate in percentage

2014-03-19 Thread Jaegeuk Kim
It is more reasonable to determine the reclaiming rate of prefree segments according to the volume size, which is set to 5% by default. For example, if the volume is 128GB, the prefree segments are reclaimed when the number reaches to 6.4GB. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com

[f2fs-dev] [PATCH 4/5] f2fs: add missing documentation for dir_level

2014-03-19 Thread Jaegeuk Kim
This patch adds missing dir_level documentation. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs index

[f2fs-dev] [PATCH 2/3] f2fs: skip unnecessary node writes during fsync

2014-03-20 Thread Jaegeuk Kim
. Otherwise, we should do a new node block with the mark for roll-forward recovery. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 2 ++ fs/f2fs/node.c | 37 - fs/f2fs/node.h | 1 + 4 files changed, 32 insertions

[f2fs-dev] [PATCH 1/3] f2fs: introduce fi-i_sem to protect fi's info

2014-03-20 Thread Jaegeuk Kim
This patch introduces fi-i_sem to protect fi's info that includes xattr_ver, pino, i_nlink. This enables to remove i_mutex during f2fs_sync_file, resulting in performance improvement when a number of fsync calls are triggered from many concurrent threads. Signed-off-by: Jaegeuk Kim jaegeuk

[f2fs-dev] [PATCH 3/3] f2fs: avoid RECLAIM_FS-ON-W warning

2014-03-20 Thread Jaegeuk Kim
/0x180 f2fs_init_acl+0x29/0xcc [f2fs] __f2fs_add_link+0x259/0x710 [f2fs] f2fs_create+0xad/0x1c0 [f2fs] vfs_create+0xed/0x150 do_last+0xd36/0xed0 path_openat+0xc5/0x680 do_filp_open+0x43/0xa0 do_sys_open+0x13c/0x230 SyS_creat+0x1e/0x20 system_call_fastpath+0x16/0x1b Signed-off-by: Jaegeuk

[f2fs-dev] [PATCH] f2fs: return -EIO when node id is not matched

2014-04-01 Thread Jaegeuk Kim
During the cleaing of node segments, F2FS can get errored node blocks due to data race between node page lock and its valid bitmap operations. In that case, it needs to return an error to skip such the obsolete block copy. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/node.c | 3

[f2fs-dev] [PATCH] f2fs: fix to cover io-bio with io_rwsem

2014-04-01 Thread Jaegeuk Kim
In the f2fs_wait_on_page_writeback, io-bio should be covered by io_rwsem. Otherwise, the bio pointer can become a dangling pointer due to data races. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/segment.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[f2fs-dev] [PATCH] f2fs: introduce f2fs_issue_flush to avoid redundant flush issue

2014-04-03 Thread Jaegeuk Kim
be used under a workload consisting of very intensive concurrent fsync calls, while the storage handles cache_flush commands slowly. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- Documentation/filesystems/f2fs.txt | 4 ++ fs/f2fs/f2fs.h | 16 +++ fs/f2fs/file.c

Re: [f2fs-dev] [PATCH v2] f2fs: introduce f2fs_issue_flush to avoid redundant flush issue

2014-04-03 Thread Jaegeuk Kim
change log from v1: o do not create a flush thread, if the option is not set From deb512157c4bcae079197eb55590e3e764cedc7f Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Wed, 2 Apr 2014 15:34:36 +0900 Subject: [PATCH] f2fs: introduce f2fs_issue_flush to avoid redundant

Re: [f2fs-dev] f2fs: kernel BUG at fs/f2fs/segment.h:543

2014-04-06 Thread Jaegeuk Kim
-- Jaegeuk Kim Samsung -- Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net

[f2fs-dev] [GIT PULL] f2fs updates for v3.15

2014-04-06 Thread Jaegeuk Kim
segment_info's show for better legibility f2fs: optimize restore_node_summary slightly Jaegeuk Kim (37): f2fs: update_inode_page should be done all the time f2fs: handle dirty segments inside refresh_sit_entry f2fs: fix to recover xattr node block f2fs: remove the ugly pointer

Re: [f2fs-dev] [PATCH 1/7] f2fs: put the bio when issue_flush completed

2014-04-13 Thread Jaegeuk Kim
/segment.c +++ b/fs/f2fs/segment.c @@ -226,6 +226,7 @@ repeat: next = cmd-next; complete(cmd-wait); } + bio_put(bio); sm_i-dispatch_list = NULL; } -- Jaegeuk Kim Samsung

Re: [f2fs-dev] [PATCH 0/7] f2fs: some fix and cleanup about flush_merge

2014-04-13 Thread Jaegeuk Kim
(-) -- To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jaegeuk Kim Samsung

[f2fs-dev] [PATCH 2/3] f2fs: fix to decrease the number of dirty dentry page

2014-04-15 Thread Jaegeuk Kim
The f2fs_write_data_page should decrease the number of dirty dentry page all the time. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 45abd60..9a3fa38 100644

Re: [f2fs-dev] f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-15 Thread Jaegeuk Kim
incur any performance regression significantly. Could you test this patch? From 60588ceb7277aae2a79e7f67f5217d1256720d78 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Tue, 15 Apr 2014 13:57:55 +0900 Subject: [PATCH] f2fs: avoid to conduct roll-forward due to the remained

Re: [f2fs-dev] [PATCH 2/3 v2] f2fs: fix to decrease the number of dirty dentry page

2014-04-15 Thread Jaegeuk Kim
Change log from v1: o change the patch, which includes this bug fix From 0f3b8427b40b9ace829ba0b16336d5cd67589022 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Tue, 15 Apr 2014 16:04:15 +0900 Subject: [PATCH] f2fs: call redirty_page_for_writepage This patch replace

Re: [f2fs-dev] [PATCH 3/3] f2fs: flush dirty directory pages when scattered pages are gathered

2014-04-15 Thread Jaegeuk Kim
Hi all, Please ignore this, since it turns out that is doesn't solve the problem. Instead, please consider the following patch. From ac9ad0b1de42dc311323b9c3b8f431f4b097b43b Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Wed, 16 Apr 2014 10:47:06 +0900 Subject: [PATCH

[f2fs-dev] [PATCH] f2fs: fix to unlock f2fs_lock at the omitted error case

2014-04-16 Thread Jaegeuk Kim
If it occurs an error, we should call f2fs_unlock_op. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/inline.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index 383db1f..3258c7c 100644 --- a/fs/f2fs/inline.c

Re: [f2fs-dev] f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-16 Thread Jaegeuk Kim
disable_roll_forward. Thanks, 15.04.2014 15:04, Jaegeuk Kim пишет: Hi, Thank you for the report. I retrieved the fault image and found out that previous garbage data wreak such the wrong behaviors. So, I wrote the following patch that fills one zero-block at the checkpoint procedure

Re: [f2fs-dev] [PATCH] f2fs: fix wrong number of max_nid when init

2014-04-17 Thread Jaegeuk Kim
-nat_cnt = 0; nm_i-ram_thresh = DEF_RAM_THRESHOLD; -- Jaegeuk Kim Samsung -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications

Re: [f2fs-dev] f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Jaegeuk Kim
mean it needs to avoid such the BUG_ONs if the image has obsolete data being used before? Thanks, Regards, Alexey On 16.04.2014 16:35, Jaegeuk Kim wrote: Hi, 2014-04-16 (수), 13:11 +0400, Andrey Tsyvarev: Hi, With this patch mounting of the image continues to fail (with similar

Re: [f2fs-dev] [PATCH] f2fs: fix to enable readahead last NAT block

2014-04-17 Thread Jaegeuk Kim
-- Jaegeuk Kim Samsung -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first

Re: [f2fs-dev] [PATCH] f2fs: fix to enable readahead last NAT block

2014-04-18 Thread Jaegeuk Kim
Got it. The patch is like this. Thanks, From 5f7a3bcf0df10bbb47a6e4409cc92ba8e6090674 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Fri, 18 Apr 2014 11:14:37 +0900 Subject: [PATCH] f2fs: add available_nids to fix handling max_nid correctly This patch introduces

Re: [f2fs-dev] f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-18 Thread Jaegeuk Kim
Thank you for the explanation. The following patch will resolve the issue. Thanks, From 2048e7458c982f4297da9d3366ab29224ae2e8b0 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Fri, 18 Apr 2014 15:21:04 +0900 Subject: [PATCH] f2fs: avoid BUG_ON when mouting corrupted

[f2fs-dev] [PATCH] f2fs: adjust free mem size to flush dentry blocks

2014-04-18 Thread Jaegeuk Kim
If so many dirty dentry blocks are cached, not reached to the flush condition, we should fall into livelock in balance_dirty_pages. So, let's consider the mem size for the condition. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 3 ++- fs/f2fs/f2fs.h | 1 + fs/f2fs

[f2fs-dev] [PATCH 2/3] f2fs: pass flags field to setxattr functions

2014-04-22 Thread Jaegeuk Kim
This patch passes the flags field to the low level setxattr functions to use XATTR_REPLACE in the following patches. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/acl.c | 2 +- fs/f2fs/xattr.c | 13 +++-- fs/f2fs/xattr.h | 4 ++-- 3 files changed, 10 insertions(+), 9

[f2fs-dev] [PATCH 3/3] f2fs: return errors right after checking them

2014-04-22 Thread Jaegeuk Kim
This patch adds two error conditions early in the setxattr operations. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/xattr.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index bbe9c2b..6073f9f 100644 --- a/fs

[f2fs-dev] [PATCH] f2fs-tools: announce dual licenses with GPL and LGPL v2

2014-04-24 Thread Jaegeuk Kim
This patch announces LGPL v2 for the following files. - include/f2fs_fs.h - lib/libf2fs.c - lib/libf2fs_io.c - mkfs/f2fs_format.c - mkfs/f2fs_format_main.c - mkfs/f2fs_format_utils.c - mkfs/f2fs_format_utils.h Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- COPYING | 492

[f2fs-dev] [PATCH 2/2] f2fs: consider fallocated space for SEEK_DATA

2014-04-28 Thread Jaegeuk Kim
2) write 4KB at 5MB offset f - N N N N N X N N N N N N ... N 3) SEEK_DATA from 0 should return 5MB offset So, this patch adds a routine to search the first dirty page to handle that. Then, the SEEK_DATA flow skips NEW_ADDR offsets until any dirty page is found. Signed-off-by: Jaegeuk Kim jaegeuk

Re: [f2fs-dev] [PATCH 3/3 v3] f2fs: fix to truncate inline data in inode page when setattr

2014-04-29 Thread Jaegeuk Kim
f2fs_sb_info *sbi = F2FS_SB(inode-i_sb); -- Jaegeuk Kim Samsung -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled

Re: [f2fs-dev] [PATCH 3/3 v3] f2fs: fix to truncate inline data in inode page when setattr

2014-04-29 Thread Jaegeuk Kim
Hi, 2014-04-29 (화), 15:53 +0800, Chao Yu: Hi Kim, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Tuesday, April 29, 2014 2:16 PM To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org

[f2fs-dev] [PATCH 4/4] f2fs: decrease the lock granularity during write_begin

2014-04-29 Thread Jaegeuk Kim
This patch reduces the lock granularity during write_begin. When the system is under memory pressure, it would be better to reduce the locking time for the data pages. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 14 +- 1 file changed, 13 insertions(+), 1

[f2fs-dev] [PATCH 2/4] f2fs: avoid grab_cache_page_write_begin for data pages

2014-04-29 Thread Jaegeuk Kim
We don't need to wait on page writeback for these cases. Signed-off-by: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 4 ++-- fs/f2fs/inline.c | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs

[f2fs-dev] [PATCH 1/4] f2fs: split grab_cache_page and wait_on_page_writeback for node pages

2014-04-29 Thread Jaegeuk Kim
This patch splits grab_cache_page_write_begin into grab_cache_page and wait_on_page_writeback for node pages. This patch intends to enhance the latency to get node pages by alleviating unnecessary wait_on_page_writeback. Signed-off-by: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim

[f2fs-dev] [PATCH 3/4] f2fs: no need to wait on page writebck to meta pages

2014-04-29 Thread Jaegeuk Kim
This patch removes grab_cache_page_write_begin for meta pages. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 1346ce9..b6f6ead 100644 --- a/fs

Re: [f2fs-dev] Segment size

2014-05-06 Thread Jaegeuk Kim
/linux-f2fs-devel -- Jaegeuk Kim Samsung -- Is your legacy SCM system holding you back? Join Perforce May 7 to find out: #149; 3 signs your SCM is hindering your productivity #149; Requirements for releasing software

Re: [f2fs-dev] [PATCH 6/6] f2fs: add a tracepoint for f2fs_read_data_pages

2014-05-06 Thread Jaegeuk Kim
), ino = %lu, start = %lu nrpage = %u, + show_dev_ino(__entry), + (unsigned long)__entry-start, + __entry-nrpage) +); + TRACE_EVENT(f2fs_submit_page_mbio, TP_PROTO(struct page *page, int rw, int type, block_t blk_addr), -- Jaegeuk Kim Samsung

Re: [f2fs-dev] Segment size

2014-05-08 Thread Jaegeuk Kim
2014-05-08 (목), 12:43 -0700, Paul Ni: On 6 May 2014 17:04, Jaegeuk Kim jaegeuk@samsung.com wrote: Hi, 2014-05-04 (일), 23:59 +, Paul Ni: Is it possible to set an arbitrary segment size? I'm trying to set it to 1.5MiB to make it align with erase blocks on flash chips in my EVO

Re: [f2fs-dev] [PATCH] f2fs: avoid crash when trace f2fs_submit_page_mbio event in ra_sum_pages

2014-05-20 Thread Jaegeuk Kim
; } -- Jaegeuk Kim signature.asc Description: This is a digitally signed message part -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get

Re: [f2fs-dev] [PATCH] f2fs: large volume support

2014-05-20 Thread Jaegeuk Kim
#define CP_COMPACT_SUM_FLAG 0x0004 #define CP_ORPHAN_PRESENT_FLAG 0x0002 -- Jaegeuk Kim signature.asc Description: This is a digitally signed message part -- Accelerate Dev Cycles with Automated Cross

[f2fs-dev] [PATCH 2/3] f2fs: recover fallocated space

2014-06-07 Thread Jaegeuk Kim
If a fallocated file is fsynced, we should recover the i_size after sudden power cut. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index d97e5c4..78110da 100644 --- a/fs/f2fs/file.c +++ b/fs

[f2fs-dev] [GIT PULL] f2fs updates for v3.16

2014-06-09 Thread Jaegeuk Kim
handle in the remount flow f2fs: introduce struct flush_cmd_control to wrap the flush_merge fields f2fs: introduce help function {create,destroy}_flush_cmd_control Jaegeuk Kim (25): f2fs: avoid to conduct roll-forward due to the remained garbage blocks f2fs: call

[f2fs-dev] [PATCH] libf2fs, fsck, mkfs: call f2fs_finalize_device before exit

2014-06-13 Thread Jaegeuk Kim
The fsck tool should call f2fs_finalize_device before exit to close the device file. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fsck/main.c | 3 +++ include/f2fs_fs.h| 1 + lib/libf2fs.c| 12 mkfs/f2fs_format.c | 2 -- mkfs

[f2fs-dev] [PATCH] mkfs: set BLKDISCARD by default

2014-06-13 Thread Jaegeuk Kim
And let's show some debug info as well. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- mkfs/Makefile.am | 2 +- mkfs/f2fs_format_utils.c | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am index 68cab66..ff136a7 100644

[f2fs-dev] [PATCH 3/3] f2fs: fix not to allocate unnecessary blocks during fallocate

2014-06-13 Thread Jaegeuk Kim
blocks, f2fs allocates 6 blocks including pg_end. So, this patch adds one condition to avoid block allocation. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/file.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 623df73..d621ddb

[f2fs-dev] [PATCH 2/3] f2fs: recover fallocated data and its i_size together

2014-06-13 Thread Jaegeuk Kim
This patch arranges the f2fs_locks to cover the fallocated data and its i_size. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/file.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 9c49c59..623df73 100644 --- a/fs/f2fs

[f2fs-dev] [PATCH 1/3] f2fs: fix to report newly allocate region as extent

2014-06-13 Thread Jaegeuk Kim
Previous get_block in f2fs didn't report the newly allocated region which has NEW_ADDR. For reader, it should not report, but fiemap needs this. So, this patch introduces two get_block sharing core function. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 23

Re: [f2fs-dev] SELinux context not working

2014-06-19 Thread Jaegeuk Kim
___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- Jaegeuk Kim -- HPCC Systems Open Source Big Data Platform from LexisNexis

Re: [f2fs-dev] SELinux context not working

2014-06-19 Thread Jaegeuk Kim
On 19/06/14 21:27, Jaegeuk Kim wrote: Hi, On Thu, Jun 19, 2014 at 08:32:43PM +1000, Brian Chadwick wrote: Hi I cant get file contexts to work with F2FS. I have tried a variety of kernels up to the latest 3.16rc1 with the Security Labels option selected in the config. I am using the latest

Re: [f2fs-dev] SELinux context not working

2014-06-19 Thread Jaegeuk Kim
Hi, On Fri, Jun 20, 2014 at 11:00:10AM +1000, Brian Chadwick wrote: On 20/06/14 01:33, Jaegeuk Kim wrote: Hi, On Thu, Jun 19, 2014 at 10:14:22PM +1000, Brian Chadwick wrote: Hi again I tried mounting with seclabel specifically stated, i.e.: mount -t f2fs -o rw,relatime,background_gc

Re: [f2fs-dev] SELinux context not working

2014-06-20 Thread Jaegeuk Kim
On Fri, Jun 20, 2014 at 03:15:49PM +1000, Brian Chadwick wrote: On 20/06/14 15:00, Jaegeuk Kim wrote: Hi, On Fri, Jun 20, 2014 at 11:00:10AM +1000, Brian Chadwick wrote: On 20/06/14 01:33, Jaegeuk Kim wrote: Hi, On Thu, Jun 19, 2014 at 10:14:22PM +1000, Brian Chadwick wrote: Hi again

Re: [f2fs-dev] SELinux context not working

2014-06-22 Thread Jaegeuk Kim
Hi, On Fri, Jun 20, 2014 at 10:50:27PM +1000, Brian Chadwick wrote: On 20/06/14 16:21, Jaegeuk Kim wrote: On Fri, Jun 20, 2014 at 03:15:49PM +1000, Brian Chadwick wrote: On 20/06/14 15:00, Jaegeuk Kim wrote: Hi, On Fri, Jun 20, 2014 at 11:00:10AM +1000, Brian Chadwick wrote: On 20/06/14

[f2fs-dev] [PATCH 1/2] f2fs: introduce f2fs_do_tmpfile for code consistency

2014-06-22 Thread Jaegeuk Kim
This patch adds f2fs_do_tmpfile to eliminate the redundant init_inode_metadata flow. Throught this, we can provide the consistent lock usage, e.g., fi-i_sem, and this will enable better debugging stuffs. Cc: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs

[f2fs-dev] [PATCH 2/2] f2fs: clean up an unused parameter and assignment

2014-06-22 Thread Jaegeuk Kim
This patch cleans up simple unnecessary codes. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/dir.c | 2 +- fs/f2fs/f2fs.h | 2 +- fs/f2fs/namei.c | 26 +- fs/f2fs/node.c | 2 +- 4 files changed, 12 insertions(+), 20 deletions(-) diff --git a/fs/f2fs

Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: introduce f2fs_do_tmpfile for code consistency

2014-06-23 Thread Jaegeuk Kim
Change log from v1: o avoid mark_inode_dirty(dir), suggested by Chao Yu From f28528b0d835d7f2168e9a729016f68350be0308 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaeg...@kernel.org Date: Fri, 20 Jun 2014 21:37:02 -0700 Subject: [PATCH v2] f2fs: introduce f2fs_do_tmpfile for code consistency

<    1   2   3   4   5   6   7   8   9   10   >