Re: [f2fs-dev] [PATCH v9 16/25] fs: Convert mpage_readpages to mpage_readahead

2020-03-20 Thread Namjae Jeon
> diff --git a/drivers/staging/exfat/exfat_super.c > b/drivers/staging/exfat/exfat_super.c > index b81d2a87b82e..96aad9b16d31 100644 > --- a/drivers/staging/exfat/exfat_super.c > +++ b/drivers/staging/exfat/exfat_super.c Maybe, You should change fs/exfat instead of staging/exfat that is gone from -

Re: [f2fs-dev] [PATCH -next] f2fs: fix error return code in init_f2fs_fs()

2013-08-23 Thread Namjae Jeon
rolling the gc_thread) > > Signed-off-by: Wei Yongjun Acked-by: Namjae Jeon -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights,

Re: [f2fs-dev] [PATCH] f2fs: fix a build failure due to missing the kobject header

2013-08-08 Thread Namjae Jeon
; struct kobject s_kobj; > > The failure was caused by missing the kobject header file in dir.c. > So, this patch move the header file to the right location, f2fs.h. > > CC: Namjae Jeon > Signe

Re: [f2fs-dev] [PATCH 1/3] f2fs: add sysfs support for controlling the gc_thread

2013-08-06 Thread Namjae Jeon
Agree. Sorry to bother. > > If you agree to them, I'll merge the final patch into the tree. > Thanks, Thank you! :) > > 2013-08-04 (일), 23:09 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> Add sysfs entries to control the timing parameters for >> f2fs g

[f2fs-dev] [PATCH 3/3] f2fs: remove redundant code from f2fs_write_begin

2013-08-04 Thread Namjae Jeon
From: Namjae Jeon This code is being used for nobh_write_end() function. But since now f2fs_write_end function is added so there is no need for this code. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/data.c |3 --- 1 file changed, 3 deletions(-) diff --git a/fs

[f2fs-dev] [PATCH 1/3] f2fs: add sysfs support for controlling the gc_thread

2013-08-04 Thread Namjae Jeon
From: Namjae Jeon Add sysfs entries to control the timing parameters for f2fs gc thread. Various Sysfs options introduced are: gc_min_sleep_time: Min Sleep time for GC in ms gc_max_sleep_time: Max Sleep time for GC in ms gc_no_gc_sleep_time: Default Sleep time for GC in ms Cc: Gu Zheng Signed

[f2fs-dev] [PATCH 2/3] f2fs: add sysfs entries to select the gc policy

2013-08-04 Thread Namjae Jeon
From: Namjae Jeon Add sysfs entry gc_idle to control the gc policy. Where gc_idle = 1 corresponds to selecting a cost benefit approach, while gc_idle = 2 corresponds to selecting a greedy approach to garbage collection. The selection is mutually exclusive one approach will work at any point. If

Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs entries to select the gc policy

2013-08-01 Thread Namjae Jeon
2013/8/1, Gu Zheng : > Hi Jeon, > > On 07/31/2013 10:33 PM, Namjae Jeon wrote: > >> From: Namjae Jeon >> >> Add sysfs entries namely gc_long_idle and gc_short_idle to control the >> gc policy. Where long idle corresponds to selecting a cost benefit >> ap

Re: [f2fs-dev] [PATCH 1/2] f2fs: add sysfs support for controlling the gc_thread

2013-08-01 Thread Namjae Jeon
>> >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >> index 78777cd..63813be 100644 >> --- a/fs/f2fs/f2fs.h >> +++ b/fs/f2fs/f2fs.h >> @@ -430,6 +430,10 @@ struct f2fs_sb_info { >> #endif >> unsigned int last_victim[2];/* last victim segment # */ >> spinlock_t stat_lock;

[f2fs-dev] [PATCH 2/2] f2fs: add sysfs entries to select the gc policy

2013-07-31 Thread Namjae Jeon
From: Namjae Jeon Add sysfs entries namely gc_long_idle and gc_short_idle to control the gc policy. Where long idle corresponds to selecting a cost benefit approach, while short idle corresponds to selecting a greedy approach to garbage collection. The selection is mutually exclusive one

[f2fs-dev] [PATCH 1/2] f2fs: add sysfs support for controlling the gc_thread

2013-07-31 Thread Namjae Jeon
From: Namjae Jeon Add sysfs entries to control the timing parameters for f2fs gc thread. Various Sysfs options introduced are: gc_min_sleep_time: Min Sleep time for GC in ms gc_max_sleep_time: Max Sleep time for GC in ms gc_no_gc_sleep_time: Default Sleep time for GC in ms Signed-off-by

Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-06-26 Thread Namjae Jeon
2013/6/27, Jaegeuk Kim : > Hi, > > 2013-06-26 (수), 14:10 +0900, Namjae Jeon: >> 2013/6/25, Jaegeuk Kim : >> >> > - any priority scheme for cleaning? >> >> Could you plz tell me a little more detail ? >> > >> > I meant, as well

Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-06-25 Thread Namjae Jeon
2013/6/25, Jaegeuk Kim : > Hi Namjae, > > Sorry for the late reply. > > 2013-05-29 (수), 09:01 +0900, Namjae Jeon: >> >> I have thought more after getting your reply. >> >> f2fs_cleaner(a tentative name) is that provide the following several >> &g

Re: [f2fs-dev] [PATCH 1/4] f2fs: reorganize the f2fs_setattr() function.

2013-06-21 Thread Namjae Jeon
mutex_lock_op(sbi)) Thanks. > >> >> > >> > >> > Subject: [PATCH v2] f2fs: reorganize the f2fs_setat

[f2fs-dev] [PATCH 2/2] f2fs: optimise the init_dirty_segmap function

2013-06-15 Thread Namjae Jeon
From: Namjae Jeon Optimise the while loop condition Since this condition will always be true and while loop will be terminated by the following condition in code: if (segno >= TOTAL_SEGS(sbi)) break; Hence we can replace the while loop condition with while(1) instead of always checking

[f2fs-dev] [PATCH 1/2] f2fs: add remount_fs callback support

2013-06-15 Thread Namjae Jeon
From: Namjae Jeon Add the f2fs_remount function call which will be used during the filesystem remounting. This function will help us to change the mount options specific to f2fs. Also modify the f2fs background_gc mount option, which will allow the user to dynamically trun on/off the garbage

Re: [f2fs-dev] [PATCH 1/4] f2fs: reorganize the f2fs_setattr() function.

2013-06-13 Thread Namjae Jeon
2013/6/11, Namjae Jeon : > 2013/6/11, Changman Lee : >> On 화, 2013-06-11 at 07:57 +0900, Namjae Jeon wrote: >>> 2013/6/10, Changman Lee : >>> > Hello, Namjae >>> Hi. Changman. >>> > >>> > If using ACL, whenever i_mode is changed we sho

Re: [f2fs-dev] [PATCH 1/4] f2fs: reorganize the f2fs_setattr() function.

2013-06-11 Thread Namjae Jeon
2013/6/11, Changman Lee : > On 화, 2013-06-11 at 07:57 +0900, Namjae Jeon wrote: >> 2013/6/10, Changman Lee : >> > Hello, Namjae >> Hi. Changman. >> > >> > If using ACL, whenever i_mode is changed we should update acl_mode >> > which >> >

Re: [f2fs-dev] [PATCH 1/4] f2fs: reorganize the f2fs_setattr() function.

2013-06-10 Thread Namjae Jeon
inode->i_mode = fi->i_acl_mode; > + if (err || is_inode_flag_set(fi, FI_ACL_MODE)) > clear_inode_flag(fi, FI_ACL_MODE); > - } > } > > Thanks. > > > On 토, 2013-06-08 at 21:25 +0900, Namjae Jeon wrote: >> From: Namjae Jeo

[f2fs-dev] [PATCH 2/4] f2fs: reorganise the function get_victim_by_default

2013-06-08 Thread Namjae Jeon
From: Namjae Jeon Fix the function get_victim_by_default, where it checks for the condition that p.min_segno != NULL_SEGNO as shown: if (p.min_segno != NULL_SEGNO) goto got_it; and if above condition is true then got_it: if (p.min_segno != NULL_SEGNO) { So this condition

[f2fs-dev] [PATCH 4/4] f2fs: optimise the truncate_data_blocks_range() range.

2013-06-08 Thread Namjae Jeon
From: Namjae Jeon The function truncate_data_blocks_range() decrements the valid block count of inode via dec_valid_block_count(). Since this function updates the i_blocks field of inode, we can update this field once we have calculated total the number of blocks to be freed. Therefore we can

[f2fs-dev] [PATCH 3/4] f2fs: use the F2FS sepcifice flags in f2fs_ioctl()

2013-06-08 Thread Namjae Jeon
From: Namjae Jeon In f2fs_ioctl() function, it is using generic flags. Since F2FS specific flags are defined. So lets use those flags. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/file.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/f2fs

[f2fs-dev] [PATCH 1/4] f2fs: reorganize the f2fs_setattr() function.

2013-06-08 Thread Namjae Jeon
From: Namjae Jeon Remove the redundant code from this function and make it aligned with usages of latest generic vfs layer function e.g using the setattr_copy() instead of using the f2fs specific function. Also correct the condition for updating the size of file via truncate_setsize(). Signed

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: support xattr security labels

2013-06-07 Thread Namjae Jeon
2013/6/7, Jaegeuk Kim : > Change log from v1: > o fix a bug > > From 901aea226653e26aa3556edd88ca1e48fa89eb5f Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Mon, 3 Jun 2013 19:46:19 +0900 > Subject: [PATCH 2/2] f2fs: support xattr security labels > Cc: linux-fsde...@vger.kernel.org, linux-k

Re: [f2fs-dev] [PATCH 1/2] f2fs: add remount_fs callback support

2013-06-06 Thread Namjae Jeon
[snip] >> >>> + + /** + * We stop the GC thread if FS is mounted as RO + * or if background_gc = 0 is passed in mount + * option. Also sync the filesystem. + */ + if ((*flags & MS_RDONLY) || !test_opt(sbi, BG_GC)) { >>> >>> >>> Another

Re: [f2fs-dev] [PATCH 1/2] f2fs: add remount_fs callback support

2013-06-04 Thread Namjae Jeon
2013/6/4 Gu Zheng : > On 06/01/2013 03:20 PM, Namjae Jeon wrote: > >> From: Namjae Jeon >> >> Add the f2fs_remount function call which will be used >> during the filesystem remounting. This function >> will help us to change the mount options specific to

Re: [f2fs-dev] [RFC 0/5] Enable f2fs support inline data

2013-06-03 Thread Namjae Jeon
Hi. Huajun. I agree jaegeuk's opinion. Additionally, It is better that you describe the effect in change-log when this feature is added to f2fs. e.g. 1. how much space is saved when storing kernel-tree(small files) ? 2. small files creation performance test. 3. file look-up performance

[f2fs-dev] [PATCH 1/2] f2fs: add remount_fs callback support

2013-06-01 Thread Namjae Jeon
From: Namjae Jeon Add the f2fs_remount function call which will be used during the filesystem remounting. This function will help us to change the mount options specific to f2fs. Also modify the f2fs background_gc mount option, which will allow the user to dynamically trun on/off the garbage

[f2fs-dev] [PATCH 2/2] f2fs: reorganise the function get_victim_by_default

2013-06-01 Thread Namjae Jeon
From: Namjae Jeon Fix the function get_victim_by_default, where it checks for the condition that p.min_segno != NULL_SEGNO as shown: if (p.min_segno != NULL_SEGNO) goto got_it; and if above condition is true then got_it: if (p.min_segno != NULL_SEGNO) { So this condition

Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-28 Thread Namjae Jeon
2013/5/28, Jaegeuk Kim : > Hi, > > 2013-05-27 (월), 13:45 +0900, Namjae Jeon: >> 2013/5/27, Jaegeuk Kim : >> > Hi Namjae, >> Hi Jaegeuk. >> >> First, Thanks for your interest. >> > >> > This is an interesting functionality. >> > C

Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-26 Thread Namjae Jeon
2013/5/27, Jaegeuk Kim : > Hi Namjae, Hi Jaegeuk. First, Thanks for your interest. > > This is an interesting functionality. > Could you describe why and when we need to do this? > What are pros and cons? > How can we use this? As the default size of the F2FS parameter can vary as per the storage

[f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-25 Thread Namjae Jeon
From: Namjae Jeon Add sysfs entries to control the timing parameters for f2fs gc thread and also provide a control flag, which will allow the user to forcefully start a FG garbage collection if required. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/f2fs.h |6

[f2fs-dev] [PATCH v2 1/2] f2fs: return proper error from start_gc_thread

2013-05-25 Thread Namjae Jeon
From: Namjae Jeon when there is an error from kthread_run, then return proper error rather than returning -ENOMEM. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/gc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/gc.c b/fs

Re: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread

2013-05-23 Thread Namjae Jeon
2013/5/23, Jason Hrycay : > On 5/23/2013 8:58 AM, Namjae Jeon wrote: >> From: Namjae Jeon >> >> when there is an error from kthread_run, then return proper error >> rather than returning -ENOMEM. >> >> Signed-off-by: Namjae Jeon >> Signed-off-by:

[f2fs-dev] [PATCH 4/4] f2fs: optimize several routines in node.h

2013-05-23 Thread Namjae Jeon
From: Namjae Jeon There are various functions with common code which could be separated out to make common routines. So, made new routines and in order to retain the same call path and no major changes, written some macros to access those routines. Signed-off-by: Namjae Jeon Signed-off-by

[f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread

2013-05-23 Thread Namjae Jeon
From: Namjae Jeon when there is an error from kthread_run, then return proper error rather than returning -ENOMEM. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/gc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index

[f2fs-dev] [PATCH 2/4] f2fs: remove unneeded initializations in f2fs_parent_dir

2013-05-23 Thread Namjae Jeon
From: Namjae Jeon There is no need to initialize few pointers in f2fs_parent_dir as the values are not checked and instead directly initialized values are used. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/dir.c |6 +++--- 1 file changed, 3 insertions(+), 3

[f2fs-dev] [PATCH 1/4] f2fs: push some variables to debug part

2013-05-23 Thread Namjae Jeon
From: Namjae Jeon Some, counters are needed only for the statistical information while debugging. So, those can be controlled using CONFIG_F2FS_STAT_FS, pushing the usage for few variables under this flag. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/checkpoint.c