Re: [f2fs-dev] [PATCH] f2fs: set zstd compress level correctly

2022-11-23 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 17, 2022, at 7:10 AM, Sheng Yong wrote: > > > > Fixes: cf30f6a5f0c6 ("lib: zstd: Add kernel-specific API") > Signed-off-by: Sheng Yong > --- > fs/f2fs/compress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c > index

Re: [f2fs-dev] [syzbot] INFO: trying to register non-static key in f2fs_handle_error

2022-11-11 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 7, 2022, at 4:15 PM, syzbot > wrote: > > !---| > This Message Is From an External Sender > > |---! > > syzbot has found a reproducer for the following

Re: [f2fs-dev] [GIT PULL] zstd changes for v5.16

2022-03-01 Thread Nick Terrell via Linux-f2fs-devel
> On Feb 20, 2022, at 1:45 AM, Sedat Dilek wrote: > > On Tue, Nov 9, 2021 at 2:24 AM Nick Terrell wrote: >> >> From: Nick Terrell >> >> Hi Linus, >> >> I am sending you a pull request to add myself as the maintainer of zstd and >> update the zstd version in the kernel, which is now 4

Re: [f2fs-dev] [GIT PULL] zstd changes for v5.16

2021-11-11 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 11, 2021, at 2:59 PM, Linus Torvalds > wrote: > > On Wed, Nov 10, 2021 at 10:47 AM Nick Terrell wrote: >> >> I just wanted to make sure that you’ve received my pull request. I’m a newbie >> here, so I want to make sure I’m not making a stupid mistake that means >> you’ve >> missed

Re: [f2fs-dev] [GIT PULL] zstd changes for v5.16

2021-11-11 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 8, 2021, at 5:30 PM, Nick Terrell wrote: > > From: Nick Terrell > > Hi Linus, > > I am sending you a pull request to add myself as the maintainer of zstd and > update the zstd version in the kernel, which is now 4 years out of date, > to the latest zstd release. This includes bug

Re: [f2fs-dev] [GIT PULL] zstd changes for v5.16

2021-11-10 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 8, 2021, at 5:30 PM, Nick Terrell wrote: > > From: Nick Terrell > > Hi Linus, > > I am sending you a pull request to add myself as the maintainer of zstd and > update the zstd version in the kernel, which is now 4 years out of date, > to the latest zstd release. This includes bug

Re: [f2fs-dev] [GIT PULL] zstd changes for linux-next

2021-10-06 Thread Nick Terrell via Linux-f2fs-devel
> On Oct 6, 2021, at 2:39 PM, Sedat Dilek wrote: > > On Wed, Oct 6, 2021 at 9:21 PM Nick Terrell wrote: >> >> From: Nick Terrell >> >> The following changes since commit 9e1ff307c779ce1f0f810c7ecce3d95bbae40896: >> >> Linux 5.15-rc4 (2021-10-03 14:08:47 -0700) >> >> are available in the

Re: [f2fs-dev] [GIT PULL] zstd changes for linux-next

2021-10-06 Thread Nick Terrell via Linux-f2fs-devel
> On Oct 6, 2021, at 2:57 PM, Stephen Rothwell wrote: > > Hi Nick, > > On Wed, 6 Oct 2021 12:17:24 -0700 Nick Terrell > wrote: >> >> From: Nick Terrell >> >> The following changes since commit 9e1ff307c779ce1f0f810c7ecce3d95bbae40896: >> >> Linux 5.15-rc4 (2021-10-03 14:08:47 -0700)

Re: [f2fs-dev] [GIT PULL][v12] zstd changes for linux-next

2021-10-04 Thread Nick Terrell via Linux-f2fs-devel
> On Oct 4, 2021, at 7:26 PM, Stephen Rothwell wrote: > > Hi Nick, > > On Mon, 4 Oct 2021 18:41:18 -0700 Nick Terrell > wrote: >> >> From: Nick Terrell >> >> The following changes since commit a25006a77348ba06c7bc96520d331cd9dd370715: >> >> Add linux-next specific files for 20211001

Re: [f2fs-dev] [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10

2021-05-11 Thread Nick Terrell via Linux-f2fs-devel
> On Apr 29, 2021, at 6:31 PM, Nick Terrell wrote: > > From: Nick Terrell > > Please pull from > > g...@github.com:terrelln/linux.git tags/v11-zstd-1.4.10 > > to get these changes. Alternatively the patchset is included. Hi all, Pinging this series. Is there anything I should do to

Re: [f2fs-dev] [GIT PULL][PATCH v10 0/4] Update to zstd-1.4.10

2021-04-27 Thread Nick Terrell via Linux-f2fs-devel
> On Apr 27, 2021, at 3:09 PM, Randy Dunlap wrote: > > On 4/26/21 4:46 PM, Nick Terrell wrote: >> From: Nick Terrell >> >> Please pull from >> >> g...@github.com:terrelln/linux.git tags/v10-zstd-1.4.10 >> >> to get these changes. Alternatively the patchset is included. >> >> This

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-18 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 16, 2020, at 5:23 PM, Michał Mirosław wrote: > > On Wed, Dec 16, 2020 at 10:07:38PM +, Nick Terrell wrote: > [...] >> It is very large. If it helps, in the commit message I’ve provided this link >> [0], >> which provides the diff between upstream zstd as-is and the imported zstd,

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-16 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 16, 2020, at 10:50 AM, David Sterba wrote: > > On Wed, Dec 16, 2020 at 11:58:07AM +1100, Herbert Xu wrote: >> On Wed, Dec 16, 2020 at 12:48:51AM +, Nick Terrell wrote: >>> >>> Thanks for the advice! The first zstd patches went through Herbert’s tree, >>> which is >>> why I’ve

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-15 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 15, 2020, at 4:58 PM, Herbert Xu wrote: > > On Wed, Dec 16, 2020 at 12:48:51AM +, Nick Terrell wrote: >> >> Thanks for the advice! The first zstd patches went through Herbert’s tree, >> which is >> why I’ve sent them this way. > > Sorry, but I'm not touch these patches as

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-15 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 15, 2020, at 4:00 PM, Eric Biggers wrote: > > On Tue, Dec 15, 2020 at 08:58:52PM +0000, Nick Terrell via Linux-f2fs-devel > wrote: >> >> >>> On Dec 3, 2020, at 12:51 PM, Nick Terrell wrote: >>> >>> From: Nick Terrell >>

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-15 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 3, 2020, at 12:51 PM, Nick Terrell wrote: > > From: Nick Terrell > > Please pull from > > g...@github.com:terrelln/linux.git tags/v7-zstd-1.4.6 > > to get these changes. Alternatively the patchset is included. Is it possible to get this patchset merged in the 5.11 merge window?

Re: [f2fs-dev] [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-03 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 2, 2020, at 9:03 PM, Michał Mirosław wrote: > > On Thu, Dec 03, 2020 at 03:59:21AM +, Nick Terrell wrote: >> On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote: >>> On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: On Dec 2, 2020, at 5:16 PM, Michał Mirosław

Re: [f2fs-dev] [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 2, 2020, at 9:03 PM, Michał Mirosław wrote: > > On Thu, Dec 03, 2020 at 03:59:21AM +, Nick Terrell wrote: >> On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote: >>> On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: On Dec 2, 2020, at 5:16 PM, Michał Mirosław

Re: [f2fs-dev] [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote: > > On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: >> >> >>> On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote: >>> >>> On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: From: Nick Terrell This

Re: [f2fs-dev] [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Nick Terrell via Linux-f2fs-devel
> On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote: > > On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: >> From: Nick Terrell >> >> This patch: >> - Moves `include/linux/zstd.h` -> `lib/zstd/zstd.h` >> - Adds a new API in `include/linux/zstd.h` that is functionally >>

Re: [f2fs-dev] [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-10 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 10, 2020, at 10:39 AM, Christoph Hellwig wrote: > > On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote: >> You do consistently ask for a shim layer, but you haven???t explained what >> we gain by diverging from the documented and tested API of the upstream zstd >> project.

Re: [f2fs-dev] [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-10 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 10, 2020, at 7:25 AM, David Sterba wrote: > > On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote: >> On 6 Nov 2020, at 13:38, Christoph Hellwig wrote: >>> You just keep resedning this crap, don't you? Haven't you been told >>> multiple times to provide a proper kernel API by

Re: [f2fs-dev] [GIT PULL][PATCH v5 0/9] Update to zstd-1.4.6

2020-11-06 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 6, 2020, at 9:15 AM, Josef Bacik wrote: > > On 11/3/20 1:05 AM, Nick Terrell wrote: >> From: Nick Terrell >> Please pull from >> g...@github.com:terrelln/linux.git tags/v5-zstd-1.4.6 >> to get these changes. Alternatively the patchset is included. > > Where did we come down on the

Re: [f2fs-dev] [PATCH v5 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-11-06 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 6, 2020, at 9:10 AM, Josef Bacik wrote: > > On 11/3/20 1:05 AM, Nick Terrell wrote: >> From: Nick Terrell >> Move away from the compatibility wrapper to the zstd-1.4.6 API. This >> code is functionally equivalent. >> Signed-off-by: Nick Terrell >> --- >> fs/btrfs/zstd.c | 48

Re: [f2fs-dev] [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6

2020-10-01 Thread Nick Terrell via Linux-f2fs-devel
> On Oct 1, 2020, at 3:18 AM, David Sterba wrote: > > On Wed, Sep 30, 2020 at 08:49:49PM +, Nick Terrell wrote: >>> On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote: >>> >>> From: Nick Terrell >> >> It has been brought to my attention that patch 3 hasn’t made it to patchwork, >> likely

Re: [f2fs-dev] [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6

2020-09-30 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote: > > From: Nick Terrell It has been brought to my attention that patch 3 hasn’t made it to patchwork, likely because it is too large. I’ll include a pull request in the next cover letter, together with the patches (if needed). Please pull

Re: [f2fs-dev] [PATCH v4 0/9] Update to zstd-1.4.6

2020-09-30 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 29, 2020, at 11:53 PM, Christoph Hellwig wrote: > > As you keep resend this I keep retelling you that should not do it. > Please provide a proper Linux API, and switch to that. Versioned APIs > have absolutely no business in the Linux kernel. The API is not versioned. We provide a

Re: [f2fs-dev] [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 17, 2020, at 6:47 PM, Chao Yu wrote: > > On 2020/9/18 3:34, Nick Terrell wrote: >>> On Sep 17, 2020, at 11:00 AM, Nick Terrell wrote: >>> >>> >>> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, On 2020/9/17 2:39, Nick Terrell wrote: >> On Sep

Re: [f2fs-dev] [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 17, 2020, at 11:00 AM, Nick Terrell wrote: > > > >> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote: >> >> Hi Nick, >> >> On 2020/9/17 2:39, Nick Terrell wrote: On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: Hi Nick, remove not related mailing list.

Re: [f2fs-dev] [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 16, 2020, at 11:31 PM, Chao Yu wrote: > > Hi Nick, > > On 2020/9/17 2:39, Nick Terrell wrote: >>> On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: >>> >>> Hi Nick, >>> >>> remove not related mailing list. >>> >>> On 2020/9/16 11:43, Nick Terrell wrote: From: Nick Terrell

Re: [f2fs-dev] [PATCH 1/9] lib: zstd: Add zstd compatibility wrapper

2020-09-17 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 16, 2020, at 1:48 AM, Christoph Hellwig wrote: > > On Tue, Sep 15, 2020 at 08:42:54PM -0700, Nick Terrell wrote: >> From: Nick Terrell >> >> Adds zstd_compat.h which provides the necessary functions from the >> current zstd.h API. It is only active for zstd versions 1.4.6 and newer.

Re: [f2fs-dev] [PATCH 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 16, 2020, at 7:46 AM, Christoph Hellwig wrote: > > On Wed, Sep 16, 2020 at 10:43:04AM -0400, Chris Mason wrote: >> Otherwise we just end up with drift and kernel-specific bugs that are harder >> to debug. To the extent those APIs make us contort the kernel code, I???m >> sure Nick is

Re: [f2fs-dev] [PATCH 3/9] lib: zstd: Upgrade to latest upstream zstd version 1.4.6

2020-09-16 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 15, 2020, at 8:42 PM, Nick Terrell wrote: > > From: Nick Terrell > > Upgrade to the latest upstream zstd version 1.4.6. > > This patch is 100% generated from upstream zstd commit c4763f087c2b [0]. > > This patch is very large because it is transitioning from the custom > kernel zstd

Re: [f2fs-dev] [PATCH 6/9] f2fs: zstd: Switch to the zstd-1.4.6 API

2020-09-16 Thread Nick Terrell via Linux-f2fs-devel
> On Sep 15, 2020, at 11:31 PM, Chao Yu wrote: > > Hi Nick, > > remove not related mailing list. > > On 2020/9/16 11:43, Nick Terrell wrote: >> From: Nick Terrell >> Move away from the compatibility wrapper to the zstd-1.4.6 API. This >> code is more efficient because it uses the