LGTM
On Mon, Dec 4, 2023 at 10:06 AM Jaegeuk Kim wrote:
>
> If fsck can allocate a new zone, it'd be better to use that instead of
> allocating a new one.
>
> And, it modifies kernel messages.
>
> Signed-off-by: Jaegeuk Kim
> ---
> fs/f2fs/segment.c | 33 +
> 1
From: Daeho Jeong
Do not finishing zones for current zones.
Signed-off-by: Daeho Jeong
Fixes: 06a25b021d15 ("f2fs-tools: make six open zone check resilient")
---
fsck/fsck.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/fsck/fsck.c b/fsck/fsck.c
index
LGTM
On Mon, Dec 4, 2023 at 10:06 AM Jaegeuk Kim wrote:
>
> 1. do roll forward recovery
> 2. update current segments pointers
> 3. fix the entire zones' write pointers
> 4. do checkpoint
>
> Signed-off-by: Jaegeuk Kim
> ---
> fs/f2fs/recovery.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>
LGTM
On Mon, Dec 4, 2023 at 10:07 AM Jaegeuk Kim wrote:
>
> In order to limit # of open zones, let's finish or reset zones given # of
> valid blocks per section and its zone condition.
>
> Signed-off-by: Jaegeuk Kim
> ---
> fs/f2fs/segment.c | 74 +++
LGTM
On Mon, Dec 4, 2023 at 10:07 AM Jaegeuk Kim wrote:
>
> Let's fix any inconsistency until checkpint being enabled back.
>
> Signed-off-by: Jaegeuk Kim
> ---
> fsck/mount.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fsck/mount.c b/fsck/mount.c
> index
LGTM
On Mon, Dec 4, 2023 at 10:06 AM Jaegeuk Kim wrote:
>
> Even if f2fs was rebooted as staying checkpoint=disable, let's match the write
> pointers all the time.
>
> Signed-off-by: Jaegeuk Kim
> ---
> fs/f2fs/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
Blocks are tracked by u32, so the max permitted filesize is
U32_MAX * BLOCK_SIZE. Additionally, in order to support crypto data unit
sizes of 4K with a 16K block size with IV_INO_LBLK_{32,63}, we must
further restrict max filesize to U32_MAX * 4096. This does not affect 4K
blocksize f2fs as the
Thanks. Let me add reviewed-by. :)
On 12/04, Daeho Jeong wrote:
> LGTM
>
> On Mon, Dec 4, 2023 at 10:07 AM Jaegeuk Kim wrote:
> >
> > Let's fix any inconsistency until checkpint being enabled back.
> >
> > Signed-off-by: Jaegeuk Kim
> > ---
> > fsck/mount.c | 1 +
> > 1 file changed, 1
On Mon, Dec 04, 2023 at 03:46:15PM -0800, Daniel Rosenberg via Linux-f2fs-devel
wrote:
> Blocks are tracked by u32, so the max permitted filesize is
> U32_MAX * BLOCK_SIZE. Additionally, in order to support crypto data unit
> sizes of 4K with a 16K block size with IV_INO_LBLK_{32,63}, we must
If fsck can allocate a new zone, it'd be better to use that instead of
allocating a new one.
And, it modifies kernel messages.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/segment.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git
In order to limit # of open zones, let's finish or reset zones given # of
valid blocks per section and its zone condition.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/segment.c | 74 +++
1 file changed, 17 insertions(+), 57 deletions(-)
diff --git
Let's fix any inconsistency until checkpint being enabled back.
Signed-off-by: Jaegeuk Kim
---
fsck/mount.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fsck/mount.c b/fsck/mount.c
index e957904494ef..30c62280b281 100644
--- a/fsck/mount.c
+++ b/fsck/mount.c
@@ -1435,6 +1435,7 @@ static
Even if f2fs was rebooted as staying checkpoint=disable, let's match the write
pointers all the time.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 617340e9ea7f..9a874b4d1501 100644
1. do roll forward recovery
2. update current segments pointers
3. fix the entire zones' write pointers
4. do checkpoint
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/recovery.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index
Hello,
On Mon, Dec 04, 2023 at 04:03:47PM +, Naohiro Aota wrote:
> Recently, commit 636b927eba5b ("workqueue: Make unbound workqueues to use
> per-cpu pool_workqueues") changed WQ_UNBOUND workqueue's behavior. It
> changed the meaning of alloc_workqueue()'s max_active from an upper limit
>
Blocks are tracked by u32, so the max permitted filesize is
(U32_MAX + 1) * BLOCK_SIZE. Additionally, in order to support crypto
data unit sizes of 4K with a 16K block with IV_INO_LBLK_{32,64}, we must
further restrict max filesize to (U32_MAX + 1) * 4096. This does not
affect 4K blocksize f2fs as
Hi Juhyung,
On 2023/12/4 11:41, Juhyung Park wrote:
...
- Could you share the full message about the output of `lscpu`?
Sure:
Architecture:x86_64
CPU op-mode(s):32-bit, 64-bit
Address sizes: 39 bits physical, 48 bits virtual
Byte Order:
Recently, commit 636b927eba5b ("workqueue: Make unbound workqueues to use
per-cpu pool_workqueues") changed WQ_UNBOUND workqueue's behavior. It
changed the meaning of alloc_workqueue()'s max_active from an upper limit
imposed per NUMA node to a limit per CPU. As a result, massive number of
workers
18 matches
Mail list logo
