Re: [f2fs-dev] [PATCH] f2fs: add default mount options to remount

On 2015/5/7 17:20, Yunlei He wrote: I use f2fs filesystem with /data partition on my Android phone by the default mount options. When I remount /data in order to adding discard option to run some benchmarks, I find the default options such as background_gc, user_xattr and acl turned off. So

[f2fs-dev] Not use inline_data after file shrink

Hi Jaegeuk, I found that when files(size MAX_INLINE_DATA) shrink(size MAX_INLINE_DATA), inline_data option is not used in the file after narrow I mount f2fs with inline_data as follow: /dev/block/mmcblk0p40 /data f2fs rw,nosuid,nodev,noatime,background_gc=on,discard,

[f2fs-dev] Dwrite with non-aligned offset and size

Hi Jaegeuk, We run ltp testcase with f2fs and obtain a TFAIL in diotest4, the result in detail is as fallow: dio04 test_start tag=dio04 stime=1432278894 cmdline=diotest4 contacts= analysis=exit test_output diotest41 TPASS : Negative Offset diotest42 TPASS : removed diotest43

Re: [f2fs-dev] Data lost in Android app for not write new checkpoint

On 2015/7/31 18:49, Chao Yu wrote: Hi Bintian, -Original Message- From: He YunLei [mailto:heyun...@huawei.com] Sent: Friday, July 31, 2015 10:29 AM To: linux-f2fs-devel@lists.sourceforge.net; Jaegeuk Kim Cc: Chao Yu; cm224@samsung.com; Bintian Subject: [f2fs-dev] Data lost

Re: [f2fs-dev] [PATCH] f2fs: initialize both two copies of NAT and SIT area

Hi Jaegeuk On 2015/7/24 2:18, Jaegeuk Kim wrote: Hi Yunlei, On Thu, Jul 23, 2015 at 09:43:04AM +0800, Yunlei He wrote: In the process of formatting, we zero out only one copy of NAT and SIT area, but we use both of them when the filesystem is sucessfully mounted. So I change the code to

Re: [f2fs-dev] Dwrite with non-aligned offset and size

On 2015/7/3 16:02, Chao Yu wrote: Hi Yunlei, Sorry for the long delay. -Original Message- From: He YunLei [mailto:heyun...@huawei.com] Sent: Tuesday, June 02, 2015 12:21 PM To: Jaegeuk Kim Cc: linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Subject: Re

Re: [f2fs-dev] [PATCH] mkfs.f2fs: introduce -b option to support specified fs size formating

hi, We can specify fs size in function f2fs_parse_options as follow: if ((optind + 1) < argc) { /* We have a sector count. */ config.total_sectors = atoll(argv[optind+1]); which one is better? Thanks On 2015/11/10 16:48, Chao Yu wrote: > This patch introduces a new option

Re: [f2fs-dev] [PATCH 2/3] f2fs: add a tracepoint for background gc

On 2015/10/6 6:43, Jaegeuk Kim wrote: > This patch introduces a tracepoint to monitor background gc behaviors. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c| 3 +++ > include/trace/events/f2fs.h | 28 > 2 files changed,

Re: [f2fs-dev] [PATCH] f2fs: add a judgment in add_discard_addrs

On 2015/9/9 9:11, Chao Yu wrote: >> -Original Message- >> From: He YunLei [mailto:heyun...@huawei.com] >> Sent: Wednesday, September 09, 2015 7:54 AM >> To: Chao Yu >> Cc: jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net; >> bintian.w...@

Re: [f2fs-dev] [PATCH] back-up raw_super in sbi

On 2015/12/9 14:11, Chao Yu wrote: > Hi, > >> -Original Message- >> From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >> Sent: Wednesday, December 09, 2015 2:19 AM >> To: Yunlei He >> Cc: linux-f2fs-devel@lists.sourceforge.net; chao2...@samsung.com; >> hebi...@huawei.com; >>

Re: [f2fs-dev] [PATCH] mkfs.f2fs: introduce zone align for main area

On 2016/1/8 7:29, Jaegeuk Kim wrote: > Hi Yunlei, > > Could you rebase the patch based on f2fs-tools.git? > I can't merge this. > > Thanks, Hi Kim, I am sorry that, I have sent a new one. Thanks, > > On Wed, Jan 06, 2016 at 03:54:37PM +0800, Yunlei He wrote: >> This patch calculate main area

Re: [f2fs-dev] [PATCH] f2fs: add a max block count for f2fs_map_blocks

On 2015/12/26 21:21, Chao Yu wrote: > Hi, > > On 12/25/15 6:17 PM, liuxue wrote: >> On 2015/12/25 17:25, Chao Yu wrote: >>> Hi, >>> -Original Message- From: Yunlei He [mailto:heyun...@huawei.com] Sent: Friday, December 25, 2015 4:48 PM To:

Re: [f2fs-dev] [PATCH] f2fs: add a segment and section num check in sanity_check_raw_super

On 2015/12/29 7:10, Jaegeuk Kim wrote: > Hi Yunlei, > > On Sat, Dec 26, 2015 at 10:55:45AM +0800, He YunLei wrote: >> On 2015/12/26 10:46, Yunlei He wrote: >>> This patch add a mismatch check between segment and section in >>> sanity_check_raw_super. >&g

Re: [f2fs-dev] [PATCH 2/2] f2fs: speed up shrinking extent tree entries

On 2015/12/22 13:20, Chao Yu wrote: > Hi Jaegeuk, > > We should update _zombie_tree whenever removing unreferenced > extent tree during shrinking: > - f2fs_shrink_extent_tree > if (!atomic_read(>refcount)) { > ... > atomic_dec(>total_ext_tree); > atomic_dec(>total_zombie_tree); >

Re: [f2fs-dev] [PATCH 1/2] f2fs: use atomic variable for total_extent_tree

On 2015/12/22 11:38, Jaegeuk Kim wrote: > It would be better to use atomic variable for total_extent_tree. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/debug.c| 5 +++-- > fs/f2fs/extent_cache.c | 8 > fs/f2fs/f2fs.h | 2 +- > fs/f2fs/node.c

Re: [f2fs-dev] [PATCH 1/4] f2fs: propagate error given by f2fs_find_entry

On 2016/5/27 8:25, Jaegeuk Kim wrote: > If we get ENOMEM or EIO in f2fs_find_entry, we should stop right away. > Otherwise, for example, we can get duplicate directory entry by ->chash and > ->clevel. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/dir.c| 23

Re: [f2fs-dev] [PATCH] fsck.f2fs: avoid fix ssa in some case

On 2016/1/30 1:12, Jaegeuk Kim wrote: > Hi Yunlei, > > On Thu, Jan 28, 2016 at 04:18:16PM +0800, Yunlei He wrote: >> In some case, we need confirm node or data blkaddr is ok at first, >> and then fix the conflict in ssa block. If the node blkaddr happen to >> locate in data type segment caused by

Re: [f2fs-dev] [PATCH] f2fs: avoid hungtask problem caused by losing wake_up

On 2016/2/24 11:46, Chao Yu wrote: > Hi Yunlei, > >> -Original Message----- >> From: He YunLei [mailto:heyun...@huawei.com] >> Sent: Tuesday, February 23, 2016 7:36 PM >> To: Chao Yu; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >> C

Re: [f2fs-dev] [PATCH] f2fs: avoid hungtask problem caused by losing wake_up

On 2016/2/23 17:32, Shawn Lin wrote: > On 2016/2/23 15:02, He YunLei wrote: >> On 2016/2/23 13:44, Chao Yu wrote: >>> Hi Yunlei, >> Hi Chao, >>> >>>> -Original Message- >>>> From: Yunlei He [mailto:heyun...@huawei.com] >

Re: [f2fs-dev] [PATCH] f2fs: avoid hungtask problem caused by losing wake_up

On 2016/2/23 17:15, Chao Yu wrote: Hi Chao, > Hi Yunlei, > >> -Original Message----- >> From: He YunLei [mailto:heyun...@huawei.com] >> Sent: Tuesday, February 23, 2016 3:03 PM >> To: Chao Yu; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >> C

Re: [f2fs-dev] [PATCH] f2fs: avoid hungtask problem caused by losing wake_up

On 2016/2/24 11:46, Chao Yu wrote: >>> > > >>> > >But I doubt more that the reason we are stuck is there are remained pages >>> > >cached in bio buffer without being submitted. To make sure, maybe in >>> > >wait_on_all_pages_writeback we could add print info to see whether >>> >

Re: [f2fs-dev] [PATCH] f2fs: avoid hungtask problem caused by losing wake_up

On 2016/2/23 13:44, Chao Yu wrote: > Hi Yunlei, Hi Chao, > >> -Original Message- >> From: Yunlei He [mailto:heyun...@huawei.com] >> Sent: Tuesday, February 23, 2016 12:08 PM >> To: chao2...@samsung.com; jaeg...@kernel.org; >> linux-f2fs-devel@lists.sourceforge.net >> Cc:

Re: [f2fs-dev] [PATCH 1/3] resize.f2fs: support to expand partition size

On 2016/4/26 10:17, Jaegeuk Kim wrote: > Hello, > > ... > >>> + /* ovp / free segments */ >>> + set_cp(overprov_segment_count, config.new_overprovision); >>> + set_cp(rsvd_segment_count, config.new_reserved_segments); >> >> maybe something wrong here: >> set_cp(rsvd_segment_count,

Re: [f2fs-dev] [PATCH 1/3] resize.f2fs: support to expand partition size

hi, kim On 2016/4/26 8:28, Jaegeuk Kim wrote: > Now user can expand existing partition with resize.f2fs. > Currently, it doesn't support shrink an image. > > For example, > # resize.f2fs -t [# of sectors] [image] > > Signed-off-by: Jaegeuk Kim > --- > fsck/Makefile.am |