Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-28 Thread Chao Yu 

On 2024/4/28 9:23, Daeho Jeong wrote:

I have a question. Is it okay for META_GENERIC?


It seems all users of META_GENERIC comes from IO paths:
a) f2fs_merge_page_bio
b) f2fs_submit_page_bio
c) f2fs_submit_page_write - verify_fio_blkaddr

They are all impossible cases? so it's fine to record the error
for this case?

Thanks,


___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-27 Thread Daeho Jeong 
On Thu, Apr 25, 2024 at 12:30 AM Chao Yu  wrote:
>
> On 2024/4/19 18:27, Juhyung Park wrote:
> > On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim  wrote:
> >>
> >> On 04/11, Chao Yu wrote:
> >>> On 2024/4/10 4:34, Jaegeuk Kim wrote:
>  f2fs_ra_meta_pages can try to read ahead on invalid block address which 
>  is
>  not the corruption case.
> >>>
> >>> In which case we will read ahead invalid meta pages? recovery w/ META_POR?
> >
> > In my case, it seems like it's META_SIT, and it's triggered right after 
> > mount.
>
> Ah, I see, actually it hits at this case, thanks for the information.
>
> Thanks,
>
> > fsck detects invalid_blkaddr, and when the kernel mounts it, it
> > immediately flags invalid_blkaddr again:
> >
> > [6.333498] init: [libfs_mgr] Running /system/bin/fsck.f2fs -a -c
> > 1 --debug-cache /dev/block/sda13
> > [6.337671] fsck.f2fs: Info: Fix the reported corruption.
> > [6.337947] fsck.f2fs: Info: not exist /proc/version!
> > [6.338010] fsck.f2fs: Info: can't find /sys, assuming normal block 
> > device
> > [6.338294] fsck.f2fs: Info: MKFS version
> > [6.338319] fsck.f2fs:   "5.10.160-android12-9-ge5cfec41c8e2"
> > [6.338366] fsck.f2fs: Info: FSCK version
> > [6.338380] fsck.f2fs:   from "5.10-arter97"
> > [6.338393] fsck.f2fs: to "5.10-arter97"
> > [6.338414] fsck.f2fs: Info: superblock features = 1499 :  encrypt
> > verity extra_attr project_quota quota_ino casefold
> > [6.338429] fsck.f2fs: Info: superblock encrypt level = 0, salt =
> > 
> > [6.338442] fsck.f2fs: Info: checkpoint stop reason: shutdown(180)
> > [6.338455] fsck.f2fs: Info: fs errors: invalid_blkaddr
> > [6.338468] fsck.f2fs: Info: Segments per section = 1
> > [6.338480] fsck.f2fs: Info: Sections per zone = 1
> > [6.338492] fsck.f2fs: Info: total FS sectors = 58971571 (230357 MB)
> > [6.340599] fsck.f2fs: Info: CKPT version = 2b7e3b29
> > [6.340620] fsck.f2fs: Info: version timestamp cur: 19789296, prev: 
> > 18407008
> > [6.677041] fsck.f2fs: Info: checkpoint state = 46 :  crc
> > compacted_summary orphan_inodes sudden-power-off
> > [6.677052] fsck.f2fs: [FSCK] Check node 1 / 712937 (0.00%)
> > [8.997922] fsck.f2fs: [FSCK] Check node 71294 / 712937 (10.00%)
> > [   10.629205] fsck.f2fs: [FSCK] Check node 142587 / 712937 (20.00%)
> > [   12.278186] fsck.f2fs: [FSCK] Check node 213880 / 712937 (30.00%)
> > [   13.768177] fsck.f2fs: [FSCK] Check node 285173 / 712937 (40.00%)
> > [   17.446971] fsck.f2fs: [FSCK] Check node 356466 / 712937 (50.00%)
> > [   19.891623] fsck.f2fs: [FSCK] Check node 427759 / 712937 (60.00%)
> > [   23.251327] fsck.f2fs: [FSCK] Check node 499052 / 712937 (70.00%)
> > [   28.493457] fsck.f2fs: [FSCK] Check node 570345 / 712937 (80.00%)
> > [   29.640800] fsck.f2fs: [FSCK] Check node 641638 / 712937 (90.00%)
> > [   30.718347] fsck.f2fs: [FSCK] Check node 712931 / 712937 (100.00%)
> > [   30.724176] fsck.f2fs:
> > [   30.737160] fsck.f2fs: [FSCK] Max image size: 167506 MB, Free space: 
> > 62850 MB
> > [   30.737164] fsck.f2fs: [FSCK] Unreachable nat entries
> >   [Ok..] [0x0]
> > [   30.737638] fsck.f2fs: [FSCK] SIT valid block bitmap checking
> >   [Ok..]
> > [   30.737640] fsck.f2fs: [FSCK] Hard link checking for regular file
> >   [Ok..] [0xd]
> > [   30.737641] fsck.f2fs: [FSCK] valid_block_count matching with CP
> >   [Ok..] [0x28b98e6]
> > [   30.737644] fsck.f2fs: [FSCK] valid_node_count matching with CP (de
> > lookup)  [Ok..] [0xae0e9]
> > [   30.737646] fsck.f2fs: [FSCK] valid_node_count matching with CP
> > (nat lookup) [Ok..] [0xae0e9]
> > [   30.737647] fsck.f2fs: [FSCK] valid_inode_count matched with CP
> >   [Ok..] [0xa74a3]
> > [   30.737649] fsck.f2fs: [FSCK] free segment_count matched with CP
> >   [Ok..] [0x7aa3]
> > [   30.737662] fsck.f2fs: [FSCK] next block offset is free
> >   [Ok..]
> > [   30.737663] fsck.f2fs: [FSCK] fixing SIT types
> > [   30.737867] fsck.f2fs: [FSCK] other corrupted bugs
> >   [Ok..]
> > [   30.737893] fsck.f2fs: [update_superblock: 765] Info: Done to
> > update superblock
> > [   30.960610] fsck.f2fs:
> > [   30.960618] fsck.f2fs: Done: 24.622956 secs
> > [   30.960620] fsck.f2fs:
> > [   30.960622] fsck.f2fs: c, u, RA, CH, CM, Repl=
> > [   30.960627] fsck.f2fs: 1 1 43600517 42605434 995083 985083
> > [   30.963274] F2FS-fs (sda13): Using encoding defined by superblock:
> > utf8-12.1.0 with flags 0x0
> > [   30.995360] __f2fs_is_valid_blkaddr: type=2
> >
> > (Manually added that print ^)
> >
> > [   30.995369] [ cut here ]
> > [   30.995375] WARNING: CPU: 7 PID: 1 at f2fs_handle_error+0x18/0x3c
> > [   30.995378] CPU: 7 PID: 1 Comm: init Tainted: G S  W
> > 5.10.209-arter97-r15-kernelsu-g0867d0e4f1d2 #6
> > [   30.995379] Hardware name: Qualcomm Technologies, Inc. Cape QRD
> > with PM8010 (DT)
> > [   30.995380] pstate:

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-25 Thread Chao Yu 

On 2024/4/19 18:27, Juhyung Park wrote:

On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim  wrote:


On 04/11, Chao Yu wrote:

On 2024/4/10 4:34, Jaegeuk Kim wrote:

f2fs_ra_meta_pages can try to read ahead on invalid block address which is
not the corruption case.


In which case we will read ahead invalid meta pages? recovery w/ META_POR?


In my case, it seems like it's META_SIT, and it's triggered right after mount.


Ah, I see, actually it hits at this case, thanks for the information.

Thanks,


fsck detects invalid_blkaddr, and when the kernel mounts it, it
immediately flags invalid_blkaddr again:

[6.333498] init: [libfs_mgr] Running /system/bin/fsck.f2fs -a -c
1 --debug-cache /dev/block/sda13
[6.337671] fsck.f2fs: Info: Fix the reported corruption.
[6.337947] fsck.f2fs: Info: not exist /proc/version!
[6.338010] fsck.f2fs: Info: can't find /sys, assuming normal block device
[6.338294] fsck.f2fs: Info: MKFS version
[6.338319] fsck.f2fs:   "5.10.160-android12-9-ge5cfec41c8e2"
[6.338366] fsck.f2fs: Info: FSCK version
[6.338380] fsck.f2fs:   from "5.10-arter97"
[6.338393] fsck.f2fs: to "5.10-arter97"
[6.338414] fsck.f2fs: Info: superblock features = 1499 :  encrypt
verity extra_attr project_quota quota_ino casefold
[6.338429] fsck.f2fs: Info: superblock encrypt level = 0, salt =

[6.338442] fsck.f2fs: Info: checkpoint stop reason: shutdown(180)
[6.338455] fsck.f2fs: Info: fs errors: invalid_blkaddr
[6.338468] fsck.f2fs: Info: Segments per section = 1
[6.338480] fsck.f2fs: Info: Sections per zone = 1
[6.338492] fsck.f2fs: Info: total FS sectors = 58971571 (230357 MB)
[6.340599] fsck.f2fs: Info: CKPT version = 2b7e3b29
[6.340620] fsck.f2fs: Info: version timestamp cur: 19789296, prev: 18407008
[6.677041] fsck.f2fs: Info: checkpoint state = 46 :  crc
compacted_summary orphan_inodes sudden-power-off
[6.677052] fsck.f2fs: [FSCK] Check node 1 / 712937 (0.00%)
[8.997922] fsck.f2fs: [FSCK] Check node 71294 / 712937 (10.00%)
[   10.629205] fsck.f2fs: [FSCK] Check node 142587 / 712937 (20.00%)
[   12.278186] fsck.f2fs: [FSCK] Check node 213880 / 712937 (30.00%)
[   13.768177] fsck.f2fs: [FSCK] Check node 285173 / 712937 (40.00%)
[   17.446971] fsck.f2fs: [FSCK] Check node 356466 / 712937 (50.00%)
[   19.891623] fsck.f2fs: [FSCK] Check node 427759 / 712937 (60.00%)
[   23.251327] fsck.f2fs: [FSCK] Check node 499052 / 712937 (70.00%)
[   28.493457] fsck.f2fs: [FSCK] Check node 570345 / 712937 (80.00%)
[   29.640800] fsck.f2fs: [FSCK] Check node 641638 / 712937 (90.00%)
[   30.718347] fsck.f2fs: [FSCK] Check node 712931 / 712937 (100.00%)
[   30.724176] fsck.f2fs:
[   30.737160] fsck.f2fs: [FSCK] Max image size: 167506 MB, Free space: 62850 MB
[   30.737164] fsck.f2fs: [FSCK] Unreachable nat entries
  [Ok..] [0x0]
[   30.737638] fsck.f2fs: [FSCK] SIT valid block bitmap checking
  [Ok..]
[   30.737640] fsck.f2fs: [FSCK] Hard link checking for regular file
  [Ok..] [0xd]
[   30.737641] fsck.f2fs: [FSCK] valid_block_count matching with CP
  [Ok..] [0x28b98e6]
[   30.737644] fsck.f2fs: [FSCK] valid_node_count matching with CP (de
lookup)  [Ok..] [0xae0e9]
[   30.737646] fsck.f2fs: [FSCK] valid_node_count matching with CP
(nat lookup) [Ok..] [0xae0e9]
[   30.737647] fsck.f2fs: [FSCK] valid_inode_count matched with CP
  [Ok..] [0xa74a3]
[   30.737649] fsck.f2fs: [FSCK] free segment_count matched with CP
  [Ok..] [0x7aa3]
[   30.737662] fsck.f2fs: [FSCK] next block offset is free
  [Ok..]
[   30.737663] fsck.f2fs: [FSCK] fixing SIT types
[   30.737867] fsck.f2fs: [FSCK] other corrupted bugs
  [Ok..]
[   30.737893] fsck.f2fs: [update_superblock: 765] Info: Done to
update superblock
[   30.960610] fsck.f2fs:
[   30.960618] fsck.f2fs: Done: 24.622956 secs
[   30.960620] fsck.f2fs:
[   30.960622] fsck.f2fs: c, u, RA, CH, CM, Repl=
[   30.960627] fsck.f2fs: 1 1 43600517 42605434 995083 985083
[   30.963274] F2FS-fs (sda13): Using encoding defined by superblock:
utf8-12.1.0 with flags 0x0
[   30.995360] __f2fs_is_valid_blkaddr: type=2

(Manually added that print ^)

[   30.995369] [ cut here ]
[   30.995375] WARNING: CPU: 7 PID: 1 at f2fs_handle_error+0x18/0x3c
[   30.995378] CPU: 7 PID: 1 Comm: init Tainted: G S  W
5.10.209-arter97-r15-kernelsu-g0867d0e4f1d2 #6
[   30.995379] Hardware name: Qualcomm Technologies, Inc. Cape QRD
with PM8010 (DT)
[   30.995380] pstate: 2245 (nzCv daif +PAN -UAO +TCO BTYPE=--)
[   30.995382] pc : f2fs_handle_error+0x18/0x3c
[   30.995384] lr : __f2fs_is_valid_blkaddr+0x2a4/0x2b0
[   30.995385] sp : ff80209e79b0
[   30.995386] x29: ff80209e79b0 x28: 0037
[   30.995388] x27: 01c7 x26: 20120121
[   30.995389] x25: 00d9 x24: 
[   30.995390] x23: 00f1a700 x22: 0828
[   30.995391] x21:

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-19 Thread Jaegeuk Kim 
On 04/19, Juhyung Park wrote:
> On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim  wrote:
> >
> > On 04/11, Chao Yu wrote:
> > > On 2024/4/10 4:34, Jaegeuk Kim wrote:
> > > > f2fs_ra_meta_pages can try to read ahead on invalid block address which 
> > > > is
> > > > not the corruption case.
> > >
> > > In which case we will read ahead invalid meta pages? recovery w/ META_POR?
> 
> In my case, it seems like it's META_SIT, and it's triggered right after mount.
> fsck detects invalid_blkaddr, and when the kernel mounts it, it
> immediately flags invalid_blkaddr again:
> 
> [6.333498] init: [libfs_mgr] Running /system/bin/fsck.f2fs -a -c
> 1 --debug-cache /dev/block/sda13
> [6.337671] fsck.f2fs: Info: Fix the reported corruption.
> [6.337947] fsck.f2fs: Info: not exist /proc/version!
> [6.338010] fsck.f2fs: Info: can't find /sys, assuming normal block device
> [6.338294] fsck.f2fs: Info: MKFS version
> [6.338319] fsck.f2fs:   "5.10.160-android12-9-ge5cfec41c8e2"
> [6.338366] fsck.f2fs: Info: FSCK version
> [6.338380] fsck.f2fs:   from "5.10-arter97"
> [6.338393] fsck.f2fs: to "5.10-arter97"
> [6.338414] fsck.f2fs: Info: superblock features = 1499 :  encrypt
> verity extra_attr project_quota quota_ino casefold
> [6.338429] fsck.f2fs: Info: superblock encrypt level = 0, salt =
> 
> [6.338442] fsck.f2fs: Info: checkpoint stop reason: shutdown(180)
> [6.338455] fsck.f2fs: Info: fs errors: invalid_blkaddr
> [6.338468] fsck.f2fs: Info: Segments per section = 1
> [6.338480] fsck.f2fs: Info: Sections per zone = 1
> [6.338492] fsck.f2fs: Info: total FS sectors = 58971571 (230357 MB)
> [6.340599] fsck.f2fs: Info: CKPT version = 2b7e3b29
> [6.340620] fsck.f2fs: Info: version timestamp cur: 19789296, prev: 
> 18407008
> [6.677041] fsck.f2fs: Info: checkpoint state = 46 :  crc
> compacted_summary orphan_inodes sudden-power-off
> [6.677052] fsck.f2fs: [FSCK] Check node 1 / 712937 (0.00%)
> [8.997922] fsck.f2fs: [FSCK] Check node 71294 / 712937 (10.00%)
> [   10.629205] fsck.f2fs: [FSCK] Check node 142587 / 712937 (20.00%)
> [   12.278186] fsck.f2fs: [FSCK] Check node 213880 / 712937 (30.00%)
> [   13.768177] fsck.f2fs: [FSCK] Check node 285173 / 712937 (40.00%)
> [   17.446971] fsck.f2fs: [FSCK] Check node 356466 / 712937 (50.00%)
> [   19.891623] fsck.f2fs: [FSCK] Check node 427759 / 712937 (60.00%)
> [   23.251327] fsck.f2fs: [FSCK] Check node 499052 / 712937 (70.00%)
> [   28.493457] fsck.f2fs: [FSCK] Check node 570345 / 712937 (80.00%)
> [   29.640800] fsck.f2fs: [FSCK] Check node 641638 / 712937 (90.00%)
> [   30.718347] fsck.f2fs: [FSCK] Check node 712931 / 712937 (100.00%)
> [   30.724176] fsck.f2fs:
> [   30.737160] fsck.f2fs: [FSCK] Max image size: 167506 MB, Free space: 62850 
> MB
> [   30.737164] fsck.f2fs: [FSCK] Unreachable nat entries
>  [Ok..] [0x0]
> [   30.737638] fsck.f2fs: [FSCK] SIT valid block bitmap checking
>  [Ok..]
> [   30.737640] fsck.f2fs: [FSCK] Hard link checking for regular file
>  [Ok..] [0xd]
> [   30.737641] fsck.f2fs: [FSCK] valid_block_count matching with CP
>  [Ok..] [0x28b98e6]
> [   30.737644] fsck.f2fs: [FSCK] valid_node_count matching with CP (de
> lookup)  [Ok..] [0xae0e9]
> [   30.737646] fsck.f2fs: [FSCK] valid_node_count matching with CP
> (nat lookup) [Ok..] [0xae0e9]
> [   30.737647] fsck.f2fs: [FSCK] valid_inode_count matched with CP
>  [Ok..] [0xa74a3]
> [   30.737649] fsck.f2fs: [FSCK] free segment_count matched with CP
>  [Ok..] [0x7aa3]
> [   30.737662] fsck.f2fs: [FSCK] next block offset is free
>  [Ok..]
> [   30.737663] fsck.f2fs: [FSCK] fixing SIT types
> [   30.737867] fsck.f2fs: [FSCK] other corrupted bugs
>  [Ok..]
> [   30.737893] fsck.f2fs: [update_superblock: 765] Info: Done to
> update superblock
> [   30.960610] fsck.f2fs:
> [   30.960618] fsck.f2fs: Done: 24.622956 secs
> [   30.960620] fsck.f2fs:
> [   30.960622] fsck.f2fs: c, u, RA, CH, CM, Repl=
> [   30.960627] fsck.f2fs: 1 1 43600517 42605434 995083 985083
> [   30.963274] F2FS-fs (sda13): Using encoding defined by superblock:
> utf8-12.1.0 with flags 0x0
> [   30.995360] __f2fs_is_valid_blkaddr: type=2
> 
> (Manually added that print ^)
> 
> [   30.995369] [ cut here ]
> [   30.995375] WARNING: CPU: 7 PID: 1 at f2fs_handle_error+0x18/0x3c
> [   30.995378] CPU: 7 PID: 1 Comm: init Tainted: G S  W
> 5.10.209-arter97-r15-kernelsu-g0867d0e4f1d2 #6
> [   30.995379] Hardware name: Qualcomm Technologies, Inc. Cape QRD
> with PM8010 (DT)
> [   30.995380] pstate: 2245 (nzCv daif +PAN -UAO +TCO BTYPE=--)
> [   30.995382] pc : f2fs_handle_error+0x18/0x3c
> [   30.995384] lr : __f2fs_is_valid_blkaddr+0x2a4/0x2b0
> [   30.995385] sp : ff80209e79b0
> [   30.995386] x29: ff80209e79b0 x28: 0037
> [   30.995388] x27: 01c7 x26: 20120121
> [   30.995389] x25:

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-19 Thread Juhyung Park 
On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim  wrote:
>
> On 04/11, Chao Yu wrote:
> > On 2024/4/10 4:34, Jaegeuk Kim wrote:
> > > f2fs_ra_meta_pages can try to read ahead on invalid block address which is
> > > not the corruption case.
> >
> > In which case we will read ahead invalid meta pages? recovery w/ META_POR?

In my case, it seems like it's META_SIT, and it's triggered right after mount.
fsck detects invalid_blkaddr, and when the kernel mounts it, it
immediately flags invalid_blkaddr again:

[6.333498] init: [libfs_mgr] Running /system/bin/fsck.f2fs -a -c
1 --debug-cache /dev/block/sda13
[6.337671] fsck.f2fs: Info: Fix the reported corruption.
[6.337947] fsck.f2fs: Info: not exist /proc/version!
[6.338010] fsck.f2fs: Info: can't find /sys, assuming normal block device
[6.338294] fsck.f2fs: Info: MKFS version
[6.338319] fsck.f2fs:   "5.10.160-android12-9-ge5cfec41c8e2"
[6.338366] fsck.f2fs: Info: FSCK version
[6.338380] fsck.f2fs:   from "5.10-arter97"
[6.338393] fsck.f2fs: to "5.10-arter97"
[6.338414] fsck.f2fs: Info: superblock features = 1499 :  encrypt
verity extra_attr project_quota quota_ino casefold
[6.338429] fsck.f2fs: Info: superblock encrypt level = 0, salt =

[6.338442] fsck.f2fs: Info: checkpoint stop reason: shutdown(180)
[6.338455] fsck.f2fs: Info: fs errors: invalid_blkaddr
[6.338468] fsck.f2fs: Info: Segments per section = 1
[6.338480] fsck.f2fs: Info: Sections per zone = 1
[6.338492] fsck.f2fs: Info: total FS sectors = 58971571 (230357 MB)
[6.340599] fsck.f2fs: Info: CKPT version = 2b7e3b29
[6.340620] fsck.f2fs: Info: version timestamp cur: 19789296, prev: 18407008
[6.677041] fsck.f2fs: Info: checkpoint state = 46 :  crc
compacted_summary orphan_inodes sudden-power-off
[6.677052] fsck.f2fs: [FSCK] Check node 1 / 712937 (0.00%)
[8.997922] fsck.f2fs: [FSCK] Check node 71294 / 712937 (10.00%)
[   10.629205] fsck.f2fs: [FSCK] Check node 142587 / 712937 (20.00%)
[   12.278186] fsck.f2fs: [FSCK] Check node 213880 / 712937 (30.00%)
[   13.768177] fsck.f2fs: [FSCK] Check node 285173 / 712937 (40.00%)
[   17.446971] fsck.f2fs: [FSCK] Check node 356466 / 712937 (50.00%)
[   19.891623] fsck.f2fs: [FSCK] Check node 427759 / 712937 (60.00%)
[   23.251327] fsck.f2fs: [FSCK] Check node 499052 / 712937 (70.00%)
[   28.493457] fsck.f2fs: [FSCK] Check node 570345 / 712937 (80.00%)
[   29.640800] fsck.f2fs: [FSCK] Check node 641638 / 712937 (90.00%)
[   30.718347] fsck.f2fs: [FSCK] Check node 712931 / 712937 (100.00%)
[   30.724176] fsck.f2fs:
[   30.737160] fsck.f2fs: [FSCK] Max image size: 167506 MB, Free space: 62850 MB
[   30.737164] fsck.f2fs: [FSCK] Unreachable nat entries
 [Ok..] [0x0]
[   30.737638] fsck.f2fs: [FSCK] SIT valid block bitmap checking
 [Ok..]
[   30.737640] fsck.f2fs: [FSCK] Hard link checking for regular file
 [Ok..] [0xd]
[   30.737641] fsck.f2fs: [FSCK] valid_block_count matching with CP
 [Ok..] [0x28b98e6]
[   30.737644] fsck.f2fs: [FSCK] valid_node_count matching with CP (de
lookup)  [Ok..] [0xae0e9]
[   30.737646] fsck.f2fs: [FSCK] valid_node_count matching with CP
(nat lookup) [Ok..] [0xae0e9]
[   30.737647] fsck.f2fs: [FSCK] valid_inode_count matched with CP
 [Ok..] [0xa74a3]
[   30.737649] fsck.f2fs: [FSCK] free segment_count matched with CP
 [Ok..] [0x7aa3]
[   30.737662] fsck.f2fs: [FSCK] next block offset is free
 [Ok..]
[   30.737663] fsck.f2fs: [FSCK] fixing SIT types
[   30.737867] fsck.f2fs: [FSCK] other corrupted bugs
 [Ok..]
[   30.737893] fsck.f2fs: [update_superblock: 765] Info: Done to
update superblock
[   30.960610] fsck.f2fs:
[   30.960618] fsck.f2fs: Done: 24.622956 secs
[   30.960620] fsck.f2fs:
[   30.960622] fsck.f2fs: c, u, RA, CH, CM, Repl=
[   30.960627] fsck.f2fs: 1 1 43600517 42605434 995083 985083
[   30.963274] F2FS-fs (sda13): Using encoding defined by superblock:
utf8-12.1.0 with flags 0x0
[   30.995360] __f2fs_is_valid_blkaddr: type=2

(Manually added that print ^)

[   30.995369] [ cut here ]
[   30.995375] WARNING: CPU: 7 PID: 1 at f2fs_handle_error+0x18/0x3c
[   30.995378] CPU: 7 PID: 1 Comm: init Tainted: G S  W
5.10.209-arter97-r15-kernelsu-g0867d0e4f1d2 #6
[   30.995379] Hardware name: Qualcomm Technologies, Inc. Cape QRD
with PM8010 (DT)
[   30.995380] pstate: 2245 (nzCv daif +PAN -UAO +TCO BTYPE=--)
[   30.995382] pc : f2fs_handle_error+0x18/0x3c
[   30.995384] lr : __f2fs_is_valid_blkaddr+0x2a4/0x2b0
[   30.995385] sp : ff80209e79b0
[   30.995386] x29: ff80209e79b0 x28: 0037
[   30.995388] x27: 01c7 x26: 20120121
[   30.995389] x25: 00d9 x24: 
[   30.995390] x23: 00f1a700 x22: 0828
[   30.995391] x21: ff80462aa000 x20: ff80462aa000
[   30.995392] x19: 0002 x18: 
[   30.995393] x17:

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-12 Thread Jaegeuk Kim 
On 04/11, Chao Yu wrote:
> On 2024/4/10 4:34, Jaegeuk Kim wrote:
> > f2fs_ra_meta_pages can try to read ahead on invalid block address which is
> > not the corruption case.
> 
> In which case we will read ahead invalid meta pages? recovery w/ META_POR?

I was trying to debug another issue, but found the root cause. Let me drop this
patch.

> 
> Thanks,
> 
> > 
> > Fixes: 31f85ccc84b8 ("f2fs: unify the error handling of 
> > f2fs_is_valid_blkaddr")
> > Signed-off-by: Jaegeuk Kim 
> > ---
> >   fs/f2fs/checkpoint.c | 9 +
> >   1 file changed, 5 insertions(+), 4 deletions(-)
> > 
> > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> > index eac698b8dd38..b01320502624 100644
> > --- a/fs/f2fs/checkpoint.c
> > +++ b/fs/f2fs/checkpoint.c
> > @@ -179,22 +179,22 @@ static bool __f2fs_is_valid_blkaddr(struct 
> > f2fs_sb_info *sbi,
> > break;
> > case META_SIT:
> > if (unlikely(blkaddr >= SIT_BLK_CNT(sbi)))
> > -   goto err;
> > +   goto check_only;
> > break;
> > case META_SSA:
> > if (unlikely(blkaddr >= MAIN_BLKADDR(sbi) ||
> > blkaddr < SM_I(sbi)->ssa_blkaddr))
> > -   goto err;
> > +   goto check_only;
> > break;
> > case META_CP:
> > if (unlikely(blkaddr >= SIT_I(sbi)->sit_base_addr ||
> > blkaddr < __start_cp_addr(sbi)))
> > -   goto err;
> > +   goto check_only;
> > break;
> > case META_POR:
> > if (unlikely(blkaddr >= MAX_BLKADDR(sbi) ||
> > blkaddr < MAIN_BLKADDR(sbi)))
> > -   goto err;
> > +   goto check_only;
> > break;
> > case DATA_GENERIC:
> > case DATA_GENERIC_ENHANCE:
> > @@ -228,6 +228,7 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info 
> > *sbi,
> > return true;
> >   err:
> > f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR);
> > +check_only:
> > return false;
> >   }


___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

2024-04-11 Thread Chao Yu 

On 2024/4/10 4:34, Jaegeuk Kim wrote:

f2fs_ra_meta_pages can try to read ahead on invalid block address which is
not the corruption case.


In which case we will read ahead invalid meta pages? recovery w/ META_POR?

Thanks,



Fixes: 31f85ccc84b8 ("f2fs: unify the error handling of f2fs_is_valid_blkaddr")
Signed-off-by: Jaegeuk Kim 
---
  fs/f2fs/checkpoint.c | 9 +
  1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index eac698b8dd38..b01320502624 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -179,22 +179,22 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info 
*sbi,
break;
case META_SIT:
if (unlikely(blkaddr >= SIT_BLK_CNT(sbi)))
-   goto err;
+   goto check_only;
break;
case META_SSA:
if (unlikely(blkaddr >= MAIN_BLKADDR(sbi) ||
blkaddr < SM_I(sbi)->ssa_blkaddr))
-   goto err;
+   goto check_only;
break;
case META_CP:
if (unlikely(blkaddr >= SIT_I(sbi)->sit_base_addr ||
blkaddr < __start_cp_addr(sbi)))
-   goto err;
+   goto check_only;
break;
case META_POR:
if (unlikely(blkaddr >= MAX_BLKADDR(sbi) ||
blkaddr < MAIN_BLKADDR(sbi)))
-   goto err;
+   goto check_only;
break;
case DATA_GENERIC:
case DATA_GENERIC_ENHANCE:
@@ -228,6 +228,7 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info 
*sbi,
return true;
  err:
f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR);
+check_only:
return false;
  }
  



___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel