Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: check zeros in first 16MB for Android

2019-08-15 Thread Chao Yu
On 2019/8/16 9:02, Jaegeuk Kim wrote: > On 08/16, Chao Yu wrote: >> On 2019/8/16 6:21, Jaegeuk Kim wrote: >>> On 08/12, Chao Yu wrote: On 2019/8/9 23:12, Jaegeuk Kim wrote: > We actually don't need to issue trim on entire disk by checking first > blocks having zeros. In heap

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: check zeros in first 16MB for Android

2019-08-15 Thread Jaegeuk Kim
On 08/16, Chao Yu wrote: > On 2019/8/16 6:21, Jaegeuk Kim wrote: > > On 08/12, Chao Yu wrote: > >> On 2019/8/9 23:12, Jaegeuk Kim wrote: > >>> We actually don't need to issue trim on entire disk by checking first > >>> blocks having zeros. > >> > >> In heap mode, we locate node log header to tail

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: check zeros in first 16MB for Android

2019-08-15 Thread Chao Yu
On 2019/8/16 6:21, Jaegeuk Kim wrote: > On 08/12, Chao Yu wrote: >> On 2019/8/9 23:12, Jaegeuk Kim wrote: >>> We actually don't need to issue trim on entire disk by checking first >>> blocks having zeros. >> >> In heap mode, we locate node log header to tail end of device, should we >> consider to

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: check zeros in first 16MB for Android

2019-08-15 Thread Jaegeuk Kim
On 08/12, Chao Yu wrote: > On 2019/8/9 23:12, Jaegeuk Kim wrote: > > We actually don't need to issue trim on entire disk by checking first > > blocks having zeros. > > In heap mode, we locate node log header to tail end of device, should we > consider to check block contain according to heap

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: check zeros in first 16MB for Android

2019-08-11 Thread Chao Yu
On 2019/8/9 23:39, Jaegeuk Kim wrote: > On 08/10, Ju Hyung Park wrote: >> Hi Jaegeuk, >> >> Just out of curiosity, what's the point of this? >> >> I thought flash chips skip erasing blocks if it's already erased to >> preserve P/E cycles as much as possible. >> All Android devices I had(various

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: check zeros in first 16MB for Android

2019-08-11 Thread Chao Yu
On 2019/8/9 23:12, Jaegeuk Kim wrote: > We actually don't need to issue trim on entire disk by checking first > blocks having zeros. In heap mode, we locate node log header to tail end of device, should we consider to check block contain according to heap option? BTW, if we changed cp_ver

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: check zeros in first 16MB for Android

2019-08-09 Thread Jaegeuk Kim
On 08/10, Ju Hyung Park wrote: > Hi Jaegeuk, > > Just out of curiosity, what's the point of this? > > I thought flash chips skip erasing blocks if it's already erased to > preserve P/E cycles as much as possible. > All Android devices I had(various versions of eMMC and UFS) ran full range >

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: check zeros in first 16MB for Android

2019-08-09 Thread Jaegeuk Kim
We actually don't need to issue trim on entire disk by checking first blocks having zeros. Signed-off-by: Jaegeuk Kim --- v2 from v1: - clean up mkfs/f2fs_format_utils.c | 53 ++-- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git