Re: [PATCH v2 8/9] bfs: remove multiple assignments

Al Viro wrote: > On Mon, Jan 28, 2008 at 01:02:03AM -0600, Joel Schopp wrote: > -inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; > +inode->i_mtime = CURRENT_TIME_SEC; > +inode->i_atime = CURRENT_TIME_SEC; > +inode->i_ctime = CURRENT_TIME_SEC; >>>

Re: [PATCH v2 8/9] bfs: remove multiple assignments

Adrian Bunk пишет: > On Sat, Jan 26, 2008 at 06:35:41PM +, Tigran Aivazian wrote: >> On Sat, 26 Jan 2008, Dmitri Vorobiev wrote: >>> - inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; >>> + inode->i_mtime = CURRENT_TIME_SEC; &g

Re: [PATCH v2 8/9] bfs: remove multiple assignments

Tigran Aivazian wrote: > On Sat, 26 Jan 2008, Dmitri Vorobiev wrote: >> -inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; >> +inode->i_mtime = CURRENT_TIME_SEC; >> +inode->i_atime = CURRENT_TIME_SEC; >> +inode-

Re: [PATCH v2 8/9] bfs: remove multiple assignments

Tigran Aivazian wrote: > On Sat, 26 Jan 2008, Dmitri Vorobiev wrote: >> -inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; >> +inode->i_mtime = CURRENT_TIME_SEC; >> +inode->i_atime = CURRENT_TIME_SEC; >> +inode-

[PATCH v2 3/9] bfs: coding style cleanup in fs/bfs/bfs.h

functional changes introduced. This patch was compile-tested by building the BFS driver both as a module and as a part of the kernel proper. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- fs/bfs/bfs.h |4 ++-- 1 files changed,

[PATCH v2 2/9] bfs: coding style cleanup in fs/bfs/inode.c

lines checked No functional changes introduced. This patch was compile-tested by building the BFS driver both as a module and as a part of the kernel proper. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- fs/bfs/in

[PATCH v2 0/9] bfs: assorted cleanups

Hi Adrian, Please drop the previous version of the BFS patches I sent to the trivial patches yesterday. I am now sending a new version, where part #5 has been redone addressing the comments I received. Please note that the driver maintainer (I'm Cc:in him now) has approved the changes in a privat

[PATCH v2 4/9] bfs: coding style cleanup in fs/bfs/dir.c

functional changes introduced. This patch was compile-tested by building the BFS driver both as a module and as a part of the kernel proper. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- fs/bfs/dir.c | 14 +++--- 1 file

[PATCH v2 9/9] bfs: use the proper header file for inclusion

as a part of the kernel proper. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- fs/bfs/inode.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index 7eefafb..00c54fa 100644

[PATCH v2 7/9] bfs: coding style cleanup in include/linux/bfs_fs.h

lines checked No functional changes introduced. This patch was compile-tested by building the BFS driver both as a module and as a part of the kernel proper. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- include/linux/bfs

[PATCH v2 8/9] bfs: remove multiple assignments

and as a part of the kernel proper. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- fs/bfs/dir.c | 13 + fs/bfs/file.c |6 -- fs/bfs/inode.c |7 +-- 3 files changed, 18 insertions(+), 8 deletions(-)

[PATCH v2 6/9] bfs: coding style cleanup in fs/bfs/file.c

functional changes introduced. This patch was compile-tested by building the BFS driver both as a module and as a part of the kernel proper. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- fs/bfs/file.c | 12 ++-- 1 file

[PATCH v2 1/9] bfs: remove a useless variable

d finished successfully. Run time test was performed using a BFS image and verifying that the filesystem remained functional after the change. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- fs/bfs/inode.c |3 +-- 1 files chang

[PATCH v2 5/9] bfs: move function prototype to the proper header file

the kernel proper. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> Acked-by: Tigran Aivazian <[EMAIL PROTECTED]> --- fs/bfs/bfs.h |3 +++ fs/bfs/dir.c |2 -- fs/bfs/inode.c |2 -- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/bfs/bfs.h b/fs/bfs

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

Andrew Morton пишет: > On Thu, 22 Nov 2007 01:49:19 +0300 > Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > >> Zach Brown пишет: >>>>> This doesn't look fine. Did you test this? >>>> Oops, my fault. Of course, I tested the patch, but kernel mo

Re: [PATCH] [2.6.24-rc3-mm1] loop cleanup in fs/namespace.c - repost

get it in, > though. It's just a cleanup and so shouldn't go in this late in the -rc > line. > > Maybe Andrew will be willing to queue it until that time in -mm. I am enclosing the patch against current -mm tree and adding Andrew to the Cc: list. Thanks, Dmitri > >

Re: [PATCH]loop cleanup in fs/namespace.c - repost

ount.h. So lots of callers of mntput() in modules will end up trying to call mntput_no_expire() from modules. $ nm fs/fuse/fuse.ko | grep mntput_no_expire U mntput_no_expire - z Signed-off-by Dmitri Vorobiev <[EMAIL PROTECTED]> --- diff --git a/fs/namespace.c b/fs/names

[PATCH]loop cleanup in fs/namespace.c - repost

. Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]> --- diff --git a/fs/namespace.c b/fs/namespace.c index 0608388..38b4b4a 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -278,8 +278,7 @@ static inline void __mntput(struct vfsmo void mntput_no_expire(struct vfsmount *mnt) { -repeat: -