[PATCH 1/18] xfs: kill struct fid/fid_t namespace pollution

2007-03-16 Thread Christoph Hellwig
XFS currently defines various fid types internally, including an fid_t which I will introduce kernel wide in the next patch. This patch kills the fid_t and xfs_fid2_t types inside xfs and uses xfs_fid_t consistantly. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/xfs

[PATCH 2/18] exportfs: add fid type

2007-03-16 Thread Christoph Hellwig
filehandle formats we have in lowlevel filesystems better. Also add an enum that gives the various filehandle types humand readable names. Note: Some people might think the struct containing an anonymous union is ugly, but I didn't want to pass around a raw union type. Signed-off-by: Christoph

[PATCH 3/18] exportfs: add new methods

2007-03-16 Thread Christoph Hellwig
it. There are default implementations for these methods that only take a callback for an nfs-enhanced iget variant and implement the rest of the semantics. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/include/linux/exportfs.h

[PATCH 4/18] efs: new export ops

2007-03-16 Thread Christoph Hellwig
Trivial switch over to the new generic helpers. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/efs/namei.c === --- linux-2.6.orig/fs/efs/namei.c 2007-03-13 18:19:44.0 +0100 +++ linux-2.6/fs/efs

[PATCH 5/18] ext2: new export ops

2007-03-16 Thread Christoph Hellwig
Trivial switch over to the new generic helpers. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/ext2/super.c === --- linux-2.6.orig/fs/ext2/super.c 2007-03-13 18:19:43.0 +0100 +++ linux-2.6/fs

[PATCH 6/18] ext3: new export ops

2007-03-16 Thread Christoph Hellwig
Trivial switch over to the new generic helpers. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/ext3/super.c === --- linux-2.6.orig/fs/ext3/super.c 2007-03-13 18:19:43.0 +0100 +++ linux-2.6/fs

[PATCH 7/18] ext4: new export ops

2007-03-16 Thread Christoph Hellwig
Trivial switch over to the new generic helpers. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/ext4/super.c === --- linux-2.6.orig/fs/ext4/super.c 2007-03-13 18:19:43.0 +0100 +++ linux-2.6/fs

[PATCH 8/18] jfs: new export ops

2007-03-16 Thread Christoph Hellwig
Trivial switch over to the new generic helpers. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/jfs/jfs_inode.h === --- linux-2.6.orig/fs/jfs/jfs_inode.h 2007-03-13 18:19:44.0 +0100 +++ linux-2.6/fs

[PATCH 9/18] ntfs: new export ops

2007-03-16 Thread Christoph Hellwig
Trivial switch over to the new generic helpers. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/ntfs/namei.c === --- linux-2.6.orig/fs/ntfs/namei.c 2007-03-13 19:29:22.0 +0100 +++ linux-2.6/fs

[PATCH 11/18] fat: new export ops

2007-03-16 Thread Christoph Hellwig
Very little changes here, fat had a mostly no op decode_fh before and does not store any parent information. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/fat/inode.c === --- linux-2.6.orig/fs/fat/inode.c

[PATCH 12/18] isofs: new export ops

2007-03-16 Thread Christoph Hellwig
Nice little cleanup by consolidating things a little and using a structure for the special file handle format. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/isofs/export.c === --- linux-2.6.orig/fs/isofs

[PATCH 13/18] shmem: new export ops

2007-03-16 Thread Christoph Hellwig
I'm not sure what people were thinking when adding support to nfs export tmpfs, but here's the conversion anyway: Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/mm/shmem.c === --- linux-2.6.orig/mm/shmem.c

[PATCH 14/18] reiserfs: new export ops

2007-03-16 Thread Christoph Hellwig
Another nice little cleanup by using the new methods. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/reiserfs/inode.c === --- linux-2.6.orig/fs/reiserfs/inode.c 2007-03-16 15:43:55.0 +0100 +++ linux

[PATCH 15/18] gfs2: new export ops

2007-03-16 Thread Christoph Hellwig
a smaller gfs2_inum_host passed. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/gfs2/ops_export.c === --- linux-2.6.orig/fs/gfs2/ops_export.c 2007-03-13 18:18:17.0 +0100 +++ linux-2.6/fs/gfs2/ops_export.c

[PATCH 16/18] ocfs2: new export ops

2007-03-16 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/ocfs2/export.c === --- linux-2.6.orig/fs/ocfs2/export.c2007-02-11 11:18:17.0 +0100 +++ linux-2.6/fs/ocfs2/export.c 2007-02-11 11:24:29.0

[PATCH 17/18] exportfs: remove old methods

2007-03-16 Thread Christoph Hellwig
Now that all filesystems are converted remove support for the old methods. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/exportfs/expfs.c === --- linux-2.6.orig/fs/exportfs/expfs.c 2007-03-13 20:38

[PATCH 18/18] exportfs: update documentation

2007-03-16 Thread Christoph Hellwig
@@ - +/* + * Copyright (C) Neil Brown 2002 + * Copyright (C) Christoph Hellwig 2007 + * + * This file contains the code mapping from inodes to NFS file handles, + * and for mapping back from file handles to dentries. + * + * For details on why we doo all the strange and hairy things in here + * take

Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread Christoph Hellwig
On Mon, Mar 19, 2007 at 10:30:08AM +1100, David Chinner wrote: Generic page_mkwrite functionality. Filesystems that make use of the VM -page_mkwrite() callout will generally use the same core code to implement it. There are several tricky truncate-related issues that we need to deal with

Re: [PATCH 1/2] fs: remove duplicated iovec checking code v8

2007-03-19 Thread Christoph Hellwig
On Mon, Mar 19, 2007 at 10:49:01AM +0300, Dmitriy Monakhov wrote: Where are several places where the same code used for iovec checks. This patch just move this code to separate helper function, and replace duplicated code with it. IMHO it is better because these are checks that we want for

Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread Christoph Hellwig
On Mon, Mar 19, 2007 at 09:11:31PM +1100, Nick Piggin wrote: I've got the patches in -mm now. I hope they will get merged when the the next window opens. I didn't submit the -page_mkwrite conversion yet, because I didn't have any callers to look at. It is is slightly less trivial than for

Re: [PATCH] Turn do_sync_file_range() into do_sync_mapping_range()

2007-03-21 Thread Christoph Hellwig
On Tue, Mar 20, 2007 at 02:46:26PM -0700, Mark Fasheh wrote: do_sync_file_range() accepts a file * from which it takes an address_space to sync. Abstract out the bulk of the function into do_sync_mapping_range() which takes the address_space directly. This way callers who want to sync an

Re: [NFS] [PATCH 0/18] export operations rewrite

2007-03-28 Thread Christoph Hellwig
On Sat, Mar 17, 2007 at 01:09:46AM +, Christoph Hellwig wrote: This patchset is a medium scale rewrite of the export operations interface. The goal is to make the interface less complex, and easier to understand from the filesystem side, aswell as preparing generic support for exporting

Re: [NFS] [PATCH 2/18] exportfs: add fid type

2007-03-29 Thread Christoph Hellwig
On Wed, Mar 28, 2007 at 07:35:20PM -0400, J. Bruce Fields wrote: A basic question: what do these apply against? They're against current mainline plus my patchset from Match 7th (starting with [PATCH 0/8] exportfs cleanups) - To unsubscribe from this list: send the line unsubscribe linux-fsdevel

Re: [ANNOUNCE] new new aops patchset

2007-04-05 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 04:13:05AM +0200, Nick Piggin wrote: On a related note - what's the rules for a perform_write() implementation? I noticed that wasn't documented with write_begin and write_end and I don't see any other filesystem implementing it yet Ah, so it isn't, thanks I'll

Re: [PATCH 1/17] locks: trivial removal of unnecessary parentheses

2007-04-06 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 07:40:51PM -0400, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] - unquoted Remove some unnecessary parentheses. Looks good. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 2/17] locks: create posix-to-flock helper functions

2007-04-06 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 07:40:52PM -0400, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] - unquoted Factor out a bit of messy code by creating posix-to-flock counterparts to the existing flock-to-posix helper functions. Ok. - To unsubscribe from this list: send the line

Re: [PATCH 3/17] locks: make -lock release private data before returning in GETLK case

2007-04-06 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 07:40:53PM -0400, J. Bruce Fields wrote: diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index f52cf5c..d557a51 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3019,6 +3019,8 @@ static int _nfs4_proc_getlk(struct nfs4_state *state, int cmd, struct

Re: [PATCH 4/17] locks: give posix_test_lock same interface as -lock

2007-04-06 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 07:40:54PM -0400, J. Bruce Fields wrote: From: Marc Eshel [EMAIL PROTECTED] - unquoted posix_test_lock() and -lock() do the same job but have gratuitously different interfaces. Modify posix_test_lock() so the two agree, simplifying some code in the process. Ok. -

Re: [PATCH 5/17] locks: factor out generic/filesystem switch from test_lock

2007-04-06 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 07:40:55PM -0400, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] - unquoted Factor out the code that switches between generic and filesystem-specific lock methods; eventually we want to call this from lock managers (lockd and nfsd) too; currently they

Re: [PATCH 6/17] locks: factor out generic/filesystem switch from setlock code

2007-04-06 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 07:40:56PM -0400, J. Bruce Fields wrote: From: Marc Eshel [EMAIL PROTECTED] - unquoted Factor out the code that switches between generic and filesystem-specific lock methods; eventually we want to call this from lock managers (lockd and nfsd) too; currently they only

Re: [PATCH 7/17] locks: allow {vfs,posix}_lock_file to return conflicting lock

2007-04-06 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 07:40:57PM -0400, J. Bruce Fields wrote: From: Marc Eshel [EMAIL PROTECTED] - unquoted The nfsv4 protocol's lock operation, in the case of a conflict, returns information about the conflicting lock. It's unclear how clients can use this, so for now we're not going

Re: [PATCH 8/17] locks: add fl_notify arguments for asynchronous lock return

2007-04-09 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 07:40:58PM -0400, J. Bruce Fields wrote: From: Marc Eshel [EMAIL PROTECTED] - unquoted Acquiring a lock on a cluster filesystem may require communication with remote hosts, and to avoid blocking lockd or nfsd threads during such communication, we allow the results to

Re: [PATCH 1/17] cramfs: use read_mapping_page

2007-04-12 Thread Christoph Hellwig
On Wed, Apr 11, 2007 at 07:49:38PM -0700, Nate Diller wrote: read_mapping_page_async() is going away, so convert its only user to read_mapping_page(). This change has not been benchmarked, however, in order to get real parallelism this wants something completely different, like

Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

2007-04-13 Thread Christoph Hellwig
On Thu, Apr 12, 2007 at 05:05:50AM -0600, Andreas Dilger wrote: struct fibmap_extent { __u64 fe_start; /* starting offset in bytes */ __u64 fe_len; /* length in bytes */ } struct fibmap { struct fibmap_extent fm_start; /* offset, length

Re: [nameidata 2/2] Pass no useless nameidata to the create, lookup, and permission IOPs

2007-04-16 Thread Christoph Hellwig
On Mon, Apr 16, 2007 at 06:29:20PM +0200, Andreas Gruenbacher wrote: enum { MAX_NESTED_LINKS = 8 }; +/** + * Fields shared between nameidata and nameidata2 -- nameidata2 could + * be embedded in nameidata, but then the vfs code would become + * cluttered with dereferences. you could use

Re: [nameidata 1/2] Don't pass NULL nameidata to vfs_create

2007-04-16 Thread Christoph Hellwig
On Mon, Apr 16, 2007 at 06:40:41PM +0200, Andreas Gruenbacher wrote: On Monday 16 April 2007 18:21, Christoph Hellwig wrote: But anyway, creating fake nameidata structures is not really helpful. If there is a nameidata passed people expect it to be complete, and if you pass them to an LSM

Re: 2.6.21-rc6 new aops patchset

2007-04-17 Thread Christoph Hellwig
On Tue, Apr 17, 2007 at 07:59:44AM +0200, Nick Piggin wrote: I'll possibly omit the perform_write stuff in the first -mm merge, so that we can get the basics reviewed and working, and exercise the write_begin/write_end paths well first. I agree. One thing that should be done for the merge is

Re: [Devel] Re: [patch 05/10] add permit user mounts in new namespace clone flag

2007-04-18 Thread Christoph Hellwig
On Wed, Apr 18, 2007 at 10:26:29AM -0400, Trond Myklebust wrote: That doesn't really change my agrument though. _If_ the flag is per mount, then it makes sense to be able to change it on a master and not on a slave. If mount flags are propagated, this is not possible. Read-only isn't

Re: [d_path 0/7] Fixes to d_path: Respin

2007-04-22 Thread Christoph Hellwig
On Sat, Apr 21, 2007 at 09:04:06PM +0200, Andreas Gruenbacher wrote: It is unspecified whether all members of the statvfs structure have meaningful values on all file systems. In my opinion, the advantage of not reporting bogus pathnames in /proc/mounts by far outweighs the problems is

Re: [patch 13/44] mm: restore KERNEL_DS optimisations

2007-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2007 at 11:23:59AM +1000, Nick Piggin wrote: Restore the KERNEL_DS optimisation, especially helpful to the 2copy write path. This may be a pretty questionable gain in most cases, especially after the legacy 2copy write path is removed, but it doesn't cost much. Well, it gets

Re: [patch 16/44] rd convert to new aops

2007-04-24 Thread Christoph Hellwig
+ page = __grab_cache_page(mapping, index); btw, __grab_cache_page should probably get a more descriptive and non-__-prefixed name now that it's used all over the place. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED]

Re: [patch 16/44] rd convert to new aops

2007-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2007 at 01:05:49PM +0200, Nick Piggin wrote: On Tue, Apr 24, 2007 at 11:46:47AM +0100, Christoph Hellwig wrote: + page = __grab_cache_page(mapping, index); btw, __grab_cache_page should probably get a more descriptive and non-__-prefixed name now that it's used all over

Re: [patch 16/44] rd convert to new aops

2007-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2007 at 01:16:53PM +0200, Nick Piggin wrote: find_or_create_cache_page given that's it's like find_or_create_page + add_to_page_cache? find_or_create_page adds to page cache as well, though :P All those random little slightly different allocators scattered over filemap.c

Re: review: don't block non-blocking writes when frozen

2007-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2007 at 09:13:37AM +1000, David Chinner wrote: So, given the catch-22 you've just presented us can we revisit the nfsd non-blocking I/O issue again? This affects anyone using DM snapshots on their NFS servers and has nothing to do with HSMs or DMAPI... FWIW, you can still

Re: [NFS] [PATCH 0/18] export operations rewrite

2007-05-01 Thread Christoph Hellwig
On Fri, Mar 30, 2007 at 01:34:53PM +1000, Neil Brown wrote: On Saturday March 17, [EMAIL PROTECTED] wrote: less that 2 weeks later more than one month later :) My only question involves motivation. You say less complex, but to me it just looks different - though being very

Re: TAKE 963965 - Add lockdep support for XFS

2007-05-02 Thread Christoph Hellwig
On Fri, Apr 27, 2007 at 06:50:45PM +1000, Lachlan McIlroy wrote: Add lockdep support for XFS I don't think this is entirely correct, and it misses some of the most interesting cases. I've Cc'ed -fsdevel and Al to get some comments on the more tricky issues in the rename section at the end of

Re: [PATCH 1/1] fs: add 4th case to do_path_lookup

2007-05-04 Thread Christoph Hellwig
sorry, I proposed Jeff a reply long ago but haven't done yet. On Fri, May 04, 2007 at 12:02:00AM -0700, Andrew Morton wrote: @@ -1125,6 +1125,10 @@ static int fastcall do_path_lookup(int dfd, const char *name, nd-mnt = mntget(fs-rootmnt); nd-dentry =

Re: [PATCH 1/1] fs: add 4th case to do_path_lookup

2007-05-04 Thread Christoph Hellwig
Oh and btw, net/sunrpc/rpc_pipe.c:rpc_lookup_parent() and fs/nfsctl.c:do_open() should be switched to the new code, at which point the path_walk() export can go. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 1/2] fs: Fix indentation in do_path_lookup

2007-05-06 Thread Christoph Hellwig
On Sat, May 05, 2007 at 06:59:39PM -0400, Josef 'Jeff' Sipek wrote: Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 0262594..600a4e7 100644 --- a/fs/namei.c +++

Re: [PATCH 2/2] fs: Use path_walk in do_path_lookup

2007-05-06 Thread Christoph Hellwig
On Sat, May 05, 2007 at 06:59:40PM -0400, Josef 'Jeff' Sipek wrote: Since, path_walk sets the total_link_count to 0, and calls link_path_walk, we can just call path_walk directly. Ok. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL

Re: [PATCH 1/4] fs: Introduce path_component_lookup

2007-05-06 Thread Christoph Hellwig
I wrote up the suggestion before my first morning tea yesterday and must admit that the name path_component_lookup is pretty stupid. We don't just look up a component but any relative path starting from the vfsmount/dentry pair. How about vfs_path_lookup instead because it mirrors various other

Re: [PATCH 4/4] fs: Remove path_walk export

2007-05-06 Thread Christoph Hellwig
On Sat, May 05, 2007 at 07:09:34PM -0400, Josef 'Jeff' Sipek wrote: Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) it should be possible to make it static now aswell. (the uml code using it is #if0'ed and will

cifs review reminder

2007-05-06 Thread Christoph Hellwig
Steve, any chance to please send cifs uodates to -fsdevel before sending them to Linus? A lot of the cifs code really would benefit from some review. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] fs: Fix indentation in do_path_lookup

2007-05-06 Thread Christoph Hellwig
On Sun, May 06, 2007 at 11:30:28AM -0400, Josef 'Jeff' Sipek wrote: + if (unlikely(!retval !audit_dummy_context() nd + nd-dentry nd-dentry-d_inode)) the check for nd is not needed either as I hopefully mentioned in my last mail. - To unsubscribe from this

Re: [PATCH 1/2] fs: Fix indentation in do_path_lookup

2007-05-06 Thread Christoph Hellwig
On Sun, May 06, 2007 at 12:43:23PM -0400, Josef Sipek wrote: On Sun, May 06, 2007 at 12:11:24PM +0100, Christoph Hellwig wrote: On Sat, May 05, 2007 at 06:59:39PM -0400, Josef 'Jeff' Sipek wrote: Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |2 +- 1 files

Re: [PATCH 1/5] fs: Introduce vfs_path_lookup

2007-05-06 Thread Christoph Hellwig
On Sun, May 06, 2007 at 01:41:25PM -0400, Josef 'Jeff' Sipek wrote: Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c| 32 include/linux/namei.h |2 ++ 2 files changed, 34 insertions(+), 0 deletions(-) Looks good to me. -

Re: [PATCH 3/5] nfsctl: Use vfs_path_lookup

2007-05-06 Thread Christoph Hellwig
On Sun, May 06, 2007 at 01:41:27PM -0400, Josef 'Jeff' Sipek wrote: use vfs_path_lookup instead of open-coding the necessary functionality. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/nfsctl.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff

Re: [PATCH 4/5] fs: Mark link_path_walk static

2007-05-06 Thread Christoph Hellwig
On Sun, May 06, 2007 at 01:41:28PM -0400, Josef 'Jeff' Sipek wrote: +/* forward declaration */ +static int fastcall link_path_walk(const char *name, struct nameidata *nd); I don't think we need that comment, otherwise this looks good. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 5/5] fs: Remove path_walk export

2007-05-06 Thread Christoph Hellwig
On Sun, May 06, 2007 at 01:41:29PM -0400, Josef 'Jeff' Sipek wrote: Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c|3 +-- include/linux/namei.h |1 - 2 files changed, 1 insertions(+), 3 deletions(-) Ok. - To unsubscribe from this list: send the line

Re: [PATCH 0/2] [TRIVIAL] Small cleanups for do_path_lookup (V2)

2007-05-06 Thread Christoph Hellwig
On Sun, May 06, 2007 at 01:47:54PM -0400, Josef 'Jeff' Sipek wrote: (For changes since V1, see the end of this email.) The following 2 patches are trivial cleanups to do_path_lookup in namei.c. Since these changes are trivial, they can go into 2.6.22-rc1 without any problems. Josef 'Jeff'

Re: [NFS] [PATCH 0/18] export operations rewrite

2007-05-07 Thread Christoph Hellwig
On Mon, May 07, 2007 at 10:06:10AM +1000, Neil Brown wrote: On Monday May 7, [EMAIL PROTECTED] wrote: Would you be able to respin that second patch series with one of those changes? Of course it is actually the first series of patches that introduces this problem. So maybe just a full

Re: [NFS] [PATCH 0/18] export operations rewrite

2007-05-13 Thread Christoph Hellwig
On Sun, Apr 01, 2007 at 04:03:25PM +0100, David Woodhouse wrote: On Sat, 2007-03-17 at 01:09 +, Christoph Hellwig wrote: This touches all nfs exporting filesystems, and I've done testing on all of the filesystems I have here locally (xfs, ext2, ext3, reiserfs, jfs) modprobe mtdram

Re: + knfsd-exportfs-add-exportfsh-header-fix.patch added to -mm tree

2007-05-16 Thread Christoph Hellwig
at all, so we should rather remove the whole file: Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/cifs/cifsfs.c === --- linux-2.6.orig/fs/cifs/cifsfs.c 2007-05-16 07:55:35.0 +0200 +++ linux-2.6/fs

Re: + knfsd-exportfs-add-exportfsh-header-fix.patch added to -mm tree

2007-05-16 Thread Christoph Hellwig
On Wed, May 16, 2007 at 08:57:21AM +0200, Christoph Hellwig wrote: On Tue, May 15, 2007 at 02:49:14PM -0700, [EMAIL PROTECTED] wrote: fs/cifs/export.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN fs/cifs/export.c~knfsd-exportfs-add-exportfsh-header-fix fs/cifs

Re: + knfsd-exportfs-add-exportfsh-header-fix.patch added to -mm tree

2007-05-22 Thread Christoph Hellwig
On Wed, May 16, 2007 at 09:55:41AM -0500, Steven French wrote: Any ideas what are the minimum export operation(s) that cifs would need to add to export under nfsd? It was not clear to me after reading the Exporting document in Documentation directory. (some users had wanted to export

Re: [RFC] obsoleting /etc/mtab

2007-06-01 Thread Christoph Hellwig
On Fri, Jun 01, 2007 at 10:33:09AM +0200, Karel Zak wrote: The core of the problem is that HAL doesn't have entries in /etc/fstab, so you cannot check for user= and users= by umount(8). The HAL have enough information about user's privileges, but the umount(8) knows nothing. Please don't

Re: [PATCH] support larger cifs network reads

2007-06-05 Thread Christoph Hellwig
On Thu, May 31, 2007 at 06:08:23PM -0500, Steve French wrote: With Samba 3.0.26pre it is now possible for a cifs client (one which supports the newest Unix/Posix cifs extensions) to request up to almost 8MB at a time on a cifs read request. A patch for the cifs client to support larger reads

Re: [PATCH] CIFS: make cifsd (more) signal-safe

2007-06-06 Thread Christoph Hellwig
On Tue, Jun 05, 2007 at 03:23:40PM -0400, Jeff Layton wrote: I recently sent a similar, smaller patch for this problem. After some discussion with Steve and Shaggy, I think I better understand why cifsd allows signals through, and I realize that my earlier patch wasn't comprehensive enough

Re: [ANNOUNCE] Btrfs: a copy on write, snapshotting FS

2007-06-12 Thread Christoph Hellwig
On Tue, Jun 12, 2007 at 04:14:39PM -0400, Chris Mason wrote: Aside from folding snapshot history into the origin's namespace... It could be possible to have a mount.btrfs that allows subvolumes and/or snapshot volumes to be mounted as unique roots? I'd imagine a bind mount _could_ provide

Re: [RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-20 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 11:24:18AM +0530, Bharata B Rao wrote: From: Bharata B Rao [EMAIL PROTECTED] Subject: Directory listing support for union mounted directories. Modifies readdir()/getdents() to support union mounted directories. This patch adds support to readdir()/getdents() to read

Re: [RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-20 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 10:22:28AM -0400, Trond Myklebust wrote: No it shouldn't. The struct file contains other stateful information from the open() call (such as authentication info) that needs to be passed into readdir. Which is exactly that problem this tries to solve. Once you have union

Re: [PATCH 01/26] document nlink function

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:04PM -0700, Dave Hansen wrote: These should have been documented from the beginning. Fix it. Ok. This is a trivial doc fix and should go into the 2.6.22 queue IMHO. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a

Re: [PATCH 03/26] ext4: remove extra IS_RDONLY() check

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:06PM -0700, Dave Hansen wrote: ext4_change_inode_journal_flag() is only called from one location: ext4_ioctl(EXT3_IOC_SETFLAGS). That ioctl case already has a IS_RDONLY() call in it so this one is superfluous. Ditto. - To unsubscribe from this list: send the

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:08PM -0700, Dave Hansen wrote: Christoph H. says this stands on its own and can go in before the rest of the r/o bind mount set. --- Some filesystems forego the vfs and may_open() and create their own 'struct file's. This patch creates a couple of

Re: [PATCH 05/26] r/o bind mounts: stub functions

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:09PM -0700, Dave Hansen wrote: This patch adds two function mnt_want_write() and mnt_drop_write(). These are used like a lock pair around and fs operations that might cause a write to the filesystem. Before these can become useful, we must first cover each

Re: [PATCH 06/26] elevate write count open()'d files

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:10PM -0700, Dave Hansen wrote: This is the first really tricky patch in the series. It elevates the writer count on a mount each time a non-special file is opened for write. This is not completely apparent in the patch because the two if() conditions in

Re: [PATCH 09/26] make access() use mnt check

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:14PM -0700, Dave Hansen wrote: It is OK to let access() go without using a mnt_want/drop_write() pair because it doesn't actually do writes to the filesystem, and it is inherently racy anyway. This is a rare case when it is OK to use __mnt_is_readonly()

Re: [PATCH 10/26] elevate mnt writers for callers of vfs_mkdir()

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:16PM -0700, Dave Hansen wrote: Pretty self-explanatory. Fits in with the rest of the series. Ok for this and similar patch 11-13. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 14/26] elevate write count for file_update_time()

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:21PM -0700, Dave Hansen wrote: Signed-off-by: Dave Hansen [EMAIL PROTECTED] We really want a guaranteed non-NULL file here, but I don't want to put this on your plate also. Please add a comment about bloody NFS exports for now. - To unsubscribe from this list:

Re: [PATCH 15/26] mount_is_safe(): add comment

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:22PM -0700, Dave Hansen wrote: This area of code is currently #ifdef'd out, so add a comment for the time when it is actually used. Ok. Does this clash with the user mount patches? Even if it does I think we want this patch first in the series and fix the

Re: [PATCH 17/26] elevate write count over calls to vfs_rename()

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:25PM -0700, Dave Hansen wrote: This also creates a little helper in the NFS code to make an if() a little bit less ugly. That should probably be a separate patch. Or better one to just rip out the MSNFS ifdefs completely, they've always been true for about the

Re: [PATCH 18/26] nfs: check mnt instead of superblock directly

2007-06-23 Thread Christoph Hellwig
Ok. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 19/26] elevate writer count for do_sys_truncate()

2007-06-23 Thread Christoph Hellwig
Ok. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/26] elevate write count for do_utimes()

2007-06-23 Thread Christoph Hellwig
Ok. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 21/26] elevate write count for do_sys_utime() and touch_atime()

2007-06-23 Thread Christoph Hellwig
Ok. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs_mknod/create()

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:32PM -0700, Dave Hansen wrote: This takes care of all of the direct callers of vfs_mknod(). Since a few of these cases also handle normal file creation as well, this also covers some calls to vfs_create(). Ok. diff -puN

Re: [PATCH 23/26] elevate mnt writers for vfs_unlink() callers

2007-06-23 Thread Christoph Hellwig
Ok. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 24/26] do_rmdir(): elevate write count

2007-06-23 Thread Christoph Hellwig
Ok. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/26] r/o bind mounts: elevate write count for some ioctls

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:12PM -0700, Dave Hansen wrote: Some ioctl()s can cause writes to the filesystem. Take these, and make them use mnt_want/drop_write() instead. We need to pass the filp one layer deeper in XFS, but somebody _just_ pulled it out in February because nobody was

Re: [PATCH 08/26] elevate writer count for chown and friends

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:13PM -0700, Dave Hansen wrote: chown/chmod,etc... don't call permission in the same way that the normal open for write calls do. They still write to the filesystem, so bump the write count during these operations. Looks good. - To unsubscribe from this

Re: [PATCH 26/26] honor r/w changes at do_remount() time

2007-06-23 Thread Christoph Hellwig
On Fri, Jun 22, 2007 at 01:03:37PM -0700, Dave Hansen wrote: Originally from: Herbert Poetzl [EMAIL PROTECTED] This is the core of the read-only bind mount patch set. Note that this does _not_ add a ro option directly to the bind mount operation. If you require such a mount, you must

Re: [PATCH] make iunique use a do/while loop rather than its obscure goto loop

2007-06-23 Thread Christoph Hellwig
On Wed, Apr 11, 2007 at 05:58:56PM -0400, Jeffrey Layton wrote: A while back, Christoph mentioned that he thought that iunique ought to be cleaned up to use a more conventional loop construct. This patch does that, turning the strange goto loop into a do/while. Signed-off-by: Jeff Layton

Re: vm/fs meetup in september?

2007-06-25 Thread Christoph Hellwig
On Sun, Jun 24, 2007 at 06:23:45AM +0200, Nick Piggin wrote: I'd just like to take the chance also to ask about a VM/FS meetup some time around kernel summit (maybe take a big of time during UKUUG or so). I won't be around until a day or two before KS, so I'd prefer to have it after KS if

Re: vm/fs meetup in september?

2007-06-26 Thread Christoph Hellwig
On Mon, Jun 25, 2007 at 05:08:02PM -0700, Jared Hulbert wrote: -memory mappable swap file (I'm not sure if this one is appropriate for the proposed meeting) Please explain what this is supposed to mean. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a

Re: [PATCH] CIFS: make cifsd (more)

2007-06-26 Thread Christoph Hellwig
On Mon, Jun 25, 2007 at 05:25:00PM -0500, Steve French wrote: Jeff, Not seeing any objections to your revised approach (to not allowing signals for cifsd kernel thread), I just merged something similar to your patch to the cifs-2.6.git tree (also fixed some nearby lines that went past 80

Re: [PATCH 0/6][TAKE5] fallocate system call

2007-06-29 Thread Christoph Hellwig
On Thu, Jun 28, 2007 at 11:33:42AM -0700, Andrew Morton wrote: I think Mingming was asking that Ted move the current quilt tree into git, presumably because she's working off git. I'm not sure what to do, really. The core kernel patches need to be in Ted's tree for testing but that'll

Re: [PATCH] CIFS: make cifsd (more)

2007-06-30 Thread Christoph Hellwig
On Mon, Jun 25, 2007 at 05:25:00PM -0500, Steve French wrote: Jeff, Not seeing any objections to your revised approach (to not allowing signals for cifsd kernel thread), I just merged something similar to your patch to the cifs-2.6.git tree (also fixed some nearby lines that went past 80

Re: [RFD 0/4] AppArmor - Don't pass NULL nameidata to vfs_create/lookup/permission IOPs

2007-06-30 Thread Christoph Hellwig
On Tue, Jun 26, 2007 at 07:46:15PM -0400, Trond Myklebust wrote: I don't object to the concept per se, but could you please give it a more descriptive name please? struct vfs_intent would be a lot more accurate than nameidata2. Agreed, but I prefer lookup_intent - intent by itself is a word

Re: [PATCH 1/6] locks: share more common lease code

2007-06-30 Thread Christoph Hellwig
On Fri, Jun 29, 2007 at 03:21:25PM -0400, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] Share more code between setlease (used by nfsd) and fcntl. Also some minor cleanup. Looks good. Fine for mainline just after 2.6.23 opens. - To unsubscribe from this list: send the

Re: [PATCH 3/6] locks: rename lease functions to reflect locks.c conventions

2007-06-30 Thread Christoph Hellwig
On Fri, Jun 29, 2007 at 03:21:27PM -0400, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] We've been using the convention that vfs_foo is the function that calls a filesystem-specific foo method if it exists, or falls back on a generic method if it doesn't. So rename

<    1   2   3   4   >