Re: [ANNOUNCE] new new aops patchset

2007-04-05 Thread Nick Piggin
On Thu, Apr 05, 2007 at 08:21:54AM -0700, Badari Pulavarty wrote: > On Thu, 2007-04-05 at 04:08 +0200, Nick Piggin wrote: > > > > ->readpage can still return AOP_TRUNCATED_PAGE. Were there any from > > prepare_write or commit_write still around? > > > > > > Not a big deal. But trying to underst

Re: [ANNOUNCE] new new aops patchset

2007-04-05 Thread Badari Pulavarty
On Thu, 2007-04-05 at 04:08 +0200, Nick Piggin wrote: > On Wed, Apr 04, 2007 at 04:32:24PM -0700, Badari Pulavarty wrote: > > On Wed, 2007-04-04 at 16:17 -0700, Mark Fasheh wrote: > > > On Wed, Apr 04, 2007 at 04:05:19PM -0700, Badari Pulavarty wrote: > > > > Hmm.. Okay, only filesystems that could

Re: [ANNOUNCE] new new aops patchset

2007-04-05 Thread Christoph Hellwig
On Thu, Apr 05, 2007 at 04:13:05AM +0200, Nick Piggin wrote: > > On a related note - what's the rules for a perform_write() implementation? > > I noticed that wasn't documented with write_begin and write_end and > > I don't see any other filesystem implementing it yet > > Ah, so it isn't, than

Re: [ANNOUNCE] new new aops patchset

2007-04-05 Thread Nick Piggin
On Thu, Apr 05, 2007 at 08:45:29AM +0100, Christoph Hellwig wrote: > On Thu, Apr 05, 2007 at 04:13:05AM +0200, Nick Piggin wrote: > > > On a related note - what's the rules for a perform_write() implementation? > > > I noticed that wasn't documented with write_begin and write_end and > > > I don't

Re: [ANNOUNCE] new new aops patchset

2007-04-05 Thread Nick Piggin
On Thu, Apr 05, 2007 at 04:18:09PM +1000, David Chinner wrote: [lots of interesting stuff] > Ah, found it. page_cache_write_begin() returns zero on success. So this: > >status = pagecache_write_begin(NULL, mapping, pos, bytes, >AOP_FLAG_UNI

Re: [ANNOUNCE] new new aops patchset

2007-04-05 Thread David Chinner
On Thu, Apr 05, 2007 at 05:00:44AM +0200, Nick Piggin wrote: > On Thu, Apr 05, 2007 at 12:43:50PM +1000, David Chinner wrote: > > On Thu, Apr 05, 2007 at 10:10:18AM +1000, David Chinner wrote: > > > On Mon, Apr 02, 2007 at 02:09:34PM +0200, Nick Piggin wrote: > > > > Updated aops patchset against 2

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Nick Piggin
On Thu, Apr 05, 2007 at 12:43:50PM +1000, David Chinner wrote: > On Thu, Apr 05, 2007 at 10:10:18AM +1000, David Chinner wrote: > > On Mon, Apr 02, 2007 at 02:09:34PM +0200, Nick Piggin wrote: > > > Updated aops patchset against 2.6.21-rc5. > > > > > > http://www.kernel.org/pub/linux/kernel/people

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread David Chinner
On Thu, Apr 05, 2007 at 10:10:18AM +1000, David Chinner wrote: > On Mon, Apr 02, 2007 at 02:09:34PM +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* >

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Nick Piggin
On Thu, Apr 05, 2007 at 10:10:18AM +1000, David Chinner wrote: > On Mon, Apr 02, 2007 at 02:09:34PM +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* >

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Nick Piggin
On Wed, Apr 04, 2007 at 03:10:34PM -0700, Mark Fasheh wrote: > On Mon, Apr 02, 2007 at 02:09:34PM +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Thanks again for pushing this stuff out Nic

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Nick Piggin
On Wed, Apr 04, 2007 at 04:32:24PM -0700, Badari Pulavarty wrote: > On Wed, 2007-04-04 at 16:17 -0700, Mark Fasheh wrote: > > On Wed, Apr 04, 2007 at 04:05:19PM -0700, Badari Pulavarty wrote: > > > Hmm.. Okay, only filesystems that could return AOP_TRUNCATED_PAGE > > > are ocf2 and gfs2. Now that b

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread David Chinner
On Mon, Apr 02, 2007 at 02:09:34PM +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* > > Contains numerous fixes from Mark and myself -- I'd say the core code i

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Badari Pulavarty
On Wed, 2007-04-04 at 16:17 -0700, Mark Fasheh wrote: > On Wed, Apr 04, 2007 at 04:05:19PM -0700, Badari Pulavarty wrote: > > Hmm.. Okay, only filesystems that could return AOP_TRUNCATED_PAGE > > are ocf2 and gfs2. Now that both of them are switched to have > > write_begin()/write_end(), why do we

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Mark Fasheh
On Wed, Apr 04, 2007 at 04:05:19PM -0700, Badari Pulavarty wrote: > Hmm.. Okay, only filesystems that could return AOP_TRUNCATED_PAGE > are ocf2 and gfs2. Now that both of them are switched to have > write_begin()/write_end(), why do we need this code to handle > AOP_TRUNCATED_PAGE (in the else par

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Badari Pulavarty
On Wed, 2007-04-04 at 15:10 -0700, Mark Fasheh wrote: ... > +int pagecache_write_begin(struct file *file, struct address_space *mapping, > + loff_t pos, unsigned len, unsigned flags, > + struct page **pagep, void **fsdata) > +{ > + const s

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Badari Pulavarty
On Wed, 2007-04-04 at 15:51 -0700, Mark Fasheh wrote: > On Wed, Apr 04, 2007 at 03:39:48PM -0700, Badari Pulavarty wrote: > > Could you elaborate on issues ext3 caused ? Its pretty stable for > > me (after bunch of simple fixes, I posted earlier). Anything I need > > to be aware ? > > Oh, I meant

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Mark Fasheh
On Wed, Apr 04, 2007 at 03:39:48PM -0700, Badari Pulavarty wrote: > Could you elaborate on issues ext3 caused ? Its pretty stable for > me (after bunch of simple fixes, I posted earlier). Anything I need > to be aware ? Oh, I meant merge issues - that's all. And that's just because I was trying to

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Badari Pulavarty
On Wed, 2007-04-04 at 15:10 -0700, Mark Fasheh wrote: > On Mon, Apr 02, 2007 at 02:09:34PM +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Thanks again for pushing this stuff out Nick. > >

Re: [ANNOUNCE] new new aops patchset

2007-04-04 Thread Mark Fasheh
On Mon, Apr 02, 2007 at 02:09:34PM +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ Thanks again for pushing this stuff out Nick. Fwiw, I had merge conflicts working against the latest git code from

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Nick Piggin
On Tue, Apr 03, 2007 at 10:35:19AM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* > >

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Nick Piggin
On Tue, Apr 03, 2007 at 09:03:50AM -0700, Badari Pulavarty wrote: > On Tue, 2007-04-03 at 11:31 +0200, Nick Piggin wrote: > > On Tue, Apr 03, 2007 at 02:08:53AM +0200, Nick Piggin wrote: > > > > BTW, I will take a shot at ext4 tomorrow. > > > > > > Thanks, so long as you think ext3 is looking OK?

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Nick Piggin
On Tue, Apr 03, 2007 at 08:59:57AM -0700, Badari Pulavarty wrote: > On Tue, 2007-04-03 at 01:58 +0200, Nick Piggin wrote: > > On Mon, Apr 02, 2007 at 01:44:59PM -0700, Badari Pulavarty wrote: > > > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > > > Updated aops patchset against 2.6.21-rc

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Nick Piggin
On Tue, Apr 03, 2007 at 08:57:03AM -0700, Badari Pulavarty wrote: > On Tue, 2007-04-03 at 01:49 +0200, Nick Piggin wrote: > > > > Ahh, just the person I wanted to ask! ;) How useful is it, out of curiosity? > > What sort of users use it, and what sort of improvements do they get? > > Well, at the

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* Here is the ext4 support for it. This is a simple port from ext3 code. Ran fsx wi

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Badari Pulavarty
On Tue, 2007-04-03 at 11:31 +0200, Nick Piggin wrote: > On Tue, Apr 03, 2007 at 02:08:53AM +0200, Nick Piggin wrote: > > > BTW, I will take a shot at ext4 tomorrow. > > > > Thanks, so long as you think ext3 is looking OK? > > > > BTW. is it a known issue that ext3 fails fsx-linux? (I tried 2.6.21

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Badari Pulavarty
On Tue, 2007-04-03 at 01:58 +0200, Nick Piggin wrote: > On Mon, Apr 02, 2007 at 01:44:59PM -0700, Badari Pulavarty wrote: > > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > > Updated aops patchset against 2.6.21-rc5. > > > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patc

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Badari Pulavarty
On Tue, 2007-04-03 at 01:49 +0200, Nick Piggin wrote: > On Mon, Apr 02, 2007 at 04:14:59PM -0700, Badari Pulavarty wrote: > > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > > Updated aops patchset against 2.6.21-rc5. > > > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patc

Re: [ANNOUNCE] new new aops patchset

2007-04-03 Thread Nick Piggin
On Tue, Apr 03, 2007 at 02:08:53AM +0200, Nick Piggin wrote: > > BTW, I will take a shot at ext4 tomorrow. > > Thanks, so long as you think ext3 is looking OK? > > BTW. is it a known issue that ext3 fails fsx-linux? (I tried 2.6.21-rc3 > IIRC, and ordered and writeback both eventually failed I th

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Nick Piggin
On Mon, Apr 02, 2007 at 01:18:13PM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* > >

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Nick Piggin
On Mon, Apr 02, 2007 at 05:00:50PM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* > >

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Nick Piggin
On Mon, Apr 02, 2007 at 04:56:11PM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* > >

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* One more cleanup. "index" is unused. BTW, I will take a shot at ext4 tomorrow. (

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Nick Piggin
On Mon, Apr 02, 2007 at 01:44:59PM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* > >

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* ext3_write_begin() is computing "start" incorrectly. Thanks, Badari --- fs/ext3

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Nick Piggin
On Mon, Apr 02, 2007 at 04:14:59PM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* > >

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Nick Piggin
On Mon, Apr 02, 2007 at 04:31:22PM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Sorry to send you so many silly fixes, b

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > Sorry to send you so many silly fixes, but I though it would be easy to review individual ones. Thanks, Badari --- mm

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* Baaah !! You took away ext3 -nobh option :( Do you have plans to support nobh ver

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* > Simple cleanup for block_write_begin(). Thanks, Badari --- fs/buffer.c |

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* [EMAIL PROTECTED] linux-2.6.21-rc5]# make -j8 modules CHK include/linux/ver

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* > > Contains numerous fixes from Mark and myself -- I'd say the core code is > get

Re: [ANNOUNCE] new new aops patchset

2007-04-02 Thread Badari Pulavarty
On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > Updated aops patchset against 2.6.21-rc5. > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > Files/dirs are 2.6.21-rc5-new-aops* > > Contains numerous fixes from Mark and myself -- I'd say the core code is > get

[ANNOUNCE] new new aops patchset

2007-04-02 Thread Nick Piggin
Updated aops patchset against 2.6.21-rc5. http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ Files/dirs are 2.6.21-rc5-new-aops* Contains numerous fixes from Mark and myself -- I'd say the core code is getting reasonably stable at this point. New stuff: patches from Mark an