Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Dejan Muhamedagic
On Mon, Feb 16, 2015 at 01:12:55PM +0100, Kristoffer Grönlund wrote: Lars Marowsky-Bree l...@suse.com writes: On 2015-02-16T09:20:22, Kristoffer Grönlund kgronl...@suse.com wrote: Actually, I decided that it does make sense to return 0 as the error code even if the resource to delete

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Kristoffer Grönlund
Dejan Muhamedagic deja...@fastmail.fm writes: If Dejan also votes to revert this change, I will do so. Must say that I somehow missed the change. The most useful thing to do seems be to exit with 0 in case --force (or crm -F) is in effect (perhaps to suppress the error message too), just

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Vladislav Bogdanov
16.02.2015 14:34, Lars Marowsky-Bree wrote: On 2015-02-16T09:20:22, Kristoffer Grönlund kgronl...@suse.com wrote: Actually, I decided that it does make sense to return 0 as the error code even if the resource to delete doesn't exist, so I pushed a commit to change this. The error message is

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Dejan Muhamedagic
On Mon, Feb 16, 2015 at 03:25:58PM +0100, Kristoffer Grönlund wrote: Dejan Muhamedagic deja...@fastmail.fm writes: If Dejan also votes to revert this change, I will do so. Must say that I somehow missed the change. The most useful thing to do seems be to exit with 0 in case --force

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Dejan Muhamedagic
Hi, On Mon, Feb 16, 2015 at 11:20:16AM +0300, Vladislav Bogdanov wrote: 16.02.2015 11:15, Kristoffer Grönlund wrote: Vladislav Bogdanov bub...@hoster-ok.com writes: Hi Kristoffer, may be it is worth to silently (or at least with rc=0) allow deletion of non-existing or already-deleted

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Kristoffer Grönlund
Vladislav Bogdanov bub...@hoster-ok.com writes: Hi Kristoffer, may be it is worth to silently (or at least with rc=0) allow deletion of non-existing or already-deleted configuration statements? Background for that is that I keep track of the all configuration statements myself, and, when

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Kristoffer Grönlund
Vladislav Bogdanov bub...@hoster-ok.com writes: Hi Kristoffer, may be it is worth to silently (or at least with rc=0) allow deletion of non-existing or already-deleted configuration statements? Background for that is that I keep track of the all configuration statements myself, and, when

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Vladislav Bogdanov
16.02.2015 11:15, Kristoffer Grönlund wrote: Vladislav Bogdanov bub...@hoster-ok.com writes: Hi Kristoffer, may be it is worth to silently (or at least with rc=0) allow deletion of non-existing or already-deleted configuration statements? Background for that is that I keep track of the all

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Lars Marowsky-Bree
On 2015-02-16T09:20:22, Kristoffer Grönlund kgronl...@suse.com wrote: Actually, I decided that it does make sense to return 0 as the error code even if the resource to delete doesn't exist, so I pushed a commit to change this. The error message is still printed, though. I'm not sure I agree,

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Kristoffer Grönlund
Lars Marowsky-Bree l...@suse.com writes: On 2015-02-16T09:20:22, Kristoffer Grönlund kgronl...@suse.com wrote: Actually, I decided that it does make sense to return 0 as the error code even if the resource to delete doesn't exist, so I pushed a commit to change this. The error message is

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-16 Thread Vladislav Bogdanov
Hi Dejan, 16.02.2015 13:47, Dejan Muhamedagic wrote: Hi, On Mon, Feb 16, 2015 at 11:20:16AM +0300, Vladislav Bogdanov wrote: 16.02.2015 11:15, Kristoffer Grönlund wrote: Vladislav Bogdanov bub...@hoster-ok.com writes: Hi Kristoffer, may be it is worth to silently (or at least with rc=0)

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-13 Thread Kristoffer Grönlund
Vladislav Bogdanov bub...@hoster-ok.com writes: Hi, Following fails with the current crmsh (e4b10ee). # crm resource stop cl-http-lv # crm resource stop cl-http-lv ERROR: crm_diff apparently failed to produce the diff (rc=0) ERROR: Failed to commit updates to cl-http-lv # echo $? 1 Hi,

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-13 Thread Vladislav Bogdanov
Hi Kristoffer, 13.02.2015 17:20, Kristoffer Grönlund wrote: Vladislav Bogdanov bub...@hoster-ok.com writes: Hi, Following fails with the current crmsh (e4b10ee). # crm resource stop cl-http-lv # crm resource stop cl-http-lv ERROR: crm_diff apparently failed to produce the diff (rc=0)

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-13 Thread Kristoffer Grönlund
Vladislav Bogdanov bub...@hoster-ok.com writes: Hi Kristoffer, 13.02.2015 17:20, Kristoffer Grönlund wrote: Vladislav Bogdanov bub...@hoster-ok.com writes: Hi, Following fails with the current crmsh (e4b10ee). # crm resource stop cl-http-lv # crm resource stop cl-http-lv ERROR:

Re: [Linux-HA] crmsh fails to stop already stopped resource

2015-02-13 Thread Vladislav Bogdanov
13.02.2015 18:04, Kristoffer Grönlund wrote: Vladislav Bogdanov bub...@hoster-ok.com writes: Hi Kristoffer, 13.02.2015 17:20, Kristoffer Grönlund wrote: Vladislav Bogdanov bub...@hoster-ok.com writes: Hi, Following fails with the current crmsh (e4b10ee). # crm resource stop cl-http-lv #