Re: [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences

2018-08-14 Thread Guenter Roeck
On Tue, Aug 14, 2018 at 12:12:36PM +0300, Dan Carpenter wrote: > The adt7475_update_device() function returns error pointers. The > problem is that in show_pwmfreq() we dereference it before the check. > And then in pwm_use_point2_pwm_at_crit_show() there isn't a check at > all. I don't know if

RE: [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences

2018-08-14 Thread IKEGAMI Tokunori
Hi Dan-san, Thank you so much for the fixes. But very sorry for the problem caused by my changes. I have reviewed them and those look good. Reviewed-by: Tokunori Ikegami Regards, Ikegami > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday,