Re: [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences

2018-08-14 Thread Guenter Roeck
On Tue, Aug 14, 2018 at 12:12:36PM +0300, Dan Carpenter wrote: > The adt7475_update_device() function returns error pointers. The > problem is that in show_pwmfreq() we dereference it before the check. > And then in pwm_use_point2_pwm_at_crit_show() there isn't a check at > all. I don't know if

RE: [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences

2018-08-14 Thread IKEGAMI Tokunori
: Tuesday, August 14, 2018 6:13 PM > To: Jean Delvare; IKEGAMI Tokunori > Cc: Guenter Roeck; linux-hwmon@vger.kernel.org; > kernel-janit...@vger.kernel.org > Subject: [PATCH 1/2] hwmon: (adt7475) Potential error pointer > dereferences > > The adt7475_update_device() f

[PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences

2018-08-14 Thread Dan Carpenter
The adt7475_update_device() function returns error pointers. The problem is that in show_pwmfreq() we dereference it before the check. And then in pwm_use_point2_pwm_at_crit_show() there isn't a check at all. I don't know if it's required, but it silences a static checker warning and it's