[PATCH] i2c: convert drivers/i2c/* to use module_i2c_driver()

2012-02-13 Thread Axel Lin
This patch converts the drivers in drivers/i2c/* to use the module_i2c_driver() macro which makes the code smaller and a bit simpler. Signed-off-by: Axel Lin axel@gmail.com Cc: Wolfram Sang w.s...@pengutronix.de Cc: Guenter Roeck guenter.ro...@ericsson.com Cc: Jean Delvare kh...@linux-fr.org

Re: [PATCH 1/4 v2] i2c/gpio: add DT support

2012-02-13 Thread Karol Lewandowski
On 09.02.2012 03:25, Jean-Christophe PLAGNIOL-VILLARD wrote: Hi! Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj-sclMFOaUSTBWk0Htik3J/w...@public.gmane.org Cc: Nicolas Ferre nicolas.ferre-aife0yeh4naavxtiumw...@public.gmane.org Cc: linux-i2c-u79uwxl29ty76z2rm5m...@public.gmane.org

Re: [PATCH] i2c: convert drivers/i2c/* to use module_i2c_driver()

2012-02-13 Thread Wolfram Sang
On Mon, Feb 13, 2012 at 05:05:03PM +0800, Axel Lin wrote: This patch converts the drivers in drivers/i2c/* to use the module_i2c_driver() macro which makes the code smaller and a bit simpler. Signed-off-by: Axel Lin axel@gmail.com Cc: Wolfram Sang w.s...@pengutronix.de Cc: Guenter Roeck

Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume

2012-02-13 Thread Ben Dooks
On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: From: Kisoo Yu ksoo...@samsung.com need to set flag after finishing its work Signed-off-by: Kisoo Yu ksoo...@samsung.com Signed-off-by: Huisung Kang hs1218.k...@samsung.com --- drivers/i2c/busses/i2c-s3c2410.c |2 +- 1

Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume

2012-02-13 Thread Ben Dooks
On Sun, Feb 12, 2012 at 01:12:31PM +, Mark Brown wrote: On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: From: Kisoo Yu ksoo...@samsung.com need to set flag after finishing its work - i2c-suspended = 0; clk_enable(i2c-clk); s3c24xx_i2c_init(i2c);

[PATCH 1/3] i2c-s3c2410: Convert to devm_kzalloc()

2012-02-13 Thread Mark Brown
Saves remembering to call kfree(). There's some kfree()s used by the resource still, these will be removed in 3.4 using the newly added devm_request_and_ioremap(). Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Reviewed-by: Barry Song baohua.s...@csr.com ---

[PATCH 3/3] i2c-s3c2410: Refactor ifdefs for PM_SLEEP

2012-02-13 Thread Mark Brown
Use the PM_SLEEP ifdef for system suspend and resume. This is partly in preparation for adding runtime operations and partly because a user may in theory choose to enable runtime suspend but not system suspend. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com ---

[PATCH 2/3] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Mark Brown
Add stub runtime_pm calls which go through the flow of enabling and disabling but don't actually do anything with the device itself as there's nothing useful we can do. This provides the core PM framework with information about when the device is idle, enabling chip wide power savings.

Re: [PATCH 1/4 v2] i2c/gpio: add DT support

2012-02-13 Thread Ben Dooks
On Thu, Feb 09, 2012 at 03:25:05AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: linux-i2c@vger.kernel.org Cc: devicetree-disc...@lists.ozlabs.org --- v2: use devm

Re: Xilinx iic i2c bus interface GPIO support for i2c-mux in Linux.

2012-02-13 Thread Ben Dooks
On Wed, Feb 08, 2012 at 01:46:15PM -0600, Robin Holt wrote: We are using a Xilinx FPGA which implements a series of i2c bus interfaces. We are planning on implementing a single-bit GPIO (XIIC_GPO_REG_OFFSET) which is included in that logic block to act as a MUX selector (also in the FPGA)

Re: [PATCH 1/4] i2c/gpio-i2c add: add DT support

2012-02-13 Thread Ben Dooks
On Mon, Feb 06, 2012 at 07:38:29PM +0100, Karol Lewandowski wrote: On 05.02.2012 11:38, Jean-Christophe PLAGNIOL-VILLARD wrote: Hi! +Device-Tree bindings for i2c gpio driver + +Required properties: +- compatible = gpio-i2c; Driver name is i2c-gpio in file i2c-gpio.c. Previous

Re: [PATCH 2/2] i2c: tegra: Remove unnecessary write to INT_STATUS

2012-02-13 Thread Ben Dooks
On Fri, Feb 03, 2012 at 05:10:17PM -0700, Stephen Warren wrote: From: Alok Chauhan al...@nvidia.com The write is not necessary and may cause the I2C controller to misbehave. With this fix, I2C on Tegra30 works (at least, running i2cdump repeatedly on the WM8903 on Cardhu's I2C5/DVC bus).

Re: [PATCH 3.3 v2] I2C: OMAP: fix build breakage when CONFIG_OF is not set

2012-02-13 Thread Ben Dooks
On Wed, Feb 08, 2012 at 01:18:21PM +0200, Luciano Coelho wrote: Since commit 6145197 (i2c: OMAP: Add DT support for i2c controller), building i2c_omap.c breaks if CONFIG_OF is not set: drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe': drivers/i2c/busses/i2c-omap.c:1021: error:

Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

2012-02-13 Thread Ben Dooks
On Thu, Jan 26, 2012 at 04:13:34PM +, Alan Cox wrote: From: Kristen Carlson Accardi kris...@linux.intel.com Don't call i2c_enable on resume because it causes a spurious interrupt. Signed-off-by: Kristen Carlson Accardi kris...@linux.intel.com Signed-off-by: Kirill A. Shutemov

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Ben Dooks
On Sun, Jan 22, 2012 at 09:39:53PM +, Mark Brown wrote: On Sun, Jan 22, 2012 at 06:48:36PM +0100, Sylwester Nawrocki wrote: On 01/22/2012 06:27 PM, Bill Gatliff wrote: I for one would rather see in-kernel drivers that require it, and then In fact we have to deal with the opposite

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-02-13 Thread Ben Dooks
On Mon, Jan 23, 2012 at 09:56:05AM +0100, Heiko Schocher wrote: add of support for the davinci i2c driver. Signed-off-by: Heiko Schocher h...@denx.de Cc: davinci-linux-open-sou...@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Cc: devicetree-disc...@lists.ozlabs.org Cc:

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-02-13 Thread Ben Dooks
On Sat, Jan 21, 2012 at 05:10:22PM +0100, Sylwester Nawrocki wrote: On 01/21/2012 02:28 PM, Mark Brown wrote: Saves remembering to call kfree(). There's some kfree()s used by the resource still, these will be removed in 3.3 using the newly added devm_request_and_ioremap().

Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Ben Dooks
On Sat, Jan 21, 2012 at 01:28:47PM +, Mark Brown wrote: Add stub runtime_pm calls which go through the flow of enabling and disabling but don't actually do anything with the device itself as there's nothing useful we can do. This provides the core PM framework with information about when

Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

2012-02-13 Thread Alan Cox
On Mon, 13 Feb 2012 23:28:57 + Ben Dooks ben-...@fluff.org wrote: On Thu, Jan 26, 2012 at 04:13:34PM +, Alan Cox wrote: From: Kristen Carlson Accardi kris...@linux.intel.com Don't call i2c_enable on resume because it causes a spurious interrupt. Signed-off-by: Kristen

Current backlog of email

2012-02-13 Thread Ben Dooks
I'm at the point where I have been so busy that email to both my own account and to several mailing-list boxes is now at the level where there are items from early December 2011 that have not been looked at. Efforts to try and sort this out just make the backlog worse so as of tomorrow I will be

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Mark Brown
On Mon, Feb 13, 2012 at 11:31:39PM +, Ben Dooks wrote: On Sun, Jan 22, 2012 at 09:39:53PM +, Mark Brown wrote: TBH I think most of the devices for which people are running these days will be able to get some win from the system wide stuff - the WFI modes aren't exactly the latest

RE: [PATCH v2] i2c: tegra: Add delay before reset the controller

2012-02-13 Thread Alok Chauhan
Hi Shubhrajyot, On Mon, Dec 26, 2011 at 4:44 PM, Alok Chauhan al...@nvidia.com wrote: From: Alok Chauhan al...@nvidia.com In NACK error condition, I2C controller violates clock-to-data setup time before stop. In Software, because of this reset of controller is happening before I2C

RE: [PATCH 00/10] I2C updates

2012-02-13 Thread Hebbar, Gururaja
Hi, I am interested in testing these patches on AM335x. Do you have a tree with these patches applied so that I can pull. On Fri, Feb 10, 2012 at 19:29:55, Datta, Shubhrajyoti wrote: This patch series colates the various i2c updates into a series. Since it is collection of various patches

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-02-13 Thread Heiko Schocher
Hello Ben, Ben Dooks wrote: On Mon, Jan 23, 2012 at 09:56:05AM +0100, Heiko Schocher wrote: add of support for the davinci i2c driver. Signed-off-by: Heiko Schocher h...@denx.de Cc: davinci-linux-open-sou...@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Cc: