Re: [PATCH 1/2] of: base: add function to get highest id of an alias stem

2015-03-28 Thread Grant Likely
On Wed, 18 Mar 2015 13:46:31 +0100 , Wolfram Sang w...@the-dreams.de wrote: On Thu, Mar 12, 2015 at 05:17:58PM +0100, Wolfram Sang wrote: I2C supports adding adapters using either a dynamic or fixed id. The latter is provided by aliases in the DT case. To prevent id collisions of those two

Re: [PATCH v8 3/8] OF: DT-Overlay configfs interface (v2)

2014-11-26 Thread Grant Likely
On Tue, 25 Nov 2014 16:50:15 +0200 , Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Grant, On Nov 25, 2014, at 12:28 , Grant Likely grant.lik...@secretlab.ca wrote: Hi Pantelis, Comments below... On Tue, 28 Oct 2014 22:36:00 +0200 , Pantelis Antoniou

Re: [PATCH v8 3/8] OF: DT-Overlay configfs interface (v2)

2014-11-25 Thread Grant Likely
Hi Pantelis, Comments below... On Tue, 28 Oct 2014 22:36:00 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Add a runtime interface to using configfs for generic device tree overlay usage. A device-tree configfs entry is created in /config/device-tree/overlays * To

[PATCH v2 11/14] i2c/of: Factor out Devicetree registration code

2014-11-24 Thread Grant Likely
Antoniou pantelis.anton...@konsulko.com [grant.likely: Made new function static and removed changes to header] Signed-off-by: Grant Likely grant.lik...@linaro.org Cc: Wolfram Sang w...@the-dreams.de Cc: Rob Herring robh...@kernel.org Cc: linux-i2c@vger.kernel.org --- drivers/i2c/i2c-core.c | 97

[PATCH v2 12/14] i2c/of: Add OF_RECONFIG notifier handler

2014-11-24 Thread Grant Likely
as required. Signed-off-by: Pantelis Antoniou pantelis.anton...@konsulko.com [grant.likely: clean up #ifdefs and drop unneeded error handling] Signed-off-by: Grant Likely grant.lik...@linaro.org Cc: Wolfram Sang w...@the-dreams.de Cc: Rob Herring robh...@kernel.org Cc: linux-i2c@vger.kernel.org

Re: [PATCH v8 6/8] OF: i2c: Add OF notifier handler

2014-11-21 Thread Grant Likely
On Thu, 20 Nov 2014 18:03:33 -0800 , Guenter Roeck li...@roeck-us.net wrote: On 11/20/2014 05:53 PM, Grant Likely wrote: On Tue, 28 Oct 2014 22:36:03 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Add OF notifier handler needed for creating/destroying i2c devices

Re: [PATCH] of: spi: Export single device registration method and accessors (v2)

2014-11-21 Thread Grant Likely
On Wed, 29 Oct 2014 12:22:04 + , Mark Brown broo...@kernel.org wrote: On Wed, Oct 29, 2014 at 01:48:06PM +0200, Pantelis Antoniou wrote: On Oct 29, 2014, at 12:14 , Mark Brown broo...@kernel.org wrote: This feels like there is an abstraction problem somewhere, whatever code is

Re: [PATCH] of: spi: Export single device registration method and accessors (v2)

2014-11-21 Thread Grant Likely
On Fri, Nov 21, 2014 at 3:44 PM, Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Grant, On Nov 21, 2014, at 17:33 , Grant Likely grant.lik...@secretlab.ca wrote: On Wed, 29 Oct 2014 12:22:04 + , Mark Brown broo...@kernel.org wrote: On Wed, Oct 29, 2014 at 01:48:06PM +0200

Re: [PATCH v8 5/8] of: i2c: Export single device registration method

2014-11-20 Thread Grant Likely
-by: Grant Likely grant.lik...@linaro.org Wolfram, this patch and the next one only make sense in conjunction with the overlay patches, but they don't necessarily need to be merged via the same tree. I'm happy to take them, but am equally happy to have you take them (assuming I ack the next patch; I

Re: [PATCH v8 6/8] OF: i2c: Add OF notifier handler

2014-11-20 Thread Grant Likely
case and just do a WARN_ON() if it fails. Otherwise: Acked-by: Grant Likely grant.lik...@linaro.org class_err: #ifdef CONFIG_I2C_COMPAT class_compat_unregister(i2c_adapter_compat_class); -- 1.7.12 -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

Re: [PATCH v8 1/8] OF: Introduce DT overlay support. (v2)

2014-11-17 Thread Grant Likely
On Mon, Nov 17, 2014 at 2:35 PM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Grant, On Nov 14, 2014, at 01:36 , Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 28 Oct 2014 22:35:58 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Introduce DT overlay

Re: [PATCH v8 1/8] OF: Introduce DT overlay support. (v2)

2014-11-13 Thread Grant Likely
On Tue, 28 Oct 2014 22:35:58 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Introduce DT overlay support. Makes it possible to dynamically overlay a part of the kernel's tree with another tree that's been dynamically loaded. Removal of nodes and properties is also possible.

Re: [PATCH 1/3] of/irq: Export of_irq_get()

2014-11-04 Thread Grant Likely
...@ideasonboard.com I think it makes sense if I take this via I2C to get the dependencies for the later patches right? Agreed. Acked-by: Grant Likely grant.lik...@linaro.org --- drivers/of/irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index

Re: [PATCH v7 1/9] OF: Introduce Device Tree resolve support.

2014-10-01 Thread Grant Likely
On Fri, 4 Jul 2014 19:59:20 +0300 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Introduce support for dynamic device tree resolution. Using it, it is possible to prepare a device tree that's been loaded on runtime to be modified and inserted at the kernel live tree. Export of

Re: [PATCH] of: Transactional DT support.

2014-06-26 Thread Grant Likely
On Wed, 25 Jun 2014 12:20:16 -0700, Dan Malek dan.ma...@konsulko.com wrote: On Jun 25, 2014, at 7:48 AM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: +int of_transaction_commit(struct of_transaction *oft); How about of_transaction_apply()? Sure. LOL! Panto, you

Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes

2014-06-25 Thread Grant Likely
On Tue, 24 Jun 2014 10:10:01 +0200, Alexander Sverdlin alexander.sverd...@nsn.com wrote: Hi Pantelis, Grant, On 23/06/14 20:33, Ioan Nicu wrote: On 22/06/14 11:40, ext Pantelis Antoniou wrote: Introduce helper functions for working with the live DT tree, all of them related to

Re: [PATCH 2/6] OF: Add [__]of_find_node_by_full_name

2014-06-24 Thread Grant Likely
On Mon, 23 Jun 2014 21:00:39 +0300, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Guenter, On Jun 23, 2014, at 8:58 PM, Guenter Roeck wrote: On 06/22/2014 02:40 AM, Pantelis Antoniou wrote: __of_find_node_by_full_name recursively searches for a matching node with the

Re: [PATCH 7/9] of/device: Allow I2C devices to OF match without supplying an OF node

2014-06-07 Thread Grant Likely
On Fri, 6 Jun 2014 16:52:30 +0100, Lee Jones lee.jo...@linaro.org wrote: The I2C framework supplies a means for devices to be registered without the requirement for platform_data, DT or ACPI. The current solution is that every single I2C device in the kernel is forced to supply a normally

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-07 Thread Grant Likely
On Fri, 6 Jun 2014 13:36:53 +0100, Lee Jones lee.jo...@linaro.org wrote: On Fri, 06 Jun 2014, Mark Brown wrote: On Thu, Jun 05, 2014 at 04:55:09PM +0100, Lee Jones wrote: On Thu, 05 Jun 2014, Grant Likely wrote: I still think the way to do it is to emulate the missing i2c_device_id

Re: [PATCH 3/9] i2c: Match using traditional OF methods, then by vendor-less compatible strings

2014-06-07 Thread Grant Likely
On Fri, 6 Jun 2014 16:52:26 +0100, Lee Jones lee.jo...@linaro.org wrote: This function provides a single call for all I2C devices which need to match firstly using traditional OF means i.e by of_node, then if that fails we attempt to match using the supplied I2C client name with a list of

Re: [PATCH 1/9] i2c: Add pointer dereference protection to i2c_match_id()

2014-06-07 Thread Grant Likely
for other, similar code trimming. Acked-by: Grant Likely grant.lik...@linaro.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- drivers/i2c/i2c-core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index

Re: [PATCH 3/7] i2c: Add the ability to match device to compatible string without an of_node

2014-06-07 Thread Grant Likely
On Fri, 6 Jun 2014 09:10:26 +0100, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Grant Likely wrote: On Wed, 4 Jun 2014 13:09:52 +0100, Lee Jones lee.jo...@linaro.org wrote: A great deal of I2C devices are currently matched via DT node name, and as such the compatible

Re: [PATCH 0/9] i2c: Relax mandatory I2C ID table passing (+ some creep)

2014-06-07 Thread Grant Likely
=;-) Aside from patch 7/9 and the comment I made about struct device vs. struct i2c_client in the API, I think this series looks good. You can add my acks to 1-6 and 8-9. Number 7 is nacked. Acked-by: Grant Likely grant.lik...@linaro.org g. Kind regards, Lee drivers/i2c/i2c-core.c

Re: [PATCH 5/7] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices

2014-06-05 Thread Grant Likely
the aforementioned table and match on either DT and/or ACPI match tables instead. Signed-off-by: Lee Jones lee.jo...@linaro.org Looks okay to me. I've not applied or tested in any way though. Acked-by: Grant Likely grant.lik...@linaro.org --- drivers/i2c/i2c-core.c | 15 +-- 1

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Grant Likely
On Wed, 4 Jun 2014 13:09:56 +0100, Lee Jones lee.jo...@linaro.org wrote: Currently this is a helper function for the I2C subsystem to aid the matching of non-standard compatible strings and devices which use DT and/or ACPI, but do not supply any nodes (see: [1] Method 4). However, it has

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Grant Likely
On Thu, 5 Jun 2014 09:20:08 +0100, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Mika Westerberg wrote: On Wed, Jun 04, 2014 at 02:28:20PM +0100, Lee Jones wrote: On Wed, 04 Jun 2014, Mika Westerberg wrote: On Wed, Jun 04, 2014 at 02:37:42PM +0200, Rafael J. Wysocki wrote:

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Grant Likely
On Thu, Jun 5, 2014 at 11:37 AM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Grant Likely wrote: On Wed, 4 Jun 2014 13:09:56 +0100, Lee Jones lee.jo...@linaro.org wrote: Currently this is a helper function for the I2C subsystem to aid the matching of non-standard compatible

Re: [PATCH 3/7] i2c: Add the ability to match device to compatible string without an of_node

2014-06-05 Thread Grant Likely
On Wed, 4 Jun 2014 13:09:52 +0100, Lee Jones lee.jo...@linaro.org wrote: A great deal of I2C devices are currently matched via DT node name, and as such the compatible naming convention of 'vendor,device' has gone somewhat awry - some nodes don't supply one, some supply an arbitrary string

Re: [PATCH 7/7] OF/ACPI/I2C: Add generic match function for the aforementioned systems

2014-06-05 Thread Grant Likely
On Thu, Jun 5, 2014 at 4:55 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Grant Likely wrote: On Thu, Jun 5, 2014 at 11:37 AM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 05 Jun 2014, Grant Likely wrote: On Wed, 4 Jun 2014 13:09:56 +0100, Lee Jones lee.jo...@linaro.org

Re: [PATCH 3/3] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices

2014-06-03 Thread Grant Likely
On Tue, 3 Jun 2014 09:11:09 +0100, Lee Jones lee.jo...@linaro.org wrote: On Mon, 02 Jun 2014, Grant Likely wrote: On Mon, 2 Jun 2014 14:41:03 +0100, Lee Jones lee.jo...@linaro.org wrote: Currently the I2C framework insists on devices supplying an I2C ID table. Many of the devices which

Re: [PATCH 1/3] i2c: Provide 'device type' to 'OF device node' look-up

2014-06-02 Thread Grant Likely
On Mon, 2 Jun 2014 14:41:01 +0100, Lee Jones lee.jo...@linaro.org wrote: We have a problem. There are lots of I2C device ID tables scattered around the kernel which are redundant in all Device Tree and/or ACPI only supported device drivers. After recent discussions it has become apparent

Re: [PATCH 2/3] i2c: Add pointer dereference protection to i2c_match_id()

2014-06-02 Thread Grant Likely
for other, similar code trimming. Signed-off-by: Lee Jones lee.jo...@linaro.org Seems reasonable. Acked-by: Grant Likely grant.lik...@linaro.org --- drivers/i2c/i2c-core.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c

Re: [PATCH 3/3] i2c: Make I2C ID tables non-mandatory for DT'ed and/or ACPI'ed devices

2014-06-02 Thread Grant Likely
On Mon, 2 Jun 2014 14:41:03 +0100, Lee Jones lee.jo...@linaro.org wrote: Currently the I2C framework insists on devices supplying an I2C ID table. Many of the devices which do so unnecessarily adding quite a few wasted lines to kernel code. This patch allows drivers a means to 'not' supply

Re: [PATCH] i2c: Fix modalias for ACPI enumerated I2C devices

2013-10-15 Thread Grant Likely
On Wed, Oct 16, 2013 at 12:47 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Tuesday, October 15, 2013 04:31:43 PM Greg Kroah-Hartman wrote: On Tue, Oct 15, 2013 at 11:24:01PM +0200, Rafael J. Wysocki wrote: On Tuesday, October 15, 2013 01:48:29 PM Greg Kroah-Hartman wrote: On Tue, Oct 15,

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-28 Thread Grant Likely
s.nawro...@samsung.com Signed-off-by: Wolfram Sang w...@the-dreams.de Acked-by: Grant Likely grant.lik...@linaro.org --- V2-V3: Was trying to be too smart by only fixing includes needed. Took a more general approach this time, converting of_i2c.h to i2c.h in case i2c.h

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-17 Thread Grant Likely
On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij linus.wall...@linaro.org wrote: On Mon, Jun 17, 2013 at 5:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: This has just shown up in next-20130617, and breaks at least the TPS65910 and TPS62360 drivers, since they assume that the id parameter

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-12 Thread Grant Likely
On Fri, 7 Jun 2013 23:32:42 +0200, Wolfram Sang w...@the-dreams.de wrote: ... I2C devices probed from device tree should subsequently be fixed to handle the case where of_match_table() is used (I think none of them do that today), and platforms should fix their device trees to use

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-12 Thread Grant Likely
On Mon, 10 Jun 2013 15:40:14 +0200, Wolfram Sang w...@the-dreams.de wrote: On Mon, Jun 10, 2013 at 02:18:17PM +0200, Linus Walleij wrote: On Fri, Jun 7, 2013 at 11:32 PM, Wolfram Sang w...@the-dreams.de wrote: ... I2C devices probed from device tree should subsequently be fixed to

Re: [PATCH] i2c: core: make it possible to match a pure device tree driver

2013-05-13 Thread Grant Likely
On 13 May 2013 10:26, Linus Walleij linus.wall...@linaro.org wrote: On Mon, May 13, 2013 at 9:16 AM, Sascha Hauer s.ha...@pengutronix.de wrote: - status = driver-probe(client, i2c_match_id(driver-id_table, client)); + if (dev-driver-of_match_table) + /* Device tree

Re: [PATCH RFC 1/1] gpio: mcp23s08: convert driver to DT

2013-02-05 Thread Grant Likely
On Thu, 31 Jan 2013 21:51:36 +0100, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Jan 31, 2013 at 4:58 PM, Lars Poeschel la...@wh2.tu-dresden.de wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt @@ -0,0 +1,27 @@ +Microchip

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Grant Likely
On Wed, Dec 19, 2012 at 5:14 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 12:32:01PM +, Grant Likely wrote: I'm not convinced on the design of this protocol. It won't scale beyond 2 bus masters and it seems very specific to the design of a specific

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Grant Likely
On Thu, Dec 20, 2012 at 12:17 AM, Simon Glass s...@chromium.org wrote: On Wed, Dec 19, 2012 at 9:14 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 12:32:01PM +, Grant Likely wrote: I'm not convinced on the design of this protocol. It won't scale beyond

Re: I2C and devicetrees

2012-12-14 Thread Grant Likely
but for a lot of drivers that don't do anything special it works just fine. The moment you need to identify a specific device it becomes better to use an of match table. g. -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

2012-12-10 Thread Grant Likely
On Fri, 07 Dec 2012 12:30:57 -0500 (EST), David Miller da...@davemloft.net wrote: From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 4 Dec 2012 21:49:26 + On Tue, Dec 4, 2012 at 9:10 PM, David Miller da...@davemloft.net wrote: From: Grant Likely grant.lik...@secretlab.ca Date

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

2012-12-04 Thread Grant Likely
On Tue, Dec 4, 2012 at 9:10 PM, David Miller da...@davemloft.net wrote: From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 4 Dec 2012 14:44:57 + On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson andr...@gaisler.com wrote: This series removes the dependency on !SPARC for OF_I2C

Re: [PATCH RESEND] i2c: Add support for device-tree based chip initialization

2012-11-26 Thread Grant Likely
On Sun, 25 Nov 2012 20:53:56 -0800, Guenter Roeck li...@roeck-us.net wrote: Some I2C devices are not or not correctly initialized by the firmware. Configuration would be possible via platform data, but that would require per-driver platform data and a lot of code, and changing it would not be

Re: [PATCH] bindings: i2c: use consistent naming for i2c binding descriptions

2012-11-15 Thread Grant Likely
: Grant Likely grant.lik...@secretlab.ca Applied, thanks. g. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 5/7] ARM: davinci: i2c: add OF support

2012-05-26 Thread Grant Likely
Cc: linux-i2c@vger.kernel.org Cc: Ben Dooks ben-li...@fluff.org Cc: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: Sekhar Nori nsek...@ti.com Cc: Wolfgang Denk w...@denx.de Cc: Sylwester Nawrocki s.nawro...@samsung.com --- - changes for v2: - add comments

Re: [PATCH v2 1/5] i2c: Convert i2c-octeon.c to use device tree.

2012-05-19 Thread Grant Likely
On Thu, 26 Apr 2012 18:20:26 -0700, David Daney ddaney.c...@gmail.com wrote: From: David Daney david.da...@cavium.com There are three parts to this: 1) Remove the definitions of OCTEON_IRQ_TWSI and OCTEON_IRQ_TWSI2. The interrupts are specified by the device tree and these hard

Re: [PATCH 1/3] i2c-s3c2410: Drop unused define

2012-03-18 Thread Grant Likely
Acked-by: Grant Likely grant.lik...@secretlab.ca --- drivers/i2c/busses/i2c-s3c2410.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 737f721..85e3664 100644 --- a/drivers/i2c/busses/i2c

Re: [PATCH 0/2] i2c: Don't assume bus nr 0 if none was specified

2012-03-17 Thread Grant Likely
On Fri, 16 Mar 2012 13:27:27 +0100, Karol Lewandowski k.lewando...@samsung.com wrote: On 16.03.2012 13:19, Karol Lewandowski wrote: Hi, i2c controller drivers used to assume bus number 0 when none (-1) was specified. This worked on non-device tree systems, where one could

Re: [RFC PATCH 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board

2012-02-01 Thread Grant Likely
On Wed, Feb 01, 2012 at 02:20:13PM +0400, Sergei Shtylyov wrote: Hello. On 31-01-2012 17:04, Heiko Schocher wrote: On Mon, Jan 23, 2012 at 09:56:07AM +0100, Heiko Schocher wrote: - AM1808 based board - 64 MiB DDR ram - 2 MiB Nor flash - 128 MiB NAND flash - use internal RTC - I2C

Re: [RFC PATCH 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board

2012-01-30 Thread Grant Likely
On Mon, Jan 23, 2012 at 09:56:07AM +0100, Heiko Schocher wrote: - AM1808 based board - 64 MiB DDR ram - 2 MiB Nor flash - 128 MiB NAND flash - use internal RTC - I2C support - hwmon lm75 support - UBI/UBIFS support - MMC support - USB OTG support Signed-off-by: Heiko Schocher

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-01-30 Thread Grant Likely
On Tue, Jan 24, 2012 at 10:51:50AM +0100, Sylwester Nawrocki wrote: Hello Heiko, On 01/24/2012 08:18 AM, Heiko Schocher wrote: On 01/23/2012 09:56 AM, Heiko Schocher wrote: add of support for the davinci i2c driver. Signed-off-by: Heiko Schocherh...@denx.de Cc:

Re: [PATCH 2/3] mfd: mc13xxx-core: Move spi specific code into separate module.

2012-01-19 Thread Grant Likely
On Thu, Jan 19, 2012 at 09:08:43AM +0100, Uwe Kleine-König wrote: Hello, On Thu, Jan 19, 2012 at 12:01:33PM +1100, Marc Reilly wrote: All spi specific code is moved into a new module. The mc13xxx struct moves to the include file by necessity. A new config choice selects the bus type

Re: [PATCH v4 03/12] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-02 Thread Grant Likely
On Thu, Dec 22, 2011 at 03:56:37PM +0100, Benoit Cousson wrote: Add initial device-tree support for twl familly chips. The current version is missing the regulator entries due to the lack of DT regulator bindings for the moment. Only the simple sub-modules that do not depend on platform_data

Re: [PATCH 1/5] drivercore: Generalize module_platform_driver

2011-11-16 Thread Grant Likely
be used to generate bus specific macros for registering drivers like the module_platform_driver macro. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Grant Likely grant.lik...@secretlab.ca ---  include/linux/init.h            |   21 +  include/linux

Re: [PATCH 2/5] I2C: Add helper macro for i2c_driver boilerplate

2011-11-16 Thread Grant Likely
but register/unregister the I2C driver. By using this macro it is possible to eliminate a few lines of boilerplate code per I2C driver. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Grant Likely grant.lik...@secretlab.ca ---  include/linux/i2c.h |   13 +  1 files changed

Re: [PATCH 3/5] SPI: Add helper macro for spi_driver boilerplate

2011-11-16 Thread Grant Likely
but register/unregister the SPI driver. By using this macro it is possible to eliminate a few lines of boilerplate code per SPI driver. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Grant Likely grant.lik...@secretlab.ca ---  include/linux/spi/spi.h |   11 +++  1 files changed

Re: [PATCH 0/5] Generalize module_platform_driver

2011-11-16 Thread Grant Likely
On Wed, Nov 16, 2011 at 9:37 AM, Greg KH gre...@suse.de wrote: On Wed, Nov 16, 2011 at 05:36:18PM +0100, Jean Delvare wrote: On Wed, 16 Nov 2011 08:02:06 -0800, Greg KH wrote: On Wed, Nov 16, 2011 at 10:13:34AM +0100, Lars-Peter Clausen wrote: Grant Likely recently introduced

Re: [PATCH 5/5] staging:iio: Use module_spi_driver to register SPI driver

2011-11-16 Thread Grant Likely
On Wed, Nov 16, 2011 at 2:13 AM, Lars-Peter Clausen l...@metafoo.de wrote: Use the newly introduced module_spi_driver macro for registering SPI drivers. This allows us to remove a few lines of boilerplate code. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Grant Likely grant.lik

Re: [PATCH v2] i2c-tegra: Use the suspend_noirq/resume_noirq not suspend/resume

2011-09-22 Thread Grant Likely
to get the ordering right. * Enhance device probing such that the ASoC sound card device could defer its probing until all required resources were available. This would then cause the overall sound card suspend to occur at an appropriate early time. Grant Likely was reported to have been

Re: [PATCH V3 1/5] i2c: Add irq_gpio field to struct i2c_client, i2c_board_info.

2011-09-19 Thread Grant Likely
On Fri, Sep 02, 2011 at 08:56:20AM +0200, Jean Delvare wrote: Stephen, Can you please fix your e-mail client / system / whatever so that your patch series are no longer sent duplicated? On Thu, 1 Sep 2011 16:04:27 -0600, Stephen Warren wrote: Some devices use a single pin as both an IRQ

Re: [PATCH 2/3] i2c: move OF i2c related functions into i2c core

2011-08-06 Thread Grant Likely
On Sat, Aug 6, 2011 at 12:15 AM, Rob Herring robherri...@gmail.com wrote: Grant, On 08/05/2011 05:56 PM, Grant Likely wrote: On Fri, Aug 05, 2011 at 04:24:27PM -0500, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com This simplifies i2c drivers by removing calls

Re: [PATCH 1/3] i2c: move of_i2c_register_devices call into core

2011-08-05 Thread Grant Likely
. i2c is not up to me. g. Signed-off-by: Rob Herring rob.herr...@calxeda.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Jochen Friedrich joc...@scram.de Cc: Jean Delvare kh...@linux-fr.org Cc: Ben Dooks ben-li...@fluff.org Cc: Sebastian Andrzej Siewior bige...@linutronix.de Cc: Dirk

Re: [PATCH] i2c-designware: add OF binding support

2011-08-04 Thread Grant Likely
and DT style i2c registration to designware i2c driver. Signed-off-by: Rob Herring rob.herr...@calxeda.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: devicetree-disc...@lists.ozlabs.org Cc: Ben Dooks ben-li...@fluff.org Cc: linux-i2c@vger.kernel.org ---  Documentation/devicetree/bindings/i2c

Re: [PATCH] i2c-designware: add OF binding support

2011-08-03 Thread Grant Likely
On Wed, Aug 3, 2011 at 9:04 PM, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com Add of_match_table and DT style i2c registration to designware i2c driver. Signed-off-by: Rob Herring rob.herr...@calxeda.com Cc: Grant Likely grant.lik...@secretlab.ca Cc

Re: [PATCH v2 3/3] arm: dt: Add device tree support for i2c instance 0 and 1 on exynos4 dt machine

2011-07-31 Thread Grant Likely
MACH_EXYNOS4_DT select S3C_DEV_HSMMC select S3C_DEV_HSMMC2 select EXYNOS4_SETUP_SDHCI + select EXYNOS4_SETUP_I2C0 + select EXYNOS4_SETUP_I2C1 Hmmm, there should be a better way do do this; but I don't have any objections. Acked-by: Grant Likely grant.lik...@secretlab.ca

Re: [PATCH v2 2/3] i2c: s3c2410: Add device tree support

2011-07-31 Thread Grant Likely
= { .owner = THIS_MODULE, .name = s3c-i2c, .pm = S3C24XX_DEV_PM_OPS, + .of_match_table = s3c24xx_i2c_match, }, Looks pretty good. After fixing the above comment, feel free to add my: Acked-by: Grant Likely grant.lik...@secretlab.ca

Re: [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine

2011-07-18 Thread Grant Likely
On Mon, Jul 18, 2011 at 3:45 AM, Ben Dooks ben-...@fluff.org wrote: On Sun, Jul 17, 2011 at 10:30:59PM -0600, Grant Likely wrote: On Mon, Jul 18, 2011 at 06:20:41AM +0530, Thomas Abraham wrote: Add device node for i2c instance 1 and list all its connected slave devices. Signed-off

Re: [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine

2011-07-18 Thread Grant Likely
On Mon, Jul 18, 2011 at 5:53 AM, G, Manjunath Kondaiah manj...@linaro.org wrote: Abraham, Few comments on i2c child devices handling: On 18 July 2011 06:20, Thomas Abraham thomas.abra...@linaro.org wrote: Add device node for i2c instance 1 and list all its connected slave devices.

Re: [PATCH 1/2] i2c: s3c24xx: Add device tree support

2011-07-17 Thread Grant Likely
On Mon, Jul 18, 2011 at 06:20:40AM +0530, Thomas Abraham wrote: Add device tree support for Samsung's s3c24xx i2c driver. It adds support for parsing platform data from device tree and initialize all the slave devices specified as child nodes. Signed-off-by: Thomas Abraham

Re: [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine

2011-07-17 Thread Grant Likely
On Mon, Jul 18, 2011 at 06:20:41AM +0530, Thomas Abraham wrote: Add device node for i2c instance 1 and list all its connected slave devices. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- arch/arm/boot/dts/exynos4-smdkv310.dts | 19 ++-

Re: [PATCH] i2c: Tegra: Add of_match_table

2011-07-14 Thread Grant Likely
, was applied to next-i2c. This change is that missing chunk. Signed-off-by: John Bonesio bo...@secretlab.ca Signed-off-by: Stephen Warren swar...@nvidia.com Acked-by: Grant Likely grant.lik...@secretlab.ca ---  drivers/i2c/busses/i2c-tegra.c |   12  1 files changed, 12 insertions

Re: [PATCH 2/2] i2c/imx: add device tree probe support

2011-07-14 Thread Grant Likely
On Fri, Jul 15, 2011 at 12:03:45AM +0800, Shawn Guo wrote: It adds device tree probe support for i2c-imx driver. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Grant Likely grant.lik...@secretlab.ca Cc: Darius Augulis augulis.dar...@gmail.com Cc: Ben Dooks ben-li...@fluff.org

Re: [PATCH 1/2] i2c/imx: remove init/exit hooks from platform data

2011-07-14 Thread Grant Likely
On Fri, Jul 15, 2011 at 12:03:44AM +0800, Shawn Guo wrote: The init/exit hooks in platform data are being used nowhere, so can be removed. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Darius Augulis augulis.dar...@gmail.com Cc: Ben Dooks ben-li...@fluff.org Acked-by: Grant Likely

Re: [PATCH] i2c: tegra: Fix compile when !CONFIG_OF

2011-07-13 Thread Grant Likely
reason other than to avoid bloating linux/of.h. I probably would accept a patch that added it. Acked-by: Grant Likely grant.lik...@secretlab.ca g.  drivers/i2c/busses/i2c-tegra.c |    5 -  1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b

Re: [PATCH] i2c: Allow i2c_add_numbered_adapter() to assign a bus id.

2011-07-05 Thread Grant Likely
On Tue, Jul 5, 2011 at 2:53 AM, Jean Delvare kh...@linux-fr.org wrote: Hi Grant, Sorry for the late answer. On Mon, 27 Jun 2011 13:02:45 -0600, Grant Likely wrote: On Mon, Jun 27, 2011 at 12:55 PM, Grant Likely grant.lik...@secretlab.ca wrote: Currently, if an i2c bus driver supports both

Re: [PATCH] gpio: pca953x: change driver name to be unique

2011-06-30 Thread Grant Likely
On Thu, Jun 30, 2011 at 8:18 AM, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Jun 30, 2011 at 04:11:01PM +0200, Jean Delvare wrote: On Thu, 30 Jun 2011 15:35:59 +0200, Wolfram Sang wrote: This driver handles the variants pca9534-pca9539, so it chose the name pca953x. However, there is a

[PATCH] i2c: Allow i2c_add_numbered_adapter() to assign a bus id.

2011-06-27 Thread Grant Likely
Currently, if an i2c bus driver supports both static and dynamic bus ids, it needs to choose between calling i2c_add_numbered_adapter() and i2c_add_adapter(). This patch makes i2c_add_numbered_adapter() redirect to i2c_add_adapter() if the requested bus id is -1. Signed-off-by: Grant Likely

Re: [PATCH] i2c: Allow i2c_add_numbered_adapter() to assign a bus id.

2011-06-27 Thread Grant Likely
On Mon, Jun 27, 2011 at 12:55 PM, Grant Likely grant.lik...@secretlab.ca wrote: Currently, if an i2c bus driver supports both static and dynamic bus ids, it needs to choose between calling i2c_add_numbered_adapter() and i2c_add_adapter().  This patch makes i2c_add_numbered_adapter() redirect

Re: [PATCH] ARM: Tegra: i2c driver

2011-06-20 Thread Grant Likely
On Mon, Jun 20, 2011 at 6:23 PM, John Bonesio bo...@secretlab.ca wrote: This patch modifies the tegra i2c driver so that it can be initiailized using the device tree along with the devices connected to the i2c bus. Signed-off-by: John Bonesio bo...@secretlab.ca Acked-by: Grant Likely

Re: [REPOST PATCH] i2c: pxa2xx: remove ifdef CONFIG_OF

2011-05-03 Thread Grant Likely
at the time, this one was merged later. Acked-by: Grant Likely grant.lik...@secretlab.ca Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Hey Ben, Can you pick up this patch? Thanks, g. --- drivers/i2c/busses/i2c-pxa.c |2 -- 1 files changed, 0 insertions(+), 2 deletions

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Wed, Apr 06, 2011 at 11:38:54AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 11:25:57AM -0700, Andres Salomon wrote: We've been faced with the problem of being able to pass both MFD related data and a platform_data pointer to some of those drivers. Squeezing the MFD bits in the

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Thu, Apr 07, 2011 at 03:40:23PM +0200, Samuel Ortiz wrote: Hi Felipe, On Wed, Apr 06, 2011 at 09:59:02PM +0300, Felipe Balbi wrote: Hi, On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: What is a MFD cell pointer and why is it needed in struct device? An MFD

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Mon, Apr 4, 2011 at 8:04 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Apr 04, 2011 at 12:03:15PM +0200, Samuel Ortiz wrote: diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h index d96db98..734d254 100644 --- a/include/linux/platform_device.h

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Thu, Apr 07, 2011 at 05:03:23PM +0200, Samuel Ortiz wrote: On Thu, Apr 07, 2011 at 07:35:15AM -0700, Grant Likely wrote: Below is a patch for the Xilinx SPI example. Although this would fix the issue, we'd still have to do that on device per device basis. I had a similar solution

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-04 Thread Grant Likely
On Mon, Apr 04, 2011 at 12:03:15PM +0200, Samuel Ortiz wrote: On Fri, Apr 01, 2011 at 05:58:44PM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 11:47

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote: Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote: [...] Gah.  Not all devices instantiated via mfd will be an mfd

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 11:56 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote: Hi Grant, On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 1 Apr 2011 13:20:31 +0200 Samuel Ortiz sa...@linux.intel.com wrote

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-03-31 Thread Grant Likely
On Wed, Feb 02, 2011 at 08:08:12PM -0800, Andres Salomon wrote: No need to explicitly set the cell's platform_data/data_size. In this case, move the various platform_data pointers to driver_data. All of the clients which make use of it are also changed. Signed-off-by: Andres Salomon

Re: [PATCH] i2c: pxa2xx: remove ifdef CONFIG_OF

2011-03-25 Thread Grant Likely
in tree at the time, this one was merged later. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Acked-by: Grant Likely grant.lik...@secretlab.ca This should go via the i2c tree since there are no device tree patches depending on it. g. ---  drivers/i2c/busses/i2c-pxa.c |    2

[PATCH] i2c/ocores: Fix pointer type mismatch error

2011-02-28 Thread Grant Likely
: warning: assignment discards qualifiers from pointer target type drivers/i2c/busses/i2c-ocores.c:261: warning: assignment discards qualifiers from pointer target type Signed-off-by: Grant Likely grant.lik...@secretlab.ca Cc: Peter Korsgaard jac...@sunsite.dk Cc: Ben Dooks ben-li...@fluff.org Cc

Re: [RFC PATCH 07/10] i2c: Convert i2c-octeon.c to use device tree.

2011-02-23 Thread Grant Likely
On Tue, Feb 22, 2011 at 12:57:51PM -0800, David Daney wrote: Signed-off-by: David Daney dda...@caviumnetworks.com Cc: Jean Delvare (PC drivers, core) kh...@linux-fr.org Cc: Ben Dooks (embedded platforms) ben-li...@fluff.org Cc: linux-i2c@vger.kernel.org ---

Re: [PATCH v3 2/2] i2c: xiic: Use 32bit accesses only

2011-02-23 Thread Grant Likely
On Wed, Feb 23, 2011 at 09:08:47AM +0100, Michal Simek wrote: Grant Likely wrote: On Tue, Feb 22, 2011 at 10:49 AM, Michal Simek mon...@monstr.eu wrote: i2c driver is used for LE/BE that's why is useful to use 32bit accesses. Then it is not necessary to solve any endian issues. Are you

Re: [PATCH v2 1/2] i2c: xiic: Add OF support for Xilinx i2c bus interface

2011-02-22 Thread Grant Likely
://vger.kernel.org/majordomo-info.html Please read the FAQ at  http://www.tux.org/lkml/ -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 2/2] i2c: xiic: Use 32bit accesses only

2011-02-22 Thread Grant Likely
-- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html Please read the FAQ at  http://www.tux.org/lkml/ -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH v3 1/2] i2c: xiic: Add OF support for Xilinx i2c bus interface

2011-02-22 Thread Grant Likely
[cc'ing Ben Dooks, embedded i2c maintainer] On Tue, Feb 22, 2011 at 10:49 AM, Michal Simek mon...@monstr.eu wrote: Add OF support to Xilinx i2c bus interface. It is used on Microblaze systems. Signed-off-by: Michal Simek mon...@monstr.eu Acked-by: Grant Likely grant.lik...@secretlab.ca Ben

Re: [PATCH] i2c-ocores: register devices on child nodes

2011-02-22 Thread Grant Likely
; } -- 1.7.4 -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe

  1   2   >