Re: [PATCH v2] i2c: enable i2c adapter to suspend/resume asynchronously

Any comments are welcome. Thanks, Zhonghui On 9/24/2015 2:50 PM, Fu, Zhonghui wrote: > Now, PM core supports asynchronous suspend/resume mode for devices > during system suspend/resume, and the power state transition of one > device may be completed in separate kernel thread. PM core ensures

Re: [PATCH v2] i2c/designware: enable i2c controller to suspend/resume asynchronously

Any comments are welcome. Thanks, Zhonghui On 9/24/2015 3:10 PM, Fu, Zhonghui wrote: > Now, PM core supports asynchronous suspend/resume mode for devices > during system suspend/resume, and the power state transition of one > device may be completed in separate kernel thread. PM core ensures

Re: [PATCH v2] i2c: enable i2c device to suspend/resume asynchronously

Hi, Any comments are welcome. Thanks, Zhonghui On 9/24/2015 2:26 PM, Fu, Zhonghui wrote: > Now, PM core supports asynchronous suspend/resume mode for devices > during system suspend/resume, and the power state transition of one > device may be completed in separate kernel thread. PM core

Re: [PATCH v4 2/3] i2c-piix4: Add support for multiplexed main adapter in SB800

On Sun, Nov 15, 2015 at 12:33:03PM +0100, Christian Fetzer wrote: > The SB800 chipset supports a multiplexed main SMBus controller with > four ports. The multiplexed ports share the same SMBus address and > register set. The port is selected by bits 2:1 of the smb_en register > (0x2C). > > Only

[PATCH 2/3] i2c: xiic: Prevent concurrent running of the IRQ handler and __xiic_start_xfer()

Prior to commit e6c9a037bc8a ("i2c: xiic: Remove the disabling of interrupts") IRQs where disabled when the initial __xiic_start_xfer() was called. After the commit the interrupt is enabled while the function is running, this means it is possible for the interrupt to be triggered while the

[PATCH 1/3] i2c: Revert "i2c: xiic: Do not reset controller before every transfer"

Commit d701667bb331 ("i2c: xiic: Do not reset controller before every transfer") removed the reinitialization of the controller before the start of each transfer. Apparently this change is not safe to make and the commit results in random I2C bus failures. An easy way to trigger the issue is to

[PATCH 3/3] i2c: xiic: Replace spinlock with mutex

All protected sections are only called from sleep-able context, so there is no need to use a spinlock. Signed-off-by: Lars-Peter Clausen --- drivers/i2c/busses/i2c-xiic.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

Hi Wolfram, Thank you for the patch. Sorry for bringing bad news, but as with v1, this patch breaks ADV7511 detection on my Koelsch board. Reverting it on top of the series fixes the problem. You'll find the dmesg and trace logs with your debugging patch applied attached to this e-mail in

[PATCH v6] at24: Support SMBus read/write of 16-bit devices

Previously, the at24 driver would bail out in the case of a 16-bit addressable EEPROM attached to an SMBus controller. This is because SMBus block reads and writes don't map to I2C multi-byte reads and writes when the offset portion is 2 bytes. Instead of bailing out, this patch settles for

Re: [PATCH 3/3] i2c: xiic: Replace spinlock with mutex

On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen wrote: > All protected sections are only called from sleep-able context, so there is > no need to use a spinlock. Looks good to me. Feel free to add my reviewed by. > > Signed-off-by: Lars-Peter Clausen > ---

Re: [PATCH 1/3] i2c: Revert "i2c: xiic: Do not reset controller before every transfer"

On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen wrote: > Commit d701667bb331 ("i2c: xiic: Do not reset controller before every > transfer") removed the reinitialization of the controller before the start > of each transfer. Apparently this change is not safe to make and the

Re: [PATCH 3/3] i2c: xiic: Replace spinlock with mutex

On Tue, Nov 17, 2015 at 10:48 AM, Shubhrajyoti Datta wrote: > On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen wrote: >> All protected sections are only called from sleep-able context, so there is >> no need to use a spinlock. > > Looks good to

Re: [PATCH 2/3] i2c: xiic: Prevent concurrent running of the IRQ handler and __xiic_start_xfer()

On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen wrote: > Prior to commit e6c9a037bc8a ("i2c: xiic: Remove the disabling of > interrupts") IRQs where disabled when the initial __xiic_start_xfer() was > called. After the commit the interrupt is enabled while the function is >

Re: [PATCH 1/3] i2c: Revert "i2c: xiic: Do not reset controller before every transfer"

On Tue, Nov 17, 2015 at 10:47 AM, Shubhrajyoti Datta wrote: > On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen wrote: >> Commit d701667bb331 ("i2c: xiic: Do not reset controller before every >> transfer") removed the reinitialization of the

Re: [PATCH v4 2/3] i2c-piix4: Add support for multiplexed main adapter in SB800

On Sun, 2015-11-15 at 12:33 +0100, Christian Fetzer wrote: > The SB800 chipset supports a multiplexed main SMBus controller with > four ports. The multiplexed ports share the same SMBus address and > register set. The port is selected by bits 2:1 of the smb_en register > (0x2C). > > Only one port

Re: [PATCH v4 0/3] Support multiplexed main SMBus interface on SB800

On Sun, 2015-11-15 at 12:33 +0100, Christian Fetzer wrote: > This is an attempt to upstream the patches created by Thomas Brandon > and > Eddi De Pieri to support the multiplexed main SMBus interface on the > SB800 > chipset. (https://www.mail-archive.com/linux-i2c@vger.kernel.org/msg0 >

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

Hi Laurent, > Sorry for bringing bad news, but as with v1, this patch breaks ADV7511 > detection on my Koelsch board. Reverting it on top of the series fixes the > problem. In v1, patch 5/9 was breaking. I hope in v2, it is 6/10 and not 5/10 as you replied to (patch 1/10 is the new one)? This

Re: [PATCH 1/3] i2c: Revert "i2c: xiic: Do not reset controller before every transfer"

On 11/17/2015 06:17 AM, Shubhrajyoti Datta wrote: > On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen wrote: >> Commit d701667bb331 ("i2c: xiic: Do not reset controller before every >> transfer") removed the reinitialization of the controller before the start >> of each

Re: [PATCH v2 05/10] i2c: rcar: refactor setup of a msg

Hi Wolfram, On Tuesday 17 November 2015 08:00:53 Wolfram Sang wrote: > Hi Laurent, > > > Sorry for bringing bad news, but as with v1, this patch breaks ADV7511 > > detection on my Koelsch board. Reverting it on top of the series fixes the > > problem. > > In v1, patch 5/9 was breaking. I hope