[PATCH V3 0/4] AT91: replace broken TWI driver i2c-at91.c

2011-11-08 Thread Nikolaus Voss
does not rely on more than one repeated start. V3: Integrated review comments from Ryan Mallon and Felipe Balbi V2: Fixed whitespace issue Nikolaus Voss (4): drivers/i2c/busses/i2c-at91.c: remove broken driver drivers/i2c/busses/i2c-at91.c: add new driver G45 TWI: remove open drain setting

[PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-08 Thread Nikolaus Voss
types. (The hardware does not support issuing arbitrary Sr conditions on the bus.) Tested on Atmel G45 with BQ20Z80 battery SMBus client. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- drivers/i2c/busses/Kconfig| 11 +- drivers/i2c/busses/i2c-at91.c | 442

[PATCH V3 4/4] Add lookup entries for twi_clk for devices with more than one TWI port

2011-11-08 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45.c |2 ++ arch/arm/mach-at91/at91sam9rl.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-at91/at91sam9g45.c b/arch/arm/mach-at91/at91sam9g45.c index e04c5fb..c985fdb

[PATCH V3 3/4] G45 TWI: remove open drain setting for twi function gpios

2011-11-08 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 files changed, 0 insertions(+), 6

[PATCH v4 0/4] AT91: replace broken TWI driver i2c-at91.c

2011-11-09 Thread Nikolaus Voss
does not rely on more than one repeated start. v4: Integrated more review comments from Ryan Mallon and Felipe Balbi: Moved register include file to local include, code cleanups v3: Integrated review comments from Ryan Mallon and Felipe Balbi v2: Fixed whitespace issue Nikolaus Voss (4

[PATCH v4 2/4] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-09 Thread Nikolaus Voss
types. (The hardware does not support issuing arbitrary Sr conditions on the bus.) Tested on Atmel G45 with BQ20Z80 battery SMBus client. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- drivers/i2c/busses/Kconfig| 11 +- drivers/i2c/busses/Makefile |1 + drivers/i2c/busses

[PATCH v4 4/4] Add lookup entries for twi_clk for devices with more than one TWI port

2011-11-09 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45.c |2 ++ arch/arm/mach-at91/at91sam9rl.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-at91/at91sam9g45.c b/arch/arm/mach-at91/at91sam9g45.c index 318b040..a374899

[PATCH v4 1/4] drivers/i2c/busses/i2c-at91.c: remove broken driver

2011-11-09 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 327 3 files changed, 0 insertions(+), 396 deletions

[PATCH v4 3/4] G45 TWI: remove open drain setting for twi function gpios

2011-11-09 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 files changed, 0 insertions(+), 6

[PATCH v5 0/4] AT91: replace broken TWI driver i2c-at91.c

2011-11-10 Thread Nikolaus Voss
, code cleanups v3: Integrated review comments from Ryan Mallon and Felipe Balbi v2: Fixed whitespace issue Nikolaus Voss (4): drivers/i2c/busses/i2c-at91.c: remove broken driver Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk drivers/i2c/busses/i2c-at91.c: add new driver

[PATCH v5 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-10 Thread Nikolaus Voss
types. (The hardware does not support issuing arbitrary Sr conditions on the bus.) Tested on Atmel G45 with BQ20Z80 battery SMBus client. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- drivers/i2c/busses/Kconfig| 11 +- drivers/i2c/busses/Makefile |1 + drivers/i2c/busses

[PATCH v5 4/4] G45 TWI: remove open drain setting for twi function gpios

2011-11-10 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 files changed, 0 insertions(+), 6

[PATCH v5 1/4] drivers/i2c/busses/i2c-at91.c: remove broken driver

2011-11-10 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 327 3 files changed, 0 insertions(+), 396 deletions

[PATCH v5 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk

2011-11-10 Thread Nikolaus Voss
The old driver used con_id clock entries. Convert to use dev_id for clock lookup via standard method. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91cap9.c|1 + arch/arm/mach-at91/at91rm9200.c |1 + arch/arm/mach-at91/at91sam9260.c |1 + arch/arm/mach

[PATCH v6 0/5] AT91: replace broken TWI driver i2c-at91.c

2011-11-18 Thread Nikolaus Voss
, cleanups v4: Integrated more review comments from Ryan Mallon and Felipe Balbi: Moved register include file to local include, code cleanups v3: Integrated review comments from Ryan Mallon and Felipe Balbi v2: Fixed whitespace issue Nikolaus Voss (5): drivers/i2c/busses/i2c-at91.c: remove

[PATCH v6 4/5] G45 TWI: remove open drain setting for twi function gpios

2011-11-18 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 files changed, 0 insertions(+), 6

[PATCH v6 5/5] i2c-at91.c: add SMBUS_READ_BLOCK_DATA functionality

2011-11-18 Thread Nikolaus Voss
SMBus emulation uses I2C_M_RECV_LEN flag to indicate a SMBus block read operation in which the length of a transfer is inicated by the first received byte. Make better use of clk_prepare()/clk_unprepare(). More sensible transfer timeout. Signed-off-by: Nikolaus Voss n.v...@weinmann.de

[PATCH v6 2/5] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk

2011-11-18 Thread Nikolaus Voss
The old driver used con_id clock entries. Convert to use dev_id for clock lookup via standard method. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91cap9.c|1 + arch/arm/mach-at91/at91rm9200.c |1 + arch/arm/mach-at91/at91sam9260.c |1 + arch/arm/mach

[PATCH v6 1/5] drivers/i2c/busses/i2c-at91.c: remove broken driver

2011-11-18 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 327 3 files changed, 0 insertions(+), 396 deletions

[PATCH v6 3/5] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-18 Thread Nikolaus Voss
types. (The hardware does not support issuing arbitrary Sr conditions on the bus.) Tested on Atmel G45 with BQ20Z80 battery SMBus client. Signed-off-by: Nikolaus Voss n.v...@weinmann.de Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/Kconfig| 11 +- drivers/i2c/busses

[PATCH v7 4/5] G45 TWI: remove open drain setting for twi function gpios

2011-11-23 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 files changed, 0 insertions(+), 6

[PATCH v7 2/5] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk

2011-11-23 Thread Nikolaus Voss
The old driver used con_id clock entries. Convert to use dev_id for clock lookup via standard method. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91cap9.c|1 + arch/arm/mach-at91/at91rm9200.c |1 + arch/arm/mach-at91/at91sam9260.c |1 + arch/arm/mach

[PATCH v7 5/5] i2c-at91.c: add SMBUS_READ_BLOCK_DATA functionality

2011-11-23 Thread Nikolaus Voss
SMBus emulation uses I2C_M_RECV_LEN flag to indicate a SMBus block read operation in which the length of a transfer is inicated by the first received byte. Make better use of clk_prepare()/clk_unprepare(). More sensible transfer timeout. Signed-off-by: Nikolaus Voss n.v...@weinmann.de

[PATCH v7 3/5] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-23 Thread Nikolaus Voss
types. (The hardware does not support issuing arbitrary Sr conditions on the bus.) Tested on Atmel G45 with BQ20Z80 battery SMBus client. Signed-off-by: Nikolaus Voss n.v...@weinmann.de Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/Kconfig| 11 +- drivers/i2c/busses

[PATCH v7 1/5] drivers/i2c/busses/i2c-at91.c: remove broken driver

2011-11-23 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 327 3 files changed, 0 insertions(+), 396 deletions

[PATCH v8 0/7] AT91: replace broken TWI driver i2c-at91.c

2011-11-28 Thread Nikolaus Voss
Nikolaus Voss (7): drivers/i2c/busses/i2c-at91.c: remove broken driver Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk drivers/i2c/busses/i2c-at91.c: add new driver G45 TWI: remove open drain setting for twi function gpios i2c-at91.c: add SMBUS_READ_BLOCK_DATA functionality

[PATCH v8 1/7] drivers/i2c/busses/i2c-at91.c: remove broken driver

2011-11-28 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 327 3 files changed, 0 insertions(+), 396 deletions

[PATCH v8 2/7] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk

2011-11-28 Thread Nikolaus Voss
The old driver used con_id clock entries. Convert to use dev_id for clock lookup via standard method. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91cap9.c|1 + arch/arm/mach-at91/at91rm9200.c |1 + arch/arm/mach-at91/at91sam9260.c |1 + arch/arm/mach

[PATCH v8 3/7] drivers/i2c/busses/i2c-at91.c: add new driver

2011-11-28 Thread Nikolaus Voss
types. (The hardware does not support issuing arbitrary Sr conditions on the bus.) Tested on Atmel G45 with BQ20Z80 battery SMBus client. Signed-off-by: Nikolaus Voss n.v...@weinmann.de Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/Kconfig| 11 +- drivers/i2c/busses

[PATCH v8 5/7] i2c-at91.c: add SMBUS_READ_BLOCK_DATA functionality

2011-11-28 Thread Nikolaus Voss
SMBus emulation uses I2C_M_RECV_LEN flag to indicate a SMBus block read operation in which the length of a transfer is inicated by the first received byte. Make better use of clk_prepare()/clk_unprepare(). More sensible transfer timeout. Signed-off-by: Nikolaus Voss n.v...@weinmann.de

[PATCH v8 6/7] i2c-at91: removed local include

2011-11-28 Thread Nikolaus Voss
Register definitions are directly placed into the driver file. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- drivers/i2c/busses/i2c-at91.c | 33 - drivers/i2c/busses/i2c-at91.h | 80 - 2 files changed, 31 insertions(+), 82

[PATCH v8 7/7] i2c-at91: make ckdiv bug a property of the platform_device

2011-11-28 Thread Nikolaus Voss
The twi IP of AT91RM9200 has a bug which limits ckdiv to be less than or equal to 5. Previously, this was checked in the driver with cpu_is_rm9200(). This patch moves this information into the platform_device as suggested by Arnd Bergmann. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch

[PATCH v9 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk

2012-03-19 Thread Nikolaus Voss
The old driver used con_id clock entries. Convert to use dev_id for clock lookup via standard method. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91cap9.c|1 + arch/arm/mach-at91/at91rm9200.c |1 + arch/arm/mach-at91/at91sam9260.c |1 + arch/arm/mach

[PATCH v9 1/4] drivers/i2c/busses/i2c-at91.c: remove broken driver

2012-03-19 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 314 3 files changed, 0 insertions(+), 383 deletions

[PATCH v9 4/4] G45 TWI: remove open drain setting for twi function gpios

2012-03-19 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 files changed, 0 insertions(+), 6

[PATCH v9 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2012-03-19 Thread Nikolaus Voss
) Signed-off-by: Nikolaus Voss n.v...@weinmann.de Reviewed-by: Felipe Balbi ba...@ti.com Tested-by: Hubert Feurstein h.feurst...@gmail.com --- arch/arm/mach-at91/at91rm9200_devices.c |9 + drivers/i2c/busses/Kconfig | 11 +- drivers/i2c/busses/Makefile |1

[PATCH v10 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk

2012-04-20 Thread Nikolaus Voss
The old driver used con_id clock entries. Convert to use dev_id for clock lookup via standard method. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91cap9.c|1 + arch/arm/mach-at91/at91rm9200.c |1 + arch/arm/mach-at91/at91sam9260.c |1 + arch/arm/mach

[PATCH v10 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2012-04-20 Thread Nikolaus Voss
) Signed-off-by: Nikolaus Voss n.v...@weinmann.de Reviewed-by: Felipe Balbi ba...@ti.com Tested-by: Hubert Feurstein h.feurst...@gmail.com --- v10: - applied fix for RXRDY overrun bug submitted by Hubert Feurstein - applied fix for calculating twi_clk v9: - merge i2c-at91.c patches to single

[PATCH v10 4/4] G45 TWI: remove open drain setting for twi function gpios

2012-04-20 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 files changed, 0 insertions(+), 6

[PATCH v10 1/4] drivers/i2c/busses/i2c-at91.c: remove broken driver

2012-04-20 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 314 3 files changed, 0 insertions(+), 383 deletions

[PATCH v10 0/4] AT91: replace broken TWI driver i2c-at91.c

2012-04-20 Thread Nikolaus Voss
does not rely on more than one repeated start. Signed-off-by: Nikolaus Voss n.v...@weinmann.de Reviewed-by: Felipe Balbi ba...@ti.com Tested-by: Hubert Feurstein h.feurst...@gmail.com v10: - applied fix for RXRDY overrun bug submitted by Hubert Feurstein - applied fix for calculating twi_clk

Re: [PATCH v10 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2012-04-26 Thread Nikolaus Voss
Hi Carsten, On Wed, 25 Apr 2012, Carsten Behling wrote: I cannot find the fix for the RXRDY overrun bug in this patch: The fix refers to the bug when RXRDY flag was masked out by TXCOMP, reported by Hubert. I hope this is fixed with v10. [...] here you only report the status flags after a

[PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios

2012-08-22 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 file changed, 6 deletions(-) diff

[PATCH v11 1/4] drivers/i2c/busses/i2c-at91.c: remove old polling driver

2012-08-22 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 314 3 files changed, 383 deletions(-) delete mode 100644

[PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2012-08-22 Thread Nikolaus Voss
) Signed-off-by: Nikolaus Voss n.v...@weinmann.de Reviewed-by: Felipe Balbi ba...@ti.com Tested-by: Hubert Feurstein h.feurst...@gmail.com v11: - fix for flags persistency suggested by Carsten Behling - calc_twi_clock fix for sam9261 by Ludovic Desroches v10: - applied fix for RXRDY overrun bug

[PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver

2012-08-22 Thread Nikolaus Voss
does not rely on more than one repeated start. Changes since v10: - fix for flags persistency suggested and tested by Carsten Behling - clk_lookup.dev_id entries for at91sam9x5 - calc_twi_clock fix for sam9261 by Ludovic Desroches Nikolaus Voss (4): drivers/i2c/busses/i2c-at91.c: remove old

[PATCH v11 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk

2012-08-22 Thread Nikolaus Voss
The old driver used con_id clock entries. Convert to use dev_id for clock lookup via standard method. Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91rm9200.c |1 + arch/arm/mach-at91/at91sam9260.c |1 + arch/arm/mach-at91/at91sam9261.c |1 + arch/arm/mach

[PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver

2012-08-29 Thread Nikolaus Voss
does not rely on more than one repeated start. Changes since v11: - corrected wrong id_entry on sam9261 twi gpio pdev Nikolaus Voss (4): drivers/i2c/busses/i2c-at91.c: remove old polling driver Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk drivers/i2c/busses/i2c-at91.c

[PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios

2012-08-29 Thread Nikolaus Voss
The G45 datasheets explicitly states that setting the open drain property on peripheral function gpios is not allowed. (How about other A91 chips?) Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/at91sam9g45_devices.c |6 -- 1 file changed, 6 deletions(-) diff

[PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2012-08-29 Thread Nikolaus Voss
) Signed-off-by: Nikolaus Voss n.v...@weinmann.de Reviewed-by: Felipe Balbi ba...@ti.com Tested-by: Hubert Feurstein h.feurst...@gmail.com v12: - corrected wrong id_entry on sam9261 twi gpio pdev v11: - fix for flags persistency suggested by Carsten Behling - calc_twi_clock fix for sam9261

[PATCH v11 1/4] drivers/i2c/busses/i2c-at91.c: remove old polling driver

2012-08-29 Thread Nikolaus Voss
Signed-off-by: Nikolaus Voss n.v...@weinmann.de --- arch/arm/mach-at91/include/mach/at91_twi.h | 68 -- drivers/i2c/busses/Makefile|1 - drivers/i2c/busses/i2c-at91.c | 314 3 files changed, 383 deletions(-) delete mode 100644