On Mon, Jan 19, 2015 at 05:22:55PM +0100, Wolfram Sang wrote:
From: Wolfram Sang wsa+rene...@sang-engineering.com
Due to a copypaste error, the last byte of the shared memory was not
accessible via sysfs.
Reported-by: Debora Grosse deb...@mds.com
Signed-off-by: Wolfram Sang wsa+rene
On Thu, Jan 22, 2015 at 07:28:21PM +0100, Peter Korsgaard wrote:
Wolfram == Wolfram Sang w...@the-dreams.de writes:
The clock here is not the i2c bus clock, but the clock input of the
Yes, what I would expect from a clk-property :)
controller. The function ocores_init initializes
On Thu, Jan 15, 2015 at 08:33:18PM +0200, Pantelis Antoniou wrote:
Mark (and unmark) device nodes with the POPULATE flag as appropriate.
This is required to avoid multi probing when using I2C and device
overlays containing a mux.
This patch is also more careful with the release of the adapter
The clock here is not the i2c bus clock, but the clock input of the
Yes, what I would expect from a clk-property :)
controller. The function ocores_init initializes the prescaler register of
the controller so that the bus clock equals 100kHz (internal clock
runs at 500kHz):
@@ -320,9 +322,23 @@ static int ocores_i2c_of_probe(struct platform_device
*pdev,
}
if (of_property_read_u32(np, clock-frequency, val)) {
- dev_err(pdev-dev,
- Missing required parameter 'clock-frequency'\n);
- return -ENODEV;
+
- (pdata pdata-modes[num].deselect_on_exit)
+ (idle_disconnect_pd || idle_disconnect_dt)
I like that. Very readable.
I don't like the buildlog, however:
drivers/i2c/muxes/i2c-mux-pca954x.c: In function 'pca954x_probe':
On Thu, Jan 22, 2015 at 08:58:36AM -0600, Rob Herring wrote:
On Thu, Jan 22, 2015 at 8:48 AM, Wolfram Sang w...@the-dreams.de wrote:
On Thu, Jan 15, 2015 at 08:33:18PM +0200, Pantelis Antoniou wrote:
Mark (and unmark) device nodes with the POPULATE flag as appropriate.
This is required
On Thu, Jan 22, 2015 at 04:17:29PM +0100, Philipp Zabel wrote:
This patch fixes up some whitespace issues and addresses a few
checkpatch warnings.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Fugang Duan b38...@freescale.com
Applied to for-next, thanks!
signature.asc
On Wed, Jan 14, 2015 at 03:14:07PM +0100, Wolfram Sang wrote:
On Tue, Jan 06, 2015 at 03:48:19PM +0100, Philipp Zabel wrote:
If the i2c device tree nodes don't contain the dmas and dma-names property,
an
error is displayed for each i2c device:
of_dma_request_slave_channel: dma
On Thu, Jan 22, 2015 at 11:53:51PM +0300, Max Filippov wrote:
On Thu, Jan 22, 2015 at 10:26 PM, Wolfram Sang w...@the-dreams.de wrote:
On Thu, Jan 22, 2015 at 10:15:40PM +0300, Max Filippov wrote:
On Thu, Jan 22, 2015 at 9:57 PM, Wolfram Sang w...@the-dreams.de wrote:
My suggestion
Since you're doing this rework, could you remove moorestown for good?
It's no longer supported as one of intel mid's platform anyway.
If support for that platform is not broken anyhow, I'd say let's keep
it. There still might be users out there...
signature.asc
Description: Digital
On Thu, Jan 22, 2015 at 10:15:40PM +0300, Max Filippov wrote:
On Thu, Jan 22, 2015 at 9:57 PM, Wolfram Sang w...@the-dreams.de wrote:
My suggestion is:
1) if there is a clk node:
- we get the clock rate via clock framework
- clock-frequency is describing the bus speed
On Thu, Jan 22, 2015 at 11:36:25PM +0300, Max Filippov wrote:
On Thu, Jan 22, 2015 at 9:57 PM, Wolfram Sang w...@the-dreams.de wrote:
2?) a new binding is present to specify the IP clock speed:
- is this needed? is somebody using the driver without CCF?
- if so, the new
+ struct i2c_adapter_quirks *quirks;
};
#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)
I suggest to add const.
const struct i2c_adapter_quirks *quirks;
also, in i2c-core.c, should modify:
const struct i2c_adapter_quirks *q = adap-quirks;
Hi,
This can describe the behavior of our current upstream driver[1], which
only support combine write-then-read.
After checking with Xudong HW guys, it seems our HW can do more.
On MT8135, it can support at most 2 messages, no matter read or write,
with the limitation that the length of
Having the maintainer on CC helps to see i2c-tools related messages in
the bulk of messages for the Linux kernel I2C subsystem.
Signed-off-by: Wolfram Sang w...@the-dreams.de
Cc: Jean Delvare jdelv...@suse.de
---
README | 2 ++
1 file changed, 2 insertions(+)
diff --git a/README b/README
index
Good idea, I have applied a similar change also explicitly requesting
that I am Cc'd.
Great, thanks!
signature.asc
Description: Digital signature
From: Wolfram Sang wsa+rene...@sang-engineering.com
Due to a copypaste error, the last byte of the shared memory was not
accessible via sysfs.
Reported-by: Debora Grosse deb...@mds.com
Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com
---
drivers/i2c/i2c-slave-eeprom.c | 4 ++--
1
On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote:
Hello,
On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote:
On 01/17/15 00:42, Ray Jui wrote:
[...]
+/*
+ * Can be expanded in the future if more interrupt status bits are
utilized
+ */
+#define
On Sun, Jan 18, 2015 at 12:17:59PM +0100, Uwe Kleine-König wrote:
Hello Wolfram,
On Sun, Jan 18, 2015 at 12:06:58PM +0100, Wolfram Sang wrote:
On Sun, Jan 18, 2015 at 10:47:41AM +0100, Uwe Kleine-König wrote:
On Sun, Jan 18, 2015 at 10:14:04AM +0100, Arend van Spriel wrote:
On 01/17
On Thu, Jan 15, 2015 at 04:54:14PM +0200, Laurent Pinchart wrote:
DT nodes should use the more specific adi,adxl345 and adi,adxl346
compatible values instead. As the ADXL346 is backward-compatible with
the ADXL345, ADXL346 nodes must list both adi,adxl346 and adi,adxl345,
in that order.
On Thu, Jan 15, 2015 at 06:32:31PM +0100, Geert Uytterhoeven wrote:
On Thu, Jan 15, 2015 at 6:02 PM, Wolfram Sang w...@the-dreams.de wrote:
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -18,8 +18,7 @@ adi
is
backward-compatible with the ADXL345 with differences handled by runtime
detection of the device model.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Reviewed-by: Wolfram Sang wsa+rene...@sang-engineering.com
signature.asc
Description: Digital signature
On Thu, Jan 15, 2015 at 06:33:55PM +0200, Pantelis Antoniou wrote:
Mark (and unmark) device nodes with the POPULATE flag as appropriate.
This is required to avoid multi probing when using I2C and device
overlays containing a mux.
This patch is also more careful with the release of the adapter
On Thu, Dec 18, 2014 at 02:49:28PM +0200, Laurent Pinchart wrote:
Hi Wolfram,
On Thursday 18 December 2014 09:21:51 Wolfram Sang wrote:
On Thu, Dec 18, 2014 at 04:15:23AM +0200, Laurent Pinchart wrote:
The I2C subsystem can match devices without explicit OF support based on
the part
+ case M_CMD_STATUS_LOST_ARB:
+ dev_err(dev-device, lost bus arbitration\n);
I wouldn't dev_err that, only dev_dbg. I'm not sure how usual the errors
for the next two cases is, maybe degrade them to dev_dbg, too?
These errors are rare, and it's nice to keep them at the
+ iproc_i2c-msg = msg;
Can it happen that iproc_i2c-msg still holds an uncompleted message
here or is this serialized by the core? Wolfram? Either here something
We have per-adapter locks serializing transfers, if you mean that?
+static int bcm_iproc_i2c_cfg_speed(struct
On Fri, Dec 19, 2014 at 06:00:10PM +0100, Alexander Sverdlin wrote:
of: i2c: Add idle-disconnect DT property to PCA954x mux driver
Add idle-disconnect device tree property to PCA954x mux driver. The new
property
forces the multiplexer to disconnect child buses in idle state. This is used,
On Thu, Jan 15, 2015 at 02:09:09PM +0100, Alexander Sverdlin wrote:
Hi Wolfram!
On 15/01/15 13:32, ext Wolfram Sang wrote:
On Fri, Dec 19, 2014 at 06:00:10PM +0100, Alexander Sverdlin wrote:
of: i2c: Add idle-disconnect DT property to PCA954x mux driver
Add idle-disconnect device tree
Been there, got bitten. We only found out too late, because one driver
was in i2c and the other in GPIO (or LED even?), both using 953x :(
That seems like a development, review and/or merge process failure to me, I
wouldn't avoid generic compatible strings for that reason only.
On Tue, Jan 06, 2015 at 03:48:20PM +0100, Philipp Zabel wrote:
The ret variable is set and never used in the error path of
i2c_imx_dma_request.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Applied to for-next, thanks!
signature.asc
Description: Digital signature
On Tue, Jan 06, 2015 at 03:48:21PM +0100, Philipp Zabel wrote:
This patch fixes up some whitespace issues and addresses a few
checkpatch warnings.
Well, since you asked for it... I am not so strict with the 80 char
limit:
@@ -527,8 +528,10 @@ static int i2c_imx_start(struct imx_i2c_struct
On Wed, Jan 14, 2015 at 12:04:59AM +0530, Harini Katakam wrote:
Cadence I2C controller has the following bugs:
- completion indication is not given to the driver at the end of
a read/receive transfer with HOLD bit set.
- Invalid read transaction are generated on the bus when HW timeout
On Mon, Dec 29, 2014 at 03:48:48PM +0200, Mika Westerberg wrote:
ACPI specification allows I2C devices with multiple addresses. The current
implementation goes over all addresses and assigns the last one to the
device. This is typically not the primary address of the device.
Instead of doing
On Tue, Jan 06, 2015 at 03:48:19PM +0100, Philipp Zabel wrote:
If the i2c device tree nodes don't contain the dmas and dma-names property, an
error is displayed for each i2c device:
of_dma_request_slave_channel: dma-names property of node
'/soc/aips-bus@0210/i2c@021a' missing or
On Thu, Dec 11, 2014 at 02:26:41PM +0800, Jisheng Zhang wrote:
readl/writel is too expensive especially on Cortex A9 w/ outer L2 cache.
This introduces i2c read/write errors on Marvell BG2/BG2Q SoCs when there
are heavy L2 cache maintenance operations at the same time.
Reading this again, I
@@ -541,6 +541,18 @@ static int cdns_i2c_master_xfer(struct i2c_adapter
*adap, struct i2c_msg *msgs,
* processed with a repeated start.
*/
if (num 1) {
+ /*
+ * This controller does not give completion interrupt after a
+ * master
On Thu, Dec 11, 2014 at 07:02:40PM +0800, Addy Ke wrote:
The number of clock cycles to be written into the CLKDIV register
that determines the I2C clk high phase includes the rise time.
So to meet the timing requirements defined in the I2C specification
which defines the minimal time SCL has
On Thu, Jan 08, 2015 at 08:19:00PM +0100, Wolfram Sang wrote:
CPPCHECK rightfully says:
drivers/i2c/busses/i2c-pmcmsp.c:151: style: The function
'pmcmsptwi_reg_to_clock' is never used.
Signed-off-by: Wolfram Sang w...@the-dreams.de
Applied to for-next, thanks!
signature.asc
Hi Dave,
Timely reply. Around i2c_dw_init(), yes. I just discovered this as the source
of a recent hang that's occuring in the loop in __i2c_dw_enable().
The hange occurs very infrequently and only, so far, when not built in. A
block around i2c_dw_disable_int() would make sense as well as a
On Wed, Dec 03, 2014 at 06:33:57PM +0400, Alexander Kochetkov wrote:
This pacth series intended for fixing problem reported
by Tony Lindgren t...@atomide.com here[1]
One of first four patched could fix the problem.
Last patch provide event trace so I could resolve problem.
It could be
On Sun, Nov 30, 2014 at 01:00:01AM +0400, Alexander Kochetkov wrote:
The first patch fix i2c-omap driver for omap2420, found by code review and
later reported by Tony Lindgren t...@atomide.com here[1].
Candidate for stable?
The second patch unhide the reson of system lockup.
The patch is
On Tue, Dec 09, 2014 at 12:22:47PM +0100, Geert Uytterhoeven wrote:
This allows checkpatch to validate more DTSes.
Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be
Cc: devicet...@vger.kernel.org
Applied to for-next, thanks!
signature.asc
Description: Digital signature
On Fri, Dec 12, 2014 at 09:48:26AM +0530, Harini Katakam wrote:
The I2C controller sends a NACK to the slave when transfer size register
reaches zero, irrespective of the hold bit. So, in order to handle transfers
greater than 252 bytes, the transfer size register has to be maintained at a
On Tue, Jan 06, 2015 at 02:37:53PM +0100, Wolfram Sang wrote:
We've started upstream work for MT8173[1].
We've fixed these issues for new SoC, and we believe it is fully I2C
compatible now. We'll add mt8173 support to this driver, so this driver
will support both fully I2C compatible
On Thu, Dec 18, 2014 at 09:44:07AM -0800, Doug Anderson wrote:
On Rockchip I2C the controller drops SDA low slightly too soon to meet
the repeated start requirements.
From my own experimentation over a number of rates:
- controller appears to drop SDA at .875x (7/8) programmed clk high.
-
On Fri, Dec 19, 2014 at 10:43:15AM +0800, Jisheng Zhang wrote:
Dear all,
Is there any issue I need to resolve so that the patch can be merged?
Adding Mika to the loop. He uses the driver a lot (and knows other
people who do)...
On Wed, 10 Dec 2014 22:26:41 -0800
Jisheng Zhang
On Mon, Jan 12, 2015 at 07:01:34PM +0200, Pantelis Antoniou wrote:
Mark (and unmark) device nodes with the POPULATE flag as appropriate.
This is required to avoid multi probing when using I2C and device
overlays containing a mux.
Signed-off-by: Pantelis Antoniou
On Tue, Dec 16, 2014 at 10:19:53PM +0100, Arnaud Ebalard wrote:
This patch fixes I2C trivial-devices.txt DT documentation file to
reference isil (NASDAQ symbol and the most used prefix inside the
kernel) for Intersil.
It reverts 7c75c1d5e72b (dt-bindings: Document deprecated device
vendor
I think the quirks can describe our HW limitation without issue.
We are porting our i2c driver base on that. Will let you know the test
result.
Great news, thanks for the update :)
signature.asc
Description: Digital signature
On Mon, Jan 12, 2015 at 07:01:34PM +0200, Pantelis Antoniou wrote:
Mark (and unmark) device nodes with the POPULATE flag as appropriate.
This is required to avoid multi probing when using I2C and device
overlays containing a mux.
Signed-off-by: Pantelis Antoniou
On Sat, Dec 27, 2014 at 08:33:53AM -0500, Nicholas Mc Guire wrote:
wait_for_completion_timeout does not return negative values so
result handling here should be simplified to cover the actually
possible cases only.
patch was only compile tested for imx_v6_v7_defconfig
V2 spellchecked
On Wed, Jan 07, 2015 at 11:31:14AM +0100, Ludovic Desroches wrote:
Hi Douglas,
On Thu, Jan 01, 2015 at 01:02:13PM -0500, Douglas Gilbert wrote:
With lk 3.19.0-rc2 and a at91sam9g25 (9x5) based system I
connected a NXP SC16IS750 I2C to serial bridge. After
routing the 750's IRQ back to
On Tue, Jan 13, 2015 at 08:44:37AM -0800, Srinivas Pandruvada wrote:
On Tue, 2015-01-13 at 16:50 +0100, Wolfram Sang wrote:
On Mon, Dec 29, 2014 at 03:48:48PM +0200, Mika Westerberg wrote:
ACPI specification allows I2C devices with multiple addresses. The current
implementation goes over
I am not sure it will perfectly fit at91 quirks.
I think it does.
The hardware can handle two messages by using the internal address
feature. The internal address size is from one byte to three bytes. Then
the length of the first message is limited to three but we don't have
this
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-viperboard.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-viperboard.c
b/drivers/i2c/busses/i2c-viperboard.c
index 7533fa34d737..47e88adf2011 100644
--- a/drivers
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-cpm.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
index 2d466538b2e2..714bdc837769 100644
--- a/drivers/i2c/busses
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-pmcmsp.c | 42 -
1 file changed, 16 insertions(+), 26 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c
index 44f03eed00dd..e06efee9fa70
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-qup.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 4dad23bdffbe..fdcbdab808e9 100644
--- a/drivers/i2c/busses
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-axxia.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-axxia.c b/drivers/i2c/busses/i2c-axxia.c
index 768a598d8d03..488c5d3bf9db 100644
--- a/drivers/i2c/busses/i2c
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-at91.c | 32 +++-
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 636fd2efad88..8be7cf6e2747 100644
Let the core do the checks if HW quirks prevent a transfer. Saves code
from drivers and adds consistency.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/i2c-core.c | 53 ++
1 file changed, 53 insertions(+)
diff --git a/drivers/i2c
stabilization period for this description.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
include/linux/i2c.h | 35 +++
1 file changed, 35 insertions(+)
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index e3a1721c8354..f8a642713706 100644
--- a/include/linux
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-dln2.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-dln2.c b/drivers/i2c/busses/i2c-dln2.c
index b3fb86af4cbb..b6f9ba7eb175 100644
--- a/drivers/i2c/busses/i2c-dln2
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-powermac.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-powermac.c
b/drivers/i2c/busses/i2c-powermac.c
index 60a53c169ed2..6abcf696e359 100644
--- a/drivers/i2c
/quirks
Thanks,
Wolfram
Wolfram Sang (11):
i2c: add quirk structure to describe adapter flaws
i2c: add quirk checks to core
i2c: at91: make use of the new infrastructure for quirks
i2c: opal: make use of the new infrastructure for quirks
i2c: qup: make use of the new infrastructure
I guess this is a driver for embedded? If so, please sort it properly.
Sorry, having let this dangle for a while. I will fix up comments and submit
another version. I can move this to embedded, however Xgene is
suppose to be a server class chip.
Then simply leave it as is :)
Hi Fengguang,
It's normally private emails, except for the ones that carry patches
with them. In which case public mailing lists will also be CCed.
OK, thought so.
Is there a way to achieve this? I know that adding experimental to the
branch name will skip the testing. Is there another
On Fri, Jan 09, 2015 at 01:57:37AM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
head: b1d39af8ae21f4930854b0656aa83a83fd38049e
commit: 70181ecd2990326a91edb3dac1db4cce21e561f7 [7/11] i2c: axxia: make use
of the new infrastructure
This is odd enough, that I'd like a wider range of views on it.
Wolfram - was this the approach you had in mind?
Sorry, too busy with other stuff at this moment :(
signature.asc
Description: Digital signature
On Fri, Jan 09, 2015 at 02:02:00AM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
head: b1d39af8ae21f4930854b0656aa83a83fd38049e
commit: dfd33ddaa80259918c200cfacb9076c75cf1da82 [8/11] i2c: dln2: make use
of the new infrastructure
On Fri, Jan 09, 2015 at 02:07:53AM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
head: b1d39af8ae21f4930854b0656aa83a83fd38049e
commit: 5f7099010eda61b777ba84cf9b64dc8428846d25 [10/11] i2c: viperboard:
make use of the new
CPPCHECK rightfully says:
drivers/i2c/busses/i2c-pmcmsp.c:151: style: The function
'pmcmsptwi_reg_to_clock' is never used.
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-pmcmsp.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c
We've started upstream work for MT8173[1].
We've fixed these issues for new SoC, and we believe it is fully I2C
compatible now. We'll add mt8173 support to this driver, so this driver
will support both fully I2C compatible SoC and the current one.
From what you tell, I'd rather add the
On Tue, Dec 23, 2014 at 02:23:01PM +0100, Valentin Longchamp wrote:
Wolfgang, Scott,
Wolfram, please.
What is then the agreement here ? Add a clock-div to the device trees ? Or
do
something similar to mpc_i2c_get_sec_cfg_8xxx() ?
I think the clock-div property is better according
This guarantees it will probe after GPIOs drivers.
BTW this is not true to the best of my knowledge. It will make that
very likely but not guarantee anything. So, the race window is
smaller but it is still there. You need a proper fix anyhow.
Platforms based on devicetree won't be affected
This means there won't be any early users of the I2C platform driver in
this
scenario.
There won't be with platform as well.
Oh, OK. Then maybe you can clarify why all those i2c busses need to be
registered with initcall in the first place?
Because they want to access PMICs early
On Mon, Dec 22, 2014 at 03:15:49PM -0300, Walter Lozano wrote:
Currently, the driver is relying on a subsys_initcall() to register
the platform driver struct. This is typically done to allow early uses
of the I2C bus (for instance, I2C regulators used from early machine code).
While this
On Sun, Nov 30, 2014 at 05:52:32PM +0100, Lars-Peter Clausen wrote:
There haven't been any I2C driver that use the legacy suspend/resume
callbacks for a while now and new drivers are supposed to use PM ops. So
remove support for legacy suspend/resume for I2C drivers.
Since there aren't any
From: Wolfram Sang wsa+rene...@sang-engineering.com
Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com
Signed-off-by: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-sh_mobile.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c
b/drivers
: sh_mobile: I2C_SH_MOBILE should depend on HAS_DMA
Thomas Petazzoni (2):
i2c: mv64xxx: use BIT() macro for register value definitions
i2c: mv64xxx: rework offload support to fix several problems
Wolfram Sang (4):
i2c: sh_mobile: refactor DMA setup
i2c: sh_mobile: rework deferred
On Thu, Dec 18, 2014 at 04:15:23AM +0200, Laurent Pinchart wrote:
The I2C subsystem can match devices without explicit OF support based on
the part of their compatible property after the comma. However, this
mechanism uses the first compatible value only. For adxl34x OF device
nodes the
On Wed, Dec 17, 2014 at 09:04:52AM +0100, Geert Uytterhoeven wrote:
Hi Wolfram,
On Wed, Dec 17, 2014 at 7:58 AM, Wolfram Sang w...@the-dreams.de wrote:
On Mon, Dec 15, 2014 at 02:37:04PM +0100, Geert Uytterhoeven wrote:
If NO_DMA=y:
drivers/built-in.o: In function
If ARM and SUPERH imply HAS_DMA, that formula is almost identical to
the one I proposed in my patch?
Ehrm, true :)
depends on HAS_DMA
depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
I just prefer to split dependencies in two lines where it makes sense (hard
dependencies
On Thu, Dec 11, 2014 at 05:33:45PM +0100, Thomas Petazzoni wrote:
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
Applied to for-current, thanks!
signature.asc
Description: Digital signature
On Thu, Dec 11, 2014 at 05:33:46PM +0100, Thomas Petazzoni wrote:
Originally, the I2C controller supported by the i2c-mv64xxx driver
requires a lot of software support: an interrupt is generated at each
step of an I2C transaction (after the start bit, after sending the
address, etc.) and the
On Tue, Dec 16, 2014 at 01:31:25PM +0100, Wolfram Sang wrote:
From: Wolfram Sang wsa+rene...@sang-engineering.com
Refactor DMA setup to keep the errno so we can implement better
deferred probe support in the next step.
Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com
Applied
On Tue, Dec 16, 2014 at 01:31:26PM +0100, Wolfram Sang wrote:
From: Wolfram Sang wsa+rene...@sang-engineering.com
DMA is opt-in for this driver. So, we can't use deferred probing for
requesting DMA channels in probe, because our driver would get endlessly
deferred if DMA support is compiled
On Mon, Dec 15, 2014 at 02:37:04PM +0100, Geert Uytterhoeven wrote:
If NO_DMA=y:
drivers/built-in.o: In function `sh_mobile_i2c_dma_unmap':
i2c-sh_mobile.c:(.text+0x60de42): undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `sh_mobile_i2c_xfer_dma':
Hm, alignment style changed...
I am not too strict on that as long as the result is somewhat readable.
I'd be more interested in your thoughts about the general approach taken
in this series.
signature.asc
Description: Digital signature
On Wed, Dec 10, 2014 at 02:44:58PM +0100, Geert Uytterhoeven wrote:
Hi Wolfram,
On Wed, Dec 10, 2014 at 2:21 PM, Wolfram Sang w...@the-dreams.de wrote:
DMA is opt-in for this driver. So, we can't use deferred probing in
probe, because our driver would get endlessly deferred if DMA support
From: Wolfram Sang wsa+rene...@sang-engineering.com
DMA is opt-in for this driver. So, we can't use deferred probing for
requesting DMA channels in probe, because our driver would get endlessly
deferred if DMA support is compiled in AND the DMA driver is missing.
Because we can't know when
From: Wolfram Sang wsa+rene...@sang-engineering.com
Refactor DMA setup to keep the errno so we can implement better
deferred probe support in the next step.
Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com
---
drivers/i2c/busses/i2c-sh_mobile.c | 35
/gmane.linux.drivers.i2c/20565/focus=41758
[2] http://thread.gmane.org/gmane.linux.ports.sh.devel/41806
Wolfram Sang (2):
i2c: sh_mobile: refactor DMA setup
i2c: sh_mobile: rework deferred probing
drivers/i2c/busses/i2c-sh_mobile.c | 111 ++---
1 file changed, 53 insertions(+), 58
name to fix related warning).
Signed-off-by: Arnaud Ebalard a...@natisbad.org
Acked-by: Wolfram Sang w...@the-dreams.de
Should I take it or does it go via another tree?
signature.asc
Description: Digital signature
On Mon, Dec 15, 2014 at 02:37:04PM +0100, Geert Uytterhoeven wrote:
If NO_DMA=y:
drivers/built-in.o: In function `sh_mobile_i2c_dma_unmap':
i2c-sh_mobile.c:(.text+0x60de42): undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `sh_mobile_i2c_xfer_dma':
Please let me summarize...
Thanks for the summary, Geert!
Solutions under consideration:
1. Wolfram posted a patch to make i2c-sh_mobile fall back to PIO,
and retry DMA initialization in every request, so it will switch to
DMA when it becomes available. But this is suboptimal, as it
Quite right, this is a good question. Today we cannot distinguish between the
two. Should we improve the deferred probe to tell us when the init
is complete and all the modules have been initialized? If we ever have such
a mechanism to check then we know no modules are to be inserted then we
Hi,
please don't drop the i2c-list.
I guess you are probably extremely busy and might not have had a chance to
look into the iProc I2C driver v3 patch that was submitted on December 9.
I'm not trying to rush it, and am perfectly fine with waiting longer. I
understand subsystem maintainers
for SCCB devices
Thomas Gessler (1):
i2c: xiic: Fix big-endian register access
Wenyou Yang (3):
i2c: at91: add support for runtime PM
i2c: at91: add support for system PM
i2c: at91: adopt pinctrl support
Wolfram Sang (14):
i2c: exynos5: use proper errno for timeout
901 - 1000 of 2814 matches
Mail list logo
