> Or maybe just be a bit verbose like the original variant
> int ret;
>
> ret = device_property_read…(…);
> if (ret && use_defaults) {
> …
> }
>
> Among all variants I like the latter one here. What do you think?
I agree and fixed it like this.
signature.asc
Description: Digital signature
On Tue, Dec 08, 2015 at 10:37:44AM +0100, Wolfram Sang wrote:
> Here is a patch series adding better DT support for timing parameters like the
> raise time or the fall time which are generic for the I2C subsystem. There is
> a
> core function for parsing and an implementation for the RCar driver h
On Mon, Nov 30, 2015 at 06:53:32PM +0900, Masahiro Yamada wrote:
>
>
>
> Masahiro Yamada (4):
> i2c: uniphier: error out if clock rate is zero
> i2c: uniphier: error out if bus speed is zero
> i2c: uniphier_f: error out if clock rate is zero
> i2c: uniphier_f: error out if bus speed is z
On Sunday 13 December 2015 10:09:59 Wolfram Sang wrote:
>
> What about not ifdeffing the inline function and keep the build error
> whenever someone uses it without I2C_SLAVE being selected?
The inline function is only added there for the case that I2C_SLAVE is
disabled, so that would be pointles
> > What about not ifdeffing the inline function and keep the build error
> > whenever someone uses it without I2C_SLAVE being selected?
>
> The inline function is only added there for the case that I2C_SLAVE is
> disabled, so that would be pointless.
>
> However, what we could do is move the ex
On Monday 14 December 2015 14:52:06 Wolfram Sang wrote:
> > > What about not ifdeffing the inline function and keep the build error
> > > whenever someone uses it without I2C_SLAVE being selected?
> >
> > The inline function is only added there for the case that I2C_SLAVE is
> > disabled, so that
On Thu, 2015-10-15 at 12:54 -0700, Stephen Boyd wrote:
> On 10/14, Scott Wood wrote:
> > On Wed, 2015-10-14 at 11:31 -0700, Stephen Boyd wrote:
> > > On 10/14, Zhiqiang Hou wrote:
> > > > From: Hou Zhiqiang
> > > >
> > > > Signed-off-by: Hou Zhiqiang
> > > > ---
> > >
> > > Acked-by: Stephen Bo
Hi David:
It's better to add a cover-letter, and add changes note for new version,
such as:
changes since v0:
- split patch to two patches or more, one patch for one new feature (Heiko)
and NOT to have two same signed-off-by
在 11/12/2015 22:33, David Wu 写道:
The calc_divs of new version is dif
Hi,
I'm not sure if this has been discussed earlier. But after looking at
the the acpi_apd driver, all we need is just the platform-specific input
clock frequency value used by the
drivers/i2c/busses/i2c-designware-core.c: i2c_dw_init() to calculate the
values to program into the DW_IC_SS_SCL
On Mon, Dec 14, 2015 at 11:00:26AM +0100, Wolfram Sang wrote:
> On Tue, Dec 08, 2015 at 10:37:44AM +0100, Wolfram Sang wrote:
> > Here is a patch series adding better DT support for timing parameters like
> > the
> > raise time or the fall time which are generic for the I2C subsystem. There
> > i
For mt8173 platform with auto restart support, when doing i2c multi
transfer in high speed, we should ignore the first restart irq after
the master code, otherwise the first transfer will be discarded.
Signed-off-by: Liguo Zhang
Reviewed-by: Eddie Huang
---
Change in v3:
ignore the first restart
11 matches
Mail list logo
