[PATCH] ST DDC I2C bus driver v1

2009-05-05 Thread Linus Walleij
This adds support for the ST Microelectronic DDC I2C bus driver. This bus is used in the U300 architecture recently added to RMK:s ARM tree. (Patch based on 2.6.30-rc4.) Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/i2c/busses/Kconfig| 11 + drivers/i2c/busses

[PATCH 0/1] ST DDC I2C U300 bus driver v2

2009-05-06 Thread Linus Walleij
that zero-length messages are unsupported. * Introduced more linespacing in terse sections to ease readability. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH] Use resource_size macro

2009-05-06 Thread Linus Walleij
)/g' Then manually replacing the PXA redefiniton of the same kind of macro manually. Recompiled some ARM defconfigs I could find to make a rough test so it shouldn't break anything, though I couldn't see exactly which configs you need for all the drivers. Signed-off-by: Linus Walleij linus.wall

Re: [PATCH] Use resource_size macro

2009-05-06 Thread Linus Walleij
2009/5/6 Wolfram Sang w.s...@pengutronix.de: On Wed, May 06, 2009 at 10:28:38PM +0200, Linus Walleij wrote: From: root r...@fecusia.(none) Hello root :) Hehe, I am experimenting with using the new git-send-email script that come with newer git versions. It's great because it safely avoids

Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2

2009-05-08 Thread Linus Walleij
2009/5/6 Linus Walleij linus.ml.wall...@gmail.com: Updated patch for this driver, please tell me if it's good enough enough for mainlining now... No reply means yes I assume :-) Do I send this directly to Jean for integration? Linus -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2

2009-05-08 Thread Linus Walleij
2009/5/8 Jean Delvare kh...@linux-fr.org: No reply means yes I assume :-) Wrong assumption. No reply means we are busy. In other words: be patient. Aw sorry man. I still need to learn patience, I know. Doesn't the platform this driver is aimed at qualify as embedded? I doubt this driver

[PATCH 1/1] MFD: Add U300 AB3100 core support v2

2009-05-18 Thread Linus Walleij
, and an ALSA codec. Signed-off-by: Linus Walleij linus.wall...@stericsson.com Reviewed-by: Mike Rapoport m...@compulab.co.il Reviewed-by: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/Kconfig| 14 + drivers/mfd/Makefile |3 +- drivers/mfd/ab3100-core.c | 961

Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2

2009-05-19 Thread Linus Walleij
2009/5/12 Ben Dooks ben-li...@fluff.org: I'll be reviewing patches for the next kernel closer to the end of the week as I've still got some other arch fixing to do. I know you're busy, sorry add to that burden... Can Wolfram look at this instead perhaps? Linus -- To unsubscribe from this

[PATCH 0/1] MFD: Add U300 AB3100 core support v3

2009-05-19 Thread Linus Walleij
ChangeLog from v2 - v3: * Moved setup data to a table lookup. * Cleaned-up chip variant list. * Kerneldoc for the ab3100.h header file ab3100 struct. Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/1] MFD: Add U300 AB3100 core support v3

2009-05-20 Thread Linus Walleij
... + { + .id = 0xc8, + .name = P2B/R2B + }, doing }, { would makes these shorter still. Yeah CodingStyle actually say so if I read it closely, I'll fix. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message

[PATCH 1/1] MFD: Add U300 AB3100 core support v4

2009-05-20 Thread Linus Walleij
, and an ALSA codec. Signed-off-by: Linus Walleij linus.wall...@stericsson.com Reviewed-by: Mike Rapoport m...@compulab.co.il Reviewed-by: Samuel Ortiz sa...@linux.intel.com Reviewed-by: Ben Dooks ben-li...@fluff.org --- drivers/mfd/Kconfig| 14 + drivers/mfd/Makefile |3 +- drivers

[PATCH 0/1] ST DDC I2C U300 bus driver v3

2009-05-20 Thread Linus Walleij
with this one now Ben? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] ST DDC I2C U300 bus driver v3

2009-05-20 Thread Linus Walleij
This adds support for the ST Microelectronics DDC I2C bus driver. This bus is used in the U300 architecture recently added to RMK:s ARM tree. Signed-off-by: Linus Walleij linus.wall...@stericsson.com Reviewed-by: Ben Dooks ben-li...@fluff.org Reviewed-by: Jean Delvare kh...@linus-fr.org

Re: [PATCH 1/1] MFD: Add U300 AB3100 core support v4

2009-05-21 Thread Linus Walleij
it before I started to try to separate local accesses to the struct from accesses coming in from the outside using a singleton pattern. But no problem, I'll fix it back in the way you want it, just a minute! Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c

[PATCH 0/1] MFD: Add U300 AB3100 core support v5

2009-05-21 Thread Linus Walleij
as a pointer to a struct ab3100 * in the file private data. * Correct file permissions on write-only debugfs files. * Hoping that Sam will accept this into the -mfd tree... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message

[PATCH 1/1] MFD: Add U300 AB3100 core support v5

2009-05-21 Thread Linus Walleij
, and an ALSA codec. Signed-off-by: Linus Walleij linus.wall...@stericsson.com Reviewed-by: Mike Rapoport m...@compulab.co.il Reviewed-by: Samuel Ortiz sa...@linux.intel.com Reviewed-by: Ben Dooks ben-li...@fluff.org --- drivers/mfd/Kconfig| 14 + drivers/mfd/Makefile |3 +- drivers

Re: [PATCH 1/1] MFD: Add U300 AB3100 core support v5

2009-05-25 Thread Linus Walleij
on MFD driver style. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i2c: driver for the Synopsys DesignWare I2C controller

2009-05-28 Thread Linus Walleij
2009/5/28 Baruch Siach bar...@tkos.co.il: +static int dw_i2c_probe(struct platform_device *pdev) Can you tag this with __init? OK. __devinit is probably better. (and same for exit) Look in include/linux/init.h for the use of these macros. There are many, many erroneous drivers in the

RE: [PATCH] Use resource_size macro

2009-06-13 Thread Linus Walleij
can try to trick an SMTP engine to claim these patches were sent from that mail adress though, hang on.. Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH] Use resource_size macro

2009-06-13 Thread linus . walleij
From: Linus Walleij linus.wall...@stericsson.com This replace all instances in the i2c busses tree of res-end - res-start + 1 with the handy macro resource_size(res) from ioport.h (coming in from platform_device.h). This was created with a simple sed -i -e 's/\([a-z]*\)-end *- *[a-z]*-start

[PATCH] Make stu300 driver depend on MACH_U300

2009-06-14 Thread linus . walleij
From: Linus Walleij linus.wall...@stericsson.com This makes the stu300 driver for the ST Micro ST DDC I2C bus driver depend on MACH_U300, new platforms reusing this I2C driver will need to add in a similar dependency. Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/i2c

Re: Looking for help writing an i2c client for i2c-core

2009-06-24 Thread Linus Walleij
2009/6/23 Brian Tompson brian.tomp...@highrely.com: I am trying to write an i2c client driver for the i2c core, using the Linux Driver Model (new style driver). I don't get the whole view of what you actually want to do but you might be wanting to create a MFD multi-functional device driver.

[PATCH] I2C STU300 stability updates

2009-08-13 Thread Linus Walleij
through. Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/i2c/busses/i2c-stu300.c | 157 +++ 1 files changed, 92 insertions(+), 65 deletions(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c index 182e711

Re: [PATCH v2 2/2] i2c: Add support for Ux500/Nomadik I2C controller

2010-01-25 Thread Linus Walleij
...@stericsson.com Acked-by: Linus Walleij linus.wall...@stericsson.com It's even Reviewed-by: Linus Walleij linus.wall...@stericsson.com now that I've taken some time to do it properly. +static unsigned int nmk_i2c_functionality(struct i2c_adapter *adap); +static int nmk_i2c_xfer(struct

RE: [patch] i2c: off by one issue

2010-04-07 Thread Linus WALLEIJ
If we don't find the correct rate, we want to end the loop with i pointing to the last element in the array. Good catch! Acked-by: Linus Walleij linus.wall...@stericsson.com Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message

Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35

2010-09-01 Thread Linus Walleij
failed\n); +               return ret; +       } + +       pci_enable_wake(pdev, PCI_D3hot, 0); +       pci_disable_device(pdev); +       pci_set_power_state(pdev, pci_choose_state(pdev, state)); + +       return 0; +} Yours, Linus Walleij -- To unsubscribe from this list: send the line

RE: [PATCH v2 2/2] i2c: QUP based bus driver for Qualcomm MSM chipsets

2010-09-03 Thread Linus WALLEIJ
[Kenneth] From: Kenneth Heitke [mailto:khei...@codeaurora.org] Subject: [PATCH v2 2/2] i2c: QUP based bus driver for Qualcomm MSM chipsets (...) + dev-one_bit_t = USEC_PER_SEC/pdata-bus_freq; Maybe you want to use DIV_ROUND_UP() from kernel.h here to be on the safe side? Yours, Linus

[PATCH] I2C: various updates to the Nomadik I2C controller

2010-09-09 Thread Linus Walleij
on the controller. - Minor coding style and kerneldoc updates. Acked-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Sundar R Iyer sundar.i...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/i2c/busses/i2c-nomadik.c | 36

[PATCH 1/4] i2c-nomadik: documentation fixes

2010-09-23 Thread Linus Walleij
This fixes some kerneldoc and assorted documenatation in the Nomadik I2C driver without semantic impact. Acked-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Sundar R Iyer sundar.i...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/i2c

[PATCH 3/4] i2c-nomadik: support smbus emulation

2010-09-23 Thread Linus Walleij
We can do smbus emulation so flag this and drop the duplicate flags implied from smbus emulation. Acked-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Sundar R Iyer sundar.i...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/i2c/busses

[PATCH 4/4] i2c-nomadik: fixup bus delays

2010-09-23 Thread Linus Walleij
We were missing a transfer delay in one execution path leading to hangs and the bus timeout was too low leading to errors under stress tests. Acked-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Sundar R Iyer sundar.i...@stericsson.com Signed-off-by: Linus Walleij linus.wall

Re: [PATCH] I2C: various updates to the Nomadik I2C controller

2010-09-23 Thread Linus Walleij
2010/9/22 Ben Dooks ben-...@fluff.org: On Thu, Sep 09, 2010 at 02:29:32PM +0200, Linus Walleij wrote: This applies a few fixes and improvements to the Nomadik I2C controller: I would prefer to see these as seperate patches, so that people can see what is going on and you can test each

Re: [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization

2010-09-23 Thread Linus Walleij
of problem. Makes me think of crazy things like putting a lightweight version of Lennars Pötterings systemd scheme into the kernel for resolving these initcalls. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord

Re: [PATCH 1/4] i2c-nomadik: documentation fixes

2010-09-27 Thread Linus Walleij
2010/9/27 Ben Dooks ben-...@fluff.org: On Thu, Sep 23, 2010 at 09:03:40AM +0200, Linus Walleij wrote: This fixes some kerneldoc and assorted documenatation in the Nomadik I2C driver without semantic impact. Acked-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Sundar R

Re: [PATCH 3/4] i2c-nomadik: support smbus emulation

2010-09-27 Thread Linus Walleij
2010/9/24 Shinya Kuribayashi shinya.kuribayashi...@renesas.com: On 9/23/2010 4:04 PM, Linus Walleij wrote: We can do smbus emulation so flag this and drop the duplicate flags implied from smbus emulation. @@ -803,10 +803,7 @@ static irqreturn_t i2c_irq_handler(int irq, void *arg)  static

Re: [PATCH 1/4] i2c-nomadik: documentation fixes

2010-09-28 Thread Linus Walleij
been helpful to add a 'From:' line as well, git can be made to re-write the authour of a patch, but you'll have to search for it. Please find a method for future reference. I'm on it... thanks Ben. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c

Re: [PATCH 0/4] Led driver support for LP5521 and LP5523 chips

2010-09-28 Thread Linus Walleij
update the driver based on other comments and send v2 patch set. We (ST-Ericsson) need this driver in as well. If Richard is busy maybe Andrew can pick it up for the time being? Looking forward to the v2 version! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/4] i2c-nomadik: documentation fixes

2010-09-29 Thread Linus Walleij
on the From: if you like. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv4 1/5] misc: Driver for bh1770glc / sfh7770 ALS and proximity sensor

2010-10-26 Thread Linus Walleij
. Of course I can send a patch for this later, but I'd like to hear whether you agree on this or not. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36

2010-10-27 Thread Linus Walleij
2010/10/26 Jean Delvare kh...@linux-fr.org: On Tue, 26 Oct 2010 18:47:37 +0900, Tomoya MORINAGA wrote: Must we get Intel's signature ? We have already got the following. Isn't  this enough ? Reviewed-by: Linus Walleij linus.wall...@stericsson.com Though I haven't heard like the requirement

Re: [PATCH] dw_spi: add DMA support

2010-11-22 Thread Linus Walleij
challenge you to fix drivers/dma/dw_dmac.c or wherever the real problem sits. Can you describe where the problem with fixing this to use real slave sglists is? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org

[PATCH] i2c-nomadik: fix regression on adapter name

2010-11-29 Thread Linus Walleij
-fr.org Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/i2c/busses/i2c-nomadik.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index c9fffd0..f34a276 100644 --- a/drivers/i2c/busses/i2c

Re: platform/i2c busses: pm runtime and system sleep

2011-02-19 Thread Linus Walleij
of these problems are solved by elegance if we use runtime PM, since it will provide a hysteresis timeout that can be triggered from interrupt context and call the idling hooks in process context. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

[PATCH 00/13] Various updates to the Nomadik I2C controller

2011-05-09 Thread Linus Walleij
shall go into my ux500 tree, it is not required for the driver to function, so the rest of the patches can be applied to the I2C tree without causing any problems with the platforms using the driver. Jonas Aberg (1): i2c/i2c-nomadik: add regulator support Linus Walleij (2): i2c/i2c-nomadik: fix

[PATCH 05/13] i2c/i2c-nomadik: remove the redundant error message

2011-05-09 Thread Linus Walleij
From: srinidhi kasagar srinidhi.kasa...@stericsson.com The abort cause string itself is an error, so remove the redundant explicit error message. Signed-off-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Reviewed-by: Jonas Aberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij

[PATCH 04/13] i2c/i2c-nomadik: corrrect returned error numbers

2011-05-09 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 3bf95b9..a02141a 100644 --- a/drivers/i2c/busses/i2c-nomadik.c

[PATCH 10/13] i2c/i2c-nomadik: change the TX and RX threshold

2011-05-09 Thread Linus Walleij
...@stericsson.com Reviewed-by: Jonas Aberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 39 + 1 files changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH 08/13] i2c/i2c-nomadik: use pm_runtime API

2011-05-09 Thread Linus Walleij
From: Rabin Vincent rabin.vinc...@stericsson.com Use the pm_runtime API for pins control. Signed-off-by: Rabin Vincent rabin.vinc...@stericsson.com Reviewed-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Reviewed-by: Jonas Aberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij

[PATCH 12/13] i2c/i2c-nomadik: reset the hw after status check

2011-05-09 Thread Linus Walleij
...@stericsson.com Reviewed-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses

[PATCH 09/13] i2c/i2c-nomadik: add code to retry on timeout failure

2011-05-09 Thread Linus Walleij
Sadashivpetimath virupax.sadashivpetim...@stericsson.com Reviewed-by: Jonas ABERG jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 97 +++--- 1 files changed, 49 insertions(+), 48 deletions(-) diff --git

[PATCH 07/13] i2c/i2c-nomadik: print abort cause only on abort tag

2011-05-09 Thread Linus Walleij
virupax.sadashivpetim...@stericsson.com Reviewed-by: Jonas Aberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 27 +++ 1 files changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b

[PATCH 11/13] i2c/i2c-nomadik: remove the unnecessary delay

2011-05-09 Thread Linus Walleij
per.xb.pers...@stericsson.com Tested-by: Chethan Krishna N chethan.kris...@stericsson.com Reviewed-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 20 ++-- 1 files changed, 2 insertions

[PATCH 06/13] i2c/i2c-nomadik: correct adapter timeout initialization

2011-05-09 Thread Linus Walleij
Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index dbd93b2..28389c2

Re: [PATCH 08/13] i2c/i2c-nomadik: use pm_runtime API

2011-05-11 Thread Linus Walleij
2011/5/11 Rabin Vincent ra...@rab.in: On Wed, May 11, 2011 at 03:49, Ben Dooks ben-...@fluff.org wrote: On Mon, May 09, 2011 at 11:37:57PM +0200, Linus Walleij wrote: +     /* +      * During system suspend, runtime suspend transitions are disabled. +      * This check and direct call

Re: [PATCH 09/13] i2c/i2c-nomadik: add code to retry on timeout failure

2011-05-13 Thread Linus Walleij
message transfer. Will repost this now including deletion of the runtime PM quirks. Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 00/14] Various updates to the Nomadik I2C controller v2

2011-05-13 Thread Linus Walleij
won't be changing much stuff in the ux500 in this merge window due to kernel consolidations taking place. Jonas Aberg (1): i2c/i2c-nomadik: add regulator support Linus Walleij (3): i2c/i2c-nomadik: fix speed enumerator i2c/i2c-nomadik: break out single messsage transmission mach-ux500: set

[PATCH 06/14] i2c/i2c-nomadik: correct adapter timeout initialization

2011-05-13 Thread Linus Walleij
Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index dbd93b2..28389c2

[PATCH 04/14] i2c/i2c-nomadik: corrrect returned error numbers

2011-05-13 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 3bf95b9..a02141a 100644 --- a/drivers/i2c/busses/i2c-nomadik.c

[PATCH 09/14] i2c/i2c-nomadik: add code to retry on timeout failure

2011-05-13 Thread Linus Walleij
Sadashivpetimath virupax.sadashivpetim...@stericsson.com Reviewed-by: Jonas ABERG jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 97 +++--- 1 files changed, 49 insertions(+), 48 deletions(-) diff --git

[PATCH 08/14] i2c/i2c-nomadik: use pm_runtime API

2011-05-13 Thread Linus Walleij
code] Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 37 +++-- 1 files changed, 31 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index c8bf81a..234e4a9

[PATCH 02/14] i2c/i2c-nomadik: make i2c timeout specific per i2c bus

2011-05-13 Thread Linus Walleij
Reviewed-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/plat-nomadik/include/plat/i2c.h |6 -- drivers/i2c/busses/i2c-nomadik.c | 10 -- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 03/14] i2c/i2c-nomadik: fix speed enumerator

2011-05-13 Thread Linus Walleij
The I2C speed enumerators in the i2c-nomadik header file were in the wrong order. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/plat-nomadik/include/plat/i2c.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-nomadik/include/plat/i2c.h

[PATCH 05/14] i2c/i2c-nomadik: remove the redundant error message

2011-05-13 Thread Linus Walleij
From: srinidhi kasagar srinidhi.kasa...@stericsson.com The abort cause string itself is an error, so remove the redundant explicit error message. Signed-off-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Reviewed-by: Jonas Aberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij

[PATCH 10/14] i2c/i2c-nomadik: change the TX and RX threshold

2011-05-13 Thread Linus Walleij
...@stericsson.com Reviewed-by: Jonas Aberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 39 + 1 files changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH 14/14] mach-ux500: set proper I2C platform data from MOP500s

2011-05-13 Thread Linus Walleij
This specifies the new per-platform timeout per I2C bus and switches the I2C buses to fast mode, and increase the FIFO depth to 8 for reads and writes. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/mach-ux500/board-mop500.c | 14 -- 1 files changed, 8

[PATCH 11/14] i2c/i2c-nomadik: remove the unnecessary delay

2011-05-13 Thread Linus Walleij
per.xb.pers...@stericsson.com Tested-by: Chethan Krishna N chethan.kris...@stericsson.com Reviewed-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 20 ++-- 1 files changed, 2 insertions

[PATCH 12/14] i2c/i2c-nomadik: reset the hw after status check

2011-05-13 Thread Linus Walleij
...@stericsson.com Reviewed-by: Srinidhi Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses

[PATCH 13/14] i2c/i2c-nomadik: break out single messsage transmission

2011-05-13 Thread Linus Walleij
Reduce code size in the message transfer function by factoring out a single-message transfer function. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 80 +++--- 1 files changed, 48 insertions(+), 32 deletions

[PATCH] i2c-nomadik: fix kerneldoc warning

2011-06-15 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org There was a missing struct item in the kerneldoc, add it and fix another pretty-printing formatting issue with a missing space. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |3 ++- 1 files changed, 2

[PATCH 0/2] nomadik-i2c fixes for v3.1

2011-06-28 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This is a resend of the pending patches for i2c-nomadik that should apply cleanly on 3.0-rc4. Linus Walleij (1): i2c-nomadik: fix kerneldoc warning srinidhi kasagar (1): i2c-nomadik: Do not use _interruptible_ variant call drivers/i2c/busses

[PATCH 2/2] i2c-nomadik: fix kerneldoc warning

2011-06-28 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org There was a missing struct item in the kerneldoc, add it and fix another pretty-printing formatting issue with a missing space. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |3 ++- 1 files changed, 2

[PATCH 1/2] i2c-nomadik: Do not use _interruptible_ variant call

2011-06-28 Thread Linus Walleij
Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 0c731ca..f9b8854

[PATCH 1/2] i2c-nomadik: Do not use _interruptible_ variant call

2011-08-09 Thread Linus Walleij
Kasagar srinidhi.kasa...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 0c731ca..f9b8854

[PATCH 2/2] i2c-nomadik: fix kerneldoc warning

2011-08-09 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org There was a missing struct item in the kerneldoc, add it and fix another pretty-printing formatting issue with a missing space. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |3 ++- 1 files changed, 2

[PATCH 0/2] lost i2c-nomadik patches

2011-08-09 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org These two must have been missed somewhere between the last merge window and 3.1-rc1. If you think they are -rc material then by all means please merge them, else we'll wait for the next merge window... Linus Walleij (1): i2c-nomadik: fix kerneldoc

Re: [PATCH 0/2] lost i2c-nomadik patches

2011-08-23 Thread Linus Walleij
On Fri, Aug 12, 2011 at 2:46 AM, Ben Dooks ben-...@fluff.org wrote: On Tue, Aug 09, 2011 at 08:17:08PM +0200, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org These two must have been missed somewhere between the last merge window and 3.1-rc1. If you think they are -rc

Re: [PATCH 36/62] i2c: irq: Remove IRQF_DISABLED

2011-09-11 Thread Linus Walleij
On Wed, Sep 7, 2011 at 10:10 AM, Yong Zhang yong.zha...@gmail.com wrote: This flag is a NOOP and can be removed now. Signed-off-by: Yong Zhang yong.zha...@gmail.com Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line

[PATCH 1/2] i2c/nomadik: cosmetic coding style corrections

2011-10-20 Thread Linus Walleij
From: Jonas Aaberg jonas.ab...@stericsson.com This fixes a number of whitespace and punctuation problems around the Nomadik I2C driver. Signed-off-by: Jonas Aaberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c | 89

[PATCH 2/2] i2c/nomadik: runtime PM support

2011-10-20 Thread Linus Walleij
From: Jonas Aaberg jonas.ab...@stericsson.com Turn off the clock and regulator to the I2C block using runtime PM. Cc: Magnus Damm magnus.d...@gmail.com Cc: Rafael J. Wysocki r...@sisk.pl Signed-off-by: Jonas Aaberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org

Re: [PATCH 2/2] i2c/nomadik: runtime PM support

2011-10-21 Thread Linus Walleij
On Thu, Oct 20, 2011 at 6:44 PM, Magnus Damm magnus.d...@gmail.com wrote: On Fri, Oct 21, 2011 at 1:23 AM, Linus Walleij linus.wall...@stericsson.com wrote: From: Jonas Aaberg jonas.ab...@stericsson.com ... +static int nmk_i2c_runtime_suspend(struct device *dev) +{ +       clk_disable

Re: [PATCH 2/2] i2c/nomadik: runtime PM support

2011-10-24 Thread Linus Walleij
On Mon, Oct 24, 2011 at 4:32 PM, Magnus Damm magnus.d...@gmail.com wrote: On Fri, Oct 21, 2011 at 8:19 PM, Linus Walleij linus.wall...@linaro.org wrote: Currently we have something similar for the AMBA bus here, since it actually has code in place to grab the block clock on probe() and its

Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-07 Thread Linus Walleij
Walleij linus.wall...@linaro.org I'd ask Grant to take this into the GPIO tree if Broonie can ACK it. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-08 Thread Linus Walleij
On Thu, Mar 8, 2012 at 8:41 AM, Wolfram Sang w.s...@pengutronix.de wrote: Acked-by: Linus Walleij linus.wall...@linaro.org I'd ask Grant to take this into the GPIO tree if Broonie can ACK it. Uhm, why? What's wrong with going in via I2C? So it can be merged without bisect regressions

[PATCH RESEND] i2c/nomadik: runtime PM support

2012-03-08 Thread Linus Walleij
Signed-off-by: Linus Walleij linus.wall...@linaro.org --- So I'm resending this, after discussion with Mark Brown and others I can only conclude that the question of whether to handle clocks and/or regulators centrally in say drivers/base/power/clock_ops.c or distributed in drivers is not simple

Re: [PATCH RESEND] i2c/nomadik: runtime PM support

2012-03-19 Thread Linus Walleij
On Thu, Mar 8, 2012 at 2:30 PM, Linus Walleij linus.wall...@stericsson.com wrote: From: Jonas Aaberg jonas.ab...@stericsson.com Turn off the clock and regulator to the I2C block using runtime PM. Cc: Magnus Damm magnus.d...@gmail.com Cc: Rafael J. Wysocki r...@sisk.pl Cc: Mark Brown broo

Re: [PATCH RESEND] i2c/nomadik: runtime PM support

2012-03-19 Thread Linus Walleij
On Mon, Mar 19, 2012 at 12:35 PM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Mar 8, 2012 at 2:30 PM, Linus Walleij linus.wall...@stericsson.com wrote: From: Jonas Aaberg jonas.ab...@stericsson.com Turn off the clock and regulator to the I2C block using runtime PM. Cc: Magnus

Re: [PATCH RESEND] i2c/nomadik: runtime PM support

2012-04-10 Thread Linus Walleij
On Mon, Mar 19, 2012 at 12:35 PM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Mar 8, 2012 at 2:30 PM, Linus Walleij linus.wall...@stericsson.com wrote: From: Jonas Aaberg jonas.ab...@stericsson.com Turn off the clock and regulator to the I2C block using runtime PM. Cc: Magnus

Re: [PATCH 2/2] i2c: Add generic I2C multiplexer using pinctrl API

2012-04-17 Thread Linus Walleij
|                                +-+  +-+  +-+ Signed-off-by: Stephen Warren swar...@nvidia.com I remember you told me about this thing, it's really fascinating! Acked-by: Linus Walleij linus.wall...@linaro.org Note: This patch depends on the latest pinctrl tree. In order to merge this series into the I2C tree, you'll need to merge

Re: [PATCH RESEND] i2c/nomadik: runtime PM support

2012-04-19 Thread Linus Walleij
. (Some pain about that recently...) So now I think we should remove the regulator handling altogether, keep clk handling (which is currently distributed) and respin on top of that. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message

Re: [PATCH V3 1/2] i2c/adapter: Add bus recovery infrastructure

2012-04-24 Thread Linus Walleij
the entire driver over to bitbang mode. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2] i2c: Add generic I2C multiplexer using pinctrl API

2012-04-25 Thread Linus Walleij
these things as pin controllers. But tt's not like there is competing terminology anyway, so let's define this before we get into committee meetings... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 02/15] ARM: ux500: Remove unused i2c platform_data initialisation code

2012-05-09 Thread Linus Walleij
/include/plat/i2c.h into drivers/i2c/busses/i2c-nomadik.c and delete that header from plat at the same time? Then there sure is no way for platforms to sneak in any platform data any other way. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

Re: [PATCH 03/15] ARM: ux500: Provide auxdata to be used as name base clock search for nmk-i2c

2012-05-09 Thread Linus Walleij
() not succeed without these bindings. Signed-off-by: Lee Jones lee.jo...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Thanks, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 04/15] ARM: ux500: CONFIG: Compile in support for leds-gpio

2012-05-09 Thread Linus Walleij
select MACH_MOP500 +select LEDS_GPIO Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/15] drivers/power: Carry out platform_data error checking on ab8500 devices

2012-05-09 Thread Linus Walleij
This or equivalent is already submitted and merged by Anton into the power tree I think? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/15] ARM: ux500: PRCMU related configuration and layout corrections for Device Tree

2012-05-09 Thread Linus Walleij
(...) -                       interrupts = 46 47; +                       interrupts = 0 47 0x4; Sorry I don't get it, why is two values in decimal and one in hex? Please choose one and stick to it... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

Re: [PATCH 09/15] drivers/mfd: Enable Device Tree support for the db8500-prcmu

2012-05-09 Thread Linus Walleij
here, as they will be enabled via DT instead. Signed-off-by: Lee Jones lee.jo...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 10/15] drivers/mfd: db8500-prcmu: Add support for regulator supply for nmk-i2c.4

2012-05-09 Thread Linus Walleij
On Fri, May 4, 2012 at 8:23 PM, Lee Jones lee.jo...@linaro.org wrote: This applies a supply alias for the db8500's fifth Nomadik i2c port. Signed-off-by: Lee Jones lee.jo...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list

Re: [PATCH 11/15] drivers/mfd: Enable Device Tree for ab8500-core driver

2012-05-09 Thread Linus Walleij
); + +       if (ab8500-irq_base == 0) { Shouldn't this be (av8500-irq_base == NO_IRQ) now that we're tranisitioning to use 0 as NO_IRQ? Apart from that it looks good to me: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 13/15] ARM: ux500: Add support for ab8500 regulators into the Device Tree

2012-05-09 Thread Linus Walleij
initialisation and platform specific regulator setup information. Signed-off-by: Lee Jones lee.jo...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org

  1   2   3   >