Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-19 Thread Wolfram Sang
> > Asking linux-pm for help here: If we want to support RuntimePM for I2C > > clients, do we need to enable RuntimePM on the logical I2C adapter > > device (the bus master) which is already marked using > > pm_runtime_no_callbacks? > > In theory you don't need to. But there are some advantages

Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-19 Thread Alan Stern
On Sat, 19 Dec 2015, Wolfram Sang wrote: > Asking linux-pm for help here: If we want to support RuntimePM for I2C > clients, do we need to enable RuntimePM on the logical I2C adapter > device (the bus master) which is already marked using > pm_runtime_no_callbacks? In theory you don't need to. B

Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-19 Thread Wolfram Sang
On Thu, Dec 17, 2015 at 09:46:55AM +, Charles Keepax wrote: > On Wed, Dec 16, 2015 at 02:53:07PM +0100, Sylwester Nawrocki wrote: > > On 15/12/15 19:14, Wolfram Sang wrote: > > > Since commit 6ada5c1e1b077a ("i2c: Mark adapter devices with > > > pm_runtime_no_callbacks"), runtime PM on adapters

Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-19 Thread Wolfram Sang
Hi, > > Since commit 6ada5c1e1b077a ("i2c: Mark adapter devices with > > pm_runtime_no_callbacks"), runtime PM on adapters turned into a no-op. > > So, we can remove these calls. > > Won't this break i2c client devices that use runtime PM? Not sure > if any cases of such client exist now, I'll tr

Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-17 Thread Charles Keepax
On Wed, Dec 16, 2015 at 02:53:07PM +0100, Sylwester Nawrocki wrote: > On 15/12/15 19:14, Wolfram Sang wrote: > > Since commit 6ada5c1e1b077a ("i2c: Mark adapter devices with > > pm_runtime_no_callbacks"), runtime PM on adapters turned into a no-op. > > So, we can remove these calls. > > Won't this

Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-16 Thread Sylwester Nawrocki
On 15/12/15 19:14, Wolfram Sang wrote: > Since commit 6ada5c1e1b077a ("i2c: Mark adapter devices with > pm_runtime_no_callbacks"), runtime PM on adapters turned into a no-op. > So, we can remove these calls. Won't this break i2c client devices that use runtime PM? Not sure if any cases of such cli

[PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-15 Thread Wolfram Sang
Since commit 6ada5c1e1b077a ("i2c: Mark adapter devices with pm_runtime_no_callbacks"), runtime PM on adapters turned into a no-op. So, we can remove these calls. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-s3c2410.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/i2c