This patch similarly fails to apply:
include/linux/ata.h 1.23: 281 lines
include/linux/ata.h 1.23 -> 1.24: 281 lines
1 out of 1 hunk FAILED -- saving rejects to file include/linux/ata.h.rej
drivers/scsi/libata-core.c 1.121: 4064 lines
drivers/scsi/libata-core.c 1.121 -> 1.122: 4064 lines
2 out of 3
Albert Lee wrote:
--- libata-dev-2.6/drivers/scsi/libata-scsi.c2005-02-21
17:23:03.0 +0800
+++ libata-dev-2.6-mod/drivers/scsi/libata-scsi.c2005-02-22
18:32:19.0 +0800
@@ -785,6 +785,7 @@
if ((cyl >> 16) || (head >> 4) || (sect >> 8) || (!sect))
retur
Jeff,
Attached please find the split ata_scsi_verify_xlat() fix.
Change:
- Fix uninitialized tf->command bug in ata_scsi_verify_xlat(), introduced by
my previous CHS support patch.
(This is similar to
http://marc.theaimsgroup.com/?l=linux-ide&m=110735039505617&w=2)
- Fix comment wording.
The
Jeff Garzik wrote:
Please submit these libata-scsi changes in a separate patch.
The IDP patch with split libata-scsi fix.
Attached please find the revised patch for your review.
Albert
Signed-off-by: Albert Lee <[EMAIL PROTECTED]>
=
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff Garzik wrote:
1. For the 100MHz pdc20268 and pdc20270 adapters, rely on the hardware
to set the timing registers.
How does the hardware set the timing registers?
Does it snoop the SET FEATURES - XFER MODE command?
Yes.
All chips supported by the pata_pdc2027x driver do that.
The values set
Albert Lee wrote:
Thanks for the detailed instruction.
Attached please find the revised patch for your review.
Thanks for the updated patch.
Patch looks OK except:
--- libata-dev-2.6/drivers/scsi/libata-scsi.c2005-02-21
17:23:03.0 +0800
+++ libata-dev-2.6-mod/drivers/scsi/libata-scsi.
Jeff Garzik wrote:
Thanks. Please use the logic Mark described:
if (ATA < 4 || !lba_capable)
issue IDP command
else
no need for IDP command
Thanks for the detailed instruction.
Attached please find the revised patch for your review.
Albert
Signed-off-by: Albert Lee <[EMAIL PROTECTED]>
==
Albert Lee wrote:
1. For the 100MHz pdc20268 and pdc20270 adapters, rely on the hardware to set the timing registers.
How does the hardware set the timing registers?
Does it snoop the SET FEATURES - XFER MODE command?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-id
> Albert Lee wrote:
> I did not get the pdc2027x timing registers right for the 100 MHz adapters.
> For the 100MHz adapters, the hardware will automatically set the timing
> registers to the correct value.
> No need to set the timing register by software table lookup.
> (The values in the looku
Albert Lee wrote:
Jeff Garzik wrote:
Now that CHS support is present, I am OK with removing the "pre ATA-3"
version check.
I'll remove this check in the IDP patch and resubmit the patch.
Thanks. Please use the logic Mark described:
if (ATA < 4 || !lba_capable)
issue IDP command
else
no n
Winstel, Drew wrote:
Hello again,
With 2.6.10 + pdc20269, there is a known problem on ATAPI DMA.
Please use 2.6.11 to test ATAPI.
Easier said than done. Using 2.6.11-rc4-bk9, I get an oops
(see below) with any drives attached. This occurs whether I
use one or four controllers.
How might I g
Jeff Garzik wrote:
No problem reading/writing it. However, I have to remove the pre ATA-3
check code before testing it.
Now that CHS support is present, I am OK with removing the "pre ATA-3"
version check.
I'll remove this check in the IDP patch and resubmit the patch.
Albert
-
To unsubscribe fr
Mark Lord wrote:
Minor patch for new 2.6.xx sata_qstor driver attached,
as per Alexey's fine-toothed comb! :)
Signed-off-by: Mark Lord <[EMAIL PROTECTED]>
I had to apply this manually, since your mailer "corrupts" the patch by
encoding text/plain as base64. Please fix your mailer...
The ideal i
It has been about a decade, but my memory vaguely suggests
that I tried that once before, and some LBA-capable drives
still required the IDP before they would function normally.
I think anything ATA-4 or later was fine, though.
So..
if (ATA < 4 || !lba_capable)
issue IDP command
else
no nee
Mark Lord wrote:
Albert Lee wrote:
If the device supports LBA, then IDP is not issued in my patch. Is
this OK?
It has been about a decade, but my memory vaguely suggests
that I tried that once before, and some LBA-capable drives
still required the IDP before they would function normally.
I thin
Albert Lee wrote:
If the device supports LBA, then IDP is not issued in my patch. Is
this OK?
It has been about a decade, but my memory vaguely suggests
that I tried that once before, and some LBA-capable drives
still required the IDP before they would function normally.
I think anything ATA-4 o
Hi Bart,
[ generic comment about PATA support in libata, yes wrong thread 8) ]
I think that at one point libata and IDE drivers should be merged.
Yes, this is doable and I plan to prove it soon (this shouldn't be so
hard nowadays :-).
Do you mean the IDE subsystem and libata sharing the same lo
> Does this patch do anything useful?
>
> Jeff
>
Not really. It doesn't print the nobody cared
message, but still hangs at boot. I'd give you a
backtrace but my MAGIC_SYSRQ doesn't seem to be
working right now.
-Brian
Linux version 2.6.11-rc4 ([EMAIL PROTECTED])
(gcc version 3.3.2) #
Albert Lee wrote:
No problem reading/writing it. However, I have to remove the pre ATA-3
check code before testing it.
Now that CHS support is present, I am OK with removing the "pre ATA-3"
version check.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the
Mark Lord wrote:
>This is the patch to issue INITIALIZE DEVICE PARAMETERS
>for CHS only devices.
That comment is not accurate. What the patch really does
is issue the IDP command for devices predating ATA-4,
regardless of whether they are CHS-only or not.
The Promise GPL'ed code does that, no
BTW, please CC your replies to linux-ide@vger.kernel.org as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--- Begin Message ---
Does this patch do anything useful?
Jeff
= drivers/scsi/sata_sil.c 1.44 vs edited =
--- 1.44/drivers/scsi/sata_sil.c2005-02-17 19:43:51 -05:00
+++ edited/drivers/scsi/sata_sil.c 2005-02-23 21:27:18 -05:00
@@ -65,6 +65,7 @@
static u32 sil_scr_rea
Mark Lord wrote:
Minor patch for new 2.6.xx sata_qstor driver attached,
as per Alexey's fine-toothed comb! :)
Signed-off-by: Mark Lord <[EMAIL PROTECTED]>
Cool, I'll throw this into libata-2.6 soonish.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body
Minor patch for new 2.6.xx sata_qstor driver attached,
as per Alexey's fine-toothed comb! :)
Signed-off-by: Mark Lord <[EMAIL PROTECTED]>
Cheers
--
Mark Lord
Real-Time Remedies Inc.
[EMAIL PROTECTED]
--- linux/drivers/scsi/sata_qstor.c.orig2005-02-16 20:31:57.0
-0500
+++ linux/dri
On Wed, Feb 23, 2005 at 04:35:11PM -0600, Winstel, Drew wrote:
> I noticed that in libata-scsi.c, the ata_scsi_simulate()
> function calls for the SCSI commands SEEK_6 and SEEK_10
> are being simulated instead of being translated to the
> ATA SEEK command (0x70). Why is this being done?
That's
I noticed that in libata-scsi.c, the ata_scsi_simulate()
function calls for the SCSI commands SEEK_6 and SEEK_10
are being simulated instead of being translated to the
ATA SEEK command (0x70). Why is this being done?
I know that the SEEK command was declared obsolete with draft 1c
of ATA/ATAP
Roland Dreier schrieb:
> Prakash> If I am not totally mistaken this is not gcc4 friendly
> Prakash> code. (lvalue thing...)
>
> Actually you misread the code slightly. It's a little subtle, but
> code like
>
> *(__le32 *)prd = cpu_to_le32(len);
>
> is not using a cast as an l
Prakash> If I am not totally mistaken this is not gcc4 friendly
Prakash> code. (lvalue thing...)
Actually you misread the code slightly. It's a little subtle, but
code like
*(__le32 *)prd = cpu_to_le32(len);
is not using a cast as an lvalue. It's dereferencing a cast an
Wichert Akkerman wrote:
Previously Jeff Garzik wrote:
You should add this to your procmailrc :)
# Nuke duplicate messages
:0 Wh: msgid.lock
| $FORMAIL -D 32768 msgid.cache
That has the nasty side-effect of spreading messages for a single
discussion amongst many different mailboxes depending on whi
Alexey Dobriyan schrieb:
> On Wednesday 23 February 2005 21:57, Jeff Garzik wrote:
>>+ addr = sg_dma_address(sg);
>>+ *(u64 *)prd = cpu_to_le64(addr);
>
>
> *(__le64 *) prd
>
>
>>+ prd += sizeof(u64);
>
>
>>+ len = sg_dma_len(sg);
>>+ *(u
Thanks. All this stuff was minor, so I'll wait until 2.6.11 release to
update.
I forwarded the qstor stuff to maintainer Mark Lord.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vge
Hello again,
>With 2.6.10 + pdc20269, there is a known problem on ATAPI DMA.
>Please use 2.6.11 to test ATAPI.
Easier said than done. Using 2.6.11-rc4-bk9, I get an oops
(see below) with any drives attached. This occurs whether I
use one or four controllers.
How might I get to working aroun
On Wednesday 23 February 2005 23:45, Alexey Dobriyan wrote:
> > +static void qs_ata_setup_port(struct ata_ioports *port, unsigned long base)
> > +{
> > + port->cmd_addr =
>
> > + port->error_addr=
>
> > + port->status_addr =
>
> > + port->altstatus_addr=
>
> O
On Wednesday 23 February 2005 21:57, Jeff Garzik wrote:
> This BK push includes additional hardware support, but that's only
> because it's (a) obviously low impact and (b) it was in the queue.
> --- a/drivers/scsi/ahci.c
> +++ b/drivers/scsi/ahci.c
> +static u8 ahci_check_err(struct ata_port *
Description reproduced from 2.6 version at
http://marc.theaimsgroup.com/?l=linux-kernel&m=110918919831955&w=2:
This BK push includes additional hardware support, but that's only
because it's (a) obviously low impact and (b) it was in the queue.
Far more important are:
1) API additions, to fix a s
This BK push includes additional hardware support, but that's only
because it's (a) obviously low impact and (b) it was in the queue.
Far more important are:
1) API additions, to fix a severe bug: advanced drivers such as AHCI
were directly bitbanging --non-existent-- PCI IDE registers, causing
Hi,
[ generic comment about PATA support in libata, yes wrong thread 8) ]
I think that at one point libata and IDE drivers should be merged.
Yes, this is doable and I plan to prove it soon (this shouldn't be so
hard nowadays :-). I really don't want to have two PATA drivers in
the tree with subt
I'm sorry, but your English is difficult to understand. Are you saying
you're trying to unplug your hard drive power cables while the system is
running? If so, that is a BAD IDEA. That will hang your mahine just
about every time. If that's not what you meant, then please clarify.
-Ryan
nedc
Has anyone also seen the problem of having a SATAPI device being
detected on the secondary port of the SiS 965 chipset?
I am able to run correctly on the primary port but the secondary port
says there is no physical device present. Both ports will run our
device in Windows XP so this isnt a har
Jeff Garzik wrote:
Can you try this patch?
If it fixes the oops, I'll forward upstream ASAP.
Jeff,
It fixes the oops (pasted below) for me; please do push it ASAP.
thanks,
BR
xlated vfy cmd LBA 0x14f500 cnt 20
ahci_interrupt: int on port 2
ahci_host_intr: fatal int seen
ahci_intr_error: port 2 irq_
>This is the patch to issue INITIALIZE DEVICE PARAMETERS
>for CHS only devices.
That comment is not accurate. What the patch really does
is issue the IDP command for devices predating ATA-4,
regardless of whether they are CHS-only or not.
Correct behaviour, mind you. Just the comment appeared mis
Applied patches 1 and 2 of the first CHS series,
and patches 3-1 through 3-3 of the second CHS series, to libata-dev queue.
As a follow-up, I believe libata-core should be modified to issue the
INITIALIZE DEVICE PARAMETERS command for all CHS devices.
Jeff,
This is the patch to issue INITIALIZE
Hi,
i try to make same storage with S150 TX4 and is working good
until i have same of the hard drives power off i mean unplug power
cable.Then linux hangs. Probably you think why i make this.
I have problem with some power cables and Linux is hang whitout
error so was difficulty to findout. T
44 matches
Mail list logo
