Re: smartd causing SATA timeouts on sleeping drives

2007-10-08 Thread Tejun Heo
Andrew Paprocki wrote: I found out after posting that this is governed by the -n parameter to smartd. The default behavior is -n never which means smartd will send the cmds regardless of the drive status. The man page indicates that may cause the drive to spin-up to answer the cmds. It appears

Re: smartd causing SATA timeouts on sleeping drives

2007-10-08 Thread Andrew Paprocki
Yes, the drives were in sleep mode. That is the only case where these timeouts/resets occur. It seems like the -n never mode of smartd should send the SRST if the drive is truly sleeping, otherwise libata will soft reset the drive when it sees the timeout. The -n standby option sounds like a more

Re: Serial ATA does not find partitions (Hitachi HD, new? ATI controller) where old SATA works

2007-10-08 Thread Hernan G Solari
Right, sorry about the confusion. I think the screen capture would be useful to ACPI developers. Thanks. In any case, I appreciate your williness to help, plus I learned things I would have not learned otherwise, many thanks to you Hernan -- HernĂ¡n Gustavo Solari, [EMAIL PROTECTED],

[PATCH] sata_nv: add the wildcard support for ahci legacy mode

2007-10-08 Thread peerchen
Add the wildcard support to sata_nv driver for those new ahci controllers being configured as IDE/RAID mode and also their DIDs haven't been added into ahci driver. The patch base on kernel 2.6.23-rc9 Signed-off-by: Peer Chen [EMAIL PROTECTED] --- --- linux-2.6.23-rc9/drivers/ata/sata_nv.c.orig

Re: timeouts with SiI 4726/3531

2007-10-08 Thread Lieven Marchand
Hi, I've solved the problem with the timeouts by disabling NCQ on the four disks. Apparently there's something in the combination of NCQ+PMP that gives problems. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 6/8] ide: remove -init_setup_dma from ide_pci_device_t

2007-10-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Make ide_pci_device_t.host_flags u32 and add IDE_HFLAG_CS5520 host flag. * Pass ide_pci_device_t *d to setup-pci.c::ide_get_or_set_dma_base() and use d-name instead of hwif-cds-name. * Set IDE_HFLAG_CS5520 host flag in cs5520 host driver and use it in

Re: [PATCH 6/8] ide: remove -init_setup_dma from ide_pci_device_t

2007-10-08 Thread Alan Cox
This fixes PCI bus-mastering and DMA simplex mode not being checked for CS5510/CS5520 hosts. Just noticed this patch: You do realise that the CS5510 and CS5520 aren't IDE class devices so its wrong to check the simplex bits on them (Ditto the MPIIX ?) You really shouldn't be taking

Re: [PATCH] IDE: Remove inclusion of non-existent io_trace.h.

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 07 October 2007, Robert P. J. Day wrote: Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] --- the fact that this header file doesn't exist has apparently been known for quite some time: http://osdir.com/ml/linux.tape/2005-07/msg1.html diff --git

Re: [PATCH] ide: make jmicron match vendor and device class

2007-10-08 Thread Bartlomiej Zolnierkiewicz
On Monday 08 October 2007, Tejun Heo wrote: PATA part of all current JMB controllers behave the same way and JMicron confirms that all future ones will stay compatible. Matching vendor and device class is enough. For backward compatibility, jmicron still needs to match 361,3,5,6,8 DIDs

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 04 October 2007, Sergei Shtylyov wrote: [...] Index: b/drivers/ide/pci/hpt366.c === --- a/drivers/ide/pci/hpt366.c +++ b/drivers/ide/pci/hpt366.c @@ -845,32 +845,33 @@ static int

[PATCH 1/12] ide: check -dma_setup() return value in flagged_taskfile()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c

[PATCH 2/12] ide: check drive-using_dma in flagged_taskfile()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c |3 +++ 1 file changed, 3 insertions(+) Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c +++

[PATCH 3/12] ide: fix -data_phase in taskfile_load_raw()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
It should be TASKFILE_NO_DATA, not TASKFILE_IN. Luckily ATM -data_phase is unused if -command_type == IDE_DRIVE_TASK_NO_DATA but this may change in the future. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-acpi.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 6/12] ide: add struct ide_taskfile

2007-10-08 Thread Bartlomiej Zolnierkiewicz
* Don't set write-only ide_task_t.hobRegister[6] and ide_task_t.hobRegister[7] in idedisk_set_max_address_ext(). * Add struct ide_taskfile and use it in ide_task_t instead of tfRegister[] and hobRegister[]. * Remove no longer needed IDE_CONTROL_OFFSET_HOB define. * Add #ifndef/#endif

[PATCH 7/12] ide-disk: merge LBA28 and LBA48 Host Protected Area support code

2007-10-08 Thread Bartlomiej Zolnierkiewicz
* Merge idedisk_{read_native,set}_max_address_ext() into idedisk_{read_native,set}_max_address(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 102

[PATCH 5/12] ide: remove task_ioreg_t typedef

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Remove task_ioreg_t typedef from the kernel code (but leave it in linux/hdreg.h for #ifndef/#endif __KERNEL__ case). While at it also move sata_ioreg_t typedef under #ifndef/#endif __KERNEL__. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 20

[PATCH 8/12] ide-disk: fix taskfile registers loading order in __ide_do_rw_disk()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Load IDE_SECTOR_REG after IDE_FEATURE_REG and IDE_NSECTOR_REG when using CHS. This patch is basically a preparation for the next one which converts __ide_do_rw_disk() to use struct ide_taskfile. It shouldn't affect anything (just a usual paranoia to separate changes which change the way in

[PATCH 9/12] ide-disk: use struct ide_taskfile in __ide_do_rw_disk()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 87 - 1 file changed,

[PATCH 10/12] ide: add ide_tf_load() helper

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. * Add 'tf_flags' field (for taskfile flags) to ide_task_t. * Add IDE_TFLAG_LBA48 taskfile flag for LBA48 taskfiles. * Add IDE_TFLAG_NO_SELECT_MASK taskfile flag for __ide_do_rw_disk() which doesn't use SELECT_MASK() (looks like a bug but it requires

[PATCH 11/12] ide: add ide_no_data_taskfile() helper

2007-10-08 Thread Bartlomiej Zolnierkiewicz
* Add ide_no_data_taskfile() helper and convert ide_raw_taskfile() w/ NO DATA protocol users to use it instead. * Set -data_phase explicitly in ide_no_data_taskfile() (TASKFILE_NO_DATA is defined as 0x). * Unexport task_no_data_intr(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 12/12] ide: use do_rw_taskfile() in flagged_taskfile()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. * Move setting IDE_TFLAG_LBA48 taskfile flag from do_rw_taskfile() function to the callers. * Add IDE_TFLAG_FLAGGED taskfile flag for flagged taskfiles coming from ide_taskfile_ioctl(). Check it instead of -tf_out_flags.all. * Add IDE_TFLAG_OUT_DATA

Re: Bug #4580: hda: lost interrupt when resuming from S3 - Sony VGN-T1XP

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 07 October 2007, Rafael J. Wysocki wrote: Hi, IDE/ATA wizzards are kindly requested to have a look at: http://bugzilla.kernel.org/show_bug.cgi?id=4580#c21 as I have no idea of what we can do about the hard drive password vs suspend problem, if anything.

Re: Polling (was Re: [PATCHSET 2/2] implement PMP support, take 6)

2007-10-08 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: A few days before that, both PMP and SAS /were/ slated for 2.6.24, and after I fix the design problems, they will be again. One way or another, upstream will /not/ be doing polling PMP in 2.6.24. Just an update to let you know that I've been working on it.

sata_sis driver may be broken in openSUSE 10.3

2007-10-08 Thread Nathaniel Dube
I found your contact information in the file.. /usr/src/linux-2.6.18.8-0.5/drivers/ata/sata_sis.c And figured you might be the one to talk to. I, as well as many others have had issus with openSUSE 10.3 not detecting SATA hard drives. I don't know if the fault is with the kernel developers

[PATCH] libata: clear ehi description after initial host report

2007-10-08 Thread Tejun Heo
ehi description field is used to carry LLD specific controller description. Sometimes, it's used without clearing before and LLD description gets printed with exception information one more time. Clear after printing. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c |

[PATCH] libata: wrap schedule_timeout_uninterruptible() in loop

2007-10-08 Thread Tejun Heo
Tasks in uninterruptible sleep might be woken up by unrelated events and should check whether the condition it was waiting for has actually triggered. Wrap schedule_timeout_uninterruptible() in loop to achieve it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c |3 ++-