Re: AHCI driver preferring nr_ports over port map

2008-02-02 Thread Tejun Heo
Jan Beulich wrote: Jeff, while I realize that Intel's documentation may not be consistent with anything more generic (which I don't know where to look for), this current behavior seems to contradict what Intel documents for ESB2: 23.3.1.4 PI – Ports Implemented Register (D31:F2) Address

[PATCH] ide-pci-generic: kill the unused ifdef/endif/MODULE code

2008-02-02 Thread Denis Cheng
with module_param macro, the __setup code can be killed now: const __setup(all-generic-ide, ide_generic_all_on); and the module name generic.ko is not descriptive to its functionality, can be changed in Makefile, the ide-pci-generic.ko is better. the ide-pci-generic.all-generic-ide

[PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver

2008-02-02 Thread Ben Dooks
Use HAVE_PATA_PLATFORM for ARCH_RPC Cc: Linux ARM Kernel [EMAIL PROTECTED] Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] PATCH FOLLOWS KernelVersion: 2.6.24-git12 Index: linux-2.6.24-git12-pata/arch/arm/Kconfig

[PATCH 1/3 2.6.24-git] LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver

2008-02-02 Thread Ben Dooks
Add HAVE_PATA_PLATFORM to select the pata platform driver to ensure that we do not end up with a long 'depends on' list when other users of this driver turn up. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-git12-pata/drivers/ata/Kconfig

[PATCH 2/3 2.6.24-git] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver

2008-02-02 Thread Ben Dooks
Use HAVE_PATA_PLATFORM for ARCH_RPC Cc: Linux ARM Kernel [EMAIL PROTECTED] Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] PATCH FOLLOWS KernelVersion: 2.6.24-git12 Index: linux-2.6.24-git12-pata/arch/arm/Kconfig

[PATCH 0/3 2.6.24-git] Add HAVE_PLATFORM_PATA Kconfig

2008-02-02 Thread Ben Dooks
Repost of previous patch-set with email address in part 3 corrected. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3 2.6.24-git] LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver

2008-02-02 Thread Ben Dooks
Add HAVE_PATA_PLATFORM to select the pata platform driver to ensure that we do not end up with a long 'depends on' list when other users of this driver turn up. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-git12-pata/drivers/ata/Kconfig

[PATCH 0/3 2.6.24-git] Add HAVE_PLATFROM_PATA Kconfig

2008-02-02 Thread Ben Dooks
This is a repost of the earlier patch series, modified to use HAVE_PATA_PLATFORM for the current kernel merge window for 2.6.25. -- Ben - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

[no subject]

2008-02-02 Thread Ben Dooks
- To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC

2008-02-02 Thread Ben Dooks
Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM driver. CC: [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-git12-pata2/arch/ppc/Kconfig === --- linux-2.6.24-git12-pata2.orig/arch/ppc/Kconfig

Re: PROBLEM: SATA hotplugging not working with nForce MCP61

2008-02-02 Thread Tuomas Jormola
On Sat, Feb 02, 2008 at 02:29:24PM +0900, Tejun Heo wrote: Tuomas Jormola wrote: Hello, [1.] One line summary of the problem: SATA hotplugging does not seem to work with NVIDIA nForce MCP61. [2.] Full description of the problem/report: I have a machine with ASRock 939NF6G-VSTA

[PATCH] ide-scsi: remove needless SELECT_DRIVE() call

2008-02-02 Thread Bartlomiej Zolnierkiewicz
SELECT_DRIVE() is called by IDE core code in start_request() before device driver's -do_request method. In ide-scsi case -do_request is implemented by idescsi_do_request() which is also the only user of idescsi_issue_pc(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- goes

Re: [PATCH] ide-core: remove conditional compiling with MODULE in ide-core.c

2008-02-02 Thread Bodo Eggert
Denis Cheng [EMAIL PROTECTED] wrote: use module_init/module_exit to replace the original cond-compiling, these macros were well designed to deal module/built-in compiling. the original __setup with null string was invalid and not executed, __setup(, ide_setup); however, with the current

Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC

2008-02-02 Thread Olof Johansson
On Sat, Feb 02, 2008 at 04:21:36PM +, Ben Dooks wrote: Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM driver. CC: [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] What tree is this against? It doesn't apply to current mainline nor jgarzik's libata-dev upstream

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Saturday 02 February 2008, Jeff Garzik wrote: Linux Kernel Mailing List wrote: Commit: 0948391641918b95d8d96c15089eb5ac156850b3 PCI: Remove users of pci_enable_device_bars() This patch converts users of pci_enable_device_bars() to the new

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Greg KH
On Sat, Feb 02, 2008 at 09:01:10PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 02 February 2008, Jeff Garzik wrote: Linux Kernel Mailing List wrote: Commit: 0948391641918b95d8d96c15089eb5ac156850b3 PCI: Remove users of pci_enable_device_bars() This patch

Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC

2008-02-02 Thread Ben Dooks
On Sat, Feb 02, 2008 at 01:12:39PM -0600, Olof Johansson wrote: On Sat, Feb 02, 2008 at 04:21:36PM +, Ben Dooks wrote: Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM driver. CC: [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] What tree is this against? It

Re: PROBLEM: SATA hotplugging not working with nForce MCP61

2008-02-02 Thread Tejun Heo
Tuomas Jormola wrote: 00:08.0 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller [10de:03f6] (rev a2) 00:08.1 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller [10de:03f6] (rev a2) That's MCP61 which is GENERIC variant in sata_nv which does not support hotplugging.

Re: PROBLEM: SATA hotplugging not working with nForce MCP61

2008-02-02 Thread Robert Hancock
Tejun Heo wrote: Tuomas Jormola wrote: 00:08.0 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller [10de:03f6] (rev a2) 00:08.1 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller [10de:03f6] (rev a2) That's MCP61 which is GENERIC variant in sata_nv which does not

Re: [PATCH 23/32] ide-tape: struct idetape_tape_t: shorten member names

2008-02-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Some member names are self-explanatory, so remove their respective comments. Also, explain the exact purpose of struct members in comments in the struct definition instead of using excessively

Re: [RFC PATCH 26/32] ide-tape: remove packet command and struct request memory buffers

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Bart, this one is rather intrusive so please doublecheck it wrt to kzalloc/kfree balancing on all the codepaths so that we don't leak memory all over the place. I free all the alloc'd pc's and rq's

Re: [PATCH 27/32] ide-tape: remove idetape_increase_max_pipeline_stages()

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] This function was being used only at one place so fold it in there. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] This change is fine but depends on previous patches so I can't apply it. Please

Re: [PATCH 28/32] ide-tape: shorten some function names

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git

[BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Chris Rankin
Hi, I have tried to boot a 2.6.24 kernel on my 1 GHz Coppermine / 512 MB RAM PC. (This is without the nmi_watchdog=1 option.) However, the ATA layer is failing to initialise: Linux version 2.6.24 ([EMAIL PROTECTED]) (gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)) #1 SMP PREEMPT Sat Feb 2

Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC

2008-02-02 Thread Olof Johansson
On Sat, Feb 02, 2008 at 07:41:02PM +, Ben Dooks wrote: On Sat, Feb 02, 2008 at 01:12:39PM -0600, Olof Johansson wrote: On Sat, Feb 02, 2008 at 04:21:36PM +, Ben Dooks wrote: Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM driver. CC: [EMAIL PROTECTED]

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Jeff Garzik
Chris Rankin wrote: ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata1.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 dma 4096 in res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) ata1.00: status: { DRDY } ata1: soft resetting link ata1.00: configured for UDMA/66

RE: PROBLEM: SATA hotplugging not working with nForce MCP61

2008-02-02 Thread Kuan Luo
robert wrote: Tejun Heo wrote: Tuomas Jormola wrote: 00:08.0 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller [10de:03f6] (rev a2) 00:08.1 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller [10de:03f6] (rev a2) That's MCP61 which is GENERIC variant in

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-02 Thread Tejun Heo
James Bottomley wrote: On Fri, 2008-02-01 at 15:02 -0500, Jeff Garzik wrote: James Bottomley wrote: Could we please get this in ... I thought I mentioned several times that it fixes a fatal oops in both aic94xx and ipr. Tejun has a persistent objection... see other email. Actually, see

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Gene Heskett
On Saturday 02 February 2008, Jeff Garzik wrote: Chris Rankin wrote: ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata1.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 dma 4096 in res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) ata1.00: status: { DRDY } ata1:

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-02 Thread James Bottomley
On Sun, 2008-02-03 at 12:04 +0900, Tejun Heo wrote: James Bottomley wrote: On Fri, 2008-02-01 at 15:02 -0500, Jeff Garzik wrote: James Bottomley wrote: Could we please get this in ... I thought I mentioned several times that it fixes a fatal oops in both aic94xx and ipr. Tejun has a

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Ingo Molnar
* Gene Heskett [EMAIL PROTECTED] wrote: I think that one came from me, but it also gets over 14,000 hits on google. Now Jeff, here is the strange part. That error was killing me, many times an hour and eventually crashing completely, repeatedly. I applied that kernel argument

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: [ 27.097095] ENABLING IO-APIC IRQs [ 27.097287] ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1 [ 27.107291] ..MP-BIOS bug: 8254 timer not connected to IO-APIC [ 27.107343] ...trying to set up timer (IRQ0) through the 8259A ...

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Gene Heskett
On Saturday 02 February 2008, Ingo Molnar wrote: * Gene Heskett [EMAIL PROTECTED] wrote: I think that one came from me, but it also gets over 14,000 hits on google. Now Jeff, here is the strange part. That error was killing me, many times an hour and eventually crashing completely,

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Benjamin Herrenschmidt
Since Alan has commented on it: http://lkml.org/lkml/2007/12/17/422 5520 in fact is always enabled as it is the host bridge. pci_enable_device_io will do just fine. The 5520 fun is if you disable it the system hangs. I moved on assuming that either submitter or integrator

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Ingo Molnar
* Gene Heskett [EMAIL PROTECTED] wrote: I believe its the same, but lemme paste it for sure, yes: [ 26.339926] ENABLING IO-APIC IRQs [ 26.340119] ..TIMER: vector=0x31 apic1=0 pin1=0 apic2=-1 pin2=-1 [ 26.350129] ..MP-BIOS bug: 8254 timer not connected to IO-APIC [ 26.350182]

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Gene Heskett
On Sunday 03 February 2008, Ingo Molnar wrote: * Gene Heskett [EMAIL PROTECTED] wrote: I believe its the same, but lemme paste it for sure, yes: [ 26.339926] ENABLING IO-APIC IRQs [ 26.340119] ..TIMER: vector=0x31 apic1=0 pin1=0 apic2=-1 pin2=-1 [ 26.350129] ..MP-BIOS bug: 8254 timer not

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-02 Thread Tejun Heo
James Bottomley wrote: I think the best solution is to update block layer draining such that it can be included together before the merge window closes. I'll dig into it. Like I said, the block layer pieces are already upstream. All we need is the ATA bits and I think it should all work