Re: [PATCH 1/32] ide-tape: move historical changelog to Documentation/ide/ChangeLog.ide-tape.1995-2002

On Sunday 27 January 2008, Borislav Petkov wrote: Also, cleanup whitespace and update comments. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied with some changes --- Documentation/ide/ChangeLog.ide-tape.1995-2002 | 405 +++ drivers/ide/ide-tape.c

Re: [PATCH 3/32] ide-tape: remove struct idetape_request_sense_result_t

On Sunday 27 January 2008, Borislav Petkov wrote: Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 83 +++ 1 files changed, 27 insertions(+), 56 deletions(-) applied with minor changes diff --git

Re: [PATCH 06/32] ide-tape: remove IDETAPE_DEBUG_BUGS

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied --- drivers/ide/ide-tape.c | 42 ++ 1 files changed, 2 insertions(+), 40 deletions(-) diff --git

Re: [PATCH 22/32] ide-tape: struct idetape_packet_command_s: shorten member names

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 88 --- 1 files changed, 45 insertions(+), 43 deletions(-) diff --git

Re: [PATCH 10/32] ide-tape: remove struct idetape_read_position_result_t

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 49 +--

Re: [PATCH 0/32] ide-tape redux v1

Hi, On Sunday 27 January 2008, Borislav Petkov wrote: Hi Bart, after a lot of hammering ide-tape got pimped pretty considerably (ca. 600 lines shorter and slicker :)). I'm sure there's more to be done like, e.g. replacing Good work. :) the BKL in idetape_write_release() with

Re: [PATCH 25/32] ide-tape: simplify code branching in the interrupt handler

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] ... by adding a new typedef function pointer idetape_io_buf in order to call the proper buffer i/o handler depending on the data direction. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] ---

Re: [PATCH 31/32] ide-tape: remove idetape_config_t typedef

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Since this is used only in idetape_blkdev_ioctl(), remove the typedef and make the struct function-local. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied --- drivers/ide/ide-tape.c |

Re: [PATCH 07/32] ide-tape: refactor the debug logging facility

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Teach the debug logging macro to differentiate different log levels based on the type of debug level enabled specifically instead of a threshold-based one. Thus, convert tape-debug_level to a bitmask

Re: [PATCH 08/32] ide-tape: remove struct idetape_capabilities_page_t

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] All those 2-byte values denoting the different capabilities are being written to the local copy of the caps buffer without being converted to big endian for simplicity of usage and shorter code later.

Re: [PATCH 29/32] ide-tape: remove mtio.h related comments

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Those are already in mtio.h. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied --- drivers/ide/ide-tape.c | 96 +++ 1 files changed, 15

Re: [PATCH 24/32] ide-tape: remove unreachable code chunk

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] tape-speed_ctl is set to 1 in idetape_setup(), but, in calculate_speeds() its value is tested for being 0, 1, or 2. Remove the if-branches where tape-speed_ctl != 1 since they are never executed.

Re: [PATCH 21/32] ide-tape: idetape_chrdev_direction_t:shorten enum names

On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 60 --- 1 files changed, 31 insertions(+), 29 deletions(-) diff --git

Re: [PATCH 21/21] ide: make remaining built-in only IDE host drivers modular

Hi, On Friday 04 January 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Make remaining built-in only IDE host drivers modular, add ide-scan-pci.c file for probing PCI host drivers registered with IDE core (special case for built-in IDE and CONFIG_IDEPCI_PCIBUS_ORDER

Re: From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] (linux.* mail to news gateway)

On Saturday 26 January 2008, Jan Engelhardt wrote: On Jan 26 2008 21:31, Frans Pop wrote: config BLK_DEV_IDE_PMAC - bool Builtin PowerMac IDE support + tristate Builtin PowerMac IDE support this change is no-op at the moment because the next Kconfig line is: depends

Re: [PATCH] ide-io: set REQ_FAILED when drive is dead

On Thursday 24 January 2008, Aristeu Rozanski wrote: Currently it's possible to ide-cd to set an incorrect blocksize by reading garbage if the drive is dead: ide_cd_probe() - cdrom_read_toc() - cdrom_read_capacity() - cdrom_queue_packet_command() -

Re: [PATCH] ppc: fix #ifdef-s in mediabay driver

On Wednesday 23 January 2008, Benjamin Herrenschmidt wrote: On Wed, 2008-01-23 at 01:58 +0100, Bartlomiej Zolnierkiewicz wrote: I'm more worried about breaking automatic build checking (make randconfig) than a few extra bytes so if you remove all #ifdefs you'll have to either make

[PATCH] ide-cs: use ide_std_init_ports()

No reason to use ide_init_hwif_ports() in ide-cs (as a nice side-effect this makes ide-cs work on archs that don't define IDE_ARCH_OBSOLETE_INIT). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ide-cs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] ppc: fix #ifdef-s in mediabay driver

is defined. * check_media_bay_by_base() and media_bay_set_ide_infos() are used only by drivers/ide/ppc/pmac.c so so make these functions available only if CONFIG_MAC_FLOPPY is defined. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Ben, IMO this patch is safe for 2.6.24

Re: [PATCH 0/12] ide-floppy redux v2.5

Hi Borislav, On Sunday 20 January 2008, Borislav Petkov wrote: On Mon, Jan 14, 2008 at 10:38:17PM +0100, Bartlomiej Zolnierkiewicz wrote: By the way, I have an Iomega ZIP 100 drive somewhere in my hardware pile and will do some testing with the new :) driver just in case

Re: [PATCH] pdc2026x: remove surplus initialiser

On Saturday 19 January 2008, Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] applied with: - s/pdc2026x/pdc202xx_old/ in patch summary - drive-by CodingStyle fixups diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [PATCH] pdc2026x: remove surplus initialiser

On Saturday 19 January 2008, Alan Cox wrote: On Sat, 19 Jan 2008 19:54:03 +0300 Sergei Shtylyov [EMAIL PROTECTED] wrote: Hello. Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude

[PATCH] ide-disk: use do_rw_taskfile() (take 2)

. * Remove incorrect comment about do_rw_taskfile() from linux/ide.h. There should be no functionality changes caused by this patch. v2: * Add missing blk_fs_request() check to task_dma_ok() (for VDMA). Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 00/16] ide: various fixes/cleanups

Easy stuff done as relax from more hard-core changes... diffstat: drivers/ide/cris/ide-cris.c |6 - drivers/ide/ide-dma.c | 20 ++ drivers/ide/ide-iops.c | 145 ++-- drivers/ide/ide-probe.c | 35 ++

[PATCH 01/16] ide-tape: use ide_execute_command()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-tape.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-tape.c === --- a/drivers/ide/ide-tape.c +++ b/drivers/ide

[PATCH 02/16] ide-scsi: use ide_execute_command()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/scsi/ide-scsi.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Index: b/drivers/scsi/ide-scsi.c === --- a/drivers/scsi/ide-scsi.c +++ b/drivers

[PATCH 03/16] trm290: use ide_execute_command()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/trm290.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) Index: b/drivers/ide/pci/trm290.c === --- a/drivers/ide/pci/trm290.c +++ b/drivers

[PATCH 04/16] ide-cris: use ide_execute_command()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) Index: b/drivers/ide/cris/ide-cris.c === --- a/drivers/ide/cris/ide-cris.c

[PATCH 05/16] ide-probe: remove needless Status register reads

* Cache value read from the Status register in 'stat' variable in do_probe() and enable_nest(), then remove remove needless Status register reads. While at it: * Add proper KERN_* levels to printk() calls. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide

[PATCH 07/16] ide: convert -straight8 field in ide_hwif_t to bit flag

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h

[PATCH 08/16] ide: remove -nice0 and -nice2 fields from ide_drive_t

* -nice0 and -nice2 ide_drive_t fields are always zero so remove them. * IDE_NICE_0 and IDE_NICE_2 defines from linux/hdreg.h are no longer used by any kernel code so cover them with #ifndef/#endif __KERNEL__. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c

[PATCH 09/16] ide: remove SATA_*_REG macros

* siimage.c: use hwif-sata_scr[SATA_{ERROR,STATUS}_OFFSET] instead of SATA_{ERROR,STATUS}_REG macros. * Remove no longer needed SATA_*_REG macros. While at it: * Remove needless SATA Status register read from sil_sata_reset_poll(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 11/16] ide: unexport SELECT_DRIVE()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide-iops.c === --- a/drivers/ide/ide-iops.c +++ b/drivers/ide/ide-iops.c @@ -163,8

[PATCH 12/16] ide: remove set_transfer()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 18 -- drivers/ide/ide-taskfile.c |6 +- include/linux/ide.h|1 - 3 files changed, 5 insertions(+), 20 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 13/16] ide: remove ide_ata66_check()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 15 --- drivers/ide/ide-taskfile.c |5 - include/linux/ide.h|1 - 3 files changed, 4 insertions(+), 17 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 14/16] ide: move drive-crc_count check out from check_dma_crc()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-iops.c === --- a/drivers/ide/ide

[PATCH 15/16] ide: remove ide_auto_reduce_xfer()

While at it: * Remove needless '!drive-crc_count' check. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 41 + 1 file changed, 13 insertions(+), 28 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 16/16] ide: move check_dma_crc() to ide-dma.c

* Move check_dma_crc() to ide-dma.c and add inline version for CONFIG_BLK_DEV_IDEDMA=n case. * Rename check_dma_crc() to ide_check_dma_crc(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c | 20 drivers/ide/ide-iops.c | 24

Re: ATA device reset, shoud I be concerned?

On Monday 21 January 2008, Tejun Heo wrote: [...] Old IDE says it works for PATA. For SATA I can see it might need more care and you might simply not be able to get the info. Old IDE often locks up the machine hard after timeouts. I'm all for Could you point me to some bugreports? I

Re: [PATCH] Palmchip BK3710 IDE driver

On Friday 18 January 2008, Sergei Shtylyov wrote: Alan Cox wrote: It won't -- we can *not* call ide_setup_dma() which fills them out as this is not a PCI chip. Gak. Or maybe we still can -- with hwif-mmio set? AFAIR (from the 2006 discussion) Bart said it's *only* for

Re: [PATCH] Palmchip BK3710 IDE driver

Hi, On Thursday 17 January 2008, Anton Salnikov wrote: This is Palmchip BK3710 IDE controller support for kernel version 2.6.24-rc8. The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes. Supports interface to compact Flash (CF) configured in True-IDE mode. Thanks, overall

Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

On Tuesday 15 January 2008, Borislav Petkov wrote: On Mon, Jan 14, 2008 at 11:32:58PM +0100, Bartlomiej Zolnierkiewicz wrote: On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote: On Sunday 13 January 2008, Borislav Petkov wrote: ..and replace them with flag enums. Signed

Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

On Tuesday 15 January 2008, Borislav Petkov wrote: [...] .. this is the second one... From: Borislav Petkov [EMAIL PROTECTED] Date: Tue, 15 Jan 2008 20:49:18 +0100 Subject: [PATCH 16/18] ide-floppy: remove atomic test_*bit macros ..and replace them with flag enums. Signed-off-by:

Re: (was: Re:...) [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues-v2

On Tuesday 15 January 2008, Borislav Petkov wrote: ... and finally the last one. Whew! I think we're done here for now. :) -- From: Borislav Petkov [EMAIL PROTECTED] Date: Tue, 15 Jan 2008 21:01:04 +0100 Subject: ide-floppy: fix most of the remaining checkpatch.pl issues-v2 such as

[PATCH 00/22] ide: even more IDE probing code rework

Just another bunch of small fixes/cleanups... diffstat: drivers/ide/arm/bast-ide.c| 22 +++- drivers/ide/arm/rapide.c |4 drivers/ide/ide-acpi.c| 60 +++ drivers/ide/ide-pnp.c |9 - drivers/ide/ide-probe.c | 204

[PATCH 02/22] ide: remove redundant init_hwif_default() call from ide_register_hw()

ide_init_port_hw() call overrides setup done by init_hwif_default(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 04/22] ide: add ide_deprecated_find_port() helper

interfaces if useable ide_hwifs[] slot cannot be find). This patch leaves us with only two ide_register_hw() users: - drivers/macintosh/mediabay.c - drivers/ide/ide.c Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/bast-ide.c | 20 +++- drivers

[PATCH 05/22] ide: fix ide_unregister() usage in host drivers

. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/bast-ide.c|2 +- drivers/ide/arm/rapide.c |2 +- drivers/ide/ide-pnp.c |2 +- drivers/ide/legacy/ide-cs.c |4 ++-- drivers/ide/legacy/ide_platform.c |2 +- drivers/ide

[PATCH 06/22] ide: factor out code initializing devices from ide_init_port()

* Factor out code initializing devices from ide_init_port() to ide_port_init_devices(). * Call the new function from ide_device_add_all(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c

[PATCH 07/22] ide: add IDE_HFLAG_NO_{IO32_BIT,UNMASK_IRQS} host flags

host drivers to use it. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |4 +++- drivers/ide/legacy/dtc2278.c | 10 +++--- drivers/ide/mips/au1xxx-ide.c |3 +-- drivers/ide

[PATCH 08/22] ide: add -init_port_devs method to ide_hwif_t

by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |3 ++ drivers/ide/legacy/ht6560b.c | 26 + drivers/ide/legacy/qd65xx.c | 44 --- drivers/ide/pci/opti621.c| 10

[PATCH 09/22] ide: remove incorrect init_gendisk() comment

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |6 -- 1 file changed, 6 deletions(-) Index: b/drivers/ide/ide-probe.c === --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c

[PATCH 10/22] ide: skip not present devices in init_gendisk()

No need to initialize drive-gendev and waste memory on IDE settings for not present devices. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |4 1 file changed, 4 insertions(+) Index: b/drivers/ide/ide-probe.c

[PATCH 11/22] ide: move blk_register_region() call out from init_gendisk()

Move blk_register_region() call out from init_gendisk() to hwif_init(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b

[PATCH 12/22] ide: call init_gendisk() after ide_acpi_init()

There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c

[PATCH 13/22] ide: merge init_gendisk() into hwif_register_devices()

There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 44 1 file changed, 16 insertions(+), 28 deletions(-) Index: b/drivers/ide/ide-probe.c

[PATCH 14/22] ide: move hwif-rqsize init from ide_init_queue() to init_irq()

Move hwif-rqsize init from ide_init_queue() to init_irq(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) Index: b

[PATCH 15/22] ide: factor out adding drive to hwgroup from init_irq()

Factor out adding drive to hwgroup from init_irq() to ide_add_drive_to_hwgroup(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 29 ++--- 1 file changed, 18

[PATCH 16/22] ide: factor out devices setup from init_irq()

* Factor out devices setup from init_irq() to ide_port_setup_devices(). While at it: * Do devices setup after printing port information. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 44 1 file changed, 28

[PATCH 17/22] ide: move ide_acpi_init() call to ide_device_add_all()

There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c

[PATCH 18/22] ide-acpi: remove needless exports

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-acpi.c |4 1 file changed, 4 deletions(-) Index: b/drivers/ide/ide-acpi.c === --- a/drivers/ide/ide-acpi.c +++ b/drivers/ide/ide-acpi.c

[PATCH 19/22] ide-acpi: remove dead code from do_drive_get_GTF()

These pointers are always setup in ide_acpi_init(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-acpi.c | 10 -- 1 file changed, 10 deletions(-) Index: b/drivers/ide/ide-acpi.c

[PATCH 20/22] ide: factor out devices setup from ide_acpi_init()

. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-acpi.c | 49 +++- drivers/ide/ide-probe.c |1 include/linux/ide.h |2 + 3 files changed, 23 insertions(+), 29 deletions(-) Index: b/drivers/ide/ide-acpi.c

[PATCH 21/22] ide: move hwif-present check out from ide_proc_register_port()

Move hwif-present check out from ide_proc_register_port() to ide_device_add_all(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |9 +++-- drivers/ide/ide-proc.c |3 --- 2 files

Re: [PATCH 0/12] ide-floppy redux v2.5

Hi, On Sunday 13 January 2008, Borislav Petkov wrote: Hi Bart, here are the remaining patches which had issues to be worked out. I decided to keep the Flexible Disk Page and Capacity Descriptor in idefloppy_floppy_t for the sake of the two printk calls for which they are used. Otherwise,

Re: [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_buffers

On Sunday 13 January 2008, Borislav Petkov wrote: We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by introducing a 4th arg. called direction. According to its value we atapi_input_bytes() or atapi_output_bytes(). Also, this simplifies the interrupt handler logic a bit.

Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

On Sunday 13 January 2008, Borislav Petkov wrote: ..and replace them with flag enums. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 132 + 1 files changed, 73 insertions(+), 59 deletions(-) [...] @@ -506,14

Re: [PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO

On Sunday 13 January 2008, Borislav Petkov wrote: [...] - printk(KERN_ERR ide-floppy: Packet size is not 12 bytes long\n); + printk(KERN_ERR ide-floppy: Packet size is not 12 bytes + long\n); I added dumping 'gcw.packet_size' for

Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote: On Sunday 13 January 2008, Borislav Petkov wrote: ..and replace them with flag enums. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] small update: PC_ABORT is never set and may as well be removed in a pre-patch

Re: 40-wire cable detected when directly connected

On Saturday 12 January 2008, Bartlomiej Zolnierkiewicz wrote: [...] I've re-read the whole thread and it seems that the possible solution for Addonics card would be to detect it by PCI Subsystem Vendor/Device IDs. It seems I wasn't paying enough attention, Tejun already thought

Re: [PATCH 21/21] ide-floppy: remove atomic test_*bit macros

On Friday 11 January 2008, Borislav Petkov wrote: This change is temporary and after unification of the IDE subsystem proper bit setting and testing macros will be introduced. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 82

Re: [PATCH 14/21] ide-floppy: mv idefloppy_{should_,}report_error

On Friday 11 January 2008, Borislav Petkov wrote: In addition to shortening the function name, move the printk-call into the function thereby saving some code lines. Also, make the function out_of_line since it is not on a performance critical path. Signed-off-by: Borislav Petkov [EMAIL

Re: [PATCH 19/21] ide-floppy: fix most of the remaining checkpatch.pl issues

On Friday 11 January 2008, Borislav Petkov wrote: i.e., ERROR: switch and case should be at the same indent ERROR: need spaces around that '=' (ctx:VxV) ERROR: trailing statements should be on next line WARNING: no space between function name and open parenthesis '(' WARNING: printk() should

Re: [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe()

On Friday 11 January 2008, Borislav Petkov wrote: Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 89b26ea..0729df5 100644 ---

Re: [PATCH] IDE: terminate ACPI DMI list

On Friday 11 January 2008, Jeff Garzik wrote: Fix oops reported by Trond. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Linus, could you apply it? --- drivers/ide/ide-acpi.c |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [patch]workaround suspend bug for ACPI IDE

On Thursday 10 January 2008, Shaohua Li wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9673 ACPI _PS3 cause S4 breaks in the second attempt. The system has a _PS3 method for IDE, which will call into SMM mode. Currently we haven't clue why just the second attempt fails, as it's totally in

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

Hi Tejun, On Wednesday 09 January 2008, Tejun Heo wrote: Hello, all. Broken MWDMA on pata_ali has caused a number of bug reports. I've been trying to fix it for some time now finally got a machine with pata_ali and non-working MWDMA2 ATAPI device on my desk a few weeks ago. Testing

Re: 80 wire cable detection patch

Hi, On Sunday 06 January 2008, George Kibardin wrote: Signed-off-by: George Kibardin [EMAIL PROTECTED] --- drivers/ide/ide-iops.c.orig 2008-01-03 18:35:23.0 +0300 +++ drivers/ide/ide-iops.c 2008-01-03 18:12:29.0 +0300 @@ -612,12 +612,12 @@

[PATCH] ide: remove needless includes from PCI host drivers

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |1 - drivers/ide/pci/alim15x3.c |1 - drivers/ide/pci/amd74xx.c |3 --- drivers/ide/pci/atiixp.c |4 drivers/ide/pci/cmd640.c |4 drivers/ide/pci

Re: [RESEND PATCH 06/10] ide-floppy: report DMA handling in idefloppy_pc_intr() properly

On Saturday 05 January 2008, Borislav Petkov wrote: On Sat, Jan 05, 2008 at 04:46:05PM +0100, Bartlomiej Zolnierkiewicz wrote: Hmm, no. The driver is called ide-floppy (ide_floppy) and it is more readable this way. { idefloppy_t *floppy = drive-driver_data; struct gendisk *g

Re: [RFC PATCH] ide-floppy: remove struct idefloppy_capabilities_page

On Sunday 06 January 2008, Borislav Petkov wrote: Hi Bart, before removing all those typedefs in ide-floppy i wanted to check with you whether what i have in mind is in the right direction before doing all the work for nothing. Here's the first patch removing struct

[PATCH 0/8] ide: more IDE probing code rework

* Convert legacy host drivers to use struct ide_port_info + ide_device_add() instead of open-coding initialization of IDE port data structures. * Add -cable_detect method for cable detection + use it in PCI host drivers. * Fix some bugs in the process (handling of idex=ata66 in atiixp, cs5535

[PATCH 1/8] dtc2278: fix -io_32bit handling

On DTC2278 32-bit I/O has to be enabled for both devices on the port so always enable it during init time and disallow further changes. Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c|4 drivers/ide/legacy

[PATCH 2/8] au1xxx-ide: fix -io_32bit handling

The host driver must set hwif's -no_io_32bit setting not drive's one (ide_port_tune_devices() overrides drive's setting). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: b/drivers/ide

[PATCH 3/8] atiixp/cs5535/scc_pata: fix idex=ata66 parameter handling

cable detection to scc_cable_detect() from init_hwif_scc() and remove incorrect comment. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +16 bytes drivers/ide/pci/atiixp.c | 24 +++- drivers/ide/pci/cs5535.c |8 drivers/ide/pci/scc_pata.c

[PATCH 4/8] macide: remove drive-capacity64 quirk

Nowadays IDE core always provides drive ID and ide-disk always setups drive-capacity64 so this quirk is no longer needed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/macide.c | 10 -- 1 file changed, 10 deletions(-) Index: b/drivers/ide/legacy

[PATCH 5/8] ide: always set DMA masks in ide_pci_setup_ports()

Always set DMA masks in ide_pci_setup_ports() to make sure that the valid masks for a host are set. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +34 bytes drivers/ide/setup-pci.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) Index: b/drivers/ide/setup

[PATCH 6/8] ide: separate PCI specific init from generic init in ide_pci_setup_ports()

* Setup -mate and -channel in ide_pci_setup_ports() instead of in ide_hwif_configure(). * Make 'port' parameter for ide_hwif_configure() 'unsigned int'. * Separate PCI specific init from generic init in ide_pci_setup_ports(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +28

[PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

setup to pmac_ide_setup_device(). * Add 'struct ide_port_info' instances to legacy host drivers, pass them to ide_device_add() calls and then remove open-coded ports initialization. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c | 25

[PATCH 8/8] ide: add -cable_detect method to ide_hwif_t

tag to pdcnew_cable_detect() * pdc202xx_old.c: - rename pdc202xx_old_cable_detect() to pdc2026x_old_cable_detect() - add __devinit tag to pdc2026x_old_cable_detect() Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -105 bytes drivers/ide/ide-probe.c|5 ++ drivers/ide

Re: [PATCH] ide: delete filenames/versions from comments

Hi, On Thursday 03 January 2008, Robert Hancock wrote: Bartlomiej Zolnierkiewicz wrote: Delete filenames/versions from comments. I'm leaving decisions about adding DRV_VERSION defines and MODULE_VERSION()-s to maintainers of the respective drivers. While at it: * Remove

Re: [RESEND PATCH 02/10] ide-floppy: move ide-floppy struct and macro defs into its own header. While at it

Hi, On Saturday 05 January 2008, Borislav Petkov wrote: On Fri, Jan 04, 2008 at 11:49:09PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, Hi Bart, Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for moving code out of ide-floppy.c (and this patch series doesn't

Re: [RESEND PATCH 05/10] ide-floppy: factor out ioctl handlers from idefloppy_ioctl()

looks good, some minor issues noted below On Thursday 03 January 2008, Borislav Petkov wrote: There should be no functional change resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 90

Re: [RESEND PATCH 06/10] ide-floppy: report DMA handling in idefloppy_pc_intr() properly

On Thursday 03 January 2008, Borislav Petkov wrote: while at it: -cleanup small issues raised by scripts/checkpatch.pl -remove redundant and shorten some comments Could you split the above coding style fixes into a separate patch? There should be no functionality change resulting from this

Re: [RESEND PATCH 08/10] ide-floppy: mv idefloppy_{should_,}report_error

On Thursday 03 January 2008, Borislav Petkov wrote: Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 2c139e7..fd5fe7b 100644

Re: [RESEND PATCH 09/10] ide-floppy: use test_bit wrappers for testing flags

There are two issues here: * set_bit()/test_bit() are atomic operations and they don't see to be necessary in case of ide-floppy.c (standard '|'/'' should be enough) * using wrappers for these operations is not a bad idea but doing it _now_ just makes it harder for us to figure out how to

[PATCH 1/2] ide: don't include linux/hdsmart.h

IDE doesn't need it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h |1 - 1 file changed, 1 deletion(-) Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h

[PATCH 2/2] linux/hdsmart.h is not used by kernel code

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/hdsmart.h |2 ++ 1 file changed, 2 insertions(+) Index: b/include/linux/hdsmart.h === --- a/include/linux/hdsmart.h +++ b/include/linux/hdsmart.h

[PATCH 13/15] ide: move handling of I/O resources out of ide_probe_port()

Reserve/release I/O resources in ide_device_add_all() instead of ide_probe_port(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) Index: b/drivers/ide/ide-probe.c

[PATCH 10/15] ide: prepare init_irq() for using ide_remove_port_from_hwgroup()

* BUG_ON() early if 'hwif-next == hwif' and there is a 'match' hwgroup. * Remove printk() for impossible condition and add a BUG_ON(hwgroup-drive) to match code in ide_unregister(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -52 bytes drivers/ide/ide-probe.c |5

<    1   2   3   4   5   6   7   8   9   10   >