[ugly patch] Save .15W-.5W by AHCI powersaving

2008-02-25 Thread Pavel Machek
Hi! This is a patch (very ugly, assumes you have just one disk) to bring powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch as a base. It saves .5W compared to config with disk spinning, and even .15W compared to hdparm -y... on my thinkpad x60 anyway. It is also mandatory

Re: [ugly patch] Save .15W-.5W by AHCI powersaving

2008-02-25 Thread Pavel Machek
Hi! This is a patch (very ugly, assumes you have just one disk) to bring powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch as a base. It saves .5W compared to config with disk spinning, and even .15W compared to hdparm -y... on my thinkpad x60 anyway. .. There was a

Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors

2008-02-25 Thread Pavel Machek
On Mon 2008-02-25 16:04:08, Jeff Garzik wrote: Michael S. Tsirkin wrote: git bisect points at this commit: commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. power_state: get rid of write-only variable in SATA Hello Pavel -- It looks like this not a write-only variable after all... Yep,

Re: 2.6.25-rc2 + smartd = hang

2008-02-23 Thread Pavel Machek
Hi! So that's using the old IDE drivers. And the network and USB are sharing IRQ#11 with each other. If you are going to be using newer kernels like this (2.6.23+), then you might consider shifting those drives over to libata drivers. Yes, that will probably fix it for him, but

Re: [PATCH] enclosure: add support for enclosure services

2008-02-19 Thread Pavel Machek
On Wed 2008-02-13 09:45:02, Kristen Carlson Accardi wrote: On Tue, 12 Feb 2008 13:28:15 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: I understand what you are trying to do - I guess I just doubt the value you've added

Re: 2.6.26-git0: IDE oops during boot

2008-02-06 Thread Pavel Machek
On Wed 2008-02-06 11:53:34, Pavel Machek wrote: Hi! Trying to boot 2.6.25-git0 (few days old), I get BUG: unable to handle kernel paging request at ..ffb0 IP at init_irq+0x42e Call trace: ide_device_add_all ide_generic_init kernel_init child_rip vgacon_cursor kernel_init

Re: [patch] ata: ahci: Enclosure Management via LED

2007-12-07 Thread Pavel Machek
Hi! +static int ahci_em_messages = 1; +module_param(ahci_em_messages, int, 0444); +/* add other LED protocol types when they become supported */ +MODULE_PARM_DESC(ahci_em_messages, + Set AHCI Enclosure Management Message type (0 = disabled, 1 = LED); Should you add line in Doc*

Re: Possibly SATA related freeze killed networking and RAID

2007-11-30 Thread Pavel Machek
On Fri 2007-11-30 10:00:55, Mark Lord wrote: Pavel Machek wrote: On Fri 2007-11-30 13:13:44, Alan Cox wrote: Why does a single spurious interrupt cause it to be shut down? I can It doesn't. see if the interrupt is stuck on and keeps interrupting constantly, but if it's just

Re: Possibly SATA related freeze killed networking and RAID

2007-11-30 Thread Pavel Machek
On Fri 2007-11-30 13:13:44, Alan Cox wrote: Why does a single spurious interrupt cause it to be shut down? I can It doesn't. see if the interrupt is stuck on and keeps interrupting constantly, but if it's just the occasional spurious interrupt, why not just ignore it and move on?

Re: Possibly SATA related freeze killed networking and RAID

2007-11-26 Thread Pavel Machek
Hi! kernel: [734344.717844] irq 21: nobody cared (try booting with the irqpoll option) kernel: [734344.717866] Your machine decided to emit interrupt 21 without an apparent reason. Whatever caused that made the kernel shut down IRQ 21 at which point the disk drives on that IRQ were

size of git repository (was Re: [BUG] New Kernel Bugs)

2007-11-18 Thread Pavel Machek
On Tue 2007-11-13 12:50:08, Mark Lord wrote: Ingo Molnar wrote: for example git-bisect was godsent. I remember that years ago bisection of a bug was a very laborous task so that it was only used as a final, last-ditch approach for really nasty bugs. Today we can autonomouly bisect

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Pavel Machek
Hi! Suspend to RAM resume hangs on a tickless (NO_HZ) kernel http://bugzilla.kernel.org/show_bug.cgi?id=9275 Kernel: 2.6.23 This is HP notebook nc6320 T2400 945GM No response from developers Maybe I'm optimistic, but I expected Ingo/Thomas to look after nohz problems. nohz=off

Re: Disk spin down issue on shut down/suspend to disk

2007-08-09 Thread Pavel Machek
Hi! Oh... crap, so acpi wants to sync cache on shutdown. I wonder whether it spins down the disk correctly. Does emergency unload count increase after each power down? Also, please post the result of 'dmidecode'. I know that my Compaq X1000-series laptop does do some kind of ACPI

Re: Disk spin down issue on shut down/suspend to disk

2007-08-09 Thread Pavel Machek
Hi! firmwarekit-discuss [EMAIL PROTECTED] (added to CC list) see: http://linuxfirmwarekit.org/ But if I understand this problem right, this won't be easy. The ACPI tables are just parsed with system (iasl ...) and syntactical errors/warnings are printed out. I also thought about a

Re: [patch 0/3] AHCI Link Power Management

2007-06-13 Thread Pavel Machek
Hi! I'm not sure about this. We need better PM framework to support powersaving in other controllers and some ahcis don't save much when only link power management is used, do you have data to support this? Yeah, it was some Lenovo notebook. Pavel is more familiar with the

Re: [patch 0/3] AHCI Link Power Management

2007-06-13 Thread Pavel Machek
Hi! Yeah, it was some Lenovo notebook. Pavel is more familiar with the hardware. Pavel, what was the notebook which didn't save much power with standard SATA power save but needed port to be completely turned off? Pavel, if you have time, could you measure this with Kristen's

Re: [patch 0/3] AHCI Link Power Management

2007-06-13 Thread Pavel Machek
Hi! I'm not sure about this. We need better PM framework to support powersaving in other controllers and some ahcis don't save much when only link power management is used, do you have data to support this? Yeah, it was some Lenovo notebook. Pavel is more familiar with the

Re: Loud pop coming from hard drive on reboot

2007-04-15 Thread Pavel Machek
Hi! When I reboot my notebook, it powers off and powers back on. On poweroff a loud snapping noise seems to be coming from the hard drive. Today I noticed there is no shutdown: hda on the console when I reboot. Whne I do a normal poweroff the message is displayed and there is no noise.

Re: ATA ACPI (was Re: Linux 2.6.21-rc5)

2007-03-28 Thread Pavel Machek
Hi! So if you have reported a regression in the 2.6.21-rc series, please check 2.6.21-rc5, and update your report as appropriate (whether fixed or still problems with xyzzy). [just got back from vacation, or would have sent this earlier] FWIW, I'm still leaning towards disabling

Re: [5/6] 2.6.21-rc3: known regressions

2007-03-13 Thread Pavel Machek
/2007/2/24/41 Submitter : Pavel Machek [EMAIL PROTECTED] Status : unknown Subject: beeps get longer after suspend References : http://lkml.org/lkml/2007/2/26/276 Submitter : Pavel Machek [EMAIL PROTECTED] Status : unknown Seems fixed in -rc3

Re: [PATCH/RFC] implement __attribute_discard_text/data__ and use it to leave out PM functions if !CONFIG_PM

2007-03-10 Thread Pavel Machek
Hi! This patch is the result from the following discussion. http://thread.gmane.org/gmane.linux.ide/16475 The problem is that CONFIG_PM affects a lot of low level drivers and scattering CONFIG_PM all over the place is too ugly. This patch... * implements __attribute_discard_text__

Re: [PATCH 1/3] libata: add missing PM callbacks

2007-03-06 Thread Pavel Machek
Hi! [cc'ing Pavel and linux-kernel, hello] Original thread can be read from http://thread.gmane.org/gmane.linux.ide/16475 Jeff Garzik wrote: Tejun Heo wrote: Some LLDs were missing scsi device PM callbacks while having host/port suspend support. Add missing ones.

Re: [PATCH 1/3] libata: add missing PM callbacks

2007-03-06 Thread Pavel Machek
Hi! Much complexity for little gain. Who is running _without_ CONFIG_PM these days? Embedded people, I guess. The problem here is that if we are gonna support !CONFIG_PM configuration and try to reduce the kernel/module images size for such case, we end up sprinkling #ifdef's all over

Re: pcim_enable_device BUGs for libata devices in 2.6.20-git6

2007-02-12 Thread Pavel Machek
Hi! I'm seeing BUGs like these on all libata-driven controllers when suspending to disk on 2.6.20-git6: sata_nv :00:07.0: resuming BUG: at drivers/pci/pci.c:817 pcim_enable_device() Call Trace: [80337d21] pcim_enable_device+0x8a/0xa5 [88099d18]

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-27 Thread Pavel Machek
Hi! Please make the interface accept number of seconds (as suggested by Jens) and remove this module parameter. This way interface will be more flexible and cleaner. I really don't see any advantage in doing echo 1 ... instead of echo x ... (Pavel, please explain). Either