Re: [PATCH 7/9] libata: stop overloading port_info->private_data

2008-02-08 Thread Tejun Heo
Alan Cox wrote: > On Wed, 30 Jan 2008 18:29:01 +0900 > Tejun Heo <[EMAIL PROTECTED]> wrote: > >> port_info->private_data is currently used for two purposes - to record >> private data about the port_info or to specify host->private_data to >> use when allocating ata_host. > > Sensible point, horr

Re: [PATCH 7/9] libata: stop overloading port_info->private_data

2008-02-04 Thread Alan Cox
On Wed, 30 Jan 2008 18:29:01 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > port_info->private_data is currently used for two purposes - to record > private data about the port_info or to specify host->private_data to > use when allocating ata_host. Sensible point, horrible implementation - I'd NA

[PATCH 7/9] libata: stop overloading port_info->private_data

2008-01-30 Thread Tejun Heo
port_info->private_data is currently used for two purposes - to record private data about the port_info or to specify host->private_data to use when allocating ata_host. This overloading is confusing and counter-intuitive in that port_info->private_data becomes host->private_data instead of port->