Re: [PATCH] falconide: fix resources reservation

2008-02-20 Thread Geert Uytterhoeven
On Wed, 20 Feb 2008, Bartlomiej Zolnierkiewicz wrote: * Tell IDE layer to not manage resources by setting hwif-mmio flag and request resources in falconide_init(). * Use request_mem_region() for resources reservation. * Use driver name for resources reservation. Cc: Geert Uytterhoeven

Re: PROBLEM: I/O scheduler problem with an 8 SATA disks raid 5 under heavy load ?

2008-02-20 Thread Guillaume Laurès
Hello all, A bit of update to this issue. Switching the cabling of the most problematic drive with a new one didn't fix the issue. I couldn't yet switch the power supply with a more powerful one. However I temporarily added a pci-e SATA host and another drive, the situation was just as

[PATCH] ide-generic: Fix no initalization of idx in some case

2008-02-20 Thread Johann Felix Soden
From: Johann Felix Soden [EMAIL PROTECTED] If the slot is already occupied, there should be written 0xff to idx[i]. In the ongoing code and in this case there are no writings to idx[i], so garbage stays in idx. The kernel get into a endless loop printing: : I/O resource 0x0-0x0 not free. Trying

Re: [BUG] next-20080219 - ide oops while bootup at ide_device_add_all ()

2008-02-20 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 20 February 2008, Kamalesh Babulal wrote: Hi, The next-20080219 kernel oops while booting up on x86_64 box. This bug was fixed in the 2.6.24-git(s) with the patch posted at http://lkml.org/lkml/2008/2/11/350 ide0 at 0x1f0-0x1f7,0x3f6 on irq 14 BUG: unable to handle

Re: [PATCH] ide-generic: Fix no initalization of idx in some case

2008-02-20 Thread Bartlomiej Zolnierkiewicz
On Wednesday 20 February 2008, Johann Felix Soden wrote: From: Johann Felix Soden [EMAIL PROTECTED] If the slot is already occupied, there should be written 0xff to idx[i]. In the ongoing code and in this case there are no writings to idx[i], so garbage stays in idx. The kernel get into a

Re: hdparm-8.2 now available

2008-02-20 Thread Greg Freemyer
Mark, What kernel level is needed to support the new -N arg? Tried it on a Suse 2.6.22 kernel (possibly not patched with all the current security updates). Failed with: The Running Kernel Lack CONFIG_IDE_TASK_IOCTL Support. Thanks Greg On Mon, Feb 18, 2008 at 7:25 PM, Mark Lord [EMAIL

Re: hdparm-8.2 now available

2008-02-20 Thread Mark Lord
Greg Freemyer wrote: Mark, What kernel level is needed to support the new -N arg? .. I believe it should work with 2.4.0 or newer. But some kernels have a buggy implementation of it. Tried it on a Suse 2.6.22 kernel (possibly not patched with all the current security updates). Failed with:

Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: Use ld_qdi and ld_winbond to avoid shadowing static int variables qdi and winbond. The ld_ prefix refers to legacy_data. drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here

Re: [PATCH] sata_mv: Define module alias for platform device

2008-02-20 Thread Jeff Garzik
Martin Michlmayr wrote: The sata_mv driver can be loaded as a platform device, as is done by various Orion (ARM) based devices. The driver needs to define a module alias for the platform driver so udev will load it automatically. Tested with Debian on a QNAP TS-209. Signed-off-by: Martin

Re: [PATCH 1/2] sata_mv: use hpriv-base instead of the host-iomap

2008-02-20 Thread Jeff Garzik
Saeed Bishara wrote: this fixes crash bug as the iomap table is not valid for integrated controllers. Signed-off-by: Saeed Bishara [EMAIL PROTECTED] --- drivers/ata/sata_mv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c

Re: [PATCH] ata: fix sparse warning in libata.h

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: Avoids lots of these, also is more readable. include/linux/libata.h:1210:13: warning: potentially expensive pointer subtraction Change the subtraction to addition on the other side of the comparison. Thanks to Christer Weinigel for the suggestion. Signed-off-by: Harvey

Re: [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it

2008-02-20 Thread Jeff Garzik
Mark Lord wrote: Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir. That's nice, but most SATA devices which need it will tell us about it in their IDENTIFY PACKET response, as bit-15 of word-62 of the returned data (as per ATA7, ATA8 specifications). So for those which

Re: [PATCH] sata_mv: remove iounmap in mv_platform_remove and use devm_iomap

2008-02-20 Thread Jeff Garzik
Saeed Bishara wrote: this will fix crash bug when doing rmmod to the driver, this is because the port_stop function get called later and it could access the device's registers. Signed-off-by: Saeed Bishara [EMAIL PROTECTED] --- drivers/ata/sata_mv.c |6 ++ 1 files changed, 2

[git patches] libata fixes

2008-02-20 Thread Jeff Garzik
Note: Tejun's change is a feature addition, but one that is IMO important for debugging and serious-bug workarounds. It's self-contained and should not affect anyone not using the new parm. Please pull from 'upstream-linus' branch of

Re: [PATCH] libata: fix kernel-doc parameter warning

2008-02-20 Thread Jeff Garzik
Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Fix libata kernel-doc parameter: Warning(linux-2.6.25-rc2-git3//drivers/ata/libata-scsi.c:845): No description found for parameter 'rq' Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/ata/libata-scsi.c |2 +- 1 file

Re: What's needed for PMP support?

2008-02-20 Thread Mark Lord
Tejun Heo wrote: The following things are needed for a LLD to support PMP. .. I think that's about it. Feel free to ask if something isn't clear. .. Tejun, I've added PMP to sata_mv, and am now trying to get it to work with a Marvell PM attached. And the behaviour I see is very bizarre.

Re: [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it

2008-02-20 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir. That's nice, but most SATA devices which need it will tell us about it in their IDENTIFY PACKET response, as bit-15 of word-62 of the returned data (as per ATA7, ATA8 specifications).

Re: sata_sil24 not configuring drive right?

2008-02-20 Thread Johann-Christoph Jacob
Hello i do have a NCQ queue_depth of 1 too and my /sys/block/sda/device/queue_depth is not writeable. I thought i'd take the time to provide you with the hdparm output hoping this minor issue can be resolved. Yours faithfully Johann-Christoph Jacob From uname -a: Linux amilo 2.6.24.2 #1

Re: [PATCH] falconide: fix resources reservation

2008-02-20 Thread Bartlomiej Zolnierkiewicz
On Wednesday 20 February 2008, Geert Uytterhoeven wrote: On Wed, 20 Feb 2008, Bartlomiej Zolnierkiewicz wrote: * Tell IDE layer to not manage resources by setting hwif-mmio flag and request resources in falconide_init(). * Use request_mem_region() for resources reservation. * Use

[PATCH 1/2] ide: fix enabling DMA on it821x in smart mode

2008-02-20 Thread Bartlomiej Zolnierkiewicz
ide_tune_dma() should return '1' if IDE_HFLAG_NO_SET_MODE host flag is set. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- I wonder how this could have slipped in :( Sergei, please double-check this patch. Thanks! drivers/ide/ide-dma.c |

[PATCH 2/2] ide: remove IDE_HFLAG_CY82C693 host flag

2008-02-20 Thread Bartlomiej Zolnierkiewicz
Sergei suggested that it shouldn't be necessary + it had no effect anyway since ide_id_dma_bug() is called earlier in ide_tune_dma(). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- I went ahead since I urgently needed to re-cycle one host

Re: sata_sil24 not configuring drive right?

2008-02-20 Thread Johann-Christoph Jacob
Hello again, my problem is not with the transfer mode but with the NCQ queue_depth. My bootlog shows: ata1.00: 234441648 sectors, multi 16: LBA48 NCQ (depth 1) but i would like it to show: ata1.00: 234441648 sectors, multi 16: LBA48 NCQ (depth 31/32) or something similar. I was not exact enough

[PATCH RFC] libata-core: do something about flush cache

2008-02-20 Thread Alan Cox
The IDE layers assume a failed flush cache is a simple error, but it is actually far more complicated. The spec says that an error is returned by flush cache if a sector cannot be committed to disc. In that case the failed sector is dropped from cache and the command reports the bad sector. It

[PATCH] ide: remove hwif-straight8 flag

2008-02-20 Thread Bartlomiej Zolnierkiewicz
All host drivers now either set hwif-mmio or reserve continuous I/O resources so remove no longer needed hwif-straight8 flag and never reached code for 'hwif-straight8 == 0' case. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 36

Re: sata_sil24 not configuring drive right?

2008-02-20 Thread Tejun Heo
Johann-Christoph Jacob wrote: my problem is not with the transfer mode but with the NCQ queue_depth. My bootlog shows: ata1.00: 234441648 sectors, multi 16: LBA48 NCQ (depth 1) but i would like it to show: ata1.00: 234441648 sectors, multi 16: LBA48 NCQ (depth 31/32) or something similar. I

Re: [PATCH] scsi: align shost-hostdata to cacheline

2008-02-20 Thread Tejun Heo
James Bottomley wrote: On Fri, 2008-02-15 at 07:49 +0900, Tejun Heo wrote: James Bottomley wrote: On Thu, 2008-02-14 at 18:48 +0900, Tejun Heo wrote: shost-hostdata can contain arbitrary data including DMA target buffers. Align it to cacheline. Signed-off-by: Tejun Heo [EMAIL PROTECTED]

[PATCH] libata: automatically use DMADIR if drive/bridge requires it

2008-02-20 Thread Tejun Heo
Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir. That's nice, but most SATA devices which need it will tell us about it in their IDENTIFY PACKET response, as bit-15 of word-62 of the returned data (as per ATA7, ATA8 specifications). So for those which specify it, we