Re: [RFC-UGLYPATCH] ata: small optimization in linux/libata.h

2008-02-15 Thread Mikael Pettersson
Tejun Heo writes: Harvey Harrison wrote: I know it's ugly, but I had it done anyways. The one real problem I have with it is that if link and ap-pmp_link ever get changed to different types the compiler will not even warn as we cast away to (char *). To make it a bit more

Re: [PATCH 09/13] sata_mv ncq Use DMA memory pools for hardware memory tables

2008-01-31 Thread Mikael Pettersson
Mark Lord writes: Tejun Heo wrote: .. I'm skeptical about the benefit of IRQ coalescing on storage controllers. Coalescing improves performance when there are many small requests to complete and if you put a lot of small non-consecutive requests to a disk, it gets really really

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Mikael Pettersson
Gene Heskett writes: On Tuesday 29 January 2008, Alan Cox wrote: As slight change here, I was going to use the same .config as 2.6.24-rc8, but just discovered that neither rc8 nor final is finding the drivers for my If it is not finding a driver that is nothing to do with libata.

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mikael Pettersson
Gene Heskett writes: On Monday 28 January 2008, Peter Zijlstra wrote: On Mon, 2008-01-28 at 09:17 +0100, Mikael Pettersson wrote: 1. Wrong mailing list; use linux-ide (@vger) instead. What, and keep all us other interested people in the dark? As a test, I tried rebooting

Re: Linux 2.6.24 sata_promise SATA300TX4 problems

2008-01-26 Thread Mikael Pettersson
Peter Favrholdt writes: Hi Mikael list, I have previously reported problems with my setup: SATA300TX4 + 4 Seagate Barracuda ES 500GB I just tested with 2.6.24. After copying approx 25GB of each drive using dd if=/dev/sd[abcd] of=/dev/null bs=1M sda failed with the following

Re: Linux 2.6.24 sata_promise SATA300TX4 problems

2008-01-26 Thread Mikael Pettersson
Peter Favrholdt writes: Hi Mikael, Thanks for your reply :-) Mikael Pettersson wrote: Mysterious. What you have there is a transmission error between the controller and the disk, which is bad in and by itself, but then there's a sequence of COMRESETs that fail to bring

Re: The SX4 challenge

2008-01-20 Thread Mikael Pettersson
Jeff Garzik writes: Promise just gave permission to post the docs for their PDC20621 (i.e. SX4) hardware: http://gkernel.sourceforge.net/specs/promise/pdc20621-pguide-1.2.pdf.bz2 joining the existing PDC20621 DIMM and PLL docs:

Re: sata_promise: Keeps saying SATA link down (SStatus 0 SControl 0)

2008-01-16 Thread Mikael Pettersson
Kurt Roeckx writes: On Tue, Jan 15, 2008 at 10:28:06AM +0100, Mikael Pettersson wrote: 00:08.0 RAID bus controller: Promise Technology, Inc. PDC20376 (FastTrak 376) (rev 02) ... 00:08.0 0104: 105a:3376 (rev 02) Let me guess, this is a Promise chip included

Re: sata_promise: Keeps saying SATA link down (SStatus 0 SControl 0)

2008-01-14 Thread Mikael Pettersson
Kurt Roeckx writes: Hi, I've just tried the 2.6.24-rc7 kernel (from Debian's experimental kernel archive), running the x86_64 kernel. I keep getting things like this in my log: Jan 13 19:21:10 intrepid kernel: ata2: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0xa frozen

Re: SATA timeouts on two disks

2008-01-13 Thread Mikael Pettersson
Jim MacBaine writes: Hi, Recently I'm experiencing strange sata errors on my desktop system. The system was recently equipped with three 250 GB SATA drives from Clue #1: added drives three different manufacturers and I'm having an identical problem on two of them. The drives are

Re: Re:Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-04 Thread Mikael Pettersson
Linda Walsh writes: Mikael Pettersson wrote: Linda Walsh writes: Robert Hancock wrote: Linda Walsh wrote: read rate began falling; at 128k block-reads-at-a-time or larger, it drops below 20MB/s (only on buffered SATA). But more importantly -- I notice

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-03 Thread Mikael Pettersson
Linda Walsh writes: Robert Hancock wrote: Linda Walsh wrote: Alan Cox wrote: rate began falling; at 128k block-reads-at-a-time or larger, it drops below 20MB/s (only on buffered SATA). Try disabling NCQ - see if you've got a drive with the 'NCQ = no readahead' flaw.

Re: PIIX driver

2008-01-02 Thread Mikael Pettersson
Kalev Toots writes: Hello For specific reason I need to install old FC4 ( kernel 2.6.11 ) to new hardware ( Intel DP35DP motherboard ). Installation failed and the reason I think is that FC4 ata-piix driver don't have ICH9 support. Is it possible to port new ata-piix driver ( from

Re: HSM violation erros on sata_promise

2007-12-27 Thread Mikael Pettersson
Theo Baumgartner writes: Hello List I'm getting these HSM violation's too on all the SATA 300 TX4 ports with Seagate ST3250824NS disks. In the files attached are informations about the system with logs included and the kernel .config. Theo This is on Promise SATA300 TX4

Re: stable basic 4-port SATA card

2007-12-13 Thread Mikael Pettersson
Patric Karlsson writes: Mikael Pettersson wrote: On Thu, 15 Nov 2007 12:32:14 +0900, Tejun Heo wrote: * sata_promise: Generally works okay; however there are still some problems with recent 3Gbps chips. (Mikael, please pitch in) Right, 2nd-gen 3Gbps chips have had intermittent

Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc-tf

2007-12-03 Thread Mikael Pettersson
On Mon, 03 Dec 2007 13:49:36 +0900, Tejun Heo wrote: Mikael Pettersson wrote: what was the outcome of this discussion? I haven't looked over the Promise datasheet nor checked my brain for details, hoping Mikael would do that for me ;-) I've now tested this on top of 2.6.24-rc3

Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc-tf

2007-12-02 Thread Mikael Pettersson
On Sat, 01 Dec 2007 18:23:44 -0500, Jeff Garzik wrote: Tejun Heo wrote: Make pdc_atapi_pkt() use values from qc-tf instead of creating its own. This is to ease future ATAPI handling changes. DONT APPLY YET --- Mikael, would this work? Values other than lbam and lbah remain the

Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc-tf

2007-11-26 Thread Mikael Pettersson
On Mon, 26 Nov 2007 20:34:38 +0900, Tejun Heo wrote: Make pdc_atapi_pkt() use values from qc-tf instead of creating its own. This is to ease future ATAPI handling changes. DONT APPLY YET --- Mikael, would this work? Values other than lbam and lbah remain the same. Does sata_promise have

Re: Promise SATA TX4 300 port timeout with sata_promise in 2.6.22, kernel panic in 2.6.23

2007-11-12 Thread Mikael Pettersson
for testing purposes than the average machine with 22 Promise SATA ports.. :) [cc'ing Mikael Pettersson] It seems those 3Gbps promise controllers have hard time getting out of transmission errors. Is it because hardreset doesn't work? Can we fix it? Also, if 3Gbps can't be made reliable on those

Re: Bart's efforts?

2007-11-09 Thread Mikael Pettersson
Mikael Pettersson writes: On Sat, 3 Nov 2007 14:10:22 +, Alan Cox wrote: My question is if the drivers/ide infrastructure is slowly moving in the direction of being leverageable by libata when/if it moves out of scsi. Or does the drivers/ide code simply have the wrong kind

Re: Bart's efforts?

2007-11-03 Thread Mikael Pettersson
On Sat, 3 Nov 2007 14:10:22 +, Alan Cox wrote: My question is if the drivers/ide infrastructure is slowly moving in the direction of being leverageable by libata when/if it moves out of scsi. Or does the drivers/ide code simply have the wrong kind of plumbing for libata to ever use.

Re: Bart's efforts?

2007-11-03 Thread Mikael Pettersson
Alan Cox wrote: 2) pata_pdc202xx_old can't do UDMA on my 440BX PIII box Bug # ? No bz # yet, but you and I had a private email conversation about this on March 13 and 15 this year. There's been a couple of recent reports to linux-ide with identical (as far as I can see) issues as I get:

Re: [git patches] libata fixes

2007-10-31 Thread Mikael Pettersson
On Tue, 30 Oct 2007 11:54:01 -0700 (PDT), Linus Torvalds wrote: On Tue, 30 Oct 2007, Jeff Garzik wrote: Mikael Pettersson (2): sata_promise: ASIC PRD table bug workaround, take 2 sata_promise: cleanups You and Mikael need to sort out the way you send/accept patches

[PATCH 2.6.24-rc1] sata_promise: fix endianess bug in ASIC PRD bug workaround

2007-10-31 Thread Mikael Pettersson
format, so do the adjustment on host-endian data and then convert and store it in the PRD entry's little-endian data field. Thanks to an anonymous reviewer for detecting this bug. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- Jeff: please include this fix in any backport(s) of the ASIC PRD bug

Re: [PATCH 2.6.24-rc1] sata_promise: ASIC PRD table bug workaround

2007-10-30 Thread Mikael Pettersson
On Mon, 29 Oct 2007 15:07:06 -0400, Jeff Garzik wrote: Mikael Pettersson wrote: @@ -155,7 +155,7 @@ static struct scsi_host_template pdc_ata .queuecommand = ata_scsi_queuecmd, .can_queue = ATA_DEF_QUEUE, .this_id= ATA_SHT_THIS_ID

[PATCH 2.6.24-rc1 1/2] sata_promise: ASIC PRD table bug workaround, take 2

2007-10-30 Thread Mikael Pettersson
the vendor driver, and for writing the initial patch upon which this one is based. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] -- Changes since previous version: * use new PDC_MAX_PRD constant to initialise sg_tablesize drivers/ata/sata_promise.c | 87

[PATCH 2.6.24-rc1 2/2] sata_promise: cleanups

2007-10-30 Thread Mikael Pettersson
Minor sata_promise cleanups: - use C99 array initialisers in pdc_port_info[] - add myself in the file head's Maintained by note, since users don't always read the MAINTAINERS file - SG/PRD bug workaround warrants driver version bump Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] -- drivers

Re: [PATCH-RFC] Promise TX4 implement hw-bug workaround

2007-10-28 Thread Mikael Pettersson
On Sun, 28 Oct 2007 06:29:32 -0400, Jeff Garzik wrote: BTW, looking at the Promise code I see cam_con.h: /* for ASIC bug, limit the last element of SG byteCount must 32 Dword */ #define SG_COUNT_ASIC_BUG 32 //#define SG_COUNT_ASIC_BUG 128 and in the code itself

Re: [PATCH-RFC] Promise TX4 implement hw-bug workaround

2007-10-28 Thread Mikael Pettersson
On Sun, 28 Oct 2007 12:03:16 +0100 (MET), Mikael Pettersson wrote: On Sun, 28 Oct 2007 06:29:32 -0400, Jeff Garzik wrote: BTW, looking at the Promise code I see cam_con.h: /* for ASIC bug, limit the last element of SG byteCount must 32 Dword */ #define SG_COUNT_ASIC_BUG 32

Re: [PATCH-RFC] (was: Re: Sata Sil3512 bug?; Promise SATA300 TX4)

2007-10-27 Thread Mikael Pettersson
On Sat, 27 Oct 2007 17:24:32 +0400, Alexander Sabourenkov wrote: There appears to be a hardware bug in that it chokes on scatterlist if the last item is larger than 164 bytes. The patch that follows fixes my problem on 2.6.22. I can't think of a way to avoid second pass over scatterlist

2.6.24-rc1 IDE regression on PMAC?

2007-10-27 Thread Mikael Pettersson
As shown by this dmesg diff between 2.6.23 and 2.6.24-rc1, IDE's PMAC driver now decides to downgrade itself to PIO2 on this box. Is this intensional or a bug? --- dmesg-2.6.23 +++ dmesg-2.6.24-rc1 @@ -84,8 +89,9 @@ ide0: Found Apple Heathrow ATA controller, bus ID 0, irq 28 Probing IDE

Re: Re-enabling Serial ATA ports possible?

2007-10-17 Thread Mikael Pettersson
On Wed, 17 Oct 2007 14:38:04 +0200, Marcin Juszkiewicz wrote: On my system (2.6.23-rc9) I have Serial-ATA DVD/RW drive connected to sata_sil controller. Sometimes when there is a problem with CD or DVD disk controller shutdowns drive: [53560.095573] cdrom: sr0: mrw address space DMA

Re: Bug is fixed in 2.6.23.1: sata_promise: port is slow to respond, reset failed

2007-10-15 Thread Mikael Pettersson
On Sun, 14 Oct 2007 11:21:13 +0200, Peter Favrholdt wrote: The problem is solved in 2.6.23.1 regarding the port slow to respond issue. I'm using sata_promise on Promise Technology, Inc. PDC40718 (SATA 300 TX4) (rev 02) and 4 Seagate 500GB ES drives. Using 2.6.23.1 it is possible to run

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-10-14 Thread Mikael Pettersson
On Sun, 14 Oct 2007 13:31:34 -0400, Jeff Garzik wrote: Mikael Pettersson wrote: On Thu, 16 Aug 2007 21:19:40 +0100, Alan Cox wrote: Unfortunately this breaks pata_pdc2027x on my PowerMac G3: Did this ever get resolved? All went quiet so I assume its gone away ? -ENOTIME

Re: PDC20267 (Promise FastTrak100) instabillity/resets with newer kernels.

2007-10-04 Thread Mikael Pettersson
Yanko Kaneti writes: Hi The integrated PDC20267 (FastTrak100 BIOS version 2.30.0140.13) controller in following constants hardware setup behaves differently under live-cd fedora kernels 2.6.18-1.2869 and 2.6.23-0.214.rc8.git2.fc8. - Intel S845WD1-E server motherboard with onboard

Re: Re[2]: Sata Sil3512 bug?

2007-10-03 Thread Mikael Pettersson
On Tue, 2 Oct 2007 21:20:23 +0200, MisterE wrote: I build another setup with almost the same hardware. This motherboard had already the latest bios. I notice that the computer does almost never find the hard drive although the controller is found every time (with lspci). So i get no drive

Re: Problems with Promise controller or Seagate 500g ST3500630AS ?

2007-09-18 Thread Mikael Pettersson
Glen Larkins writes: Corrected. With only 1 of the 500g drives connected, I can boot fine. With all drives connected, I suddenly began getting COMRESET failed (errno=-16) and hearing physical noises from the two 80g drives connected to the motherboard sata. This has never occurred. This

Re: [Bugme-new] [Bug 8976] New: Regression (ata_piix): Kernel panic during driver initialization

2007-09-04 Thread Mikael Pettersson
Andrew Morton writes: On Mon, 3 Sep 2007 13:40:10 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8976 This one is apparantly a post-2.6.22 regression. The ata_piix oops at init bug in 2.6.23-rc5 has already been fixed. There's a link to the patch at

Re: sata_promise: port is slow to respond, reset failed

2007-09-04 Thread Mikael Pettersson
Peter Favrholdt writes: Hi, Below some more info on my two systems: Mikael Pettersson wrote: I assume the PE1800 has some Intel chipset? Which one? ... :00:1e.0 PCI bridge: Intel Corp. 82801 PCI Bridge (rev c2) :00:1f.0 ISA bridge: Intel Corp. 82801EB/ER (ICH5/ICH5R) LPC

Re: sata_promise: port is slow to respond, reset failed

2007-09-04 Thread Mikael Pettersson
Peter Favrholdt writes: Mikael Pettersson wrote: nForce2. Hmm.. Peter Favrholdt wrote: 11: 27474XT-PIC-XTlibata, libata, ohci_hcd:usb3, NVidia nForce2 That mystery device makes me strongly suspect that you've loaded the binary-only nvidia drivers

Re: sata_promise: port is slow to respond, reset failed

2007-09-02 Thread Mikael Pettersson
On Sun, 02 Sep 2007 13:12:42 +0200, Peter Favrholdt wrote: I'm still experiencing the same port is slow to respond problem using sata_promise in linux-2.6.22.6 with my Promise Technology, Inc. PDC40718 (SATA 300 TX4) (rev 02) and 4 Seagate 500GB ES drives: Model Number:

Re: sata_promise: port is slow to respond, reset failed

2007-09-02 Thread Mikael Pettersson
On Sun, 2 Sep 2007 17:11:36 +0200 (MEST), Mikael Pettersson wrote: On Sun, 02 Sep 2007 13:12:42 +0200, Peter Favrholdt wrote: I'm still experiencing the same port is slow to respond problem using sata_promise in linux-2.6.22.6 with my Promise Technology, Inc. PDC40718 (SATA 300 TX4) (rev

[PATCH 2.6.23-rc4] sata_promise: FastTrack TX4200 is a second-generation chip

2007-08-29 Thread Mikael Pettersson
triggered by the hotplug-enabling changes in 2.6.23-rc1. 2. Various failed to resume link for reset warnings. This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8936. Thanks to Stephen Ziemba for reporting the bug and for testing the fix. Signed-off-by: Mikael Pettersson [EMAIL

Re: [PATCH] pata_via: Add Armia W730-K8 and other rebadgings

2007-08-23 Thread Mikael Pettersson
== 0x161F pdev-subsystem_device == 0x2032) + return 1; return 0; } s/Armia/Arima/ Apart from that it works fine on my '811. Tested-by: Mikael Pettersson [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

[PATCH 2.6.23-rc3] pata_via cable override for Arima W730-K8

2007-08-22 Thread Mikael Pettersson
On Fri, 3 Aug 2007 23:32:17 +0100, Alan Cox wrote: On Fri, 3 Aug 2007 20:28:39 +0200 (MEST) Mikael Pettersson [EMAIL PROTECTED] wrote: The machine is an Athlon64 laptop with a K8T800 chipset. With the IDE VIA driver the disk is detected as udma/100: Currently old IDE via driver has a hack

Re: [PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-19 Thread Mikael Pettersson
On Sun, 19 Aug 2007 20:13:46 +0400, Sergei Shtylyov wrote: Mikael Pettersson wrote: Previously I reported that the pata_pdc2027x PLL detection changes in kernel 2.6.22 broke the driver on my PowerMac: pata_pdc2027x: Invalid PLL input clock 1691742kHz, give up! This is followed

[PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-18 Thread Mikael Pettersson
detection failure on my PowerMac, and doesn't cause any regressions on an x86 with an identical card. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- drivers/ata/pata_pdc2027x.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff -rupN linux-2.6.23-rc3/drivers

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-12 Thread Mikael Pettersson
On Fri, 10 Aug 2007 18:33:43 +0100, Alan Cox wrote: However, I'm gettting consistently lower read throughput with pata_artop (13-19 MB/s) than with aec62xx (22 MB/s) on an oldish WD drive, and using pata_artop triggers a WARN_ON(irqs_disabled()) in arch/arm/mm/consistent.c: It would be

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-10 Thread Mikael Pettersson
On Fri, 10 Aug 2007 01:45:38 +0200, Bartlomiej Zolnierkiewicz wrote: On Friday 10 August 2007, Alan Cox wrote: On Thu, 9 Aug 2007 23:19:34 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4) and for AEC6880[R]

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-09 Thread Mikael Pettersson
On Wed, 8 Aug 2007 14:33:20 +0100, Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Works fine on my CMD646 SPARC Ultra5. /Mikael - To unsubscribe from this list: send the line unsubscribe linux-ide in the

2.6.23-rc2 regression: check_irq_resend() warning from cmd64x

2007-08-05 Thread Mikael Pettersson
This is on a sparc64 ultra5 with a rev 3 CMD646. Starting with kernel 2.6.23-rc2, each boot triggers a WARNING from kernel/irq/resend.c: Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx CMD646: IDE controller at

Re: 2.6.23-rc1: pata_via cable detection differs from via82cxxx

2007-08-04 Thread Mikael Pettersson
On Fri, 3 Aug 2007 23:32:17 +0100, Alan Cox wrote: Mikael Pettersson [EMAIL PROTECTED] wrote: The machine is an Athlon64 laptop with a K8T800 chipset. With the IDE VIA driver the disk is detected as udma/100: Currently old IDE via driver has a hack in it which goes 'did the BIOS set

2.6.23-rc1: pata_via cable detection differs from via82cxxx

2007-08-03 Thread Mikael Pettersson
The machine is an Athlon64 laptop with a K8T800 chipset. With the IDE VIA driver the disk is detected as udma/100: VP_IDE: IDE controller at PCI slot :00:11.1 ACPI: PCI Interrupt Link [ALKA] disabled and referenced, BIOS bug ACPI: PCI Interrupt Link [ALKA] BIOS reported IRQ 0, using IRQ 23

Re: [PATCH libata-dev#upstream 2/2] libata: move EH repeat reporting into ata_eh_report()

2007-07-31 Thread Mikael Pettersson
on dry runs. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Mikael Pettersson [EMAIL PROTECTED] --- Mikael, please verify this removes the annonying message you're seeing. Yes, this patch eliminates the EH pending after completion message I've been getting. However, patch 1/2 in this set, don't

Re: [2.6.23-rc1] ata_piix: EH pending after completion, repeating EH (cnt=4)

2007-07-30 Thread Mikael Pettersson
On Mon, 30 Jul 2007 16:52:01 +0900, Tejun Heo wrote: Mikael Pettersson wrote: Sure, here are the boot messages with the newer debug patch: Of course I missed again. Here's yet another debug patch. Sorry about the trouble. No problem. Here's the kernel messages with the 3rd version

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Mikael Pettersson
On Thu, 26 Jul 2007 18:43:01 +0100, Alan Cox wrote: I must have been half asleep when doing the original code Signed-off-by: Alan Cox [EMAIL PROTECTED] [patch to fix .udma_mask in pata_cmd64x omitted] This fix inspired me to finally try to convert my Sun Ultra5 (sparc64) with a CMD646

Re: [2.6.23-rc1] ata_piix: EH pending after completion, repeating EH (cnt=4)

2007-07-26 Thread Mikael Pettersson
On Thu, 26 Jul 2007 15:31:10 +0900, Tejun Heo wrote: Mikael Pettersson wrote: On Tue, 24 Jul 2007 17:32:29 +0900, Tejun Heo wrote: Mikael Pettersson wrote: This machine has a known good Samsung SATA DVD on ICH8 [8086:2820]. With kernel 2.6.23-rc1 I now get the following: ata_piix

[2.6.23-rc1] ata_piix: EH pending after completion, repeating EH (cnt=4)

2007-07-23 Thread Mikael Pettersson
This machine has a known good Samsung SATA DVD on ICH8 [8086:2820]. With kernel 2.6.23-rc1 I now get the following: ata_piix :00:1f.2: version 2.11 ata_piix :00:1f.2: MAP [ P0 P2 P1 P3 ] ACPI: PCI Interrupt :00:1f.2[B] - GSI 19 (level, low) - IRQ 19 PCI: Setting latency timer of

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-07-10 Thread Mikael Pettersson
On Tue, 10 Jul 2007 11:52:59 +0800, Albert Lee wrote: Recently the PLL input clock of pata_pdc2027x is sometimes detected higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). It seems sometimes the mdelay() function is not as precise as it used to be. Per Alan's advice, HT or power

Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-07-07 Thread Mikael Pettersson
On Sat, 07 Jul 2007 15:02:49 +0800, Albert Lee wrote: After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() does more than simple irq masking. Remove the DMA stop code from pdc_freeze(). Signed-off-by: Albert Lee [EMAIL PROTECTED] --- diff -Nrup

Re: Libata PATA status

2007-07-04 Thread Mikael Pettersson
On Tue, 3 Jul 2007 23:04:26 -0400, Kyle Moffett wrote: Has anyone started a rewrite of the PPC/PowerMac IDE driver? The current one is in drivers/ide/ppc/pmac.c, and supports these chipsets: OHare ATA Heathrow ATA KeyLargo ATA-3 KeyLargo ATA-4 UniNorth ATA-6 (IE: Kauai)

[PATCH] sata_promise: SATA hotplug support, take 2

2007-07-02 Thread Mikael Pettersson
contains hotplug control and status flags for all ports. I considered following the ahci/sata_sil24 structure, but that would have required non-trivial changes to the interrupt handling path, so I chose to keep the hotplug changes simple and unobtrusive. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED

[PATCH 2.6.22-rc7] sata_sil24: sil24_interrupt() micro-optimisation

2007-07-02 Thread Mikael Pettersson
improves readability since it makes it clear that the parameter to sil24_host_intr() is the same value which was just validated. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.22-rc7/drivers/ata/sata_sil24.c.~1~ 2007-07-02 21:41:37.0 +0200 +++ linux-2.6.22-rc7

Re: [git patches] libata fixes

2007-06-28 Thread Mikael Pettersson
. Tested-by: Mikael Pettersson [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: is Promise TX4302 supported?

2007-06-27 Thread Mikael Pettersson
On Wed, 27 Jun 2007 03:46:47 +0200, [EMAIL PROTECTED] wrote: I'm considering buying a four-channel SATA PCI controller marked as Promise TX-4302 (two internal SATA links, two eSATA, independent on each other). According to the product page at Promise [1], Linux is missing from the list of

Re: SATA RAID5 speed drop of 100 MB/s

2007-06-24 Thread Mikael Pettersson
On Sun, 24 Jun 2007 10:54:56 +1000, Eyal Lebedinsky wrote: Jeff Garzik wrote: [trim] Given that some drives might be better tuned for benchmarks in non-queued mode, and that a major behavior difference is that your drives are now NCQ-enabled, the first thing I would suggest you try is

Re: sata_promise disk error 2.6.22-rc5 with hrt1 patch

2007-06-24 Thread Mikael Pettersson
(cc: linux-ide added) On Sun, 24 Jun 2007 20:49:05 +0200, otto Meier wrote: I got the following in my logs: Jun 24 19:06:40 gate2 kernel: ata4.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x0 Jun 24 19:06:40 gate2 kernel: ata4.00: (port_status 0x1000) Jun 24 19:06:40 gate2 kernel:

2.6.22-rc5 libata/ata_piix failure with older CDROM

2007-06-23 Thread Mikael Pettersson
I tried (again) to convert an Intel i815EP-chipset machine from IDE to libata, but libata still fails to initialise the CDROM on the machine. With 2.6.22-rc5, IDE says: Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide: Assuming 33MHz system bus speed for PIO modes; override with

Re: ide/dma not working from 2.6.19 to 2.6.21

2007-06-21 Thread Mikael Pettersson
On Thu, 21 Jun 2007 12:47:30 +0100, Bahadir Balban [EMAIL PROTECTED] wrote: I have a PCI Promise TX2 Ultra133 controller with a harddisk on an ARM platform (which is a barebone system with no BIOS). This setup used to work with the old linux-ide drivers on 2.6.19 but it does not work with

[PATCH 2.6.22-rc5 1/2] sata_promise: cleanups

2007-06-19 Thread Mikael Pettersson
(requested by Jeff) This patch should cause no behavioural changes, except for the removed printks. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] -- drivers/ata/sata_promise.c | 56 ++--- 1 files changed, 23 insertions(+), 33 deletions(-) --- linux

[PATCH 2.6.22-rc5 2/2] sata_promise: SATA hotplug support

2007-06-19 Thread Mikael Pettersson
control and status flags for all ports. I considered following the ahci/sata_sil24 structure, but that would have required non-trivial changes to the interrupt handling path, so I chose to keep the hotplug changes simple and unobtrusive. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] -- This patch

Re: Machine hanging on synchronize cache on shutdown 2.6.22-rc4-git[45678]

2007-06-18 Thread Mikael Pettersson
On Mon, 18 Jun 2007 16:09:49 +0900, Tejun Heo wrote: Mikael Pettersson wrote: On Sat, 16 Jun 2007 15:52:33 +0400, Brad Campbell wrote: I've got a box here based on current Debian Stable. It's got 15 Maxtor SATA drives in it on 4 Promise TX4 controllers. Using kernel 2.6.21.x it shuts

sata_promise: preliminary hotplug support

2007-06-17 Thread Mikael Pettersson
This crude but simple patch enables hotplugging of SATA disks in the sata_promise driver. Tested successfully on SATAII150 TX2plus, SATA300 TX2plus, and SATA300 TX4. The TX4 is significant because of the port_nr-to-ata_nr remapping that occurs for those chips, which affects the hotplug status

Re: Machine hanging on synchronize cache on shutdown 2.6.22-rc4-git[45678]

2007-06-16 Thread Mikael Pettersson
On Sat, 16 Jun 2007 15:52:33 +0400, Brad Campbell wrote: I've got a box here based on current Debian Stable. It's got 15 Maxtor SATA drives in it on 4 Promise TX4 controllers. Using kernel 2.6.21.x it shuts down, but of course with a huge clack as 15 drives all do emergency head parks

Re: Promise TX4 (PDC40718) hotplug support

2007-06-06 Thread Mikael Pettersson
On Wed, 6 Jun 2007 15:51:23 +0200, Jan Kasprzak wrote: I have a Promise TX4 controller, and I have problems with hotplug. It seems the controller does not recongnize the drive being hot-removed or hot-plugged. I need either to reload the sata_promise module, or to do # echo 1

Re: [git patches] libata fixes

2007-05-25 Thread Mikael Pettersson
-2 */ Acked-by: Mikael Pettersson [EMAIL PROTECTED] Good catch. This typo would have prevented pdc_host_intr() from detecting GEN_II-specific errors on the PATA port. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] sata_promise: Port enumeration order - SATA 150 TX4,

2007-05-22 Thread Mikael Pettersson
to distinguish the new and the old wiring controllers, then produce a new patch that will be a correct solution to the new wiring problem. Mikael Pettersson has been doing some excellent work recently on sata_promise. If enough data has been collected on this sata_promise port

Re: sata_promise: which version/patch to test?

2007-05-12 Thread Mikael Pettersson
On Thu, 10 May 2007 21:41:32 +0200, Peter Favrholdt wrote: I would like to help by testing the most recent version of the sata_promise driver on my Promise Technology, Inc. PDC40718 (SATA 300 TX4) (rev 02) with 4 Seagate 500GB ES drives: Model Number: ST3500630NS

Re: [PATCH 2.6.21-mm1 2/2] sata_promise: SATAII-150/300 TX4 port numbering fix

2007-05-10 Thread Mikael Pettersson
Jeff Garzik writes: + if ((pi-flags (PDC_FLAG_GEN_II|PDC_FLAG_4_PORTS)) == (PDC_FLAG_GEN_II|PDC_FLAG_4_PORTS)) { + is_sataii_tx4 = 1; + dev_printk(KERN_INFO, pdev-dev, applying SATAII TX4 port numbering workaround\n); ...though I'm not sure the printk

Re: sata_promise - another sata dvd writer problem

2007-05-06 Thread Mikael Pettersson
On Sun, 06 May 2007 16:35:11 +0200, Sven Lemke wrote: I'm using kernel 2.6.21-mm1 and get strange problems when connecting my new SATA DVD writer to the TX2Plus Promise controller. It works with an slightly older kernel version though. And since I couldn't figure out who is responsible for the

[PATCH 2.6.21-mm1 1/2] sata_promise: fix another error decode regression

2007-05-06 Thread Mikael Pettersson
ata_port_abort(), similar to ahci and sata_sil24. Doing this is important as it makes EH see the original error and not a bogus timeout. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- Thanks to Tejun for educating me about the significance of ata_port_abort()/ata_port_freeze() in ahci and sata_sil24

[PATCH 2.6.21-mm1 2/2] sata_promise: SATAII-150/300 TX4 port numbering fix

2007-05-06 Thread Mikael Pettersson
chips. This patch updates sata_promise to use the new port number to ATA engine mapping on SATAII TX4 cards, which fixes the drive enumeration order problem on those cards. Tested on several 1st and 2nd generation TX2plus and TX4 chips. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED

Re: 2.6.21-mm1: many processes end up in D state

2007-05-05 Thread Mikael Pettersson
On Sat, 05 May 2007 17:30:51 +0200, Tejun Heo wrote: Mikael Pettersson wrote: I.e. no freezing of ports... Your patch to delete the 'return 1;' on error is correct, and makes the code match exactly the behaviour of previous versions of sata_promise, except for the additional error

Re: 2.6.21-mm1: many processes end up in D state

2007-05-04 Thread Mikael Pettersson
On Fri, 04 May 2007 17:02:10 +0200, Jiri Slaby wrote: I have a problem with higher disk loads (e.g. running git-log or yum update). Many processes end up in D state and system is unusable -- I'm not able to run anything but smooth mouse moving when this happens. ...(boring stack dumps

[PATCH 2.6.21-rc7-mm2 1/2] sata_promise: SATAII-150/300 TX4 port numbering fix

2007-04-28 Thread Mikael Pettersson
chips. This patch updates sata_promise to use the new port number to ATA engine mapping on SATAII TX4 cards, which fixes the drive enumeration order problem on those cards. Tested on SATA300 TX4, SATA300 TX2plus, SATAII-150 TX2plus, and TX4000. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED

[PATCH 2.6.21-rc7-mm2 2/2] sata_promise: move port reset from error intr to EH prereset

2007-04-28 Thread Mikael Pettersson
-flow sense) all subsequent reset parts of EH. Tested on SATA300 TX4, SATA300 TX2plus, SATAII-150 TX2plus, SATA150 TX2plus, and TX4000. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- drivers/ata/sata_promise.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions

[PATCH 2.6.21-rc7] sata_promise: SATAII-150/300 TX4 port numbering fix

2007-04-22 Thread Mikael Pettersson
chips. This patch updates sata_promise to use the new port number to ATA engine mapping on SATAII TX4 cards, which fixes the drive enumeration order problem on those cards. Tested on 300 TX4, 300 TX2plus, and SATAII-150 TX2plus chips. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED

Re: sata_promise ata exceptions (2.6.20.6)

2007-04-16 Thread Mikael Pettersson
On Sun, 15 Apr 2007 23:55:31 -0700, Phil Dibowitz wrote: Given that the last one was a hardware issue, I bought a new controller. Despite my bad luck, given my price-range promise still seemed to be the = one with the most good reports, so I went with that. I was going to go with a= sil,

Re: [PATCH pata-2.6] cmd64x: procfs code fixes/cleanups (take 2)

2007-04-14 Thread Mikael Pettersson
On Sat, 14 Apr 2007 23:41:16 +0400, Sergei Shtylyov wrote: While at it, also perform the following cleanups: ... - correct the chipset names (from CMDxxx to PCI-xxx) Please explain why this rename is a correction. Did the company making these chips change name at some point? Or did they change

Re: promise ncq

2007-04-13 Thread Mikael Pettersson
On Fri, 13 Apr 2007 23:43:03 +0300, Raz Ben-Jehuda(caro) [EMAIL PROTECTED] wrote: Jeff hello I have a promise cotroller that exports its disks as logical volumes to the OS, and the OS sees them as physical drives . kernel is 2.6.17. I have set a disk manualy to support ncq using a command

Re: [PATCH 08/12] libata: convert drivers with combined SATA/PATA ports to new init model

2007-04-11 Thread Mikael Pettersson
On Wed, 11 Apr 2007 15:42:05 +0900, Tejun Heo wrote: ... diff --git a/drivers/ata/sata_promise.c b/drivers/ata/sata_promise.c index baa8368..8e8fe59 100644 --- a/drivers/ata/sata_promise.c +++ b/drivers/ata/sata_promise.c ... @@ -333,7 +349,7 @@ static struct pci_driver pdc_ata_pci_driver = {

Re: [PATCH libata#upstream] sata_promise: fix error decode regression

2007-04-09 Thread Mikael Pettersson
On Mon, 09 Apr 2007 16:52:53 +0900, Tejun Heo wrote: Mikael Pettersson wrote: Promise ATA ports should always be reset by pdc_reset_port() when errors are detected, but the recent error reason decoding update to sata_promise replaced that reset with a freeze. This patch changes the error

Re: sata_promise ata exceptions (2.6.20.6)

2007-04-09 Thread Mikael Pettersson
On Sat, 07 Apr 2007 16:41:04 -0700, Phil Dibowitz wrote: I've recently moved to a Promise Sata controller with two SATA drives in a RAID1 mirror. But I get lots of ata exceptions and the kernel eventually slows down my drive to UDMA/33. It usually happens on ata1 (sda), but sometimes it'll kick

[PATCH libata#upstream] sata_promise: fix error decode regression

2007-04-07 Thread Mikael Pettersson
only adds error decoding without changing any other behaviour. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- drivers/ata/sata_promise.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) --- linux-2.6.21-rc6+upstream/drivers/ata/sata_promise.c.~1~2007-04-06 19:40

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Mikael Pettersson
On Mon, 19 Mar 2007 12:46:16 +, Alan Cox wrote: This duplicates the IDE core LED trigger in the libata core. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. I

[PATCH libata#upstream 1/2] sata_promise: add missing cable_detect hooks

2007-03-11 Thread Mikael Pettersson
The recent change which moved cable detection from pdc_pre_reset() to the new -cable_detect hook only added the hook for SATAII chips, leaving SATAI chips and the 20619 without the hook. Fixed by this patch. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- drivers/ata/sata_promise.c |4

[PATCH libata#upstream 2/2] sata_promise: separate SATA and PATA ops

2007-03-11 Thread Mikael Pettersson
ports, a procedure with the common code, and a procedure with the SATA-specific code (this bit might be cleaned up by Tejun's new init model) Tested on 20619, 20575, and 20775 chips. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- drivers/ata/sata_promise.c | 107

[BUG 2.6.21-rc3] libata PATA CDROM detection problems

2007-03-10 Thread Mikael Pettersson
I tried to convert a machine with an Intel 815EP chipset from IDE to libata. There's a single master disk on the first channel, and a single master CDROM on the second. With kernel 2.6.21-rc3 and the IDE PIIX driver things work fine: Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide:

pata_pdc2027x success on a PowerMac

2007-03-10 Thread Mikael Pettersson
This is just to let folks know that the 2.6.21-rc3 kernel's pata_pdc2027x works w/o issues with a PDC20269 in an old PowerMac G3 of mine: pata_pdc2027x :00:0e.0: version 0.8 pata_pdc2027x :00:0e.0: PLL input clock 16000 kHz ata1: PATA max UDMA/133 cmd 0xf10197c0 ctl 0xf1019fda bmdma

Re: [RFT] sata_promise: decode and report error reasons

2007-03-07 Thread Mikael Pettersson
Tejun, Tejun Heo writes: Hello, Mikael. Mikael Pettersson wrote: +static void pdc_error_intr(struct ata_port *ap, struct ata_queued_cmd *qc, u32 port_status) +{ + struct pdc_host_priv *hp = ap-host-private_data; + struct ata_eh_info *ehi = ap-eh_info; + unsigned int

  1   2   >