seems to be updated.
regards,
Daniel Rode
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 11 January 2008, Jeff Garzik wrote:
Fix oops reported by Trond.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Linus, could you apply it?
---
drivers/ide/ide-acpi.c |2 ++
1 file changed, 2 insertions(+)
diff --git
Tejun Heo schrieb:
I don't know very well about CF but does it even fill UDMA/33? What
does 'dd if=/dev/sdc of=/dev/null bs=1M count=16 iflag=direct' say? You
can increase count for more reliable result.
16+0 Datensätze ein
16+0 Datensätze aus
16777216 Bytes (17 MB) kopiert, 0,561688 s, 29,9
i.e.,
ERROR: switch and case should be at the same indent
ERROR: need spaces around that '=' (ctx:VxV)
ERROR: trailing statements should be on next line
WARNING: no space between function name and open parenthesis '('
WARNING: printk() should include KERN_ facility level
ERROR: That open brace {
There were two almost identical function names in ide-floppy.c, which makes
their
distinction almost impossible. While ide_floppy_release() cleans up the object
after the last reference to it has been dropped, idefloppy_release() is the
blkdev
.release method from struct block_device_operations
The driver used to test whether the flexible disk page has changed by memcmp-ing
it with a cached copy of a previous version of the page from a different remo-
vable medium. Since, according to the SFF-8070i spec, the flexible disk page
specifies parameters relating to the currently installed
Replace the ide-floppy packet commands opcode defines with the generic ones.
Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The
last one can be found in the current version of INF-8090, p.905.
CC: Jens Axboe [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 89b26ea..0729df5 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
BIG FAT WARNING: This patch has already been applied to Bart's quilt tree!
This change is rather temporary and is in preparation of using generic commands
as is the case with ide-cd and the uniform cdrom layer (i.e.
init_cdrom_command())
However, before this happens, we'll have to remove all
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 25 -
1 files changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 7d4ac0b..11c2c9b 100644
--- a/drivers/ide/ide-floppy.c
+++
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 41 -
1 files changed, 0 insertions(+), 41 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 5c85833..d98264e 100644
---
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index e4ebb21..e63758a 100644
--- a/drivers/ide/ide-floppy.c
+++
* some debug_log() calls were not using ide-floppy: prefix
* a few used printk levels different than KERN_INFO (KERN_NOTICE
and KERN_ERR, which is the default one if no level is given)
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL
Hi Bart,
here's the second version of the ide-floppy refactoring trail. All the
patches are based on the version of your quilt tree from the 05.01. Also, you've
already applied patch 5 in this series but i'm submitting it still for the sake
of completeness.
drivers/ide/ide-cd.c |2
Also, move xfer_func_t typedef to the ide.h since it is used by two drivers
now (more coming).
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-cd.c |2 --
drivers/ide/ide-floppy.c | 37 ++---
include/linux/ide.h |3 +++
3
I'm seeking help for a problem we're having with a new PATA driver for a
Toshiba TX4939 MIPS SoC.
The driver works fine for most use cases, but we get an oops when stress
testing with bonnie++. The oops is always a null pointer while walking a
buffer_head list (b_this_page is null) when bonnie++
In addition to shortening the function name, move the printk-call into the
function thereby saving some code lines. Also, make the function out_of_line
since it is not on a performance critical path.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 37
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index c889c16..89b26ea 100644
--- a/drivers/ide/ide-floppy.c
+++
I keep getting the following error messages during bootup with kernel
2.6.23.12 :
scsi 4:0:0:0: CD-ROMTSSTcorp CDDVDW TS-L633A UO00 PQ: 0 ANSI: 5
ata3.00: qc timeout (cmd 0xa0)
ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata3.00: (irq_stat 0x4001)
ata3.00:
http://bugzilla.kernel.org/show_bug.cgi?id=9728
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
http://bugzilla.kernel.org/show_bug.cgi?id=9728
--- Comment #1 from [EMAIL PROTECTED] 2008-01-11 07:40 ---
Created an attachment (id=14413)
-- (http://bugzilla.kernel.org/attachment.cgi?id=14413action=view)
Looks like an unterminated DMI table...
The following patch, which
This change is temporary and after unification of the IDE subsystem proper
bit setting and testing macros will be introduced.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 82 +-
1 files changed, 45 insertions(+), 37
http://bugzilla.kernel.org/show_bug.cgi?id=9728
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
OtherBugsDependingO|
Kuan Luo wrote:
hi robert,
I have fixed a bug in rhel4u5 2.6.9-55 when running adma mode
with HDS7250SASUN500G.
Could you check this code and if no problem, then help me to
submit to the newest kernel.
It seems like a reasonable change - I'm sure you guys would know better
While at it, collapse idefloppy_analyze_error() into
idefloppy_request_sense_callback() since the latter was its only user.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 82 +
1 files changed, 24 insertions(+), 58
We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by
introducing a 4th arg. called direction. According to its value
we atapi_input_bytes() or atapi_output_bytes(). Also, simplify the interrupt
handler by removing multiple calls testing the data direction and using a local
http://bugzilla.kernel.org/show_bug.cgi?id=9728
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|VERIFIED|CLOSED
--- Comment #2 from
Hello,
Please advise on how to enable DMA on my Dell D610 (any advice is much
appreciated!). I tried hdparm –d1 /dev/hda, and I get the following
output:
setting using_dma to 1 (on)
HDIO_SET_DMA failed: Operation not permitted
Using_dma = 0 (off)
I'm running Linux kernel version 2.6.22.6 from
Thank you. I took the CD-Rom out, so that's why it didn't show. Very
observant!
My concern with disabling the new drivers is as follows: I use this
linux kernel and config image to boot machines over PXE and call a
shred program on each of the harddrives. If I turn off CONFIG_ATA,
will this
Thanks. You do indeed have both the old IDE and new IDE drivers trying to
drive bits of the system. I don't see the CD-ROM in the dmesg at all
however ?
If you turn off CONFIG_ATA you should get just old IDE drivers and your
disk back working sanely.
Alan
-
To unsubscribe from this list: send
Attached is the dmesg output.
On 1/11/08, Alan Cox [EMAIL PROTECTED] wrote:
On Fri, 11 Jan 2008 14:49:46 -0500
Kristin Vadas Marsicano [EMAIL PROTECTED] wrote:
Both laptops have IDE drives. The kernel image booted on the two
laptops are exactly the same. Please let me know if this
I have the same kernel and configuration on my Dell D600 (an older
version of the same laptop), and hdparm –d works just fine.
We you using the IDE driver for PATA devices and the SATA driver for SATA
devices ? If so the really nasty hacks for that were dropped as current
libata PATA support is
On Fri, 11 Jan 2008 14:49:46 -0500
Kristin Vadas Marsicano [EMAIL PROTECTED] wrote:
Both laptops have IDE drives. The kernel image booted on the two
laptops are exactly the same. Please let me know if this doesn't
answer your question -- I'm new to this and not quite sure I
understand the
Robert Hancock wrote:
Kuan Luo wrote:
hi robert,
I have fixed a bug in rhel4u5 2.6.9-55 when running adma mode
with HDS7250SASUN500G.
Could you check this code and if no problem, then help me to
submit to the newest kernel.
It seems like a reasonable change - I'm sure you guys
On 1/11/08, Alan Cox [EMAIL PROTECTED] wrote:
My concern with disabling the new drivers is as follows: I use this
linux kernel and config image to boot machines over PXE and call a
shred program on each of the harddrives. If I turn off CONFIG_ATA,
will this limit my ability to support
On Jan 11, 2008 4:34 PM, Alan Cox [EMAIL PROTECTED] wrote:
most of the machines I encounter (and with both SATA and IDE drives),
except for the Dell D610 and HP 7700 (small desktop pc). The models I
just mentioned run the shred really slow, which I believe is due to
the DMA problem I was
On 01/11/2008 04:35 PM, Jeff Garzik wrote:
Chuck Ebbert wrote:
commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 changed command
validation
to allow short commands in 16-byte CDBs, but it also made checking more
strict. Before the change, a 10-byte SG_IO command could have its
length set
to 9
On Jan 11, 2008 4:49 PM, Kristin Vadas Marsicano
[EMAIL PROTECTED] wrote:
On 1/11/08, Alan Cox [EMAIL PROTECTED] wrote:
My concern with disabling the new drivers is as follows: I use this
linux kernel and config image to boot machines over PXE and call a
shred program on each of the
My concern with disabling the new drivers is as follows: I use this
linux kernel and config image to boot machines over PXE and call a
shred program on each of the harddrives. If I turn off CONFIG_ATA,
will this limit my ability to support various new IDE and SATA drives
for running shred?
commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 changed command validation
to allow short commands in 16-byte CDBs, but it also made checking more
strict. Before the change, a 10-byte SG_IO command could have its length set
to 9 and still work. Now it fails. Not sure if this is a bug, but it has
On Mon, Jan 07, 2008 at 06:10:29PM -0600, Robert Hancock wrote:
Gabor, I just noticed you said that it worked OK in 2.6.20, yet 2.6.22
fails. 2.6.20 had ADMA support as well, so I wonder what change started
causing the problem. Would it be possible for you to do a git bisect (or
at
Chuck Ebbert wrote:
On 01/11/2008 04:35 PM, Jeff Garzik wrote:
Chuck Ebbert wrote:
commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 changed command
validation
to allow short commands in 16-byte CDBs, but it also made checking more
strict. Before the change, a 10-byte SG_IO command could have
On 01/11/2008 06:21 PM, Jeff Garzik wrote:
Chuck Ebbert wrote:
On 01/11/2008 04:35 PM, Jeff Garzik wrote:
Chuck Ebbert wrote:
commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 changed command
validation
to allow short commands in 16-byte CDBs, but it also made checking more
strict. Before the
I was talking to Kristin this morning about doing that. I was
concerned that there is not anybody certifying that each individual
disk drive model / firmware release is properly implementing the
Security Erase function.
Are you aware of testing body, etc. that publishes a white-list of
44 matches
Mail list logo