On Wed, Feb 13, 2008 at 08:54:55AM +0100, Dirk GOUDERS wrote:
Hi,
I'm reworking the pci device list logic (we currently keep all PCI
devices in 2 lists, which isn't the nicest, we should be able to get
away with only 1 list.)
The only bother I've found so far is the
Hm, so, to summarize:
- you needed this option many years ago to get a box to work properly
- you don't need this today
I would summarize:
- ide=reverse solved certain problems and I am not sure if there are
users who still need this option
So, if the option went away, you
ata_host_detach() detaches an attached port and shouldn't be called on
a port which hasn't been attached yet. pata_legacy incorrectly calls
ata_host_detach() on unattached port after initialization failure
causing oops. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Alan Cox [EMAIL
Hello, all.
This is the third take of implement-printk_header-and-mprintk
patchset.
Changes from the last take[L] are...
* Now header is printed on every line of a multiline message. If the
header ends with ':' followed by spaces. The colon is replaced with
space from the second line.
*
When printing multiline messages, printk() resets log level to
default_message_loglevel after the first line. This changes log level
unexpectedly when printing multiline messages.
For example, libata error messages are printed like the following.
3ata8.00: cmd
There often are times printk messages need to be assembled piece by
piece and it's usually done using one of the following methods.
* Calling printk() on partial message segments. This used to be quite
common but has a problem - the message can break up if someone else
prints something in
On Tue, Feb 12 2008 at 21:41 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Sun, 2008-02-10 at 21:05 +0200, Boaz Harrosh wrote:
- struct scsi_cmnd had a 16 bytes command buffer of its own.
This is an unnecessary duplication and copy of request's
cmd. It is probably left overs from the
* Tejun Heo [EMAIL PROTECTED] wrote:
ata_host_detach() detaches an attached port and shouldn't be called on
a port which hasn't been attached yet. pata_legacy incorrectly calls
ata_host_detach() on unattached port after initialization failure
causing oops. Fix it.
thanks, i'll try
On Tue, Feb 12, 2008 at 04:16:38PM -0800, Greg KH wrote:
Why does the calgary driver need this? Can we just use
pci_get_device() instead? Why do you need to walk the device list
backwards? Do you get false positives going forward?
It's not strictly needed, we used it for symmetry. Feel
On Tue, Feb 12, 2008 at 01:30:03PM +0100, Gabriel Paubert wrote:
On Tue, Feb 12, 2008 at 12:49:05PM +0100, Gabriel Paubert wrote:
On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote:
- couple of
--- On Tue, 2/12/08, James Bottomley [EMAIL PROTECTED] wrote:
I apologize for taking so long to review this patch.
I obviously agree
wholeheartedly with Luben. The problem I ran into
while trying to
design an enclosure management interface for the SATA
devices is that
there is all
Hello Tejun,
On Tuesday 23 October 2007 10:08:01 you wrote:
Jeff Garzik wrote:
Alan Cox wrote:
2) Once we identified, over time, the set of drives affected by this
3112 quirk (aka drives that didn't fully comply to SATA spec), the
debugging of corruption cases largely shifted to the
Bernd Schubert wrote:
Hello Tejun,
On Tuesday 23 October 2007 10:08:01 you wrote:
Jeff Garzik wrote:
Alan Cox wrote:
2) Once we identified, over time, the set of drives affected by this
3112 quirk (aka drives that didn't fully comply to SATA spec), the
debugging of corruption cases
--- On Tue, 2/12/08, James Bottomley [EMAIL PROTECTED] wrote:
I understand what you are trying to do - I guess I
just doubt the value
you've added by doing this. I think that
there's going to be so much
customization that system vendors will want to add,
that they are going
to wind up
Cai, Crane wrote:
Hi Jeff,
Sorry to diturb you. However, it is a long time for me to submit this patch. Can you tell me when this patch can be upsteamed to the kernel tree?
Thanks,
Crane
-Original Message-
From: Jeff Garzik [mailto:[EMAIL PROTECTED]
Sent: Saturday, February 02, 2008
On 13-02-08 05:44, Greg KH wrote:
While details escape me somewhat again at the monment, a few months ago
I was playing around with a PCI Promise IDE controller and needed
ide=reverse to save me from having to switch disks around to still have
a bootable system.
Or some such. Not too clear
On Wed, 2008-02-13 at 13:06 +0100, Rene Herman wrote:
On 13-02-08 05:44, Greg KH wrote:
While details escape me somewhat again at the monment, a few months ago
I was playing around with a PCI Promise IDE controller and needed
ide=reverse to save me from having to switch disks around to
Hi,
On Wednesday 13 February 2008, Michael Ellerman wrote:
On Fri, 2008-02-08 at 01:45 +0100, Bartlomiej Zolnierkiewicz wrote:
Rework PowerMac media-bay support in such way that instead of
un/registering the IDE interface we un/register IDE devices:
* Add ide_port_scan() helper for
On Wednesday 13 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote:
Why does the calgary driver need this? Can we just use pci_get_device()
instead? Why do you need to walk the device list backwards? Do you get
false positives going forward?
It
On Tuesday, 5 of February 2008, Kamalesh Babulal wrote:
Hi,
The kernel bootup panics with the 2.6.24-mm1 and 2.6.24-git13 kernel
while defconfig compiled in for x86_64 (Intel(R) Xeon) box
Is that still happening or has it been fixed?
Rafael
BUG: unable to handle kernel paging request at
On 13-02-08 13:16, Michael Ellerman wrote:
On Wed, 2008-02-13 at 13:06 +0100, Rene Herman wrote:
On 13-02-08 05:44, Greg KH wrote:
While details escape me somewhat again at the monment, a few months ago
I was playing around with a PCI Promise IDE controller and needed
ide=reverse to save me
On 13-02-08 13:06, Rene Herman wrote:
On 13-02-08 05:44, Greg KH wrote:
While details escape me somewhat again at the monment, a few months ago
I was playing around with a PCI Promise IDE controller and needed
ide=reverse to save me from having to switch disks around to still have
a bootable
On Tue, Feb 12, 2008 at 10:39:22PM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi Bart,
I think that this _really_ should be done _after_ unifying ATAPI handling [*].
Otherwise you will be making some of the same changes to the _three_ copies
of (more or less) identical code and more importantly
Rafael J. Wysocki wrote:
On Tuesday, 5 of February 2008, Kamalesh Babulal wrote:
Hi,
The kernel bootup panics with the 2.6.24-mm1 and 2.6.24-git13 kernel
while defconfig compiled in for x86_64 (Intel(R) Xeon) box
Is that still happening or has it been fixed?
Rafael
The panic is solved
Hi,
On Wednesday 13 February 2008, Borislav Petkov wrote:
On Tue, Feb 12, 2008 at 10:39:22PM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi Bart,
I think that this _really_ should be done _after_ unifying ATAPI handling
[*].
Otherwise you will be making some of the same changes to the
The keep-it-in-user-space arguments seem fairly compelling to me.
Especially as we've pushed whole i/o subsystems out to user space
(iscsi, stgt, talked about fcoe, a lot of dm control, etc).
The functionality seems to align with Doug's sg/lsscsi utility chain
as well. Granted, the new utility
James Bottomley wrote:
I don't disagree with that, but the fact is that there isn't such a
tool. It's also a fact that the enterprise is reasonably unhappy with
the lack of an enclosure management infrastructure, since it's something
they got on all the other unix systems.
I don't disagree.
On Tue, Feb 12, 2008 at 08:43:04PM -0800, Greg KH wrote:
Can't you just boot with /dev/disk/by-id/ and an initramfs to not have
to worry about such a thing in the future?
Can comebody remind me what the initramfs is for in that situation,
please ? From the little I've noticed, I thought
On Wed, 2008-02-13 at 09:08 -0500, James Smart wrote:
The keep-it-in-user-space arguments seem fairly compelling to me.
Especially as we've pushed whole i/o subsystems out to user space
(iscsi, stgt, talked about fcoe, a lot of dm control, etc).
And to me too.
The functionality seems to
James Bottomley wrote:
... I wouldn't have bothered except that I could see ad-hoc
in-kernel sysfs solutions beginning to appear.
If this is true, and if no one quickly volunteers to do the utility, then
I agree with what you are doing.
-- james s
-
To unsubscribe from this list: send the
On Wed, 2008-02-13 at 11:22 -0500, James Smart wrote:
James Bottomley wrote:
I don't disagree with that, but the fact is that there isn't such a
tool. It's also a fact that the enterprise is reasonably unhappy with
the lack of an enclosure management infrastructure, since it's something
Tejun Heo wrote:
This patch implements libata.force module parameter which can
selectively override ATA port, link and device configurations
including cable type, SATA PHY SPD limit, transfer mode and NCQ.
...
+ libata.force= [LIBATA] Force configurations. The format is comma
+
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/scsi/ide-scsi.c | 27 ++-
1 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
index d46c81c..93c3fc2 100644
--- a/drivers/scsi/ide-scsi.c
+++
This is done in one single patch in order not to cause git breakage.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 14 --
drivers/ide/ide-tape.c | 16
drivers/scsi/ide-scsi.c | 36 +++-
On Feb 13, 2008 5:18 PM, Borislav Petkov [EMAIL PROTECTED] wrote:
This is done in one single patch in order not to cause git breakage.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Looks good but could you please reorder patches and move PC_* - PC_FLAG *
rename in ide-scsi to the patch
On Wed, Feb 13, 2008 at 09:32:03AM -0800, Greg KH wrote:
Is there some reason you aren't using the real PCI driver api here
and registering a pci driver for these devices? That would take the
whole loop over all pci devices logic out of the code entirely.
I recall we had a reason, but I no
On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 13 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote:
Why does the calgary driver need this? Can we just use pci_get_device()
instead? Why do you need to walk
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 14 --
drivers/ide/ide-tape.c | 16
include/linux/ide.h | 15 +++
3 files changed, 15 insertions(+), 30 deletions(-)
diff --git a/drivers/ide/ide-floppy.c
...also, convert ide-scsi to using the generic pc-flags defines.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/scsi/ide-scsi.c | 37 -
1 files changed, 16 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/ide-scsi.c
this fixes crash bug as the iomap table is not valid for integrated controllers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 04b5717..9c9a5b0
On Wed, 2008-02-13 at 09:45 -0800, Kristen Carlson Accardi wrote:
I don't think I'm arguing whether or not your solution may work, what I
am arguing is really a more philosophical point. Not can we do it
this way, but should we do it way. I am of the opinion that
management belongs in
On Tue, 12 Feb 2008 13:28:15 -0600
James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote:
I understand what you are trying to do - I guess I just doubt the
value you've added by doing this. I think that there's going to be
so much
On Wed, Feb 13, 2008 at 07:47:11PM +0200, Muli Ben-Yehuda wrote:
On Wed, Feb 13, 2008 at 09:32:03AM -0800, Greg KH wrote:
Is there some reason you aren't using the real PCI driver api here
and registering a pci driver for these devices? That would take the
whole loop over all pci devices
On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote:
On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 13 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote:
Why does the calgary driver need this? Can we just
Alan Cox [EMAIL PROTECTED] wrote:
Has anyone else reported a problem like this? It requires
non-coherent DMA, and a lack of a cache invalidate instruction, and
one of the drivers that has this problem (it looks like sata_qstor
does too, I haven't looked at others), so maybe that doesn't
Alan Cox [EMAIL PROTECTED] wrote:
Has anyone else reported a problem like this? It requires
non-coherent DMA, and a lack of a cache invalidate instruction, and
one of the drivers that has this problem (it looks like sata_qstor
does too, I haven't looked at others), so maybe that doesn't
this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff
Saeed Bishara wrote:
this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |3 ---
1 files changed, 0
Hm, so, to summarize:
- you needed this option many years ago to get a box to work properly
- you don't need this today
So, if the option went away, you would not be inconvenienced?
After having reanimated the old system and after comments of other
persons I would not be inconvenienced
O I'm counting on kmalloc to return a cache aligned buffer. I found
some reason to think it does, but I don't remember offhand what that
Its defined to
reason was, or if it's configurable per-architecture. The buffer has
to be both physically and virtually contiguous, I was tempted to just
On Wed, Feb 13, 2008 at 09:00:15PM +0100, Dirk GOUDERS wrote:
Hm, so, to summarize:
- you needed this option many years ago to get a box to work properly
- you don't need this today
So, if the option went away, you would not be inconvenienced?
After having reanimated the old
Alan Cox [EMAIL PROTECTED] wrote:
O I'm counting on kmalloc to return a cache aligned buffer. I found
some reason to think it does, but I don't remember offhand what that
Its defined to
reason was, or if it's configurable per-architecture. The buffer has
to be both physically and
commit d1f1f84f413ab00cb2fec48170d022fcd900e214
Author: Borislav Petkov [EMAIL PROTECTED]
Date: Wed Feb 13 20:26:56 2008 +0100
ide-floppy: merge callbacks
The appropriate functionality of the callback is established through
querying
the ATAPI packet command in pc-c[0].
On Wednesday 13 February 2008, Borislav Petkov wrote:
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 13 February 2008, Borislav Petkov wrote:
...also, convert ide-scsi to using the generic pc-flags defines.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
On Wednesday 13 February 2008, Borislav Petkov wrote:
commit d1f1f84f413ab00cb2fec48170d022fcd900e214
Author: Borislav Petkov [EMAIL PROTECTED]
Date: Wed Feb 13 20:26:56 2008 +0100
ide-floppy: merge callbacks
The appropriate functionality of the callback is established
On Wednesday 13 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote:
On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 13 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9962
Summary: 2.6.26-git0: IDE oops during boot
Product: IO/Storage
Version: 2.5
KernelVersion: 2.6.25-git0
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Hi,
On Tuesday 12 February 2008, Kamalesh Babulal wrote:
Bartlomiej Zolnierkiewicz wrote:
Hi,
On Monday 11 February 2008, Kamalesh Babulal wrote:
Nish Aravamudan wrote:
On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
On Thursday 07 February 2008, Kamalesh Babulal
http://bugzilla.kernel.org/show_bug.cgi?id=9962
--- Comment #2 from [EMAIL PROTECTED] 2008-02-13 15:02 ---
As stated above, the Bugzilla entry is for tracking the regression. If you
think it should be reassigned, please let me know and I'll do that.
--
Configure bugmail:
http://bugzilla.kernel.org/show_bug.cgi?id=9962
--- Comment #1 from [EMAIL PROTECTED] 2008-02-13 14:38 ---
What makes you think that it is actually an IDE problem? The initial problem
(which Andi fixed) was with *ide_generic* oopsing and could be just
work-arounded by disabling
On Wed, 2008-02-13 at 13:46 +0100, Rene Herman wrote:
On 13-02-08 13:16, Michael Ellerman wrote:
On Wed, 2008-02-13 at 13:06 +0100, Rene Herman wrote:
On 13-02-08 05:44, Greg KH wrote:
While details escape me somewhat again at the monment, a few months ago
I was playing around with a
On Tue, 2008-02-12 at 23:10 -0800, Yinghai Lu wrote:
if (type_ptr[0] != ENCLOSURE_COMPONENT_DEVICE
type_ptr[0] != ENCLOSURE_COMPONENT_ARRAY_DEVICE)
- continue;
+ goto next;
+
Am Dienstag, 12. Februar 2008 schrieb Borislav Petkov:
On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote:
Hi,
I suffer from unreliable cdrom operations (failing DAE and burn
sessions) with the openSUSE 2.6.18.8-0.7-bigsmp kernel.
Hi,
can
On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 13 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote:
On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 13 February 2008, Greg
On Thursday 14 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 13 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote:
On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej
On Wed, 13 Feb 2008 18:09:28 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
This is the third take of implement-printk_header-and-mprintk
patchset.
Changes from the last take[L] are...
* Now header is printed on every line of a multiline message. If the
header ends with ':' followed by
http://bugzilla.kernel.org/show_bug.cgi?id=9962
--- Comment #3 from [EMAIL PROTECTED] 2008-02-13 15:58 ---
Yes, it should be reassigned to under investigation department.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail
one system: initrd get courrupted:
RAMDISK: Compressed image found at block 0
RAMDISK: incomplete write (-28 != 2048) 134217728
crc error
VFS: Mounted root (ext2 filesystem).
Freeing unused kernel memory: 388k freed
init_special_inode: bogus i_mode (17)
Warning: unable to open an initial
Mark Lord wrote:
Tejun Heo wrote:
This patch implements libata.force module parameter which can
selectively override ATA port, link and device configurations
including cable type, SATA PHY SPD limit, transfer mode and NCQ.
...
+libata.force=[LIBATA] Force configurations. The format
Previous patchset adding warm-plug support allows the removal of PPC specific
IDE hacks (500 LOC gone)...
[ Ben, please take a look when you have some time, thanks! ]
diffstat:
arch/powerpc/kernel/setup_32.c |8 --
arch/powerpc/platforms/powermac/pci.c | 22 ---
Remove unused pmac_ide_{check_base,get_irq}() and pmac_find_ide_boot(),
then remove no longer needed ide_majors[] and pmac_ide_count.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ppc/pmac.c | 47
Also remove now not needed linux/ide.h include.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
arch/ppc/platforms/hdpu.c | 36
1 file changed, 36 deletions(-)
Index: b/arch/ppc/platforms/hdpu.c
There are no default IDE ports on PPC4xx so ppc4xx_ide_init_hwif_ports() is
unnecessary, remove it. Also remove no longer needed linux/ide.h include.
There should be no functional changes caused by this patch.
Cc: Josh Boyer [EMAIL PROTECTED]
Cc: Matt Porter [EMAIL PROTECTED]
Cc: Benjamin
* Add pmac_ide_init_ports() helper and use it instead of
pmac_ide_init_hwif_ports().
* Remove ppc_ide_md hooks - no need for them
(IDE pmac host driver takes care of all this setup).
* Then remove no longer needed linux/ide.h include
from arch/powerpc/platforms/powermac/pmac.h.
Cc:
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
arch/ppc/platforms/4xx/bamboo.c |1 -
arch/ppc/platforms/4xx/ebony.c |1 -
arch/ppc/platforms/4xx/luan.c |1 -
arch/ppc/platforms/4xx/ocotea.c |1 -
* Add special cases for pplus and prep to ide_default_{irq,io_base}()
(+ FIXMEs about the need to use IDE platform host driver instead).
* Remove no longer needed ppc_ide_md and struct ide_machdep_calls.
* Then remove linux/ide.h include from:
- arch/powerpc/kernel/setup_32.c
-
http://bugzilla.kernel.org/show_bug.cgi?id=9962
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
|
* Add IDE_HFLAG_FORCE_LEGACY_IRQS host flag for Motorola-Sandpoint platform
to sl82c105 host driver.
* Disable ide_generic host driver in arch/ppc/configs/sandpoint_defconfig
and enable sl82c105 one.
* Remove ppc_ide_md hooks from arch/ppc/platforms/sandpoint.c - no need for
them (sl82c105
* Add IDE_HFLAG_FORCE_LEGACY_IRQS host flag for Motorola-LoPEC platform
to sl82c105 host driver.
* Remove ppc_ide_md hooks from arch/ppc/platforms/lopec.c - no need for
them (sl82c105 host driver takes care of all this setup).
* Then remove no longer needed linux/ide.h include.
Looking at
http://bugzilla.kernel.org/show_bug.cgi?id=9962
--- Comment #4 from [EMAIL PROTECTED] 2008-02-13 16:09 ---
Also the bug summary is totally wrong now since IDE OOPS has been already
fixed,
the problem now is:
Creating root device.
Mounting root filesystem.
mount: could not find
* Initialize IDE ports in mpc8xx_ide_probe().
* Remove m8xx_ide_init() and ppc_ide_md hooks - no need for them
(IDE mpc8xx host driver takes care of all this setup).
* Remove needless 'if (irq)' and 'if (data_port = MAX_HWIFS)' checks
from m8xx_ide_init_hwif_ports().
* Remove 'ctrl_port'
http://bugzilla.kernel.org/show_bug.cgi?id=9962
[EMAIL PROTECTED] changed:
What|Removed |Added
Component|IDE |Other
Product|IO/Storage
* Call ide_init_default_irq() for pplus in init_ide_data().
* Remove no longer needed pplus_ide_init_hwif_ports().
There should be no functional changes caused by this patch.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
IDE PMAC host driver and all IDE PCI host drivers use pci_enable_device()
nowadays so the following quirk in pmac_pcibios_after_init() can be removed.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
arch/powerpc/platforms/powermac/pci.c
I hadn't considered that approach due to the way the ata_port is allocated:
libata-core.c:
host = scsi_host_alloc(ent-sht, sizeof(struct ata_port));
hosts.c:
struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int
privsize)
{
shost =
Andrew Morton wrote:
And mprintk the following.
code:
DEFINE_MPRINTK(mp, 2 * 80);
mprintk_set_header(mp, KERN_INFO ata%u.%2u: , 1, 0);
mprintk_push(mp, ATA %d, 7);
mprintk_push(mp, , %u sectors\n, 1024);
mprintk(mp, everything seems dandy\n);
output:
6ata1.00: ATA 7, 1024
On Thu, 14 Feb 2008 09:40:51 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Can you please take a look at ata_eh_link_report() in
drivers/ata/libata-eh.c?
I did. Punishment?
Currently, it has some problems.
Yes, and the patches do clean that up.
ho hum. What tends to happen with this sort of
Hello,
Andrew Morton wrote:
On Thu, 14 Feb 2008 09:40:51 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Can you please take a look at ata_eh_link_report() in
drivers/ata/libata-eh.c?
I did. Punishment?
Heh.. :-)
Currently, it has some problems.
Yes, and the patches do clean that up.
Akira Iguchi wrote:
This patch adds default thaw ops and fixes the freeze/thaw inconsistency.
Signed-off-by: Kou Ishizaki [EMAIL PROTECTED]
Signed-off-by: Akira Iguchi [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
--
tejun
-
To unsubscribe from this list: send the line
Alan Cox wrote:
I hadn't considered that approach due to the way the ata_port is allocated:
libata-core.c:
host = scsi_host_alloc(ent-sht, sizeof(struct ata_port));
hosts.c:
struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int
privsize)
{
shost =
On Thu, Feb 14, 2008 at 01:02:55AM +0100, Bartlomiej Zolnierkiewicz wrote:
On Thursday 14 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 13 February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg
drivers/ata/ata_piix.c:1655:8: warning: symbol 'rc' shadows an earlier one
drivers/ata/ata_piix.c:1616:6: originally declared here
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
drivers/ata/ata_piix.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
drivers/ata/sata_via.c:336:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
drivers/ata/sata_via.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 30caa03..0d03f44
pp is never used again in this function, no need to declare a
new one.
drivers/ata/sata_mv.c:1545:24: warning: symbol 'pp' shadows an earlier one
drivers/ata/sata_mv.c:1501:22: originally declared here
drivers/ata/sata_mv.c:1553:24: warning: symbol 'pp' shadows an earlier one
Avoid a metric ton of sparse warnings like:
drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one
drivers/ata/pata_ali.c:176:14: originally declared here
Due to nesting min_t macro inside max_t macro which both use a __x
identifier internally.
Signed-off-by: Harvey Harrison
drop return statement.
drivers/ata/pata_amd.c:149:2: warning: returning void-valued expression
Commit ce54d1616302117fa98513ae916bbe1c02ea pata_amd: update mode selection
for NV PATAs
added the initializer for nv_mode_filter but missed deleting the previously
set mode_filter
Everybody passes in a u32...why fight it.
drivers/ata/pata_cs5536.c:124:26: warning: incorrect type in argument 3
(different signedness)
drivers/ata/pata_cs5536.c:124:26:expected int *val
drivers/ata/pata_cs5536.c:124:26:got unsigned int *noident
Signed-off-by: Harvey Harrison [EMAIL
drivers/ata/pata_jmicron.c:118:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
drivers/ata/pata_jmicron.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c
index
drivers/ata/pata_marvell.c:88:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
drivers/ata/pata_marvell.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c
index
1 - 100 of 107 matches
Mail list logo
