Re: [PATCH] libata: Register for dock events when the drive is inside a dock station

2008-02-21 Thread Holger Macht
On Wed 20. Feb - 12:11:32, Jeff Garzik wrote: > Holger Macht wrote: >> On Thu 14. Feb - 13:40:48, Holger Macht wrote: >>> If a device/bay is inside a docking station, we need to register for dock >>> events additionally to bay events. If a dock event occurs, the dock driver >>> will call the approp

Re: sata_sil24 not configuring drive right?

2008-02-21 Thread Johann-Christoph Jacob
Thanks a lot! It seems WD built yet another unordinary drive. Tejun Heo wrote: > Tejun Heo wrote: > LBA, IORDY(can be disabled) > Queue depth: 1 >> Hmm... Here it is. Interesting. The drive is reporting queue depth of >> 1. Interesting. This is the first time I see this

power_state: get rid of write-only variable in SATA

2008-02-21 Thread Pavel Machek
power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Tejun Heo wrote: Hello, Mark. Mark Lord wrote: Tejun, I've added PMP to sata_mv, and am now trying to get it to work with a Marvell PM attached. And the behaviour I see is very bizarre. After hard+soft resets, the PM signature is found, and libata interrogates the PM registers. It successful

Re: power_state: get rid of write-only variable in SATA

2008-02-21 Thread Jeff Garzik
Pavel Machek wrote: power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++ b/driv

Re: Regression: kernel 2.6.24{,.1} ahci problem, does not boot (resend)

2008-02-21 Thread Malte Schröder
On Thu, 21 Feb 2008 11:51:11 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Malte Schröder wrote: > >> Does irqpoll kernel parameter help? > > > > No, problem stays. > > Can you capture full boot log w/ irqpoll specified? If you have root > filesystem connected to ahci, you'll probably have to u

Re: [linux-pm] power_state: get rid of write-only variable in SATA

2008-02-21 Thread David Brownell
> libata uses it under the assumption that "other parts" of the system are > aware of this variable. > > May I assume that the API has changed such that this is no longer necessary? Yes. The original motivation for dev->power.power_state was to let the writes to /sys/devices/.../power/state supp

[PATCH] ide: remove dead/obsolete ->busproc method

2008-02-21 Thread Bartlomiej Zolnierkiewicz
->busproc method is used by HDIO_SET_BUSSTATE ioctl but it has no chance of working as intended (in 2.4.x days) because to issue an ioctl there is a device node needed and: - for BUSSTATE_TRISTATE+OFF it is too late (devices are already gone) - for BUSSTATE_TRISTATE+ON it is too early (devices ar

[PATCH] libata-pmp: clear hob for pmp register accesses

2008-02-21 Thread Mark Lord
Mark Lord wrote: Tejun Heo wrote: Hello, Mark. Mark Lord wrote: Tejun, I've added PMP to sata_mv, and am now trying to get it to work with a Marvell PM attached. And the behaviour I see is very bizarre. After hard+soft resets, the PM signature is found, and libata interrogates the PM registe

Re: JMicron - hard resetting link

2008-02-21 Thread Gabor FUNK
Hi, I just what to make it clear that this is not a bug of the Marvell's PM, the sata specification (I'm looking at version 2.5) defines the READ/WRITE PM registers to be extended commands, specifically, the features HOB of the READ PM register defined to be RegNum[15:8]. saeed On Thu, Feb 21, 2

Re: [linux-pm] power_state: get rid of write-only variable in SATA

2008-02-21 Thread Pavel Machek
On Thu 2008-02-21 11:33:50, David Brownell wrote: > > libata uses it under the assumption that "other parts" of the system are > > aware of this variable. There are no other relevant parts, except one debug printk that is getting removed. > > May I assume that the API has changed such that this

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Tejun Heo wrote: The following things are needed for a LLD to support PMP. .. I think that's about it. Feel free to ask if something isn't clear. .. I think we need better semantics around sata_scr_{read,write}(), or more specifically These need to be moved into ata_port_operations so th

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Mark Lord wrote: Tejun Heo wrote: The following things are needed for a LLD to support PMP. .. I think that's about it. Feel free to ask if something isn't clear. .. I think we need better semantics around sata_scr_{read,write}(), or more specifically These need to be moved into ata_port_o

Re: [PATCH] libata-pmp: clear hob for pmp register accesses

2008-02-21 Thread Tejun Heo
Mark Lord wrote: > Mark Lord wrote: >> Tejun Heo wrote: >>> Hello, Mark. >>> >>> Mark Lord wrote: Tejun, I've added PMP to sata_mv, and am now trying to get it to work with a Marvell PM attached. And the behaviour I see is very bizarre. After hard+soft resets, the PM s

Re: [PATCH] libata: Register for dock events when the drive is inside a dock station

2008-02-21 Thread Tejun Heo
> If a device/bay is inside a docking station, we need to register for dock > events additionally to bay events. If a dock event occurs, the dock driver > will call the appropriate handler (ata_acpi_ap_notify() or > ata_acpi_dev_notify()) for us. > > Signed-off-by: Holger Macht <[EMAIL PROTECTED]>

Re: JMicron - hard resetting link

2008-02-21 Thread Tejun Heo
Hello, Gabor FUNK wrote: > To sum it up: > - 1st the 4 disks on the Jmicron controller failed with 1 [chieftek] PSU > - then it failed with 2 PSU too, but this time the chieftek was only > connected to the different 4 disks - on the nvidia controller. MB > and other disks were on the other, no

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: Mark Lord wrote: Tejun Heo wrote: The following things are needed for a LLD to support PMP. .. I think that's about it. Feel free to ask if something isn't clear. .. I think we need better semantics around sata_scr_{read,write}(), or more specifically The

Re: What's needed for PMP support?

2008-02-21 Thread Tejun Heo
Mark Lord wrote: >> Heh... I never thought a PMP aware controller would use TF SRST, so what >> you want to do is set pmp value in the register and calling >> ata_std_softreset(), right? I think the correct thing to do is to >> separate out SRST sequence proper from ata_std_softreset() into, say,

Re: What's needed for PMP support?

2008-02-21 Thread Tejun Heo
Mark Lord wrote: > Mark Lord wrote: >> Tejun Heo wrote: The following things are needed for a LLD to support PMP. >>> .. I think that's about it. Feel free to ask if something isn't clear. >> .. >> >> I think we need better semantics around sata_scr_{read,write}(), >> or more specif

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: Heh... I never thought a PMP aware controller would use TF SRST, so what you want to do is set pmp value in the register and calling ata_std_softreset(), right? I think the correct thing to do is to separate out SRST sequence proper from ata_std_softreset() int

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Mark Lord wrote: Tejun Heo wrote: Mark Lord wrote: Heh... I never thought a PMP aware controller would use TF SRST, so what you want to do is set pmp value in the register and calling ata_std_softreset(), right? I think the correct thing to do is to separate out SRST sequence proper from ata_

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: .. We already have .pmp_scr_{read,write} operations. If NULL, then default to the built-ins that are there now. .. Mmm.. lost some lines there, try again: We already have .scr_{read,write} operations, and what I think we need are .pmp_scr_{read,write} in addi

new ata_port_operations for .pmp_{read,write} ?

2008-02-21 Thread Mark Lord
Tejun, Here's a first cut at this for discussion. You may prefer different names for the invoking functions inside libata-pmp.c, rather than simply pmp_read() and pmp_write(), but I've been up too long and couldn't think of a better name. An alternative to all this, might be to expose the "sele

[PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-21 Thread Huang, Shane
Jeff: SB700 SATA controller can support 64 bit DMA, the previous commit badc2341579511a247f5993865aa68379e283c5c was added with careless reference to SB600, which should be modified by this patch. Signed-off-by: Shane Huang <[EMAIL PROTECTED]> diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.

RE: [PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-21 Thread Huang, Shane
OMG, but I modified my settings and verified that the patch can really work here before I sent it to you... Shane > -Original Message- > From: Tejun Heo [mailto:[EMAIL PROTECTED] > Sent: Friday, February 22, 2008 12:59 PM > To: Huang, Shane > Cc: [EMAIL PROTECTED]; linux-ide@vger.kern

Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-21 Thread Jeff Garzik
Huang, Shane wrote: OMG, but I modified my settings and verified that the patch can really work here before I sent it to you... It's word-wrapping, and also quoting a bunch of characters, which make it difficult for tools to pick up: @ -85,6 +85,7 @@ board_ahci_ign_iferr=3D 2,

Re: [PATCH] AMD SB700/SB800 SATA support 64bit DMA

2008-02-21 Thread Tejun Heo
Huang, Shane wrote: > Jeff: > > SB700 SATA controller can support 64 bit DMA, the previous commit > badc2341579511a247f5993865aa68379e283c5c was added with > careless reference to SB600, which should be modified by this patch. > > > Signed-off-by: Shane Huang <[EMAIL PROTECTED]> Shane, it still